repository-provider 35.0.1 → 35.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "35.0.1",
+  "version": "35.0.3",
   "publishConfig": {
     "access": "public"
   },
@@ -27,7 +27,7 @@
     "docs": "documentation readme --section=API ./src/**/*.mjs",
     "lint": "npm run lint:docs && npm run lint:tsc",
     "lint:docs": "documentation lint ./src/**/*.mjs",
-    "lint:tsc": "tsc --allowJs --checkJs --noEmit -t esnext -m esnext --moduleResolution nodenext ./src/*.mjs"
+    "lint:tsc": "tsc --allowJs --checkJs --noEmit -t esnext -m esnext --module nodenext --moduleResolution nodenext ./src**/*.mjs"
   },
   "dependencies": {
     "matching-iterator": "^2.0.12",
@@ -35,7 +35,7 @@
   },
   "devDependencies": {
     "ava": "^6.1.1",
-    "browser-ava": "^2.1.9",
+    "browser-ava": "^2.1.10",
     "c8": "^9.1.0",
     "documentation": "^14.0.3",
     "repository-provider-test-support": "^3.0.2",

package/src/base-object.mjs

@@ -4,12 +4,12 @@ import {
 } from "./attribute-extras.mjs";
 import { description_attribute, id_attribute } from "./attributes.mjs";
 
-  /**
-   * Creates an instance of BaseObject.
-   * @param {Object} options
-   * @param {Object} [additionalProperties]
-   */
-  export class BaseObject {
+/**
+ * Creates an instance of BaseObject.
+ * @param {Object} options
+ * @param {Object} [additionalProperties]
+ */
+export class BaseObject {
   /**
    * @return {string} type we represent
    */
@@ -86,14 +86,6 @@ import { description_attribute, id_attribute } from "./attributes.mjs";
     return this.identifier;
   }
 
-  /**
-   * Beautified name use for human displaying only.
-   * @return {string} human readable name
-   */
-  get displayName() {
-    return this.name;
-  }
-
   /**
    * Complete name in the hierachy.
    * @return {string}
@@ -106,22 +98,6 @@ import { description_attribute, id_attribute } from "./attributes.mjs";
     return this.fullName;
   }
 
-  /**
-   * Complete name in the hierachy.
-   * @return {string}
-   */
-  get fullCondensedName() {
-    return this.fullName;
-  }
-
-  /**
-   * Name with default parts removed
-   * @return {string}
-   */
-  get condensedName() {
-    return this.name;
-  }
-
   /**
    * By default cannot be written to.
    * @return {boolean} false

package/src/named-object.mjs

@@ -40,6 +40,30 @@ export class NamedObject extends BaseObject {
     this.#name = name;
   }
 
+  /**
+   * Beautified name use for human displaying only.
+   * @return {string} human readable name
+   */
+  get displayName() {
+    return this.name;
+  }
+
+  /**
+   * Name with default parts removed
+   * @return {string}
+   */
+  get condensedName() {
+    return this.name;
+  }
+
+  /**
+   * Complete name in the hierachy.
+   * @return {string}
+   */
+  get fullCondensedName() {
+    return this.fullName;
+  }
+
   /**
    * Check for equality.
    * @param {NamedObject} other

package/src/owned-object.mjs

@@ -179,7 +179,7 @@ export class OwnedObject extends NamedObject {
 
   /**
    * By default we use the owners implementation.
-   * @return {Function} as defined in the owner
+   * @return {typeof Repository} as defined in the owner
    */
   get repositoryClass() {
     return this.owner.repositoryClass;

package/src/pull-request.mjs

@@ -58,12 +58,14 @@ export class PullRequest extends OwnedObject {
 
   /**
    * possible states
+   * @enum {string}
    */
   static states = new Set(["OPEN", "MERGED", "CLOSED"]);
 
   /**
    * All valid merge methods
    * @return {Set<string>} valid merge methods.
+   * @enum {string}
    */
   static validMergeMethods = new Set(/*["MERGE", "SQUASH", "REBASE"]*/);
 
@@ -136,7 +138,6 @@ export class PullRequest extends OwnedObject {
     let state = "OPEN";
 
     super(owner, name, options, {
-      source: { value: source },
       state: {
         set(value) {
           value = value.toUpperCase();
@@ -159,6 +160,8 @@ export class PullRequest extends OwnedObject {
         }
       }
     });
+
+    this.source = source;
   }
 
   get destination() {