repository-provider 32.4.9 → 32.5.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "32.4.9",
+  "version": "32.5.0",
   "publishConfig": {
     "access": "public"
   },
@@ -35,10 +35,10 @@
   },
   "devDependencies": {
     "ava": "^5.1.0",
-    "browser-ava": "^1.3.14",
+    "browser-ava": "^1.3.15",
     "c8": "^7.12.0",
     "documentation": "^14.0.1",
-    "repository-provider-test-support": "^2.2.30",
+    "repository-provider-test-support": "^2.2.31",
     "semantic-release": "^19.0.5",
     "typescript": "^4.9.4"
   },

package/src/base-object.mjs

@@ -59,6 +59,14 @@ export class BaseObject {
    * @param {object} additionalProperties
    */
   constructor(options, additionalProperties) {
+    this.updateAttributes(options, additionalProperties);
+  }
+
+  /**
+   * Takes values from options.
+   * @param {object} options
+   */
+  updateAttributes(options, additionalProperties) {
     definePropertiesFromOptions(
       this,
       mapAttributes(options, this.constructor.attributeMapping),

package/src/base-provider.mjs

@@ -14,6 +14,7 @@ import { url_attribute, name_attribute, description_attribute, priority_attribut
  * @typedef {Object} MessageDestination
  * Endpoint to deliver log messages to.
  * @property {Function} info
+ * @property {Function} debug
  * @property {Function} warn
  * @property {Function} error
  * @property {Function} trace
@@ -97,10 +98,6 @@ export class BaseProvider extends BaseObject {
 
   static get attributes() {
     return {
-      url: url_attribute,
-      description : description_attribute,
-      priority: priority_attribute,
-
       /**
        * Name of the provider.
        */
@@ -109,6 +106,10 @@ export class BaseProvider extends BaseObject {
         env: ["{{instanceIdentifier}}NAME"]
       },
 
+      url: url_attribute,
+      description : description_attribute,
+      priority: priority_attribute,
+
       /**
        * To forward info/warn and error messages to
        */

package/src/named-object.mjs

@@ -11,13 +11,11 @@ import { name_attribute, url_attribute, description_attribute, id_attribute } fr
  * @property {string} name
  */
 export class NamedObject extends BaseObject {
-  /**
-   * options
-   */
+
   static get attributes() {
     return {
-      name: name_attribute,
       id: id_attribute,
+      name: name_attribute,
       description: description_attribute
     };
   }

package/src/ref.mjs

@@ -1,5 +1,5 @@
 import { OwnedObject } from "./owned-object.mjs";
-import { boolean_attribute } from "./attributes.mjs";
+import { name_attribute, boolean_attribute } from "./attributes.mjs";
 
 /**
  * @typedef {Object} ContentEntry
@@ -16,7 +16,7 @@ export class Ref extends OwnedObject {
    */
   static get attributes() {
     return {
-      ...super.attributes,
+      name: name_attribute,
 
       /**
        * Can the ref be modified.
@@ -28,7 +28,6 @@ export class Ref extends OwnedObject {
 
   static get attributeMapping() {
     return {
-      ...super.attributeMapping,
       protected: "isProtected"
     };
   }

package/src/repository.mjs

@@ -4,7 +4,13 @@ import { Hook } from "./hook.mjs";
 import { Tag } from "./tag.mjs";
 import { Branch } from "./branch.mjs";
 import { PullRequest } from "./pull-request.mjs";
-import { url_attribute, size_attribute, language_attribute, boolean_attribute, boolean_read_only_attribute } from "./attributes.mjs";
+import {
+  url_attribute,
+  size_attribute,
+  language_attribute,
+  boolean_attribute,
+  boolean_read_only_attribute
+} from "./attributes.mjs";
 
 /**
  * Abstract repository
@@ -28,9 +34,8 @@ export class Repository extends OwnedObject {
     return "_addRepository";
   }
 
-  static get deleteMethodName()
-  {
-     return "_deleteRepository";  	
+  static get deleteMethodName() {
+    return "_deleteRepository";
   }
 
   static get collectionName() {
@@ -256,13 +261,20 @@ export class Repository extends OwnedObject {
    * Add a new {@link Branch}.
    * Internal branch creation does not call repository.initialize()
    * @param {string} name of the new branch
-   * @param {Object} options
+   * @param {Object} options to be passed to the branch
    * @return {Branch} newly created branch
    */
   addBranch(name, options) {
-    return (
-      this.#branches.get(name) || new this.branchClass(this, name, options)
-    );
+    const branch = this.#branches.get(name);
+    if (branch) {
+      if (options) {
+        branch.updateAttributes(options);
+      }
+
+      return branch;
+    }
+
+    return new this.branchClass(this, name, options);
   }
 
   _addBranch(branch) {