repository-provider 30.0.2 → 30.1.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "30.0.2",
+  "version": "30.1.2",
   "publishConfig": {
     "access": "public"
   },
@@ -36,7 +36,7 @@
     "ava": "^4.2.0",
     "c8": "^7.11.3",
     "documentation": "^13.2.5",
-    "repository-provider-test-support": "^2.1.20",
+    "repository-provider-test-support": "^2.1.21",
     "semantic-release": "^19.0.2",
     "typescript": "^4.7.2"
   },

package/src/attribute.mjs

@@ -193,7 +193,7 @@ export function optionJSON(
   initial = {},
   attributes = object.constructor.attributes
 ) {
-  return Object.keys(attributes || {}).reduce((a, c) => {
+  return attributes ? Object.keys(attributes).reduce((a, c) => {
     const value = object[c];
     if (value !== undefined && !(value instanceof Function)) {
       if (value instanceof Set) {
@@ -203,7 +203,7 @@ export function optionJSON(
       }
     }
     return a;
-  }, initial);
+  }, initial) : initial;
 }
 
 /**

package/src/base-provider.mjs

@@ -192,7 +192,7 @@ export class BaseProvider extends BaseObject {
    * @return {string} normalized name
    */
   normalizeGroupName(name, forLookup) {
-    const { group } = this.parseName(name, true);
+    const { group } = this.parseName(name, "group");
     return group && forLookup && !this.areGroupNamesCaseSensitive
       ? group.toLowerCase()
       : group;
@@ -239,10 +239,10 @@ export class BaseProvider extends BaseObject {
    * Parses repository name and tries to split it into
    * base, group, repository and branch.
    * @param {string} name
-   * @param {boolean} groupFocus if only one path component is given
+   * @param {string} focus where lies the focus if only one path component is given
    * @return {Object} with separated attributes
    */
-  parseName(name, groupFocus = false) {
+  parseName(name, focus = "repository") {
     const result = {};
 
     if (name === undefined) {
@@ -286,11 +286,7 @@ export class BaseProvider extends BaseObject {
         result.group = parts[i];
         result.repository = parts[i + 1];
       } else {
-        if (groupFocus) {
-          result.group = name;
-        } else {
-          result.repository = name;
-        }
+        result[focus] = name;
       }
     }
 

package/src/hook.mjs

@@ -1,4 +1,3 @@
-import { optionJSON } from "./attribute.mjs";
 import { OwnedObject } from "./owned-object.mjs";
 
 /**
@@ -20,11 +19,4 @@ export class Hook extends OwnedObject {
   static get addMethodName() {
     return "_addHook";
   }
-
-  /**
-   * Provide name, events and all defined attributes.
-   */
-  toJSON() {
-    return optionJSON(this, { name: this.name, id: this.id });
-  }
 }

package/src/pull-request.mjs

@@ -209,9 +209,7 @@ export class PullRequest extends OwnedObject {
    * @return {Repository} destination repository
    */
   get repository() {
-    return this.owner === undefined
-      ? undefined
-      : this.owner.repository;
+    return this.owner && this.owner.repository;
   }
 
   /**
@@ -236,9 +234,7 @@ export class PullRequest extends OwnedObject {
    * @return {Promise}
    */
   async delete() {
-    return this.owner === undefined
-      ? undefined
-      : this.owner.deletePullRequest(this.name);
+    return this.owner && this.owner.deletePullRequest(this.name);
   }
 
   /**