repository-provider 29.2.1 → 30.0.0

package/README.md

@@ -68,6 +68,8 @@ console.log(await readme.getString());
     *   [toString](#tostring)
     *   [displayName](#displayname)
     *   [fullName](#fullname)
+    *   [fullCondensedName](#fullcondensedname)
+    *   [identifier](#identifier)
     *   [isWritable](#iswritable)
     *   [equals](#equals)
         *   [Parameters](#parameters-8)
@@ -218,7 +220,7 @@ console.log(await readme.getString());
         *   [Parameters](#parameters-50)
     *   [decline](#decline)
     *   [reviews](#reviews)
-    *   [identifier](#identifier)
+    *   [identifier](#identifier-1)
     *   [validStates](#validstates)
     *   [defaultListStates](#defaultliststates)
     *   [validMergeMethods](#validmergemethods)
@@ -247,8 +249,7 @@ console.log(await readme.getString());
         *   [Parameters](#parameters-56)
     *   [repository](#repository-2)
     *   [fullName](#fullname-3)
-    *   [fullCondensedName](#fullcondensedname)
-    *   [identifier](#identifier-1)
+    *   [fullCondensedName](#fullcondensedname-1)
     *   [toString](#tostring-1)
     *   [issuesURL](#issuesurl)
     *   [homePageURL](#homepageurl-1)
@@ -271,7 +272,6 @@ console.log(await readme.getString());
     *   [Properties](#properties-10)
     *   [fullName](#fullname-4)
     *   [slug](#slug)
-    *   [identifier](#identifier-2)
     *   [entry](#entry-1)
         *   [Parameters](#parameters-60)
     *   [entries](#entries-1)
@@ -502,6 +502,18 @@ Complete name in the hierachy.
 
 Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
 
+### fullCondensedName
+
+Complete name in the hierachy.
+
+Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
+
+### identifier
+
+Short human readable identifier with provider and branch.
+
+Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
+
 ### isWritable
 
 By default cannot be written to.
@@ -1484,12 +1496,6 @@ But skipping the branch name if it is the default branch.
 
 Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 'user/repo#branch'
 
-### identifier
-
-Short human readable identifier with provider and branch.
-
-Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
-
 ### toString
 
 Same as identifier.
@@ -1620,12 +1626,6 @@ Name of the repo as used in the URL.
 
 Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
 
-### identifier
-
-Short human readable identifier with provider and branch.
-
-Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
-
 ### entry
 
 Lookup entries form the head of the default branch.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "29.2.1",
+  "version": "30.0.0",
   "publishConfig": {
     "access": "public"
   },
@@ -27,7 +27,7 @@
     "docs": "documentation readme --section=API ./src/**/*.mjs",
     "lint": "npm run lint:docs && npm run lint:tsc",
     "lint:docs": "documentation lint ./src/**/*.mjs",
-    "lint:tsc": "tsc --allowJs --checkJs --noEmit -t es2022 ./src/*.mjs"
+    "lint:tsc": "tsc --allowJs --checkJs --noEmit -t es2022 -m node16 ./src/*.mjs"
   },
   "dependencies": {
     "matching-iterator": "^2.0.4"
@@ -36,9 +36,9 @@
     "ava": "^4.2.0",
     "c8": "^7.11.3",
     "documentation": "^13.2.5",
-    "repository-provider-test-support": "^2.1.18",
+    "repository-provider-test-support": "^2.1.19",
     "semantic-release": "^19.0.2",
-    "typescript": "^4.6.3"
+    "typescript": "^4.7.2"
   },
   "engines": {
     "node": ">=16.15.0"

package/src/attribute.mjs

@@ -65,6 +65,11 @@ export function definePropertiesFromOptions(
       value = attribute.set(value);
     } else {
       switch (attribute.type) {
+        case "set":
+          if (Array.isArray(value)) {
+            value = new Set(value);
+          }
+          break;
         case "boolean":
           if (value !== undefined) {
             value =
@@ -120,7 +125,7 @@ export function defaultValues(attributes, object) {
         a.push([name, attribute.default]);
       } else if (attribute.get !== undefined) {
         const value = attribute.get(attribute, object);
-        if(value !== undefined) {
+        if (value !== undefined) {
           a.push([name, value]);
         }
       }
@@ -191,7 +196,11 @@ export function optionJSON(
   return Object.keys(attributes || {}).reduce((a, c) => {
     const value = object[c];
     if (value !== undefined && !(value instanceof Function)) {
-      a[c] = value;
+      if (value instanceof Set) {
+        a[c] = [...value];
+      } else {
+        a[c] = value;
+      }
     }
     return a;
   }, initial);

package/src/branch.mjs

@@ -7,7 +7,7 @@ import { Commit } from "./commit.mjs";
 /**
  * Abstract branch.
  * @see {@link Repository#_addBranch}
- * @param {Repository} repository
+ * @param {RepositoryOwner} owner
  * @param {string} name
  * @param {Object} options
  *

package/src/hook.mjs

@@ -12,7 +12,8 @@ export class Hook extends OwnedObject {
       secret: { type: "string", private: true, writable: true },
       content_type: { type: "string", default: "json", writable: true },
       insecure_ssl: { type: "boolean", default: false },
-      active: { type: "boolean", default: true, writable: true }
+      active: { type: "boolean", default: true, writable: true },
+      events: { type: "set", default: new Set(["*"]) }
     };
   }
 
@@ -20,17 +21,10 @@ export class Hook extends OwnedObject {
     return "_addHook";
   }
 
-  constructor(owner, name, events = new Set(["*"]), options) {
-    super(owner, name, options, {
-      events: { value: events }
-    });
-  }
-
   /**
    * Provide name, events and all defined attributes.
    */
   toJSON() {
-    return optionJSON(this, { name: this.name, id: this.id, events: [...this.events] });
+    return optionJSON(this, { name: this.name, id: this.id });
   }
 }
-

package/src/pull-request.mjs

@@ -9,7 +9,7 @@ import { BaseProvider } from "./base-provider.mjs";
  * Abstract pull request.
  * {@link Repository#addPullRequest}
  * @param {Branch} source merge source
- * @param {Branch} destination merge target
+ * @param {Branch} owner merge target
  * @param {string} name
  * @param {Object} options
  * @param {string} [options.title]
@@ -218,9 +218,7 @@ export class PullRequest extends OwnedObject {
    * @return {BaseProvider}
    */
   get provider() {
-    return this.owner === undefined
-      ? undefined
-      : this.owner.provider;
+    return this.owner && this.owner.provider;
   }
 
   /**

package/src/repository.mjs

@@ -25,7 +25,6 @@ import { BaseProvider } from "./base-provider.mjs";
  * @property {Map<string,Milestone>} milestones
  */
 export class Repository extends OwnedObject {
-
   static get addMethodName() {
     return "_addRepository";
   }
@@ -128,8 +127,7 @@ export class Repository extends OwnedObject {
    * @param {Object} options
    * @return {AsyncIterator<Commit>} all matching commits in the repository
    */
-  async *commits(options) {
-  }
+  async *commits(options) {}
 
   /**
    * Urls to access the repo.
@@ -234,7 +232,7 @@ export class Repository extends OwnedObject {
    * @return {Promise<Branch>}
    */
   async branch(name) {
-    if(name === this.defaultBranchName) {
+    if (name === this.defaultBranchName) {
       return this.#branches.get(name) || this.addBranch(name);
     }
 
@@ -242,8 +240,10 @@ export class Repository extends OwnedObject {
     return this.#branches.get(name);
   }
 
-  get hasBranches()
-  {
+  /**
+   * @return {boolean} true if there is at least one branch
+   */
+  get hasBranches() {
     return this.#branches.size > 0;
   }
 
@@ -277,7 +277,9 @@ export class Repository extends OwnedObject {
    * @return {Branch} newly created branch
    */
   addBranch(name, options) {
-    return this.#branches.get(name) || new this.branchClass(this, name, options);
+    return (
+      this.#branches.get(name) || new this.branchClass(this, name, options)
+    );
   }
 
   _addBranch(branch) {
@@ -323,7 +325,7 @@ export class Repository extends OwnedObject {
    * @return {Tag} newly created tag
    */
   addTag(name, options) {
-    return this.#tags.get(name) || new this.tagClass(this, name, options);
+    return this.#tags.get(name) || new this.tagClass(this, name, options);
   }
 
   _addTag(tag) {
@@ -394,11 +396,16 @@ export class Repository extends OwnedObject {
   }
 
   /**
-   * Add a Hook.
-   * @param {Hook} hook
+   * Add a new {@link Hook}.
+   * @param {string} name of the new hoook name
+   * @param {Object} options
+   * @return {Hook} newly created hook
    */
-  addHook(hook) {
-    this.#hooks.push(hook);
+  addHook(name, ...args) {
+    return (
+      this.#hooks.find(hook => hook.name == name) ||
+      new this.hookClass(this, name, ...args)
+    );
   }
 
   _addHook(hook) {
@@ -475,8 +482,7 @@ export class Repository extends OwnedObject {
    * @param {string} ref
    * @return {Promise<string>} sha of the ref
    */
-  async refId(ref) {
-  }
+  async refId(ref) {}
 
   /**
    * Provide name and all defined attributes