repository-provider 29.1.4 → 29.2.1

package/README.md

@@ -202,7 +202,7 @@ console.log(await readme.getString());
     *   [Parameters](#parameters-46)
     *   [equals](#equals-3)
         *   [Parameters](#parameters-47)
-    *   [registerInstanceMethodName](#registerinstancemethodname)
+    *   [addMethodName](#addmethodname)
 *   [Project](#project)
 *   [PullRequest](#pullrequest)
     *   [Parameters](#parameters-48)
@@ -327,7 +327,6 @@ console.log(await readme.getString());
     *   [type](#type-1)
     *   [refId](#refid-1)
         *   [Parameters](#parameters-79)
-    *   [toString](#tostring-2)
     *   [toJSON](#tojson-3)
     *   [attributes](#attributes-2)
 *   [defaultBranchName](#defaultbranchname)
@@ -489,7 +488,7 @@ Save object attributes in the backing store.
 
 ### toString
 
-Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** name
+Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** fullName
 
 ### displayName
 
@@ -1211,7 +1210,7 @@ Check for equality.
 
 Returns **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)** true if receiver and owner are equal
 
-### registerInstanceMethodName
+### addMethodName
 
 Method name to be called to register one instance in the owner.
 sample: Application => \_addApplication
@@ -1224,7 +1223,7 @@ Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/G
 
 ## PullRequest
 
-**Extends NamedObject**
+**Extends OwnedObject**
 
 Abstract pull request.
 [Repository#addPullRequest](#repositoryaddpullrequest)
@@ -1232,7 +1231,7 @@ Abstract pull request.
 ### Parameters
 
 *   `source` **[Branch](#branch)** merge source
-*   `destination` **[Branch](#branch)** merge target
+*   `owner`  
 *   `name` **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
 *   `options` **[Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** 
 
@@ -1240,6 +1239,7 @@ Abstract pull request.
     *   `options.state` **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)?** 
     *   `options.merged` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?** 
     *   `options.locked` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?** 
+*   `destination` **[Branch](#branch)** merge target
 
 ### Properties
 
@@ -1920,12 +1920,6 @@ Get sha of a ref.
 
 Returns **[Promise](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Promise)<[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)>** sha of the ref
 
-### toString
-
-full name.
-
-Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
-
 ### toJSON
 
 Provide name and all defined attributes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "29.1.4",
+  "version": "29.2.1",
   "publishConfig": {
     "access": "public"
   },
@@ -34,14 +34,14 @@
   },
   "devDependencies": {
     "ava": "^4.2.0",
-    "c8": "^7.11.2",
+    "c8": "^7.11.3",
     "documentation": "^13.2.5",
-    "repository-provider-test-support": "^2.1.17",
+    "repository-provider-test-support": "^2.1.18",
     "semantic-release": "^19.0.2",
     "typescript": "^4.6.3"
   },
   "engines": {
-    "node": ">=16.14.2"
+    "node": ">=16.15.0"
   },
   "repository": {
     "type": "git",

package/src/base-object.mjs

@@ -82,10 +82,10 @@ export class BaseObject {
   async update() {}
 
   /**
-   * @return {string} name
+   * @return {string} fullName
    */
   toString() {
-    return this.name;
+    return this.fullName;
   }
 
   /**
@@ -104,6 +104,22 @@ export class BaseObject {
     return this.name;
   }
 
+  /**
+   * Complete name in the hierachy.
+   * @return {string}
+   */
+   get fullCondensedName() {
+    return this.fullName;
+  }
+
+  /**
+   * Short human readable identifier with provider and branch.
+   * @return {string}
+   */
+  get identifier() {
+    return `${this.provider.name}:${this.fullCondensedName}`;
+  }
+
   /**
    * By default cannot be written to.
    * @return {boolean} false

package/src/branch.mjs

@@ -17,7 +17,7 @@ import { Commit } from "./commit.mjs";
  */
 export class Branch extends Ref {
 
-  static get registerInstanceMethodName() {
+  static get addMethodName() {
     return "_addBranch";
   }
 

package/src/hook.mjs

@@ -8,7 +8,6 @@ export class Hook extends OwnedObject {
   static get attributes() {
     return {
       ...super.attributes,
-      id: { type: "string", writable: true },
       url: { type: "url", description: "target url", writable: true },
       secret: { type: "string", private: true, writable: true },
       content_type: { type: "string", default: "json", writable: true },
@@ -17,7 +16,7 @@ export class Hook extends OwnedObject {
     };
   }
 
-  static get registerInstanceMethodName() {
+  static get addMethodName() {
     return "_addHook";
   }
 
@@ -34,3 +33,4 @@ export class Hook extends OwnedObject {
     return optionJSON(this, { name: this.name, id: this.id, events: [...this.events] });
   }
 }
+

package/src/named-object.mjs

@@ -33,7 +33,7 @@ export class NamedObject extends BaseObject {
    * @return {string} name with owner name
    */
   get fullName() {
-    return this.owner.name + "/" + this.name;
+    return this.owner ? this.owner.name + "/" + this.name : this.name;
   }
  
   /**

package/src/owned-object.mjs

@@ -9,7 +9,7 @@ export class OwnedObject extends NamedObject {
    * sample: Application => _addApplication
    * @return {string}
    */
-  static get registerInstanceMethodName() {
+  static get addMethodName() {
     return "_add" + this.name;
   }
 
@@ -19,7 +19,7 @@ export class OwnedObject extends NamedObject {
       owner: { value: owner }
     });
 
-    owner[this.constructor.registerInstanceMethodName](this);
+    owner[this.constructor.addMethodName](this);
   }
 
   /**

package/src/pull-request.mjs

@@ -28,7 +28,7 @@ import { BaseProvider } from "./base-provider.mjs";
  */
 export class PullRequest extends OwnedObject {
 
-  static get registerInstanceMethodName() {
+  static get addMethodName() {
     return "_addPullRequest";
   }
 
@@ -240,7 +240,7 @@ export class PullRequest extends OwnedObject {
   async delete() {
     return this.owner === undefined
       ? undefined
-      : this.owner.deletePullRequest(this.number);
+      : this.owner.deletePullRequest(this.name);
   }
 
   /**

package/src/ref.mjs

@@ -116,14 +116,6 @@ export class Ref extends OwnedObject {
       : `${this.owner.fullName}#${this.name}`;
   }
 
-  /**
-   * Short human readable identifier with provider and branch.
-   * @return {string}
-   */
-  get identifier() {
-    return `${this.provider.name}:${this.fullCondensedName}`;
-  }
-
   /**
    * Same as identifier.
    * @return {string}

package/src/repository-group.mjs

@@ -18,7 +18,7 @@ import { BaseProvider } from "./base-provider.mjs";
 
 export class RepositoryGroup extends RepositoryOwner(OwnedObject) {
 
-  static get registerInstanceMethodName() {
+  static get addMethodName() {
     return "_addRepositoryGroup";
   }
 

package/src/repository.mjs

@@ -26,7 +26,7 @@ import { BaseProvider } from "./base-provider.mjs";
  */
 export class Repository extends OwnedObject {
 
-  static get registerInstanceMethodName() {
+  static get addMethodName() {
     return "_addRepository";
   }
 
@@ -69,6 +69,7 @@ export class Repository extends OwnedObject {
   #branches = new Map();
   #tags = new Map();
   #projects = new Map();
+  #applications = new Map();
   #milestones = new Map();
   #pullRequests = new Map();
   #hooks = [];
@@ -95,14 +96,6 @@ export class Repository extends OwnedObject {
     return `${this.owner.name}/${this.name}`;
   }
 
-  /**
-   * Short human readable identifier with provider and branch.
-   * @return {string}
-   */
-  get identifier() {
-    return `${this.provider.name}:${this.fullName}`;
-  }
-
   /**
    * Lookup entries form the head of the default branch.
    * {@link Branch#entry}
@@ -461,6 +454,14 @@ export class Repository extends OwnedObject {
     return this.#projects.get(name);
   }
 
+  _addApplication(application) {
+    this.#applications.set(application.name, application);
+  }
+
+  async application(name) {
+    return this.#applications.get(name);
+  }
+
   /**
    * Get type of the repository.
    * @return {string} 'git'
@@ -477,14 +478,6 @@ export class Repository extends OwnedObject {
   async refId(ref) {
   }
 
-  /**
-   * full name.
-   * @returns {string}
-   */
-  toString() {
-    return this.fullName;
-  }
-
   /**
    * Provide name and all defined attributes
    */

package/src/tag.mjs

@@ -5,7 +5,7 @@ import { Ref } from "./ref.mjs";
  */
 export class Tag extends Ref {
 
-  static get registerInstanceMethodName() {
+  static get addMethodName() {
     return "_addTag";
   }