repository-provider 29.1.2 → 29.1.5

package/README.md

@@ -1224,7 +1224,7 @@ Returns **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/G
 
 ## PullRequest
 
-**Extends NamedObject**
+**Extends OwnedObject**
 
 Abstract pull request.
 [Repository#addPullRequest](#repositoryaddpullrequest)
@@ -1232,7 +1232,7 @@ Abstract pull request.
 ### Parameters
 
 *   `source` **[Branch](#branch)** merge source
-*   `destination` **[Branch](#branch)** merge target
+*   `owner`  
 *   `name` **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)** 
 *   `options` **[Object](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Object)** 
 
@@ -1240,6 +1240,7 @@ Abstract pull request.
     *   `options.state` **[string](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String)?** 
     *   `options.merged` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?** 
     *   `options.locked` **[boolean](https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/Boolean)?** 
+*   `destination` **[Branch](#branch)** merge target
 
 ### Properties
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "29.1.2",
+  "version": "29.1.5",
   "publishConfig": {
     "access": "public"
   },
@@ -36,7 +36,7 @@
     "ava": "^4.2.0",
     "c8": "^7.11.2",
     "documentation": "^13.2.5",
-    "repository-provider-test-support": "^2.1.15",
+    "repository-provider-test-support": "^2.1.17",
     "semantic-release": "^19.0.2",
     "typescript": "^4.6.3"
   },

package/src/pull-request.mjs

@@ -1,5 +1,5 @@
 import { optionJSON } from "./attribute.mjs";
-import { NamedObject } from "./named-object.mjs";
+import { OwnedObject } from "./owned-object.mjs";
 import { Branch } from "./branch.mjs";
 import { Repository } from "./repository.mjs";
 import { Review } from "./review.mjs";
@@ -26,7 +26,12 @@ import { BaseProvider } from "./base-provider.mjs";
  * @property {boolean} [locked]
  * @property {string} url
  */
-export class PullRequest extends NamedObject {
+export class PullRequest extends OwnedObject {
+
+  static get registerInstanceMethodName() {
+    return "_addPullRequest";
+  }
+
   /**
    * All valid states
    * @return {Set<string>} valid states
@@ -145,9 +150,8 @@ export class PullRequest extends NamedObject {
   constructor(source, owner, name, options) {
     let state = "OPEN";
 
-    super(name, options, {
+    super(owner, name, options, {
       source: { value: source },
-      owner: { value: owner },
       state: {
         set(value) {
           value = value.toUpperCase();
@@ -170,10 +174,6 @@ export class PullRequest extends NamedObject {
         }
       }
     });
-
-    if (owner !== undefined) {
-      owner._addPullRequest(this);
-    }
   }
 
   get destination()
@@ -186,7 +186,7 @@ export class PullRequest extends NamedObject {
    * @return {string} PR full name
    */
   get fullName() {
-    return `${this.owner.repository.fullName}/${this.name}`;
+    return `${this.repository.fullName}/${this.name}`;
   }
 
   /**
@@ -194,7 +194,7 @@ export class PullRequest extends NamedObject {
    * @return {string} url
    */
   get url() {    
-    return `${this.provider.url}${this.owner.repository.fullName}/pull/${this.name}`;
+    return `${this.provider.url}${this.repository.fullName}/pull/${this.name}`;
   }
 
   get number() {
@@ -240,7 +240,7 @@ export class PullRequest extends NamedObject {
   async delete() {
     return this.owner === undefined
       ? undefined
-      : this.owner.deletePullRequest(this.number);
+      : this.owner.deletePullRequest(this.name);
   }
 
   /**
@@ -271,7 +271,7 @@ export class PullRequest extends NamedObject {
     return [
       [this.name, this.title],
       ["source", this.source.identifier],
-      ["destination", this.destination.identifier],
+      ["destination", this.owner.identifier],
       ...Object.keys(this.constructor.attributes)
         .filter(
           k =>
@@ -286,7 +286,7 @@ export class PullRequest extends NamedObject {
   toJSON() {
     return optionJSON(this, {
       source: this.source,
-      destination: this.destination,
+      destination: this.owner,
       name: this.name
     });
   }