repository-provider 29.1.0 → 29.1.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "29.1.0",
+  "version": "29.1.3",
   "publishConfig": {
     "access": "public"
   },
@@ -36,7 +36,7 @@
     "ava": "^4.2.0",
     "c8": "^7.11.2",
     "documentation": "^13.2.5",
-    "repository-provider-test-support": "^2.1.14",
+    "repository-provider-test-support": "^2.1.16",
     "semantic-release": "^19.0.2",
     "typescript": "^4.6.3"
   },

package/src/pull-request.mjs

@@ -1,5 +1,5 @@
 import { optionJSON } from "./attribute.mjs";
-import { NamedObject } from "./named-object.mjs";
+import { OwnedObject } from "./owned-object.mjs";
 import { Branch } from "./branch.mjs";
 import { Repository } from "./repository.mjs";
 import { Review } from "./review.mjs";
@@ -26,7 +26,12 @@ import { BaseProvider } from "./base-provider.mjs";
  * @property {boolean} [locked]
  * @property {string} url
  */
-export class PullRequest extends NamedObject {
+export class PullRequest extends OwnedObject {
+
+  static get registerInstanceMethodName() {
+    return "_addPullRequest";
+  }
+
   /**
    * All valid states
    * @return {Set<string>} valid states
@@ -142,12 +147,11 @@ export class PullRequest extends NamedObject {
     };
   }
 
-  constructor(source, destination, name, options) {
+  constructor(source, owner, name, options) {
     let state = "OPEN";
 
-    super(name, options, {
+    super(owner, name, options, {
       source: { value: source },
-      destination: { value: destination },
       state: {
         set(value) {
           value = value.toUpperCase();
@@ -170,10 +174,11 @@ export class PullRequest extends NamedObject {
         }
       }
     });
+  }
 
-    if (destination !== undefined) {
-      destination._addPullRequest(this);
-    }
+  get destination()
+  {
+    return this.owner;
   }
 
   /**
@@ -181,7 +186,7 @@ export class PullRequest extends NamedObject {
    * @return {string} PR full name
    */
   get fullName() {
-    return `${this.destination.repository.fullName}/${this.name}`;
+    return `${this.repository.fullName}/${this.name}`;
   }
 
   /**
@@ -189,7 +194,7 @@ export class PullRequest extends NamedObject {
    * @return {string} url
    */
   get url() {    
-    return `${this.provider.url}${this.destination.repository.fullName}/pull/${this.name}`;
+    return `${this.provider.url}${this.repository.fullName}/pull/${this.name}`;
   }
 
   get number() {
@@ -204,18 +209,18 @@ export class PullRequest extends NamedObject {
    * @return {Repository} destination repository
    */
   get repository() {
-    return this.destination === undefined
+    return this.owner === undefined
       ? undefined
-      : this.destination.repository;
+      : this.owner.repository;
   }
 
   /**
    * @return {BaseProvider}
    */
   get provider() {
-    return this.destination === undefined
+    return this.owner === undefined
       ? undefined
-      : this.destination.provider;
+      : this.owner.provider;
   }
 
   /**
@@ -233,9 +238,9 @@ export class PullRequest extends NamedObject {
    * @return {Promise}
    */
   async delete() {
-    return this.destination === undefined
+    return this.owner === undefined
       ? undefined
-      : this.destination.deletePullRequest(this.number);
+      : this.owner.deletePullRequest(this.number);
   }
 
   /**
@@ -266,7 +271,7 @@ export class PullRequest extends NamedObject {
     return [
       [this.name, this.title],
       ["source", this.source.identifier],
-      ["destination", this.destination.identifier],
+      ["destination", this.owner.identifier],
       ...Object.keys(this.constructor.attributes)
         .filter(
           k =>
@@ -281,7 +286,7 @@ export class PullRequest extends NamedObject {
   toJSON() {
     return optionJSON(this, {
       source: this.source,
-      destination: this.destination,
+      destination: this.owner,
       name: this.name
     });
   }
@@ -291,6 +296,6 @@ export class PullRequest extends NamedObject {
    * @return {string}
    */
   get identifier() {
-    return `${this.destination.identifier}[${this.name}]`;
+    return `${this.owner.identifier}[${this.name}]`;
   }
 }