repository-provider 26.1.1 → 26.1.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repository-provider",
-  "version": "26.1.1",
+  "version": "26.1.2",
   "publishConfig": {
     "access": "public"
   },
@@ -38,7 +38,7 @@
     "documentation": "^13.2.5",
     "repository-provider-test-support": "^1.9.1",
     "semantic-release": "^18.0.1",
-    "typescript": "^4.6.0-dev.20211230"
+    "typescript": "^4.6.0-dev.20211231"
   },
   "engines": {
     "node": ">=14.18.1"

package/src/attribute.mjs

@@ -103,23 +103,25 @@ export function definePropertiesFromOptions(
 }
 
 /**
- * get default values.
+ * Get default values.
  * @param {Object} attributes
  * @return {Object} filled with default values
  */
-export function defaultValues(attributes) {
-  Object.entries(attributes).reduce((a, c) => {
-    const [name, attribute] = c;
-    if (attribute.default !== undefined) {
-      a.push([
-        name,
-        typeof attribute.getDefault
-          ? attribute.getDefault(attribute, object)
-          : attribute.default
-      ]);
-    }
-    return a;
-  }, []);
+export function defaultValues(attributes, object) {
+  return Object.fromEntries(
+    Object.entries(attributes).reduce((a, c) => {
+      const [name, attribute] = c;
+
+      if (attribute.default !== undefined) {
+        a.push([name, attribute.default]);
+      }
+      else if (attribute.getDefault !== undefined) {
+        a.push([name, attribute.getDefault(attribute, object)]);
+      }
+
+      return a;
+    }, [])
+  );
 }
 
 /**

package/src/base-provider.mjs

@@ -126,7 +126,7 @@ export class BaseProvider {
   /**
    * Creates a new provider for a given set of options.
    * @param {Object} options additional options
-   * @param {string} [options.instanceIdentifier]
+   * @param {string} [options.instanceIdentifier] name of the provider instance
    * @param {Object} env taken from process.env
    * @return {BaseProvider} newly created provider or undefined if options are not sufficient to construct a provider
    */
@@ -153,7 +153,7 @@ export class BaseProvider {
   }
 
   /**
-   * All possible base urls.
+   * All supported base urls.
    * For github something like:
    * - git@github.com
    * - git://github.com
@@ -293,6 +293,12 @@ export class BaseProvider {
     return result;
   }
 
+  /**
+   * Create a repository.
+   * @param {string} name of group and repository
+   * @param {Object} options
+   * @returns {Promise<Repository>}
+   */
   async createRepository(name, options) {
     const { group, repository } = this.parseName(name);
     const rg = await this.repositoryGroup(group);
@@ -311,7 +317,7 @@ export class BaseProvider {
         yield* group[type]();
       }
     } else {
-      for (let pattern of asArray(patterns)) {
+      for (const pattern of asArray(patterns)) {
         const [groupPattern, repoPattern] = stripBaseName(
           pattern,
           this.repositoryBases
@@ -387,20 +393,6 @@ export class BaseProvider {
     yield* this.list("pullRequests", patterns);
   }
 
-  /**
-   * @return {Class} repository group class used by the Provider
-   */
-  get repositoryGroupClass() {
-    return RepositoryGroup;
-  }
-
-  /**
-   * @return {Class} hook class used by the Provider
-   */
-  get hookClass() {
-    return Hook;
-  }
-
   /**
    * Deliver the provider name.
    * @return {string} class name by default
@@ -448,6 +440,34 @@ export class BaseProvider {
     return json;
   }
 
+  initializeRepositories() {}
+
+  info(...args) {
+    return this.messageDestination.info(...args);
+  }
+
+  warn(...args) {
+    return this.messageDestination.warn(...args);
+  }
+
+  error(...args) {
+    return this.messageDestination.error(...args);
+  }
+
+  /**
+   * @return {Class} repository group class used by the Provider
+   */
+  get repositoryGroupClass() {
+    return RepositoryGroup;
+  }
+
+  /**
+   * @return {Class} hook class used by the Provider
+   */
+  get hookClass() {
+    return Hook;
+  }
+
   /**
    * @return {Class} repository class used by the Provider
    */
@@ -475,18 +495,4 @@ export class BaseProvider {
   get pullRequestClass() {
     return PullRequest;
   }
-
-  initializeRepositories() {}
-
-  info(...args) {
-    return this.messageDestination.info(...args);
-  }
-
-  warn(...args) {
-    return this.messageDestination.warn(...args);
-  }
-
-  error(...args) {
-    return this.messageDestination.error(...args);
-  }
 }