reportdash-datastore-mcp-claude-desktop 1.0.9 → 1.0.11

package/index.js

@@ -12,9 +12,8 @@ const API_URL = process.env.REPORTDASH_API_URL || 'https://datastore.reportdash.
 
 // Validate configuration
 if (!API_KEY) {
-  // NOTE: In MCP stdio mode, prefer stdout only.
-  // But keeping your original behavior as-is.
-  console.error(
+  // In Claude MCP mode, stdout should be JSON only. This is fatal anyway, so ok.
+  process.stdout.write(
     JSON.stringify({
       jsonrpc: '2.0',
       error: {
@@ -22,14 +21,14 @@ if (!API_KEY) {
         message:
           'REPORTDASH_API_KEY environment variable is required. Get your API key from ReportDash DataStore app settings.',
       },
-    })
+      id: null,
+    }) + '\n'
   );
   process.exit(1);
 }
 
 /**
  * Ensure every outbound request includes platform="claude"
- * without breaking existing requests.
  */
 function withClaudePlatform(mcpRequest) {
   if (mcpRequest && typeof mcpRequest === 'object') {
@@ -39,14 +38,29 @@ function withClaudePlatform(mcpRequest) {
 }
 
 /**
- * JSON-RPC id helper:
- * Keep 0 as a valid id; only default when null/undefined.
+ * Preserve id=0. Only default when null/undefined.
  */
-function rpcId(mcpRequest) {
-  return mcpRequest?.id ?? null;
+function rpcId(req) {
+  return req?.id ?? null;
 }
 
-// Test mode
+/**
+ * Write exactly one JSON object per line to stdout (MCP framing).
+ */
+function writeJson(obj) {
+  process.stdout.write(JSON.stringify(obj) + '\n');
+}
+
+/**
+ * Build a JSON-RPC error response
+ */
+function rpcError({ id = null, code = -32603, message = 'Internal error', data }) {
+  const err = { code, message };
+  if (data !== undefined) err.data = data;
+  return { jsonrpc: '2.0', id, error: err };
+}
+
+// Test mode (prints human logs to stdout; do not run in Claude MCP mode)
 if (process.argv.includes('--test')) {
   testConnection();
   return;
@@ -62,22 +76,21 @@ const rl = readline.createInterface({
 rl.on('line', (line) => {
   if (!line.trim()) return;
 
+  let mcpRequest;
   try {
-    const mcpRequest = JSON.parse(line);
-    forwardToAPI(withClaudePlatform(mcpRequest));
+    mcpRequest = JSON.parse(line);
   } catch (error) {
-    // Only output to stdout, never stderr for MCP protocol
-    console.log(
-      JSON.stringify({
-        jsonrpc: '2.0',
-        error: {
-          code: -32700,
-          message: 'Parse error: ' + error.message,
-        },
+    writeJson(
+      rpcError({
         id: null,
+        code: -32700,
+        message: 'Parse error: ' + error.message,
       })
     );
+    return;
   }
+
+  forwardToAPI(withClaudePlatform(mcpRequest));
 });
 
 function forwardToAPI(mcpRequest) {
@@ -85,96 +98,123 @@ function forwardToAPI(mcpRequest) {
   const isHttps = url.protocol === 'https:';
   const client = isHttps ? https : http;
 
+  const body = JSON.stringify(mcpRequest);
+
+  const hasId = mcpRequest && Object.prototype.hasOwnProperty.call(mcpRequest, 'id');
+  const reqId = hasId ? mcpRequest.id : undefined;
+
   const options = {
     hostname: url.hostname,
     port: url.port || (isHttps ? 443 : 80),
-    path: url.pathname,
+    path: url.pathname + url.search,
     method: 'POST',
     headers: {
       'Content-Type': 'application/json',
+      'Content-Length': Buffer.byteLength(body),
       'X-Api-Key': API_KEY,
       'User-Agent': 'ReportDash-DataStore-MCP/1.0',
     },
-    timeout: 30000, // 30 second timeout
+    timeout: 30000,
   };
 
   const req = client.request(options, (res) => {
     let data = '';
-
-    res.on('data', (chunk) => {
-      data += chunk;
-    });
-
+    res.on('data', (chunk) => (data += chunk));
     res.on('end', () => {
-      // Treat 200-299 as success (including 204 No Content)
-      if (res.statusCode >= 200 && res.statusCode < 300) {
-        // For 204 No Content or empty response, return empty success
-        if (res.statusCode === 204 || !data.trim()) {
-          console.log(
+      // Notifications MUST NOT get responses
+      if (!hasId) return;
+
+      // 204 / empty => empty result
+      if (res.statusCode === 204 || !data.trim()) {
+        if (res.statusCode >= 200 && res.statusCode < 300) {
+          process.stdout.write(JSON.stringify({ jsonrpc: '2.0', id: reqId, result: {} }) + '\n');
+        } else {
+          process.stdout.write(
             JSON.stringify({
               jsonrpc: '2.0',
-              result: {},
-              id: rpcId(mcpRequest), // FIX: preserves id=0
-            })
+              id: reqId,
+              error: { code: res.statusCode, message: `API error: ${res.statusCode} (empty body)` },
+            }) + '\n'
           );
+        }
+        return;
+      }
+
+      let parsed;
+      try {
+        parsed = JSON.parse(data);
+      } catch (e) {
+        process.stdout.write(
+          JSON.stringify({
+            jsonrpc: '2.0',
+            id: reqId,
+            error: {
+              code: -32603,
+              message: 'API returned non-JSON response',
+              data: { statusCode: res.statusCode, body: data },
+            },
+          }) + '\n'
+        );
+        return;
+      }
+
+      // Success
+      if (res.statusCode >= 200 && res.statusCode < 300) {
+        // If backend returned a JSON-RPC object, enforce id
+        if (parsed && typeof parsed === 'object' && parsed.jsonrpc === '2.0') {
+          if (!Object.prototype.hasOwnProperty.call(parsed, 'id')) parsed.id = reqId;
+          // IMPORTANT: never allow null id
+          if (parsed.id === null) parsed.id = reqId;
+          process.stdout.write(JSON.stringify(parsed) + '\n');
         } else {
-          // Forward the response as-is
-          console.log(data);
+          process.stdout.write(JSON.stringify({ jsonrpc: '2.0', id: reqId, result: parsed }) + '\n');
         }
       } else {
-        // Send errors to stdout (not stderr!) so Claude can properly handle them
-        console.log(
+        // Error
+        process.stdout.write(
           JSON.stringify({
             jsonrpc: '2.0',
+            id: reqId,
             error: {
               code: res.statusCode,
-              message: `API error: ${res.statusCode}${data ? ' - ' + data : ''}`,
-              data: { statusCode: res.statusCode, body: data },
+              message: `API error: ${res.statusCode}`,
+              data: parsed,
             },
-            id: rpcId(mcpRequest), // FIX: preserves id=0
-          })
+          }) + '\n'
         );
       }
     });
   });
 
   req.on('error', (error) => {
-    // Send errors to stdout (not stderr!)
-    console.log(
+    if (!hasId) return; // notification: no response
+    process.stdout.write(
       JSON.stringify({
         jsonrpc: '2.0',
-        error: {
-          code: -32603,
-          message: 'Network error: ' + error.message,
-          data: { error: error.message },
-        },
-        id: rpcId(mcpRequest), // FIX: preserves id=0
-      })
+        id: reqId,
+        error: { code: -32603, message: 'Network error: ' + error.message },
+      }) + '\n'
     );
   });
 
   req.on('timeout', () => {
     req.destroy();
-    // Send errors to stdout (not stderr!)
-    console.log(
+    if (!hasId) return; // notification: no response
+    process.stdout.write(
       JSON.stringify({
         jsonrpc: '2.0',
-        error: {
-          code: -32603,
-          message: 'Request timeout after 30 seconds',
-        },
-        id: rpcId(mcpRequest), // FIX: preserves id=0
-      })
+        id: reqId,
+        error: { code: -32603, message: 'Request timeout after 30 seconds' },
+      }) + '\n'
     );
   });
 
-  req.write(JSON.stringify(mcpRequest));
+  req.write(body);
   req.end();
 }
 
+
 function testConnection() {
-  // NOTE: This prints non-JSON to stdout, which is fine for --test.
-  // Do not run --test as an MCP stdio server in Claude Desktop.
   console.log('🔍 Testing ReportDash DataStore connection...\n');
   console.log(`API URL: ${API_URL}`);
   console.log(
@@ -185,7 +225,6 @@ function testConnection() {
   const isHttps = url.protocol === 'https:';
   const client = isHttps ? https : http;
 
-  // Create MCP tools/list request
   const mcpRequest = withClaudePlatform({
     jsonrpc: '2.0',
     method: 'tools/list',
@@ -197,7 +236,7 @@ function testConnection() {
   const options = {
     hostname: url.hostname,
     port: url.port || (isHttps ? 443 : 80),
-    path: url.pathname,
+    path: url.pathname + url.search,
     method: 'POST',
     headers: {
       'Content-Type': 'application/json',
@@ -212,9 +251,7 @@ function testConnection() {
 
   const req = client.request(options, (res) => {
     let data = '';
-    res.on('data', (chunk) => {
-      data += chunk;
-    });
+    res.on('data', (chunk) => (data += chunk));
     res.on('end', () => {
       console.log(`Response Status: ${res.statusCode}\n`);
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "reportdash-datastore-mcp-claude-desktop",
-  "version": "1.0.9",
+  "version": "1.0.11",
   "description": "ReportDash DataStore MCP server for Claude Desktop",
   "main": "index.js",
   "bin": {