reportdash-datastore-mcp-claude-desktop 1.0.10 → 1.0.12

package/index.js

@@ -19,7 +19,7 @@ if (!API_KEY) {
       error: {
         code: -32600,
         message:
-          'REPORTDASH_API_KEY environment variable is required. Get your API key from ReportDash DataStore app settings.',
+          'REPORTDASH_API_KEY environment variable is required. Get your API key from ReportDash DataStore > Destinations > API Access.',
       },
       id: null,
     }) + '\n'
@@ -100,6 +100,9 @@ function forwardToAPI(mcpRequest) {
 
   const body = JSON.stringify(mcpRequest);
 
+  const hasId = mcpRequest && Object.prototype.hasOwnProperty.call(mcpRequest, 'id');
+  const reqId = hasId ? mcpRequest.id : undefined;
+
   const options = {
     hostname: url.hostname,
     port: url.port || (isHttps ? 443 : 80),
@@ -118,82 +121,91 @@ function forwardToAPI(mcpRequest) {
     let data = '';
     res.on('data', (chunk) => (data += chunk));
     res.on('end', () => {
-      const id = rpcId(mcpRequest);
+      // Notifications MUST NOT get responses
+      if (!hasId) return;
 
-      // 204 or empty body => empty result
+      // 204 / empty => empty result
       if (res.statusCode === 204 || !data.trim()) {
         if (res.statusCode >= 200 && res.statusCode < 300) {
-          writeJson({ jsonrpc: '2.0', id, result: {} });
+          process.stdout.write(JSON.stringify({ jsonrpc: '2.0', id: reqId, result: {} }) + '\n');
         } else {
-          writeJson(
-            rpcError({
-              id,
-              code: res.statusCode,
-              message: `API error: ${res.statusCode} (empty body)`,
-            })
+          process.stdout.write(
+            JSON.stringify({
+              jsonrpc: '2.0',
+              id: reqId,
+              error: { code: res.statusCode, message: `API error: ${res.statusCode} (empty body)` },
+            }) + '\n'
           );
         }
         return;
       }
 
-      // Always re-serialize to 1-line JSON for MCP framing
       let parsed;
       try {
         parsed = JSON.parse(data);
       } catch (e) {
-        writeJson(
-          rpcError({
-            id,
-            code: res.statusCode >= 400 ? res.statusCode : -32603,
-            message: 'API returned non-JSON response',
-            data: { statusCode: res.statusCode, body: data },
-          })
+        process.stdout.write(
+          JSON.stringify({
+            jsonrpc: '2.0',
+            id: reqId,
+            error: {
+              code: -32603,
+              message: 'API returned non-JSON response',
+              data: { statusCode: res.statusCode, body: data },
+            },
+          }) + '\n'
         );
         return;
       }
 
+      // Success
       if (res.statusCode >= 200 && res.statusCode < 300) {
-        // Ensure JSON-RPC envelope exists; if your API returns raw jsonrpc objects, this is fine.
-        // If it returns something else, wrap it.
+        // If backend returned a JSON-RPC object, enforce id
         if (parsed && typeof parsed === 'object' && parsed.jsonrpc === '2.0') {
-          // Some backends might omit id; ensure it's present
-          if (parsed.id === undefined) parsed.id = id;
-          writeJson(parsed);
+          if (!Object.prototype.hasOwnProperty.call(parsed, 'id')) parsed.id = reqId;
+          // IMPORTANT: never allow null id
+          if (parsed.id === null) parsed.id = reqId;
+          process.stdout.write(JSON.stringify(parsed) + '\n');
         } else {
-          writeJson({ jsonrpc: '2.0', id, result: parsed });
+          process.stdout.write(JSON.stringify({ jsonrpc: '2.0', id: reqId, result: parsed }) + '\n');
         }
       } else {
-        writeJson(
-          rpcError({
-            id,
-            code: res.statusCode,
-            message: `API error: ${res.statusCode}`,
-            data: parsed,
-          })
+        // Error
+        process.stdout.write(
+          JSON.stringify({
+            jsonrpc: '2.0',
+            id: reqId,
+            error: {
+              code: res.statusCode,
+              message: `API error: ${res.statusCode}`,
+              data: parsed,
+            },
+          }) + '\n'
         );
       }
     });
   });
 
   req.on('error', (error) => {
-    writeJson(
-      rpcError({
-        id: rpcId(mcpRequest),
-        code: -32603,
-        message: 'Network error: ' + error.message,
-        data: { error: error.message },
-      })
+    if (!hasId) return; // notification: no response
+    process.stdout.write(
+      JSON.stringify({
+        jsonrpc: '2.0',
+        id: reqId,
+        error: { code: -32603, message: 'Network error: ' + error.message },
+      }) + '\n'
     );
   });
 
   req.on('timeout', () => {
     req.destroy();
-    writeJson(
-      rpcError({
-        id: rpcId(mcpRequest),
-        code: -32603,
-        message: 'Request timeout after 30 seconds',
-      })
+    if (!hasId) return; // notification: no response
+    process.stdout.write(
+      JSON.stringify({
+        jsonrpc: '2.0',
+        id: reqId,
+        error: { code: -32603, message: 'Request timeout after 30 seconds' },
+      }) + '\n'
     );
   });
 
@@ -201,6 +213,7 @@ function forwardToAPI(mcpRequest) {
   req.end();
 }
 
+
 function testConnection() {
   console.log('🔍 Testing ReportDash DataStore connection...\n');
   console.log(`API URL: ${API_URL}`);
@@ -277,7 +290,7 @@ function testConnection() {
         console.log('❌ Connection failed');
         console.log(`Status: ${res.statusCode}`);
         console.log(`Response: ${data}`);
-        console.log('\n💡 Check your API key in ReportDash DataStore app settings');
+        console.log('\n💡 Check your API key in ReportDash DataStore > Destinations > API Access');
       }
     });
   });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "reportdash-datastore-mcp-claude-desktop",
-  "version": "1.0.10",
+  "version": "1.0.12",
   "description": "ReportDash DataStore MCP server for Claude Desktop",
   "main": "index.js",
   "bin": {