repoburg 1.3.202 → 1.3.209

package/agent-pane/backend/src/repoburg/action-mapping.ts

@@ -1,294 +0,0 @@
-/**
- * Shared mapping helpers for the repoburg provider: repoburg AIAction →
- * agent-pane item shapes, DB item helpers, and usage mapping.
- * Used by both the provider (turn orchestration) and the turn projector
- * (message-stream projection).
- */
-
-import { v4 as uuidv4 } from 'uuid';
-import type Database from 'better-sqlite3';
-import { broadcast } from '../ws/index.ts';
-import type { Item, ItemStatus } from '../db/schema.ts';
-import type { AskUserSelectionGroup, AskUserItemData } from '@agentpane/shared';
-import type { RepoburgAction } from './repoburg-client.ts';
-
-/** Safely parse a JSON string field from an action row. */
-export function parseJsonArgs(raw: string | null | undefined): Record<string, unknown> | null {
-  if (!raw) return null;
-  try {
-    const parsed = JSON.parse(raw);
-    return typeof parsed === 'object' && parsed !== null ? (parsed as Record<string, unknown>) : null;
-  } catch {
-    return null;
-  }
-}
-
-/** Parse a raw selections JSON string into validated groups (platform parity:
- *  ActionItemContent.parseSelectionGroups). Never throws; flat-string arrays
- *  coerce into single-option groups; invalid entries are dropped. */
-export function parseSelectionGroups(raw: string | null | undefined): AskUserSelectionGroup[] {
-  if (!raw) return [];
-  let parsed: unknown;
-  try {
-    parsed = JSON.parse(raw);
-  } catch {
-    return [];
-  }
-  if (!Array.isArray(parsed)) return [];
-  return parsed
-    .map((item): AskUserSelectionGroup | null => {
-      if (item && typeof item === 'object' && !Array.isArray(item)) {
-        const obj = item as Record<string, unknown>;
-        if (Array.isArray(obj.selections)) {
-          const opts = obj.selections.filter((s): s is string => typeof s === 'string');
-          if (opts.length > 0) {
-            return {
-              question: typeof obj.question === 'string' ? obj.question : '',
-              selections: opts,
-            };
-          }
-        }
-        return null;
-      }
-      // Graceful coercion: flat string → single-option group.
-      if (typeof item === 'string') {
-        return { question: '', selections: [item] };
-      }
-      return null;
-    })
-    .filter((g): g is AskUserSelectionGroup => g !== null);
-}
-
-/** Map a repoburg AIAction (+ its first execution log) to an agent-pane item
- *  shape. Returns null for actions that carry no displayable content
- *  (final/html_final — their text is part of the LLM response). */
-export function mapActionToItem(
-  action: RepoburgAction,
-): { type: Item['type']; data: Record<string, unknown>; status: ItemStatus } | null {
-  const failed = action.status === 'EXECUTION_FAILED';
-  const status: ItemStatus = failed ? 'failed' : 'completed';
-  const log = action.executionLogs?.[0];
-  const output = log?.output ?? '';
-  const errorMsg = log?.error_message ?? '';
-
-  switch (action.action_type) {
-    case 'create_file':
-    case 'overwrite_file':
-    case 'patch':
-    case 'quick_edit':
-    case 'apply_diff':
-    case 'write_todo':
-    case 'delete_file': {
-      const kind =
-        action.action_type === 'create_file'
-          ? 'add'
-          : action.action_type === 'delete_file'
-            ? 'delete'
-            : 'modify';
-      return {
-        type: 'file_change',
-        data: { changes: [{ path: action.file_path ?? '', kind }], status },
-        status,
-      };
-    }
-
-    case 'run_command':
-    case 'execute_code':
-      return {
-        type: 'command_execution',
-        data: {
-          command: action.command_string ?? action.action_type,
-          aggregated_output: output,
-          exit_code: failed ? 1 : 0,
-          status,
-        },
-        status,
-      };
-
-    case 'invoke_subagent': {
-      // background_task completed form — Claude-provider data shape. Serves
-      // snapshot reconcile + reload; the live projector finalizes the same
-      // card through the identical external id `<inputId>-action-<actionId>`.
-      const args = parseJsonArgs(action.arguments);
-      const agentName = (args?.agent_name as string) ?? (args?.agentName as string) ?? 'Sub-agent';
-      const prompt = (args?.prompt as string) ?? '';
-      return {
-        type: 'background_task',
-        data: {
-          task_id: (args?.childSessionId as string) ?? '',
-          description: prompt || agentName,
-          task_type: 'subagent',
-          subagent_type: agentName,
-          prompt: prompt || null,
-          status: failed ? 'failed' : 'completed',
-          summary: output || (failed ? errorMsg || 'Sub-agent failed' : ''),
-          output_file: null,
-          output: '',
-          token_count: null,
-          last_tool_name: null,
-        },
-        status,
-      };
-    }
-
-    case 'web_search': {
-      const args = parseJsonArgs(action.arguments);
-      return { type: 'web_search', data: { query: (args?.query as string) ?? '' }, status };
-    }
-
-    case 'ask_user': {
-      // Rendered as clickable selection buttons in the frontend.
-      // Malformed payload → fallback plain-text question card.
-      const groups = parseSelectionGroups(action.selections);
-      const data: AskUserItemData = {
-        question: groups.length ? '' : (action.selections ?? ''),
-        groups,
-      };
-      return {
-        type: 'ask_user',
-        data: { question: data.question, groups: data.groups },
-        status,
-      };
-    }
-
-    case 'final':
-    case 'html_final':
-      // Their text is part of the LLM response — no separate item.
-      return null;
-
-    default: {
-      // MCP tools (serverName__toolName) and remaining built-ins → generic tool call.
-      const isMcp = !!(action.server_name && action.tool_name);
-      return {
-        type: 'mcp_tool_call',
-        data: {
-          server: isMcp ? action.server_name : null,
-          tool: isMcp ? action.tool_name : action.action_type,
-          arguments: parseJsonArgs(action.arguments),
-          result: output ? [{ type: 'text', text: output }] : null,
-          error: failed ? errorMsg || 'Action failed' : null,
-          status,
-        },
-        status,
-      };
-    }
-  }
-}
-
-/** Map repoburg token counts to the agent-pane TokenUsage shape. */
-export function mapUsage(u: {
-  input: number;
-  cached: number;
-  output: number;
-}): {
-  input_tokens: number;
-  cached_input_tokens: number;
-  cache_write_input_tokens: number;
-  output_tokens: number;
-  reasoning_output_tokens: number;
-} {
-  return {
-    input_tokens: u.input,
-    cached_input_tokens: u.cached,
-    cache_write_input_tokens: 0,
-    output_tokens: u.output,
-    reasoning_output_tokens: 0,
-  };
-}
-
-/** Update an item's data + status and broadcast the updated item. */
-export function updateItem(
-  db: Database.Database,
-  sessionId: string,
-  turnId: string,
-  item: Item,
-  data: Record<string, unknown>,
-  status: ItemStatus,
-): void {
-  const now = new Date().toISOString();
-  db.prepare('UPDATE items SET data = ?, status = ?, updated_at = ? WHERE id = ?').run(
-    JSON.stringify(data),
-    status,
-    now,
-    item.id,
-  );
-  const updated: Item = { ...item, data, status, updated_at: now };
-  broadcast('item:updated', { sessionId, turnId, item: updated });
-}
-
-/** Update the running state and status of a session. */
-export function setSessionStatus(
-  db: Database.Database,
-  sessionId: string,
-  isRunning: 0 | 1,
-  status: string,
-  now: string,
-  hasUnreviewed = false,
-): void {
-  if (hasUnreviewed) {
-    db.prepare('UPDATE sessions SET is_running = ?, status = ?, has_unreviewed = 1, updated_at = ? WHERE id = ?').run(
-      isRunning,
-      status,
-      now,
-      sessionId,
-    );
-  } else {
-    db.prepare('UPDATE sessions SET is_running = ?, status = ?, updated_at = ? WHERE id = ?').run(
-      isRunning,
-      status,
-      now,
-      sessionId,
-    );
-  }
-}
-
-/** Insert an item row and broadcast it. Returns the created item. */
-export function insertItem(
-  db: Database.Database,
-  sessionId: string,
-  turnId: string,
-  externalId: string,
-  type: Item['type'],
-  data: Record<string, unknown>,
-  status: ItemStatus,
-  broadcastEvent: 'item:started' | 'item:completed',
-): Item {
-  const now = new Date().toISOString();
-  const itemId = uuidv4();
-  db.prepare(
-    'INSERT INTO items (id, turn_id, external_item_id, type, data, status, created_at, updated_at) VALUES (?, ?, ?, ?, ?, ?, ?, ?)',
-  ).run(itemId, turnId, externalId, type, JSON.stringify(data), status, now, now);
-
-  const item: Item = {
-    id: itemId,
-    turn_id: turnId,
-    external_item_id: externalId,
-    type,
-    data,
-    status,
-    created_at: now,
-    updated_at: now,
-  };
-  broadcast(broadcastEvent, { sessionId, turnId, item });
-  return item;
-}
-
-/** Update an item's data + status and broadcast the completed item. */
-export function completeItem(
-  db: Database.Database,
-  sessionId: string,
-  turnId: string,
-  item: Item,
-  data: Record<string, unknown>,
-  status: ItemStatus,
-): void {
-  const now = new Date().toISOString();
-  db.prepare('UPDATE items SET data = ?, status = ?, updated_at = ? WHERE id = ?').run(
-    JSON.stringify(data),
-    status,
-    now,
-    item.id,
-  );
-  const updated: Item = { ...item, data, status, updated_at: now };
-  broadcast('item:completed', { sessionId, turnId, item: updated });
-}

package/agent-pane/backend/src/repoburg/agent-runtime-client.test.ts

@@ -1,271 +0,0 @@
-import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
-import {
-  createSseParser,
-  parseSseFrame,
-  streamAgentRuntimeMessages,
-} from './agent-runtime-client.ts';
-import type { AgentRuntimeMessage } from './agent-runtime-client.ts';
-
-const enc = new TextEncoder();
-
-describe('parseSseFrame', () => {
-  it('extracts a single data line', () => {
-    expect(parseSseFrame('data: {"a":1}')).toBe('{"a":1}');
-  });
-
-  it('strips one optional space after the colon', () => {
-    expect(parseSseFrame('data: {"a":1}')).toBe('{"a":1}');
-    expect(parseSseFrame('data:{"a":1}')).toBe('{"a":1}');
-  });
-
-  it('ignores comment (heartbeat) lines and returns null when no data', () => {
-    expect(parseSseFrame(': ping')).toBeNull();
-    expect(parseSseFrame(': ping\ndata: x')).toBe('x');
-  });
-
-  it('joins multiple data lines with newlines', () => {
-    expect(parseSseFrame('data: a\ndata: b')).toBe('a\nb');
-  });
-});
-
-describe('createSseParser', () => {
-  it('splits complete frames and buffers partial ones across chunks', () => {
-    const parse = createSseParser();
-    expect(parse('data: {"type":"a"}\n\ndata: {"ty')).toEqual(['{"type":"a"}']);
-    expect(parse('pe":"b"}\n\n')).toEqual(['{"type":"b"}']);
-  });
-
-  it('handles CRLF line endings', () => {
-    const parse = createSseParser();
-    expect(parse('data: {"type":"a"}\r\n\r\n')).toEqual(['{"type":"a"}']);
-  });
-
-  it('ignores heartbeat-only frames', () => {
-    const parse = createSseParser();
-    expect(parse(': ping\n\n')).toEqual([]);
-  });
-});
-
-describe('streamAgentRuntimeMessages', () => {
-  const fetchMock = vi.fn();
-  const originalFetch = globalThis.fetch;
-
-  beforeEach(() => {
-    vi.clearAllMocks();
-    globalThis.fetch = fetchMock as never;
-  });
-
-  afterEach(() => {
-    globalThis.fetch = originalFetch;
-  });
-
-  /** Build an SSE Response body from raw chunks. */
-  function sseBody(chunks: string[], onAbort?: (error: () => void) => void): ReadableStream<Uint8Array> {
-    return new ReadableStream<Uint8Array>({
-      start(controller) {
-        for (const c of chunks) controller.enqueue(enc.encode(c));
-        if (!onAbort) controller.close();
-        else onAbort(() => controller.error(new DOMException('Aborted', 'AbortError')));
-      },
-    });
-  }
-
-  function sseResponse(body: ReadableStream<Uint8Array>): Response {
-    return { ok: true, status: 200, body } as never;
-  }
-
-  const systemFrame = 'data: {"type":"system","subtype":"init","sessionId":"rs-1","modelId":null}\n\n';
-  const assistantFrame = 'data: {"type":"assistant","sessionId":"rs-1","inputId":"in-1","content":[]}\n\n';
-  const resultFrame =
-    'data: {"type":"result","subtype":"success","sessionId":"rs-1","is_error":false,"result":"done","num_rounds":1}\n\n';
-
-  it('delivers messages in order and stops at the terminal result', async () => {
-    fetchMock.mockResolvedValue(
-      sseResponse(sseBody([systemFrame, ': ping\n\n', assistantFrame, resultFrame])),
-    );
-    const messages: AgentRuntimeMessage[] = [];
-    const onActivity = vi.fn();
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      (m) => messages.push(m),
-      { onActivity, reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('result');
-    expect(messages.map((m) => m.type)).toEqual(['system', 'assistant', 'result']);
-    // Activity fired for the received bytes (chunk coalescing makes the exact
-    // read count implementation-dependent — at least once).
-    expect(onActivity.mock.calls.length).toBeGreaterThanOrEqual(1);
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-    expect(fetchMock).toHaveBeenCalledWith(
-      'http://repoburg.test/agent-runtime/sessions/rs-1/messages?stream=1',
-      expect.objectContaining({ method: 'GET' }),
-    );
-  });
-
-  it('parses frames split across chunk boundaries', async () => {
-    fetchMock.mockResolvedValue(
-      sseResponse(
-        sseBody([
-          'data: {"type":"res',
-          'ult","subtype":"succ',
-          'ess","sessionId":"rs-1","is_error":false,"result":"d","num_rounds":1}\n\n',
-        ]),
-      ),
-    );
-    const messages: AgentRuntimeMessage[] = [];
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      (m) => messages.push(m),
-      { reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('result');
-    expect(messages).toHaveLength(1);
-    expect(messages[0].type).toBe('result');
-  });
-
-  it('reconnects after the server closes the stream without a result', async () => {
-    fetchMock
-      .mockResolvedValueOnce(sseResponse(sseBody([assistantFrame]))) // closes early
-      .mockResolvedValueOnce(sseResponse(sseBody([resultFrame])));
-    const messages: AgentRuntimeMessage[] = [];
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      (m) => messages.push(m),
-      { reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('result');
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-    expect(messages.map((m) => m.type)).toEqual(['assistant', 'result']);
-  });
-
-  it('reconnects after a fetch failure', async () => {
-    fetchMock
-      .mockRejectedValueOnce(new Error('ECONNREFUSED'))
-      .mockResolvedValueOnce(sseResponse(sseBody([resultFrame])));
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      () => {},
-      { reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('result');
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('reconnects on non-OK responses other than 404', async () => {
-    fetchMock
-      .mockResolvedValueOnce({ ok: false, status: 502 } as never)
-      .mockResolvedValueOnce(sseResponse(sseBody([resultFrame])));
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      () => {},
-      { reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('result');
-    expect(fetchMock).toHaveBeenCalledTimes(2);
-  });
-
-  it('returns session-not-found on 404 without retrying', async () => {
-    fetchMock.mockResolvedValue({ ok: false, status: 404 } as never);
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      () => {},
-      { reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('session-not-found');
-    expect(fetchMock).toHaveBeenCalledTimes(1);
-  });
-
-  it('returns aborted when the signal is already aborted', async () => {
-    const controller = new AbortController();
-    controller.abort();
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      () => {},
-      { signal: controller.signal, reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('aborted');
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('returns aborted when the signal aborts mid-stream', async () => {
-    const controller = new AbortController();
-    // Simulate real fetch semantics: aborting errors the body stream.
-    fetchMock.mockResolvedValue(
-      sseResponse(
-        sseBody([assistantFrame], (error) => {
-          controller.signal.addEventListener('abort', () => error());
-        }),
-      ),
-    );
-    const messages: AgentRuntimeMessage[] = [];
-
-    const promise = streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      (m) => messages.push(m),
-      { signal: controller.signal, reconnectDelayMs: 1 },
-    );
-    // Let the first chunk deliver, then abort.
-    await new Promise((r) => setTimeout(r, 10));
-    controller.abort();
-
-    const reason = await promise;
-
-    expect(reason).toBe('aborted');
-    expect(messages.map((m) => m.type)).toEqual(['assistant']);
-  });
-
-  it('skips malformed JSON frames without failing the stream', async () => {
-    fetchMock.mockResolvedValue(
-      sseResponse(sseBody(['data: not-json\n\n', resultFrame])),
-    );
-    const messages: AgentRuntimeMessage[] = [];
-
-    const reason = await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      (m) => messages.push(m),
-      { reconnectDelayMs: 1 },
-    );
-
-    expect(reason).toBe('result');
-    expect(messages.map((m) => m.type)).toEqual(['result']);
-  });
-
-  it('requests deltas off (?stream=0) when deltas=false', async () => {
-    fetchMock.mockResolvedValue(sseResponse(sseBody([resultFrame])));
-
-    await streamAgentRuntimeMessages(
-      'http://repoburg.test',
-      'rs-1',
-      () => {},
-      { deltas: false, reconnectDelayMs: 1 },
-    );
-
-    expect(fetchMock).toHaveBeenCalledWith(
-      'http://repoburg.test/agent-runtime/sessions/rs-1/messages?stream=0',
-      expect.anything(),
-    );
-  });
-});