repoburg 1.3.201 → 1.3.204

package/agent-pane/frontend/src/api/websocket.test.ts

@@ -1,288 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-import { connectWebSocket, disconnectWebSocket } from './websocket.ts';
-import type { Item, TokenUsage } from '../types/index.ts';
-
-// Mock the store to capture state dispatches
-vi.mock('../store/store.ts', () => {
-  const handlers: Record<string, (...args: unknown[]) => void> = {};
-  return {
-    useStore: {
-      getState: () => handlers,
-      setState: vi.fn(),
-    },
-  };
-});
-
-// We need to dynamically set the handlers on the mock
-import { useStore } from '../store/store.ts';
-
-const NOW = '2025-01-01T00:00:00Z';
-
-// Type-safe accessor for the mock store state
-function getMockStore() {
-  return useStore.getState() as unknown as Record<string, ReturnType<typeof vi.fn>>;
-}
-
-// Reset the mock store to have all the actions as vi.fn()
-function setupMockStore() {
-  const store = getMockStore();
-  const actions = [
-    'setWsConnected',
-    'addLogEntry',
-    'refreshActiveSession',
-    'addToast',
-    'onTurnStarted',
-    'onItemStarted',
-    'onItemUpdated',
-    'onItemCompleted',
-    'onItemDelta',
-    'onTurnCompleted',
-    'onTokenUsageUpdated',
-    'onTurnFailed',
-    'onTurnCancelled',
-    'onSessionTitle',
-  ];
-  for (const action of actions) {
-    store[action] = vi.fn();
-  }
-}
-
-// Mock WebSocket class
-class MockWebSocket {
-  static instances: MockWebSocket[] = [];
-  static lastInstance: MockWebSocket | null = null;
-
-  static readonly OPEN = 1;
-  static readonly CONNECTING = 0;
-  static readonly CLOSED = 3;
-
-  readyState = MockWebSocket.CONNECTING;
-  onopen: (() => void) | null = null;
-  onclose: (() => void) | null = null;
-  onerror: (() => void) | null = null;
-  onmessage: ((event: { data: string }) => void) | null = null;
-
-  constructor(public url: string) {
-    MockWebSocket.instances.push(this);
-    MockWebSocket.lastInstance = this;
-  }
-
-  close() {
-    this.readyState = MockWebSocket.CLOSED;
-    if (this.onclose) this.onclose();
-  }
-}
-
-describe('connectWebSocket', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    MockWebSocket.instances = [];
-    MockWebSocket.lastInstance = null;
-    setupMockStore();
-    vi.stubGlobal('WebSocket', MockWebSocket);
-    // Reset module-level state by calling disconnect first
-    disconnectWebSocket();
-  });
-
-  afterEach(() => {
-    disconnectWebSocket();
-    vi.unstubAllGlobals();
-  });
-
-  it('creates a new WebSocket connection', () => {
-    connectWebSocket();
-    expect(MockWebSocket.lastInstance).not.toBeNull();
-    expect(MockWebSocket.lastInstance!.url).toContain('/ws');
-  });
-
-  it('does not create duplicate connection when already connecting', () => {
-    connectWebSocket();
-    connectWebSocket();
-    expect(MockWebSocket.instances).toHaveLength(1);
-  });
-
-  it('calls setWsConnected(true) and addLogEntry on open', () => {
-    connectWebSocket();
-    const ws = MockWebSocket.lastInstance!;
-    ws.readyState = MockWebSocket.OPEN;
-    ws.onopen!();
-
-    const store = getMockStore();
-    expect(store.setWsConnected).toHaveBeenCalledWith(true);
-    expect(store.addLogEntry).toHaveBeenCalledWith('INFO', 'WebSocket connected');
-  });
-
-  it('does not call refreshActiveSession on first connect', () => {
-    connectWebSocket();
-    const ws = MockWebSocket.lastInstance!;
-    ws.readyState = MockWebSocket.OPEN;
-    ws.onopen!();
-
-    const store = getMockStore();
-    expect(store.refreshActiveSession).not.toHaveBeenCalled();
-  });
-
-  it('calls setWsConnected(false) on close', () => {
-    connectWebSocket();
-    const ws = MockWebSocket.lastInstance!;
-    ws.onclose!();
-
-    const store = getMockStore();
-    expect(store.setWsConnected).toHaveBeenCalledWith(false);
-    expect(store.addLogEntry).toHaveBeenCalledWith('WARN', 'WebSocket disconnected');
-  });
-});
-
-describe('disconnectWebSocket', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    MockWebSocket.instances = [];
-    MockWebSocket.lastInstance = null;
-    setupMockStore();
-    vi.stubGlobal('WebSocket', MockWebSocket);
-  });
-
-  afterEach(() => {
-    vi.unstubAllGlobals();
-  });
-
-  it('closes existing connection and clears handlers', () => {
-    connectWebSocket();
-    const ws = MockWebSocket.lastInstance!;
-    const closeSpy = vi.spyOn(ws, 'close');
-
-    disconnectWebSocket();
-
-    expect(closeSpy).toHaveBeenCalled();
-    expect(ws.onclose).toBeNull(); // prevents reconnect on intentional close
-    const store = getMockStore();
-    expect(store.setWsConnected).toHaveBeenCalledWith(false);
-  });
-
-  it('does nothing when no connection exists', () => {
-    disconnectWebSocket();
-    // Should not throw
-    expect(MockWebSocket.instances).toHaveLength(0);
-  });
-});
-
-describe('WebSocket event dispatch', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    MockWebSocket.instances = [];
-    MockWebSocket.lastInstance = null;
-    setupMockStore();
-    vi.stubGlobal('WebSocket', MockWebSocket);
-    connectWebSocket();
-  });
-
-  afterEach(() => {
-    disconnectWebSocket();
-    vi.unstubAllGlobals();
-  });
-
-  function sendMessage(data: unknown) {
-    const ws = MockWebSocket.lastInstance!;
-    ws.onmessage!({ data: JSON.stringify(data) });
-  }
-
-  it('dispatches turn:started event', () => {
-    sendMessage({ event: 'turn:started', data: { sessionId: 's1', turnId: 't1' } });
-    const store = getMockStore();
-    expect(store.onTurnStarted).toHaveBeenCalledWith('s1', 't1');
-  });
-
-  it('dispatches item:started event', () => {
-    const item: Item = {
-      id: 'i1', turn_id: 't1', external_item_id: 'e1', type: 'agent_message',
-      data: { text: 'hello' }, status: 'in_progress', created_at: NOW, updated_at: NOW,
-    };
-    sendMessage({ event: 'item:started', data: { sessionId: 's1', turnId: 't1', item } });
-    const store = getMockStore();
-    expect(store.onItemStarted).toHaveBeenCalledWith('s1', 't1', item);
-  });
-
-  it('dispatches item:updated event', () => {
-    const item: Item = {
-      id: 'i1', turn_id: 't1', external_item_id: 'e1', type: 'command_execution',
-      data: { command: 'ls' }, status: 'in_progress', created_at: NOW, updated_at: NOW,
-    };
-    sendMessage({ event: 'item:updated', data: { sessionId: 's1', turnId: 't1', item } });
-    const store = getMockStore();
-    expect(store.onItemUpdated).toHaveBeenCalledWith('s1', 't1', item);
-  });
-
-  it('dispatches item:completed event', () => {
-    const item: Item = {
-      id: 'i1', turn_id: 't1', external_item_id: 'e1', type: 'agent_message',
-      data: { text: 'done' }, status: 'completed', created_at: NOW, updated_at: NOW,
-    };
-    sendMessage({ event: 'item:completed', data: { sessionId: 's1', turnId: 't1', item } });
-    const store = getMockStore();
-    expect(store.onItemCompleted).toHaveBeenCalledWith('s1', 't1', item);
-  });
-
-  it('dispatches item:delta event', () => {
-    sendMessage({ event: 'item:delta', data: { sessionId: 's1', turnId: 't1', itemId: 'ext-i1', delta: 'Hello' } });
-    const store = getMockStore();
-    expect(store.onItemDelta).toHaveBeenCalledWith('s1', 't1', 'ext-i1', 'Hello');
-  });
-
-  it('dispatches turn:tokenUsage event', () => {
-    const usage: TokenUsage = {
-      input_tokens: 100, cached_input_tokens: 0, cache_write_input_tokens: 0,
-      output_tokens: 200, reasoning_output_tokens: 0,
-    };
-    sendMessage({ event: 'turn:tokenUsage', data: { sessionId: 's1', turnId: 't1', usage } });
-    const store = getMockStore();
-    expect(store.onTokenUsageUpdated).toHaveBeenCalledWith('s1', 't1', usage);
-  });
-
-  it('dispatches turn:completed event with usage', () => {
-    const usage: TokenUsage = {
-      input_tokens: 100, cached_input_tokens: 0, cache_write_input_tokens: 0,
-      output_tokens: 200, reasoning_output_tokens: 0,
-    };
-    sendMessage({ event: 'turn:completed', data: { sessionId: 's1', turnId: 't1', usage, hasUnreviewed: true } });
-    const store = getMockStore();
-    expect(store.onTurnCompleted).toHaveBeenCalledWith('s1', 't1', usage, true);
-  });
-
-  it('dispatches turn:completed event without usage (real app-server)', () => {
-    sendMessage({ event: 'turn:completed', data: { sessionId: 's1', turnId: 't1', hasUnreviewed: true } });
-    const store = getMockStore();
-    expect(store.onTurnCompleted).toHaveBeenCalledWith('s1', 't1', undefined, true);
-  });
-
-  it('dispatches turn:failed event with error', () => {
-    sendMessage({ event: 'turn:failed', data: { sessionId: 's1', turnId: 't1', error: 'crashed' } });
-    const store = getMockStore();
-    expect(store.onTurnFailed).toHaveBeenCalledWith('s1', 't1', 'crashed');
-  });
-
-  it('dispatches turn:cancelled event', () => {
-    sendMessage({ event: 'turn:cancelled', data: { sessionId: 's1', turnId: 't1' } });
-    const store = getMockStore();
-    expect(store.onTurnCancelled).toHaveBeenCalledWith('s1', 't1');
-  });
-
-  it('dispatches session:title event', () => {
-    sendMessage({ event: 'session:title', data: { sessionId: 's1', title: 'New Title' } });
-    const store = getMockStore();
-    expect(store.onSessionTitle).toHaveBeenCalledWith('s1', 'New Title');
-  });
-
-  it('ignores malformed JSON without error', () => {
-    const ws = MockWebSocket.lastInstance!;
-    // Should not throw
-    ws.onmessage!({ data: 'not json' });
-    const store = getMockStore();
-    expect(store.onTurnStarted).not.toHaveBeenCalled();
-  });
-
-  it('ignores unknown event types', () => {
-    sendMessage({ event: 'unknown:event', data: {} });
-    const store = getMockStore();
-    expect(store.onTurnStarted).not.toHaveBeenCalled();
-  });
-});

package/agent-pane/frontend/src/api/websocket.ts

@@ -1,238 +0,0 @@
-import { useStore } from '../store/store.ts';
-import type { Item, TokenUsage, Turn, DiscussionThread, ContextUsage } from '../types/index.ts';
-
-type WsEventHandler = (data: unknown) => void;
-
-let ws: WebSocket | null = null;
-let reconnectTimer: number | null = null;
-let reconnectDelay = 1000;
-const MAX_RECONNECT_DELAY = 10000;
-
-/** Build the WebSocket URL from the current page location. */
-function buildWsUrl(): string {
-  const proto = window.location.protocol === 'https:' ? 'wss:' : 'ws:';
-  return `${proto}//${window.location.host}/ws`;
-}
-
-/** Connect to the backend WebSocket server. Dispatches events to store actions. */
-export function connectWebSocket(): void {
-  if (ws && (ws.readyState === WebSocket.OPEN || ws.readyState === WebSocket.CONNECTING)) {
-    return;
-  }
-
-  ws = new WebSocket(buildWsUrl());
-
-  ws.onopen = () => {
-    const wasDisconnected = reconnectDelay > 1000;
-    reconnectDelay = 1000; // reset backoff
-    useStore.getState().setWsConnected(true);
-    useStore.getState().addLogEntry('INFO', 'WebSocket connected');
-
-    // On reconnect (not initial connect): reconcile active session
-    if (wasDisconnected) {
-      const state = useStore.getState();
-      if (state.activeSessionId) {
-        state.refreshActiveSession();
-        state.addToast('info', 'WebSocket reconnected — session state reconciled');
-      }
-    }
-  };
-
-  ws.onclose = () => {
-    useStore.getState().setWsConnected(false);
-    useStore.getState().addLogEntry('WARN', 'WebSocket disconnected');
-    useStore.getState().addToast('warn', 'WebSocket disconnected — reconnecting…');
-    scheduleReconnect();
-  };
-
-  ws.onerror = () => {
-    // onclose will fire after onerror
-  };
-
-  ws.onmessage = (event: MessageEvent) => {
-    try {
-      const msg = JSON.parse(event.data as string);
-      const handler = HANDLERS[msg.event as string];
-      if (handler) {
-        handler(msg.data);
-      }
-    } catch {
-      // Ignore malformed messages
-    }
-  };
-}
-
-/** Disconnect the WebSocket (used on unmount). */
-export function disconnectWebSocket(): void {
-  if (reconnectTimer) {
-    clearTimeout(reconnectTimer);
-    reconnectTimer = null;
-  }
-  if (ws) {
-    ws.onclose = null; // prevent reconnect on intentional close
-    ws.close();
-    ws = null;
-  }
-  useStore.getState().setWsConnected(false);
-}
-
-/** Schedule a reconnect with exponential backoff. */
-function scheduleReconnect(): void {
-  if (reconnectTimer) return;
-  reconnectTimer = window.setTimeout(() => {
-    reconnectTimer = null;
-    connectWebSocket();
-  }, reconnectDelay);
-  reconnectDelay = Math.min(reconnectDelay * 2, MAX_RECONNECT_DELAY);
-}
-
-// --- Event handlers — dispatch to store actions ---
-
-interface TurnEventPayload {
-  sessionId: string;
-  turnId: string;
-}
-
-interface ItemEventPayload {
-  sessionId: string;
-  turnId: string;
-  item: Item;
-}
-
-interface TurnCompletedPayload {
-  sessionId: string;
-  turnId: string;
-  usage?: TokenUsage;
-  hasUnreviewed?: boolean;
-}
-
-interface ItemDeltaPayload {
-  sessionId: string;
-  turnId: string;
-  itemId: string;
-  delta: string;
-}
-
-interface TokenUsageUpdatedPayload {
-  sessionId: string;
-  turnId: string;
-  usage: TokenUsage;
-}
-
-interface ContextUsagePayload {
-  sessionId: string;
-  totalTokens: number;
-  contextWindow: number;
-  percentage: number;
-}
-
-interface TurnFailedPayload {
-  sessionId: string;
-  turnId: string;
-  error: string;
-}
-
-interface SessionTitlePayload {
-  sessionId: string;
-  title: string;
-}
-
-interface BackgroundTasksPayload {
-  sessionId: string;
-  tasks: Array<{ task_id: string; task_type: string; description: string }>;
-}
-
-interface ThreadCreatedPayload {
-  sessionId: string;
-  thread: DiscussionThread;
-  turn: Turn;
-}
-
-interface ThreadFollowupPayload {
-  sessionId: string;
-  threadId: string;
-  turn: Turn;
-}
-
-interface ThreadResolvedPayload {
-  sessionId: string;
-  threadId: string;
-  status: 'open' | 'resolved';
-}
-
-interface ThreadDeletedPayload {
-  sessionId: string;
-  threadId: string;
-}
-
-const HANDLERS: Record<string, WsEventHandler> = {
-  'turn:started': (data) => {
-    const p = data as TurnEventPayload;
-    useStore.getState().onTurnStarted(p.sessionId, p.turnId);
-  },
-  'item:started': (data) => {
-    const p = data as ItemEventPayload;
-    useStore.getState().onItemStarted(p.sessionId, p.turnId, p.item);
-  },
-  'item:updated': (data) => {
-    const p = data as ItemEventPayload;
-    useStore.getState().onItemUpdated(p.sessionId, p.turnId, p.item);
-  },
-  'item:completed': (data) => {
-    const p = data as ItemEventPayload;
-    useStore.getState().onItemCompleted(p.sessionId, p.turnId, p.item);
-  },
-  'item:delta': (data) => {
-    const p = data as ItemDeltaPayload;
-    useStore.getState().onItemDelta(p.sessionId, p.turnId, p.itemId, p.delta);
-  },
-  'turn:completed': (data) => {
-    const p = data as TurnCompletedPayload;
-    useStore.getState().onTurnCompleted(p.sessionId, p.turnId, p.usage, p.hasUnreviewed);
-  },
-  'turn:tokenUsage': (data) => {
-    const p = data as TokenUsageUpdatedPayload;
-    useStore.getState().onTokenUsageUpdated(p.sessionId, p.turnId, p.usage);
-  },
-  'turn:contextUsage': (data) => {
-    const p = data as ContextUsagePayload;
-    const ctx: ContextUsage = {
-      totalTokens: p.totalTokens,
-      contextWindow: p.contextWindow,
-      percentage: p.percentage,
-    };
-    useStore.getState().onContextUsageUpdated(p.sessionId, ctx);
-  },
-  'turn:failed': (data) => {
-    const p = data as TurnFailedPayload;
-    useStore.getState().onTurnFailed(p.sessionId, p.turnId, p.error);
-  },
-  'turn:cancelled': (data) => {
-    const p = data as TurnEventPayload;
-    useStore.getState().onTurnCancelled(p.sessionId, p.turnId);
-  },
-  'session:title': (data) => {
-    const p = data as SessionTitlePayload;
-    useStore.getState().onSessionTitle(p.sessionId, p.title);
-  },
-  'background_tasks': (data) => {
-    const p = data as BackgroundTasksPayload;
-    useStore.getState().onBackgroundTasksChanged(p.sessionId, p.tasks);
-  },
-  'thread:created': (data) => {
-    const p = data as ThreadCreatedPayload;
-    useStore.getState().onThreadCreated(p.sessionId, p.thread, p.turn);
-  },
-  'thread:followup': (data) => {
-    const p = data as ThreadFollowupPayload;
-    useStore.getState().onThreadFollowup(p.sessionId, p.threadId, p.turn);
-  },
-  'thread:resolved': (data) => {
-    const p = data as ThreadResolvedPayload;
-    useStore.getState().onThreadResolved(p.sessionId, p.threadId, p.status);
-  },
-  'thread:deleted': (data) => {
-    const p = data as ThreadDeletedPayload;
-    useStore.getState().onThreadDeleted(p.sessionId, p.threadId);
-  },
-};

package/agent-pane/frontend/src/api/workspaces.test.ts

@@ -1,112 +0,0 @@
-import { describe, it, expect, beforeEach, vi } from 'vitest';
-
-// Mock the client module to capture call signatures without network access
-vi.mock('./client.ts', () => ({
-  apiGet: vi.fn(),
-  apiPost: vi.fn(),
-  apiDelete: vi.fn(),
-}));
-
-import { apiGet, apiPost, apiDelete } from './client.ts';
-import {
-  fetchWorkspaces,
-  createWorkspace,
-  hideWorkspace,
-  deleteWorkspace,
-  pickDirectory,
-} from './workspaces.ts';
-import type { Workspace } from '../types/index.ts';
-
-const NOW = '2025-01-01T00:00:00Z';
-
-function makeWorkspace(overrides: Partial<Workspace> = {}): Workspace {
-  return {
-    id: 'w1',
-    path: '/test/path',
-    label: null,
-    deleted: 0,
-    created_at: NOW,
-    ...overrides,
-  };
-}
-
-describe('fetchWorkspaces', () => {
-  beforeEach(() => vi.clearAllMocks());
-
-  it('calls apiGet with /workspaces', async () => {
-    const workspaces = [makeWorkspace()];
-    vi.mocked(apiGet).mockResolvedValue(workspaces);
-    const result = await fetchWorkspaces();
-    expect(apiGet).toHaveBeenCalledWith('/workspaces');
-    expect(result).toEqual(workspaces);
-  });
-});
-
-describe('createWorkspace', () => {
-  beforeEach(() => vi.clearAllMocks());
-
-  it('calls apiPost with path', async () => {
-    const ws = makeWorkspace({ path: '/new' });
-    vi.mocked(apiPost).mockResolvedValue(ws);
-    await createWorkspace('/new');
-    expect(apiPost).toHaveBeenCalledWith('/workspaces', { path: '/new', label: undefined });
-  });
-
-  it('passes label when provided', async () => {
-    const ws = makeWorkspace({ path: '/new', label: 'My Project' });
-    vi.mocked(apiPost).mockResolvedValue(ws);
-    await createWorkspace('/new', 'My Project');
-    expect(apiPost).toHaveBeenCalledWith('/workspaces', { path: '/new', label: 'My Project' });
-  });
-});
-
-describe('hideWorkspace', () => {
-  beforeEach(() => vi.clearAllMocks());
-
-  it('calls apiPost with path on /workspaces/hide', async () => {
-    vi.mocked(apiPost).mockResolvedValue({ success: true });
-    await hideWorkspace('/path');
-    expect(apiPost).toHaveBeenCalledWith('/workspaces/hide', { path: '/path' });
-  });
-});
-
-describe('deleteWorkspace', () => {
-  beforeEach(() => vi.clearAllMocks());
-
-  it('calls apiDelete with /workspaces/:id', async () => {
-    vi.mocked(apiDelete).mockResolvedValue({ success: true });
-    await deleteWorkspace('w1');
-    expect(apiDelete).toHaveBeenCalledWith('/workspaces/w1');
-  });
-});
-
-describe('pickDirectory', () => {
-  beforeEach(() => {
-    vi.clearAllMocks();
-    global.fetch = vi.fn();
-  });
-
-  it('returns cancelled when status is 204', async () => {
-    (global.fetch as ReturnType<typeof vi.fn>).mockResolvedValue({ status: 204 });
-    const result = await pickDirectory();
-    expect(result).toEqual({ cancelled: true });
-  });
-
-  it('returns path on ok response', async () => {
-    (global.fetch as ReturnType<typeof vi.fn>).mockResolvedValue({
-      ok: true,
-      json: () => Promise.resolve({ path: '/selected/dir' }),
-    });
-    const result = await pickDirectory();
-    expect(result).toEqual({ path: '/selected/dir' });
-  });
-
-  it('throws on error response', async () => {
-    (global.fetch as ReturnType<typeof vi.fn>).mockResolvedValue({
-      ok: false,
-      status: 500,
-      statusText: 'Internal Server Error',
-    });
-    await expect(pickDirectory()).rejects.toThrow('GET /api/pick-directory failed: 500 Internal Server Error');
-  });
-});

package/agent-pane/frontend/src/api/workspaces.ts

@@ -1,38 +0,0 @@
-import { apiGet, apiPost, apiDelete } from './client.ts';
-import type { Workspace } from '../types/index.ts';
-
-interface PickDirectoryResult {
-  path?: string;
-  cancelled?: boolean;
-}
-
-/** Fetch all workspaces (active and soft-deleted), ordered by creation date. */
-export function fetchWorkspaces(): Promise<Workspace[]> {
-  return apiGet<Workspace[]>('/workspaces');
-}
-
-/** Create a new workspace at the given path, or restore a soft-deleted one. */
-export function createWorkspace(path: string, label?: string): Promise<Workspace> {
-  return apiPost<Workspace>('/workspaces', { path, label });
-}
-
-/** Soft-delete (hide) a workspace by path. Sessions keep their cwd. */
-export function hideWorkspace(path: string): Promise<{ success: boolean }> {
-  return apiPost<{ success: boolean }>('/workspaces/hide', { path });
-}
-
-/** Soft-delete a workspace by ID. Does NOT delete sessions. */
-export function deleteWorkspace(id: string): Promise<{ success: boolean }> {
-  return apiDelete<{ success: boolean }>(`/workspaces/${id}`);
-}
-
-/** Open the native OS folder picker dialog (macOS only via osascript).
- *  @returns `{ path }` on success, or `{ cancelled: true }` if the user dismissed the dialog. */
-export async function pickDirectory(): Promise<PickDirectoryResult> {
-  const res = await fetch('/api/pick-directory');
-  if (res.status === 204) return { cancelled: true };
-  if (!res.ok) {
-    throw new Error(`GET /api/pick-directory failed: ${res.status} ${res.statusText}`);
-  }
-  return res.json() as Promise<PickDirectoryResult>;
-}