repoburg 1.3.188 → 1.3.196

package/agent-pane/backend/src/ws/index.test.ts

@@ -0,0 +1,107 @@
+import { describe, it, expect, beforeEach, vi } from 'vitest';
+import { broadcast, handleUpgrade, getWss, initWs } from './index.ts';
+import type { WebSocket, WebSocketServer } from 'ws';
+import type { IncomingMessage } from 'node:http';
+import type { Duplex } from 'node:stream';
+
+describe('getWss', () => {
+  it('returns null before initWs is called', async () => {
+    vi.resetModules();
+    const { getWss: freshGetWss } = await import('./index.ts');
+    expect(freshGetWss()).toBeNull();
+  });
+
+  it('returns instance after initWs', () => {
+    const wss = initWs();
+    expect(getWss()).toBe(wss);
+  });
+});
+
+describe('broadcast', () => {
+  let wss: WebSocketServer;
+
+  beforeEach(() => {
+    wss = initWs();
+  });
+
+  it('sends JSON message to OPEN clients', () => {
+    const client = { readyState: 1, OPEN: 1, send: vi.fn() } as unknown as WebSocket;
+    wss.clients.add(client);
+    broadcast('turn:started', { sessionId: 's1' });
+    expect(client.send).toHaveBeenCalledWith(JSON.stringify({ event: 'turn:started', data: { sessionId: 's1' } }));
+  });
+
+  it('skips non-OPEN clients', () => {
+    const client = { readyState: 3, OPEN: 1, send: vi.fn() } as unknown as WebSocket;
+    wss.clients.add(client);
+    broadcast('turn:started', {});
+    expect(client.send).not.toHaveBeenCalled();
+  });
+
+  it('sends to multiple OPEN clients', () => {
+    const c1 = { readyState: 1, OPEN: 1, send: vi.fn() } as unknown as WebSocket;
+    const c2 = { readyState: 1, OPEN: 1, send: vi.fn() } as unknown as WebSocket;
+    wss.clients.add(c1);
+    wss.clients.add(c2);
+    broadcast('item:completed', { id: 'i1' });
+    expect(c1.send).toHaveBeenCalledTimes(1);
+    expect(c2.send).toHaveBeenCalledTimes(1);
+  });
+
+  it('is no-op when no clients connected', () => {
+    broadcast('turn:started', {});
+    // No error thrown
+  });
+
+  it('is no-op when wss is not initialised', async () => {
+    vi.resetModules();
+    const { broadcast: freshBroadcast } = await import('./index.ts');
+    freshBroadcast('turn:started', {});
+    // No error thrown
+  });
+});
+
+describe('handleUpgrade', () => {
+  function makeMockWss(): WebSocketServer {
+    return { handleUpgrade: vi.fn(), emit: vi.fn() } as unknown as WebSocketServer;
+  }
+
+  it('calls wss.handleUpgrade for /ws path', () => {
+    const mockWss = makeMockWss();
+    const request = { url: '/ws' } as unknown as IncomingMessage;
+    const socket = { destroy: vi.fn() } as unknown as Duplex;
+    const head = Buffer.alloc(0);
+
+    handleUpgrade(mockWss, request, socket, head);
+
+    expect(mockWss.handleUpgrade).toHaveBeenCalledWith(request, socket, head, expect.any(Function));
+    expect(socket.destroy).not.toHaveBeenCalled();
+  });
+
+  it('emits connection event when upgrade completes', () => {
+    const mockWss = makeMockWss();
+    const request = { url: '/ws' } as unknown as IncomingMessage;
+    const socket = { destroy: vi.fn() } as unknown as Duplex;
+    const head = Buffer.alloc(0);
+
+    handleUpgrade(mockWss, request, socket, head);
+
+    const callback = (mockWss.handleUpgrade as ReturnType<typeof vi.fn>).mock.calls[0][3] as (ws: WebSocket) => void;
+    const mockWs = { readyState: 1 } as unknown as WebSocket;
+    callback(mockWs);
+
+    expect(mockWss.emit).toHaveBeenCalledWith('connection', mockWs, request);
+  });
+
+  it('destroys socket for non-/ws path', () => {
+    const mockWss = makeMockWss();
+    const request = { url: '/api/something' } as unknown as IncomingMessage;
+    const socket = { destroy: vi.fn() } as unknown as Duplex;
+    const head = Buffer.alloc(0);
+
+    handleUpgrade(mockWss, request, socket, head);
+
+    expect(mockWss.handleUpgrade).not.toHaveBeenCalled();
+    expect(socket.destroy).toHaveBeenCalled();
+  });
+});

package/agent-pane/backend/src/ws/index.ts

@@ -1,21 +1,25 @@
+import type { IncomingMessage } from 'node:http';
+import type { Duplex } from 'node:stream';
 import type { WebSocket } from 'ws';
 import { WebSocketServer } from 'ws';
 
 let wss: WebSocketServer | null = null;
 
-/** Attach WebSocket server to an existing HTTP server (noServer mode). */
+/** Initialise the WebSocket server in noServer mode.
+ *  Call `handleUpgrade` from the HTTP server's 'upgrade' event to accept connections.
+ *  @returns The created `WebSocketServer` instance. */
 export function initWs(): WebSocketServer {
   wss = new WebSocketServer({ noServer: true });
   return wss;
 }
 
-/** Handle HTTP upgrade for the /ws path. Call from server.on('upgrade'). */
-export function handleUpgrade(
-  wss: WebSocketServer,
-  request: any,
-  socket: any,
-  head: any,
-): void {
+/** Handle an HTTP upgrade request for the `/ws` path.
+ *  If the URL does not start with `/ws`, the socket is destroyed.
+ *  @param wss — The WebSocket server to upgrade to.
+ *  @param request — The incoming HTTP upgrade request.
+ *  @param socket — The raw TCP socket.
+ *  @param head — The first packet of the upgraded connection. */
+export function handleUpgrade(wss: WebSocketServer, request: IncomingMessage, socket: Duplex, head: Buffer): void {
   const url = request.url || '';
   if (url.startsWith('/ws')) {
     wss.handleUpgrade(request, socket, head, (ws: WebSocket) => {
@@ -26,7 +30,10 @@ export function handleUpgrade(
   }
 }
 
-/** Broadcast a JSON event to all connected WebSocket clients. */
+/** Broadcast a JSON event to all connected WebSocket clients.
+ *  No-op if the server is not initialised or no clients are connected.
+ *  @param event — Event name (e.g. `'turn:started'`, `'item:completed'`).
+ *  @param data — Payload object to serialise as JSON. */
 export function broadcast(event: string, data: unknown): void {
   if (!wss) return;
   const message = JSON.stringify({ event, data });
@@ -37,7 +44,8 @@ export function broadcast(event: string, data: unknown): void {
   }
 }
 
-/** Get the WebSocket server instance (or null if not initialized). */
+/** Get the current WebSocket server instance.
+ *  @returns The `WebSocketServer`, or `null` if not initialised. */
 export function getWss(): WebSocketServer | null {
   return wss;
-}
+}

package/agent-pane/backend/tsconfig.json

@@ -7,7 +7,6 @@
     "strict": true,
     "skipLibCheck": true,
     "outDir": "dist",
-    "rootDir": "src",
     "resolveJsonModule": true,
     "declaration": false,
     "sourceMap": true,
@@ -16,7 +15,10 @@
     "noUnusedParameters": true,
     "noImplicitReturns": true,
     "noFallthroughCasesInSwitch": true,
-    "allowImportingTsExtensions": true
+    "allowImportingTsExtensions": true,
+    "paths": {
+      "@agentpane/shared": ["../shared/types.ts"]
+    }
   },
   "include": ["src/**/*"],
   "exclude": ["node_modules", "dist"]

package/agent-pane/backend/vitest.config.ts

@@ -0,0 +1,20 @@
+import { defineConfig } from 'vitest/config';
+
+/**
+ * Backend vitest configuration.
+ *
+ * RAM mitigation: single-fork mode + no file parallelism.
+ * Runs all test files in one Node.js process, one file at a time.
+ */
+export default defineConfig({
+  test: {
+    environment: 'node',
+    // RAM: single process, one file at a time
+    pool: 'forks',
+    poolOptions: {
+      forks: { singleFork: true },
+    },
+    fileParallelism: false,
+    maxConcurrency: 1,
+  },
+});

package/agent-pane/eslint.config.js

@@ -0,0 +1,33 @@
+import js from '@eslint/js';
+import tseslint from 'typescript-eslint';
+import prettier from 'eslint-config-prettier';
+
+export default [
+  {
+    ignores: ['**/dist/**', '**/node_modules/**', '**/*.config.{js,ts}'],
+  },
+  js.configs.recommended,
+  ...tseslint.configs.recommended,
+  prettier,
+  {
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'module',
+    },
+    rules: {
+      '@typescript-eslint/no-unused-vars': ['error', { argsIgnorePattern: '^_' }],
+      '@typescript-eslint/no-explicit-any': 'warn',
+      'no-console': 'off',
+      'prefer-const': 'error',
+    },
+  },
+  {
+    // React frontend rules
+    files: ['frontend/**/*.tsx', 'frontend/**/*.ts'],
+    languageOptions: {
+      parserOptions: {
+        ecmaFeatures: { jsx: true },
+      },
+    },
+  },
+];

package/agent-pane/frontend/coverage/base.css

@@ -0,0 +1,224 @@
+body, html {
+  margin:0; padding: 0;
+  height: 100%;
+}
+body {
+    font-family: Helvetica Neue, Helvetica, Arial;
+    font-size: 14px;
+    color:#333;
+}
+.small { font-size: 12px; }
+*, *:after, *:before {
+  -webkit-box-sizing:border-box;
+     -moz-box-sizing:border-box;
+          box-sizing:border-box;
+  }
+h1 { font-size: 20px; margin: 0;}
+h2 { font-size: 14px; }
+pre {
+    font: 12px/1.4 Consolas, "Liberation Mono", Menlo, Courier, monospace;
+    margin: 0;
+    padding: 0;
+    -moz-tab-size: 2;
+    -o-tab-size:  2;
+    tab-size: 2;
+}
+a { color:#0074D9; text-decoration:none; }
+a:hover { text-decoration:underline; }
+.strong { font-weight: bold; }
+.space-top1 { padding: 10px 0 0 0; }
+.pad2y { padding: 20px 0; }
+.pad1y { padding: 10px 0; }
+.pad2x { padding: 0 20px; }
+.pad2 { padding: 20px; }
+.pad1 { padding: 10px; }
+.space-left2 { padding-left:55px; }
+.space-right2 { padding-right:20px; }
+.center { text-align:center; }
+.clearfix { display:block; }
+.clearfix:after {
+  content:'';
+  display:block;
+  height:0;
+  clear:both;
+  visibility:hidden;
+  }
+.fl { float: left; }
+@media only screen and (max-width:640px) {
+  .col3 { width:100%; max-width:100%; }
+  .hide-mobile { display:none!important; }
+}
+
+.quiet {
+  color: #7f7f7f;
+  color: rgba(0,0,0,0.5);
+}
+.quiet a { opacity: 0.7; }
+
+.fraction {
+  font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace;
+  font-size: 10px;
+  color: #555;
+  background: #E8E8E8;
+  padding: 4px 5px;
+  border-radius: 3px;
+  vertical-align: middle;
+}
+
+div.path a:link, div.path a:visited { color: #333; }
+table.coverage {
+  border-collapse: collapse;
+  margin: 10px 0 0 0;
+  padding: 0;
+}
+
+table.coverage td {
+  margin: 0;
+  padding: 0;
+  vertical-align: top;
+}
+table.coverage td.line-count {
+    text-align: right;
+    padding: 0 5px 0 20px;
+}
+table.coverage td.line-coverage {
+    text-align: right;
+    padding-right: 10px;
+    min-width:20px;
+}
+
+table.coverage td span.cline-any {
+    display: inline-block;
+    padding: 0 5px;
+    width: 100%;
+}
+.missing-if-branch {
+    display: inline-block;
+    margin-right: 5px;
+    border-radius: 3px;
+    position: relative;
+    padding: 0 4px;
+    background: #333;
+    color: yellow;
+}
+
+.skip-if-branch {
+    display: none;
+    margin-right: 10px;
+    position: relative;
+    padding: 0 4px;
+    background: #ccc;
+    color: white;
+}
+.missing-if-branch .typ, .skip-if-branch .typ {
+    color: inherit !important;
+}
+.coverage-summary {
+  border-collapse: collapse;
+  width: 100%;
+}
+.coverage-summary tr { border-bottom: 1px solid #bbb; }
+.keyline-all { border: 1px solid #ddd; }
+.coverage-summary td, .coverage-summary th { padding: 10px; }
+.coverage-summary tbody { border: 1px solid #bbb; }
+.coverage-summary td { border-right: 1px solid #bbb; }
+.coverage-summary td:last-child { border-right: none; }
+.coverage-summary th {
+  text-align: left;
+  font-weight: normal;
+  white-space: nowrap;
+}
+.coverage-summary th.file { border-right: none !important; }
+.coverage-summary th.pct { }
+.coverage-summary th.pic,
+.coverage-summary th.abs,
+.coverage-summary td.pct,
+.coverage-summary td.abs { text-align: right; }
+.coverage-summary td.file { white-space: nowrap;  }
+.coverage-summary td.pic { min-width: 120px !important;  }
+.coverage-summary tfoot td { }
+
+.coverage-summary .sorter {
+    height: 10px;
+    width: 7px;
+    display: inline-block;
+    margin-left: 0.5em;
+    background: url(sort-arrow-sprite.png) no-repeat scroll 0 0 transparent;
+}
+.coverage-summary .sorted .sorter {
+    background-position: 0 -20px;
+}
+.coverage-summary .sorted-desc .sorter {
+    background-position: 0 -10px;
+}
+.status-line {  height: 10px; }
+/* yellow */
+.cbranch-no { background: yellow !important; color: #111; }
+/* dark red */
+.red.solid, .status-line.low, .low .cover-fill { background:#C21F39 }
+.low .chart { border:1px solid #C21F39 }
+.highlighted,
+.highlighted .cstat-no, .highlighted .fstat-no, .highlighted .cbranch-no{
+  background: #C21F39 !important;
+}
+/* medium red */
+.cstat-no, .fstat-no, .cbranch-no, .cbranch-no { background:#F6C6CE }
+/* light red */
+.low, .cline-no { background:#FCE1E5 }
+/* light green */
+.high, .cline-yes { background:rgb(230,245,208) }
+/* medium green */
+.cstat-yes { background:rgb(161,215,106) }
+/* dark green */
+.status-line.high, .high .cover-fill { background:rgb(77,146,33) }
+.high .chart { border:1px solid rgb(77,146,33) }
+/* dark yellow (gold) */
+.status-line.medium, .medium .cover-fill { background: #f9cd0b; }
+.medium .chart { border:1px solid #f9cd0b; }
+/* light yellow */
+.medium { background: #fff4c2; }
+
+.cstat-skip { background: #ddd; color: #111; }
+.fstat-skip { background: #ddd; color: #111 !important; }
+.cbranch-skip { background: #ddd !important; color: #111; }
+
+span.cline-neutral { background: #eaeaea; }
+
+.coverage-summary td.empty {
+    opacity: .5;
+    padding-top: 4px;
+    padding-bottom: 4px;
+    line-height: 1;
+    color: #888;
+}
+
+.cover-fill, .cover-empty {
+  display:inline-block;
+  height: 12px;
+}
+.chart {
+  line-height: 0;
+}
+.cover-empty {
+    background: white;
+}
+.cover-full {
+    border-right: none !important;
+}
+pre.prettyprint {
+    border: none !important;
+    padding: 0 !important;
+    margin: 0 !important;
+}
+.com { color: #999 !important; }
+.ignore-none { color: #999; font-weight: normal; }
+
+.wrapper {
+  min-height: 100%;
+  height: auto !important;
+  height: 100%;
+  margin: 0 auto -48px;
+}
+.footer, .push {
+  height: 48px;
+}

package/agent-pane/frontend/coverage/block-navigation.js

@@ -0,0 +1,87 @@
+/* eslint-disable */
+var jumpToCode = (function init() {
+    // Classes of code we would like to highlight in the file view
+    var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no'];
+
+    // Elements to highlight in the file listing view
+    var fileListingElements = ['td.pct.low'];
+
+    // We don't want to select elements that are direct descendants of another match
+    var notSelector = ':not(' + missingCoverageClasses.join('):not(') + ') > '; // becomes `:not(a):not(b) > `
+
+    // Selector that finds elements on the page to which we can jump
+    var selector =
+        fileListingElements.join(', ') +
+        ', ' +
+        notSelector +
+        missingCoverageClasses.join(', ' + notSelector); // becomes `:not(a):not(b) > a, :not(a):not(b) > b`
+
+    // The NodeList of matching elements
+    var missingCoverageElements = document.querySelectorAll(selector);
+
+    var currentIndex;
+
+    function toggleClass(index) {
+        missingCoverageElements
+            .item(currentIndex)
+            .classList.remove('highlighted');
+        missingCoverageElements.item(index).classList.add('highlighted');
+    }
+
+    function makeCurrent(index) {
+        toggleClass(index);
+        currentIndex = index;
+        missingCoverageElements.item(index).scrollIntoView({
+            behavior: 'smooth',
+            block: 'center',
+            inline: 'center'
+        });
+    }
+
+    function goToPrevious() {
+        var nextIndex = 0;
+        if (typeof currentIndex !== 'number' || currentIndex === 0) {
+            nextIndex = missingCoverageElements.length - 1;
+        } else if (missingCoverageElements.length > 1) {
+            nextIndex = currentIndex - 1;
+        }
+
+        makeCurrent(nextIndex);
+    }
+
+    function goToNext() {
+        var nextIndex = 0;
+
+        if (
+            typeof currentIndex === 'number' &&
+            currentIndex < missingCoverageElements.length - 1
+        ) {
+            nextIndex = currentIndex + 1;
+        }
+
+        makeCurrent(nextIndex);
+    }
+
+    return function jump(event) {
+        if (
+            document.getElementById('fileSearch') === document.activeElement &&
+            document.activeElement != null
+        ) {
+            // if we're currently focused on the search input, we don't want to navigate
+            return;
+        }
+
+        switch (event.which) {
+            case 78: // n
+            case 74: // j
+                goToNext();
+                break;
+            case 66: // b
+            case 75: // k
+            case 80: // p
+                goToPrevious();
+                break;
+        }
+    };
+})();
+window.addEventListener('keydown', jumpToCode);