repoburg 1.3.163 → 1.3.166

package/daemon/dist/mcp-gateway.js

@@ -25,6 +25,11 @@ const types_js_1 = require("@modelcontextprotocol/sdk/types.js");
 const crypto_1 = require("crypto");
 const stateManager_1 = require("./stateManager");
 const serviceManager_1 = require("./serviceManager");
+/**
+ * Daemon-level tool names exposed by the gateway (always available, no
+ * instance routing needed).
+ */
+const DAEMON_TOOL_NAMES = ['list_instances', 'start_instance', 'stop_instance'];
 // ---------------------------------------------------------------------------
 // Gateway
 // ---------------------------------------------------------------------------
@@ -33,6 +38,10 @@ const INSTANCE_NAME_PARAM = {
     type: 'string',
     description: 'Name of the Repoburg instance to manage. Use the list_instances tool to see available instances.',
 };
+/** Extracts an error message from an unknown catch value. */
+function errorMessage(err) {
+    return err instanceof Error ? err.message : String(err);
+}
 class McpGateway {
     constructor() {
         this.sessions = new Map();
@@ -101,7 +110,7 @@ class McpGateway {
             res.status(405).send('Method not allowed');
         }
         catch (err) {
-            console.error(`[McpGateway] Error handling MCP request: ${err.message}`);
+            console.error(`[McpGateway] Error handling MCP request: ${errorMessage(err)}`);
             if (!res.headersSent) {
                 res.status(500).send('Internal server error');
             }
@@ -127,17 +136,23 @@ class McpGateway {
             const { name, arguments: args } = request.params;
             const toolArgs = args ?? {};
             // Daemon-level tools
+            let result;
             if (name === 'list_instances') {
-                return this.handleListInstances();
+                result = this.handleListInstances();
+            }
+            else if (name === 'start_instance') {
+                result = await this.handleStartInstance(toolArgs);
             }
-            if (name === 'start_instance') {
-                return this.handleStartInstance(toolArgs);
+            else if (name === 'stop_instance') {
+                result = await this.handleStopInstance(toolArgs);
             }
-            if (name === 'stop_instance') {
-                return this.handleStopInstance(toolArgs);
+            else {
+                // manage_* tools — proxy to the target instance
+                result = await this.handleManageTool(name, toolArgs);
             }
-            // manage_* tools — proxy to the target instance
-            return this.handleManageTool(name, toolArgs);
+            // Cast to the SDK's expected ServerResult union — structurally compatible
+            // but the Zod-inferred type is too narrow for direct assignment.
+            return result;
         });
         return server;
     }
@@ -165,12 +180,16 @@ class McpGateway {
                 console.warn(`[McpGateway] Failed to fetch tools from instance '${runningInstance.name}' (${resp.status}).`);
                 return;
             }
-            const tools = (await resp.json());
-            this.toolCache = tools.map((tool) => this.augmentWithInstanceName(tool));
+            const rawTools = (await resp.json());
+            this.toolCache = rawTools.map((raw) => this.augmentWithInstanceName({
+                name: raw.tool_name,
+                description: raw.description,
+                inputSchema: raw.input_schema,
+            }));
             console.log(`[McpGateway] Cached ${this.toolCache.length} manage_* tools from instance '${runningInstance.name}'.`);
         }
         catch (err) {
-            console.warn(`[McpGateway] Could not refresh tool cache: ${err.message}`);
+            console.warn(`[McpGateway] Could not refresh tool cache: ${errorMessage(err)}`);
         }
         finally {
             this.isRefreshing = false;
@@ -256,21 +275,22 @@ class McpGateway {
     }
     async handleStartInstance(args) {
         const projectPath = args.path;
-        if (!projectPath) {
+        if (typeof projectPath !== 'string') {
             return this.errorResult('Missing required parameter: path');
         }
+        const name = typeof args.name === 'string' ? args.name : undefined;
         try {
-            const service = await serviceManager_1.serviceManager.start(projectPath, args.name);
+            const service = await serviceManager_1.serviceManager.start(projectPath, name);
             this.invalidateToolCache();
             return this.textResult(`Instance '${service.name}' started on port ${service.port} (path: ${service.path}).`);
         }
         catch (err) {
-            return this.errorResult(`Failed to start instance: ${err.message}`);
+            return this.errorResult(`Failed to start instance: ${errorMessage(err)}`);
         }
     }
     async handleStopInstance(args) {
         const name = args.name;
-        if (!name) {
+        if (typeof name !== 'string') {
             return this.errorResult('Missing required parameter: name');
         }
         try {
@@ -278,7 +298,7 @@ class McpGateway {
             return this.textResult(`Instance '${name}' stopped.`);
         }
         catch (err) {
-            return this.errorResult(`Failed to stop instance: ${err.message}`);
+            return this.errorResult(`Failed to stop instance: ${errorMessage(err)}`);
         }
     }
     // -------------------------------------------------------------------------
@@ -286,7 +306,7 @@ class McpGateway {
     // -------------------------------------------------------------------------
     async handleManageTool(toolName, args) {
         const instanceName = args.instance_name;
-        if (!instanceName) {
+        if (typeof instanceName !== 'string') {
             return this.errorResult(`Missing required parameter: instance_name. Use the list_instances tool to see available instances.`);
         }
         const service = stateManager_1.stateManager.getService(instanceName);
@@ -314,7 +334,7 @@ class McpGateway {
             return this.toToolResult(result);
         }
         catch (err) {
-            return this.errorResult(`Failed to reach instance '${instanceName}': ${err.message}`);
+            return this.errorResult(`Failed to reach instance '${instanceName}': ${errorMessage(err)}`);
         }
     }
     // -------------------------------------------------------------------------

package/daemon/dist/mcp-gateway.spec.js

@@ -0,0 +1,295 @@
+"use strict";
+/**
+ * Tests for the MCP gateway — the daemon-hosted single MCP entry point that
+ * manages all Repoburg instances.
+ *
+ * Tests focus on:
+ *  - Tool cache refresh (fetch from running instance, augment with instance_name)
+ *  - Cache invalidation
+ *  - getGatewayInfo() shape
+ *  - Daemon-level tool routing (list_instances, start_instance, stop_instance)
+ *  - manage_* proxy routing (missing instance_name, unknown instance, not running,
+ *    valid POST, fetch failure, result mapping)
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+// Mock dependencies before importing the gateway.
+jest.mock('./stateManager', () => ({
+    stateManager: {
+        getServices: jest.fn(),
+        getService: jest.fn(),
+    },
+}));
+jest.mock('./serviceManager', () => ({
+    serviceManager: {
+        start: jest.fn(),
+        stop: jest.fn(),
+    },
+}));
+// Mock MCP SDK — we test the gateway's logic, not the SDK.
+jest.mock('@modelcontextprotocol/sdk/server/index.js', () => ({
+    Server: jest.fn().mockImplementation(() => ({
+        setRequestHandler: jest.fn(),
+        connect: jest.fn(),
+        close: jest.fn(),
+    })),
+}));
+jest.mock('@modelcontextprotocol/sdk/server/streamableHttp.js', () => ({
+    StreamableHTTPServerTransport: jest.fn(),
+}));
+jest.mock('@modelcontextprotocol/sdk/types.js', () => ({
+    CallToolRequestSchema: 'callTool',
+    ListToolsRequestSchema: 'listTools',
+    isInitializeRequest: jest.fn(),
+}));
+const mcp_gateway_1 = require("./mcp-gateway");
+const stateManager_1 = require("./stateManager");
+const serviceManager_1 = require("./serviceManager");
+const mockStateManager = stateManager_1.stateManager;
+const mockServiceManager = serviceManager_1.serviceManager;
+// Helper: create a mock Service object.
+function mockService(name, status = 'running') {
+    return { name, path: `/projects/${name}`, port: 3400, status, pid: 12345 };
+}
+// Helper: raw tool definition as returned by backend's GET /mcp-internal/tools.
+function rawToolDef(name, description, required = []) {
+    return {
+        tool_name: name,
+        description,
+        input_schema: {
+            type: 'object',
+            properties: required.reduce((acc, r) => {
+                acc[r] = { type: 'string', description: `${r} param` };
+                return acc;
+            }, {}),
+            required: required.length > 0 ? required : undefined,
+        },
+    };
+}
+describe('McpGateway', () => {
+    beforeEach(() => {
+        jest.clearAllMocks();
+        // Reset gateway state between tests.
+        mcp_gateway_1.mcpGateway.invalidateToolCache();
+        // Default: no instances.
+        mockStateManager.getServices.mockReturnValue([]);
+        mockStateManager.getService.mockReturnValue(undefined);
+        mockServiceManager.start.mockReset();
+        mockServiceManager.stop.mockReset();
+    });
+    describe('refreshToolCache', () => {
+        it('should fetch tools from a running instance and augment with instance_name', async () => {
+            mockStateManager.getServices.mockReturnValue([mockService('alpha', 'running')]);
+            global.fetch = jest.fn().mockResolvedValue({
+                ok: true,
+                json: async () => [rawToolDef('manage_agents', 'Manage agents', ['action'])],
+            });
+            await mcp_gateway_1.mcpGateway.refreshToolCache();
+            const info = await mcp_gateway_1.mcpGateway.getGatewayInfo();
+            const manageTools = info.tools.filter((t) => t.name.startsWith('manage_'));
+            expect(manageTools).toHaveLength(1);
+            expect(manageTools[0].name).toBe('manage_agents');
+            expect(manageTools[0].inputSchema.properties).toHaveProperty('instance_name');
+            expect(manageTools[0].inputSchema.required).toContain('instance_name');
+        });
+        it('should leave cache null when no instance is running', async () => {
+            mockStateManager.getServices.mockReturnValue([mockService('alpha', 'stopped')]);
+            await mcp_gateway_1.mcpGateway.refreshToolCache();
+            const info = await mcp_gateway_1.mcpGateway.getGatewayInfo();
+            // Only daemon-level tools, no manage_* tools.
+            const manageTools = info.tools.filter((t) => t.name.startsWith('manage_'));
+            expect(manageTools).toHaveLength(0);
+        });
+        it('should skip refresh when cache is already populated', async () => {
+            mockStateManager.getServices.mockReturnValue([mockService('alpha', 'running')]);
+            const fetchMock = jest.fn().mockResolvedValue({
+                ok: true,
+                json: async () => [rawToolDef('manage_agents', 'Manage agents')],
+            });
+            global.fetch = fetchMock;
+            await mcp_gateway_1.mcpGateway.refreshToolCache();
+            await mcp_gateway_1.mcpGateway.refreshToolCache(); // second call
+            // fetch should only be called once (cache hit on second call).
+            expect(fetchMock).toHaveBeenCalledTimes(1);
+        });
+        it('should handle fetch failure gracefully (cache stays null)', async () => {
+            mockStateManager.getServices.mockReturnValue([mockService('alpha', 'running')]);
+            global.fetch = jest.fn().mockResolvedValue({ ok: false, status: 500 });
+            await mcp_gateway_1.mcpGateway.refreshToolCache();
+            const info = await mcp_gateway_1.mcpGateway.getGatewayInfo();
+            const manageTools = info.tools.filter((t) => t.name.startsWith('manage_'));
+            expect(manageTools).toHaveLength(0);
+        });
+    });
+    describe('invalidateToolCache', () => {
+        it('should clear cache so next refresh re-fetches', async () => {
+            mockStateManager.getServices.mockReturnValue([mockService('alpha', 'running')]);
+            const fetchMock = jest.fn().mockResolvedValue({
+                ok: true,
+                json: async () => [rawToolDef('manage_agents', 'Manage agents')],
+            });
+            global.fetch = fetchMock;
+            await mcp_gateway_1.mcpGateway.refreshToolCache();
+            expect(fetchMock).toHaveBeenCalledTimes(1);
+            mcp_gateway_1.mcpGateway.invalidateToolCache();
+            await mcp_gateway_1.mcpGateway.refreshToolCache();
+            expect(fetchMock).toHaveBeenCalledTimes(2);
+        });
+    });
+    describe('getGatewayInfo', () => {
+        it('should return descriptor with server_name, url, instances, tools, client_config', async () => {
+            mockStateManager.getServices.mockReturnValue([
+                mockService('alpha', 'running'),
+                mockService('beta', 'stopped'),
+            ]);
+            const info = await mcp_gateway_1.mcpGateway.getGatewayInfo();
+            expect(info.server_name).toBe('repoburg-gateway');
+            expect(info.url).toBe('http://localhost:9998/mcp');
+            expect(info.instances).toHaveLength(2);
+            expect(info.instances[0].name).toBe('alpha');
+            expect(info.instances[0].status).toBe('running');
+            expect(info.client_config).toContain('http://localhost:9998/mcp');
+            // Should always include daemon-level tools.
+            const toolNames = info.tools.map((t) => t.name);
+            expect(toolNames).toContain('list_instances');
+            expect(toolNames).toContain('start_instance');
+            expect(toolNames).toContain('stop_instance');
+        });
+    });
+    describe('daemon-level tool routing', () => {
+        it('list_instances should return text with instance info', () => {
+            mockStateManager.getServices.mockReturnValue([
+                mockService('alpha', 'running'),
+                mockService('beta', 'stopped'),
+            ]);
+            const result = mcp_gateway_1.mcpGateway.handleListInstances();
+            const text = result.content[0].text;
+            expect(text).toContain('alpha');
+            expect(text).toContain('running');
+            expect(text).toContain('beta');
+            expect(text).toContain('stopped');
+            expect(result.isError).toBeUndefined();
+        });
+        it('list_instances should show message when no instances', () => {
+            mockStateManager.getServices.mockReturnValue([]);
+            const result = mcp_gateway_1.mcpGateway.handleListInstances();
+            expect(result.content[0].text).toContain('No Repoburg instances');
+        });
+        it('start_instance should call serviceManager.start and invalidate cache', async () => {
+            mockServiceManager.start.mockResolvedValue(mockService('gamma', 'running'));
+            const result = await mcp_gateway_1.mcpGateway.handleStartInstance({
+                path: '/projects/gamma',
+                name: 'gamma',
+            });
+            expect(mockServiceManager.start).toHaveBeenCalledWith('/projects/gamma', 'gamma');
+            expect(result.content[0].text).toContain('gamma');
+            expect(result.isError).toBeUndefined();
+        });
+        it('start_instance should error when path is missing', async () => {
+            const result = await mcp_gateway_1.mcpGateway.handleStartInstance({});
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain('Missing required parameter: path');
+        });
+        it('stop_instance should call serviceManager.stop', async () => {
+            const result = await mcp_gateway_1.mcpGateway.handleStopInstance({ name: 'alpha' });
+            expect(mockServiceManager.stop).toHaveBeenCalledWith('alpha');
+            expect(result.content[0].text).toContain('alpha');
+            expect(result.isError).toBeUndefined();
+        });
+        it('stop_instance should error when name is missing', async () => {
+            const result = await mcp_gateway_1.mcpGateway.handleStopInstance({});
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain('Missing required parameter: name');
+        });
+    });
+    describe('manage_* proxy routing', () => {
+        it('should error when instance_name is missing', async () => {
+            const result = await mcp_gateway_1.mcpGateway.handleManageTool('manage_agents', {
+                action: 'create',
+            });
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain('instance_name');
+        });
+        it('should error when instance is not found', async () => {
+            mockStateManager.getService.mockReturnValue(undefined);
+            const result = await mcp_gateway_1.mcpGateway.handleManageTool('manage_agents', {
+                instance_name: 'unknown',
+                action: 'create',
+            });
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain("not found");
+        });
+        it('should error when instance is not running', async () => {
+            mockStateManager.getService.mockReturnValue(mockService('alpha', 'stopped'));
+            const result = await mcp_gateway_1.mcpGateway.handleManageTool('manage_agents', {
+                instance_name: 'alpha',
+                action: 'create',
+            });
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain('not running');
+        });
+        it('should strip instance_name and POST to the instance backend', async () => {
+            mockStateManager.getService.mockReturnValue(mockService('alpha', 'running'));
+            const fetchMock = jest.fn().mockResolvedValue({
+                ok: true,
+                json: async () => ({
+                    status: 'SUCCESS',
+                    summary: 'Agent created',
+                    execution_log: { output: 'Created agent "test"' },
+                }),
+            });
+            global.fetch = fetchMock;
+            const result = await mcp_gateway_1.mcpGateway.handleManageTool('manage_agents', {
+                instance_name: 'alpha',
+                action: 'create',
+                name: 'test',
+            });
+            expect(fetchMock).toHaveBeenCalledWith('http://localhost:3400/mcp-internal/execute-tool', expect.objectContaining({
+                method: 'POST',
+                body: JSON.stringify({
+                    tool_name: 'manage_agents',
+                    arguments: { action: 'create', name: 'test' }, // instance_name stripped
+                }),
+            }));
+            expect(result.isError).toBeUndefined();
+            expect(result.content[0].text).toContain('Created agent "test"');
+        });
+        it('should map FAILURE result to isError: true', async () => {
+            mockStateManager.getService.mockReturnValue(mockService('alpha', 'running'));
+            global.fetch = jest.fn().mockResolvedValue({
+                ok: true,
+                json: async () => ({
+                    status: 'FAILURE',
+                    summary: 'Validation error',
+                    error_message: 'Name is required',
+                    execution_log: { output: '', error_message: 'Name is required' },
+                }),
+            });
+            const result = await mcp_gateway_1.mcpGateway.handleManageTool('manage_agents', {
+                instance_name: 'alpha',
+                action: 'create',
+            });
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain('Name is required');
+        });
+        it('should error when fetch to backend fails', async () => {
+            mockStateManager.getService.mockReturnValue(mockService('alpha', 'running'));
+            global.fetch = jest.fn().mockRejectedValue(new Error('ECONNREFUSED'));
+            const result = await mcp_gateway_1.mcpGateway.handleManageTool('manage_agents', {
+                instance_name: 'alpha',
+                action: 'create',
+            });
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain('ECONNREFUSED');
+        });
+        it('should error when backend returns non-ok HTTP status', async () => {
+            mockStateManager.getService.mockReturnValue(mockService('alpha', 'running'));
+            global.fetch = jest.fn().mockResolvedValue({ ok: false, status: 500 });
+            const result = await mcp_gateway_1.mcpGateway.handleManageTool('manage_agents', {
+                instance_name: 'alpha',
+                action: 'create',
+            });
+            expect(result.isError).toBe(true);
+            expect(result.content[0].text).toContain('500');
+        });
+    });
+});

package/daemon/package.json

@@ -7,7 +7,8 @@
   "scripts": {
     "build": "tsc",
     "start": "cross-env NODE_ENV=production node dist/index.js",
-    "dev": "NODE_ENV=development ts-node-dev --respawn --transpile-only src/index.ts"
+    "dev": "NODE_ENV=development ts-node-dev --respawn --transpile-only src/index.ts",
+    "test": "jest"
   },
   "keywords": [],
   "author": "Celal Ertug",
@@ -16,9 +17,21 @@
     "@types/cors": "^2.8.17",
     "@types/express": "^4.17.21",
     "@types/fs-extra": "^11.0.4",
+    "@types/jest": "^29.5.14",
     "@types/node": "^20.14.9",
     "@types/ws": "^8.5.10",
+    "jest": "^29.7.0",
+    "ts-jest": "^29.4.11",
     "ts-node-dev": "^2.0.0",
     "typescript": "^5.5.2"
+  },
+  "jest": {
+    "moduleFileExtensions": ["js", "json", "ts"],
+    "rootDir": "src",
+    "testRegex": ".*\\.spec\\.ts$",
+    "transform": {
+      "^.+\\.(t|j)s$": ["ts-jest", { "isolatedModules": true }]
+    },
+    "testEnvironment": "node"
   }
-}
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "repoburg",
-  "version": "1.3.163",
+  "version": "1.3.166",
   "description": "A local AI-powered software developer assistant that runs on your own machine.",
   "author": "Celal Ertug",
   "license": "SEE LICENSE IN LICENSE",