repluggable-core 0.0.0-pr351.77 → 0.0.0-pr355.81

package/test/interceptAnyObject.spec.ts

@@ -214,4 +214,57 @@ describe('interceptAnyObject', () => {
         const intercepted = interceptAnyObject(real, createFuncInterceptor(spy), createPropInterceptor(spy))
         expect(intercepted.get('key')).toEqual('value')
     })
+
+    it('should keep getters live instead of reading them once', () => {
+        const spy: LogSpy = jest.fn()
+        let current = 'initial'
+        const real = {
+            get liveProp() {
+                spy('liveProp')
+                return current
+            }
+        }
+        const intercepted = interceptAnyObject(real, createFuncInterceptor(spy), createPropInterceptor(spy))
+
+        expect(takeLog(spy)).toEqual([])
+        current = 'updated'
+        expect(intercepted.liveProp).toBe('updated')
+        expect(takeLog(spy)).toEqual(['liveProp'])
+    })
+
+    it('should delegate setters to the inner object', () => {
+        const spy: LogSpy = jest.fn()
+        let stored = 'initial'
+        const real = {
+            get value() {
+                return stored
+            },
+            set value(newValue: string) {
+                stored = newValue
+            }
+        }
+        const intercepted = interceptAnyObject(real, createFuncInterceptor(spy), createPropInterceptor(spy))
+
+        intercepted.value = 'updated'
+
+        expect(stored).toBe('updated')
+        expect(intercepted.value).toBe('updated')
+    })
+
+    it('should keep getters of nested objects live', () => {
+        const spy: LogSpy = jest.fn()
+        let current = 'initial'
+        const real = {
+            nested: {
+                get liveProp() {
+                    return current
+                }
+            }
+        }
+        const intercepted = interceptAnyObject(real, createFuncInterceptor(spy), createPropInterceptor(spy), 1)
+
+        current = 'updated'
+
+        expect(intercepted.nested.liveProp).toBe('updated')
+    })
 })

package/test/repluggableAppDebug.spec.ts

@@ -4,7 +4,7 @@ const unreadAPI = { name: 'unreadyAPI' }
 
 const getUnreadyAPIs = async () => {
     await new Promise(resolve => setTimeout(resolve, 0))
-    return globalThis.repluggableAppDebug.utils.getRootUnreadyAPIs()
+    return globalThis.repluggableAppDebug.utils.getRootUnreadyAPI()
 }
 
 describe('RepluggableAppDebug', () => {
@@ -14,7 +14,7 @@ describe('RepluggableAppDebug', () => {
 
             const unreadyAPIs = await getUnreadyAPIs()
 
-            expect(unreadyAPIs).toEqual([])
+            expect(unreadyAPIs).toBeUndefined()
         })
 
         it('should not report any issues in case all entry points are loaded', async () => {
@@ -27,7 +27,7 @@ describe('RepluggableAppDebug', () => {
 
             const unreadyAPIs = await getUnreadyAPIs()
 
-            expect(unreadyAPIs).toEqual([])
+            expect(unreadyAPIs).toBeUndefined()
         })
 
         it('should return an API if its not ready', async () => {
@@ -40,7 +40,7 @@ describe('RepluggableAppDebug', () => {
 
             const unreadyAPIs = await getUnreadyAPIs()
 
-            expect(unreadyAPIs).toEqual([{ name: 'unreadyAPI' }])
+            expect(unreadyAPIs).toEqual({ name: 'unreadyAPI' })
         })
 
         it('should return the root unready API when there are multiple entry points that depend on the same API', async () => {
@@ -61,7 +61,7 @@ describe('RepluggableAppDebug', () => {
 
             const unreadyAPIs = await getUnreadyAPIs()
 
-            expect(unreadyAPIs).toEqual([{ name: 'unreadyAPI' }])
+            expect(unreadyAPIs).toEqual({ name: 'unreadyAPI' })
         })
 
         it('should return the root unready API when there is a graph of dependencies', async () => {
@@ -85,29 +85,7 @@ describe('RepluggableAppDebug', () => {
 
             const unreadyAPIs = await getUnreadyAPIs()
 
-            expect(unreadyAPIs).toEqual([{ name: 'unreadyAPI' }])
-        })
-
-        it('should return all root unready APIs, excluding transitively blocked ones', async () => {
-            createAppHost([
-                {
-                    name: 'entryPoint A',
-                    getDependencyAPIs: () => [{ name: 'API B' }]
-                },
-                {
-                    name: 'entryPoint B',
-                    declareAPIs: () => [{ name: 'API B' }],
-                    getDependencyAPIs: () => [{ name: 'missing B' }]
-                },
-                {
-                    name: 'entryPoint C',
-                    getDependencyAPIs: () => [{ name: 'missing C' }]
-                }
-            ])
-
-            const unreadyAPIs = await getUnreadyAPIs()
-
-            expect(unreadyAPIs).toEqual([{ name: 'missing B' }, { name: 'missing C' }])
+            expect(unreadyAPIs).toEqual({ name: 'unreadyAPI' })
         })
 
         it('should return all traversal paths from an entry point to a transitive API', () => {
@@ -264,7 +242,7 @@ describe('RepluggableAppDebug', () => {
             const unreadyAPIs = await getUnreadyAPIs()
             // because we take the first unready entry point, and in this case its the root,
             // we don't get the rest of the unready APIs
-            expect(unreadyAPIs).toEqual([{ name: 'unreadyAPI' }])
+            expect(unreadyAPIs).toEqual({ name: 'unreadyAPI' })
         })
     })
 })

package/test/testKit.spec.tsx

@@ -149,47 +149,5 @@ describe('App Host TestKit', () => {
             jest.runAllTimers()
             await expect(hostPromise).rejects.toThrow(new RegExp(MockPublicAPI.name))
         })
-
-        it('should report all root unready APIs of independent unready entry points', async () => {
-            const hostPromise = createAppHostAndWaitForLoading(
-                [
-                    {
-                        name: 'entryPoint A',
-                        declareAPIs: () => [{ name: 'API A' }],
-                        getDependencyAPIs: () => [{ name: 'missing A' }]
-                    },
-                    {
-                        name: 'entryPoint B',
-                        declareAPIs: () => [{ name: 'API B' }],
-                        getDependencyAPIs: () => [{ name: 'missing B' }]
-                    }
-                ],
-                []
-            )
-            jest.runAllTimers()
-            const error: Error = await hostPromise.then(
-                () => {
-                    throw new Error('expected hostPromise to reject')
-                },
-                e => e
-            )
-
-            expect(error.message).toContain('"missing A"')
-            expect(error.message).toContain('"missing B"')
-        })
-
-        it('should respect a custom loading timeout', async () => {
-            let settled = false
-            const hostPromise = createAppHostAndWaitForLoading([dependsOnMockPackageEntryPoint], [], 10000)
-            hostPromise.catch(() => (settled = true))
-
-            jest.advanceTimersByTime(9999)
-            await Promise.resolve()
-            await Promise.resolve()
-            expect(settled).toBe(false)
-
-            jest.advanceTimersByTime(1)
-            await expect(hostPromise).rejects.toThrow('timed out after 10000ms')
-        })
     })
 })

package/testKit/index.ts

@@ -81,11 +81,7 @@ export function createAppHostWithPacts(packages: EntryPointOrPackage[], pacts: P
     })
 }
 
-export async function createAppHostAndWaitForLoading(
-    packages: EntryPointOrPackage[],
-    pacts: PactAPIBase[],
-    timeout: number = 3000
-): Promise<AppHost> {
+export async function createAppHostAndWaitForLoading(packages: EntryPointOrPackage[], pacts: PactAPIBase[]): Promise<AppHost> {
     const appHost = createAppHostWithPacts(packages, pacts)
     const declaredAPIs = _(packages)
         .flatten()
@@ -96,19 +92,17 @@ export async function createAppHostAndWaitForLoading(
         setTimeout(() => {
             const readyAPIs = Array.from(globalThis.repluggableAppDebug.readyAPIs)
             const unreadyAPIs = declaredAPIs.filter(api => !readyAPIs.some(readyAPI => readyAPI.name === api.name))
-            const rootUnreadyAPIs = globalThis.repluggableAppDebug.utils.getRootUnreadyAPIs()
+            const rootUnreadyAPI = globalThis.repluggableAppDebug.utils.getRootUnreadyAPI()
 
             reject(
                 new Error(
-                    `createAppHostAndWaitForLoading - waiting for loading timed out after ${timeout}ms.
-these root unready APIs are most likely the reason - unready entry points require them but nothing declares them (missing entry point or pact?): ${JSON.stringify(
-                        rootUnreadyAPIs
-                    )}
+                    `createAppHostAndWaitForLoading - waiting for loading timed out.
+there's a high chance this missing API is the main reason for it: ${JSON.stringify(rootUnreadyAPI)}
 
 in addition here's the full list of declared APIs that have not been contributed: ${JSON.stringify(unreadyAPIs)}`
                 )
             )
-        }, timeout)
+        }, 3000)
     })
 
     const loadingPromise = new Promise<void>(async resolve => {