renovate 40.0.0-next.26 → 40.0.0-next.28

package/dist/modules/platform/bitbucket-server/index.js

@@ -39,11 +39,13 @@ const git = tslib_1.__importStar(require("../../../util/git"));
 const git_1 = require("../../../util/git");
 const hostRules = tslib_1.__importStar(require("../../../util/host-rules"));
 const bitbucket_server_1 = require("../../../util/http/bitbucket-server");
+const memory_http_cache_provider_1 = require("../../../util/http/cache/memory-http-cache-provider");
 const regex_1 = require("../../../util/regex");
 const sanitize_1 = require("../../../util/sanitize");
 const url_1 = require("../../../util/url");
 const util_1 = require("../util");
 const pr_body_1 = require("../utils/pr-body");
+const pr_cache_1 = require("./pr-cache");
 const schema_1 = require("./schema");
 const utils = tslib_1.__importStar(require("./utils"));
 const utils_1 = require("./utils");
@@ -63,12 +65,12 @@ const defaults = {
     hostType: 'bitbucket-server',
     version: '0.0.0',
 };
-/* istanbul ignore next */
+/* v8 ignore start */
 function updatePrVersion(pr, version) {
     const res = Math.max(config.prVersions.get(pr) ?? 0, version);
     config.prVersions.set(pr, res);
     return res;
-}
+} /* v8 ignore stop */
 async function initPlatform({ endpoint, token, username, password, gitAuthor, }) {
     if (!endpoint) {
         throw new Error('Init: You must configure a Bitbucket Server endpoint');
@@ -87,10 +89,10 @@ async function initPlatform({ endpoint, token, username, password, gitAuthor, })
     };
     try {
         let bitbucketServerVersion;
-        // istanbul ignore if: experimental feature
+        /* v8 ignore start: experimental feature */
         if (process.env.RENOVATE_X_PLATFORM_VERSION) {
             bitbucketServerVersion = process.env.RENOVATE_X_PLATFORM_VERSION;
-        }
+        } /* v8 ignore stop */
         else {
             const { version } = (await bitbucketServerHttp.getJsonUnchecked(`./rest/api/1.0/application-properties`)).body;
             bitbucketServerVersion = version;
@@ -117,6 +119,9 @@ async function initPlatform({ endpoint, token, username, password, gitAuthor, })
         }
         try {
             const { displayName, emailAddress } = (await bitbucketServerHttp.getJson(`./rest/api/1.0/users/${username}`, options, schema_1.UserSchema)).body;
+            if (!emailAddress.length) {
+                throw new Error(`No email address configured for username ${username}`);
+            }
             platformConfig.gitAuthor = `${displayName} <${emailAddress}>`;
             logger_1.logger.debug(`Detected gitAuthor: ${platformConfig.gitAuthor}`);
         }
@@ -135,10 +140,10 @@ async function getRepos() {
         logger_1.logger.debug({ result }, 'result of getRepos()');
         return result;
     }
-    catch (err) /* istanbul ignore next */ {
+    catch (err) /* v8 ignore start */ {
         logger_1.logger.error({ err }, `bitbucket getRepos error`);
         throw err;
-    }
+    } /* v8 ignore stop */
 }
 async function getRawFile(fileName, repoName, branchOrTag) {
     const repo = repoName ?? config.repository;
@@ -202,7 +207,7 @@ async function initRepo({ repository, cloneSubmodules, cloneSubmodulesFilter, ig
         };
         return repoConfig;
     }
-    catch (err) /* istanbul ignore next */ {
+    catch (err) /* v8 ignore start */ {
         if (err.statusCode === 404) {
             throw new Error(error_messages_1.REPOSITORY_NOT_FOUND);
         }
@@ -211,7 +216,7 @@ async function initRepo({ repository, cloneSubmodules, cloneSubmodulesFilter, ig
         }
         logger_1.logger.debug({ err }, 'Unknown Bitbucket initRepo error');
         throw err;
-    }
+    } /* v8 ignore stop */
 }
 async function getBranchForceRebase(_branchName) {
     // https://docs.atlassian.com/bitbucket-server/rest/7.0.1/bitbucket-rest.html#idp342
@@ -228,7 +233,14 @@ async function getPr(prNo, refreshCache) {
     if (!prNo) {
         return null;
     }
-    const res = await bitbucketServerHttp.getJsonUnchecked(`./rest/api/1.0/projects/${config.projectKey}/repos/${config.repositorySlug}/pull-requests/${prNo}`, { memCache: !refreshCache });
+    // Disables memCache (which is enabled by default) to be replaced by
+    // memCacheProvider.
+    const opts = { memCache: false };
+    // TODO: should refresh the cache rather than just ignore it
+    if (!refreshCache) {
+        opts.cacheProvider = memory_http_cache_provider_1.memCacheProvider;
+    }
+    const res = await bitbucketServerHttp.getJsonUnchecked(`./rest/api/1.0/projects/${config.projectKey}/repos/${config.repositorySlug}/pull-requests/${prNo}`, opts);
     const pr = {
         ...utils.prInfo(res.body),
         reviewers: res.body.reviewers.map((r) => r.user.name),
@@ -238,7 +250,7 @@ async function getPr(prNo, refreshCache) {
     return pr;
 }
 // TODO: coverage (#9624)
-// istanbul ignore next
+/* v8 ignore start */
 function matchesState(state, desiredState) {
     if (desiredState === 'all') {
         return true;
@@ -247,37 +259,22 @@ function matchesState(state, desiredState) {
         return state !== desiredState.substring(1);
     }
     return state === desiredState;
-}
+} /* v8 ignore stop */
 // TODO: coverage (#9624)
-// istanbul ignore next
-const isRelevantPr = (branchName, prTitle, state) => (p) => p.sourceBranch === branchName &&
-    (!prTitle || p.title.toUpperCase() === prTitle.toUpperCase()) &&
-    matchesState(p.state, state);
+/* v8 ignore start */
+function isRelevantPr(branchName, prTitle, state) {
+    return (p) => p.sourceBranch === branchName &&
+        (!prTitle || p.title.toUpperCase() === prTitle.toUpperCase()) &&
+        matchesState(p.state, state);
+} /* v8 ignore stop */
 // TODO: coverage (#9624)
-async function getPrList(refreshCache) {
+async function getPrList() {
     logger_1.logger.debug(`getPrList()`);
-    // istanbul ignore next
-    if (!config.prList || refreshCache) {
-        const searchParams = {
-            state: 'ALL',
-        };
-        if (!config.ignorePrAuthor && config.username !== undefined) {
-            searchParams['role.1'] = 'AUTHOR';
-            searchParams['username.1'] = config.username;
-        }
-        const query = (0, url_1.getQueryString)(searchParams);
-        const values = (await bitbucketServerHttp.getJsonUnchecked(`./rest/api/1.0/projects/${config.projectKey}/repos/${config.repositorySlug}/pull-requests?${query}`, { paginate: true })).body;
-        config.prList = values.map(utils.prInfo);
-        logger_1.logger.debug(`Retrieved Pull Requests, count: ${config.prList.length}`);
-    }
-    else {
-        logger_1.logger.debug('returning cached PR list');
-    }
-    return config.prList;
+    return await pr_cache_1.BbsPrCache.getPrs(bitbucketServerHttp, config.projectKey, config.repositorySlug, config.ignorePrAuthor, config.username);
 }
 // TODO: coverage (#9624)
-// istanbul ignore next
-async function findPr({ branchName, prTitle, state = 'all', refreshCache, includeOtherAuthors, }) {
+/* v8 ignore start */
+async function findPr({ branchName, prTitle, state = 'all', includeOtherAuthors, }) {
     logger_1.logger.debug(`findPr(${branchName}, "${prTitle}", "${state}")`);
     if (includeOtherAuthors) {
         // PR might have been created by anyone, so don't use the cached Renovate PR list
@@ -297,7 +294,7 @@ async function findPr({ branchName, prTitle, state = 'all', refreshCache, includ
         }
         return utils.prInfo(prs[0]);
     }
-    const prList = await getPrList(refreshCache);
+    const prList = await getPrList();
     const pr = prList.find(isRelevantPr(branchName, prTitle, state));
     if (pr) {
         logger_1.logger.debug(`Found PR #${pr.number}`);
@@ -306,7 +303,7 @@ async function findPr({ branchName, prTitle, state = 'all', refreshCache, includ
         logger_1.logger.debug(`Renovate did not find a PR for branch #${branchName}`);
     }
     return pr ?? null;
-}
+} /* v8 ignore stop */
 // Returns the Pull Request for a branch. Null if not exists.
 async function getBranchPr(branchName) {
     logger_1.logger.debug(`getBranchPr(${branchName})`);
@@ -316,18 +313,23 @@ async function getBranchPr(branchName) {
     });
     return existingPr ? getPr(existingPr.number) : null;
 }
-// istanbul ignore next
+/* v8 ignore start */
 async function refreshPr(number) {
     // wait for pr change propagation
     await (0, promises_1.setTimeout)(1000);
     // refresh cache
     await getPr(number, true);
-}
+} /* v8 ignore stop */
 async function getStatus(branchName, memCache = true) {
     const branchCommit = git.getBranchCommit(branchName);
+    /* v8 ignore start: temporary code */
+    const opts = memCache
+        ? { cacheProvider: memory_http_cache_provider_1.memCacheProvider }
+        : { memCache: false };
+    /* v8 ignore stop */
     return (await bitbucketServerHttp.getJsonUnchecked(
     // TODO: types (#22198)
-    `./rest/build-status/1.0/commits/stats/${branchCommit}`, { memCache })).body;
+    `./rest/build-status/1.0/commits/stats/${branchCommit}`, opts)).body;
 }
 // Returns the combined status for a branch.
 // umbrella for status checks
@@ -356,7 +358,16 @@ async function getBranchStatus(branchName) {
 }
 async function getStatusCheck(branchName, memCache = true) {
     const branchCommit = git.getBranchCommit(branchName);
-    return (await bitbucketServerHttp.getJsonUnchecked(`./rest/build-status/1.0/commits/${branchCommit}`, { paginate: true, memCache })).body;
+    const opts = { paginate: true };
+    /* v8 ignore start: temporary code */
+    if (memCache) {
+        opts.cacheProvider = memory_http_cache_provider_1.memCacheProvider;
+    }
+    else {
+        opts.memCache = false;
+    }
+    /* v8 ignore stop */
+    return (await bitbucketServerHttp.getJsonUnchecked(`./rest/build-status/1.0/commits/${branchCommit}`, opts)).body;
 }
 // https://docs.atlassian.com/bitbucket-server/rest/6.0.0/bitbucket-build-rest.html#idp2
 async function getBranchStatusCheck(branchName, context) {
@@ -420,7 +431,7 @@ async function setBranchStatus({ branchName, context, description, state, url: t
     }
 }
 // Issue
-/* istanbul ignore next */
+/* v8 ignore start */
 function findIssue(title) {
     logger_1.logger.debug(`findIssue(${title})`);
     // This is used by Renovate when creating its own issues,
@@ -429,8 +440,8 @@ function findIssue(title) {
     //
     // Bitbucket Server does not have issues
     return Promise.resolve(null);
-}
-/* istanbul ignore next */
+} /* v8 ignore stop */
+/* v8 ignore start */
 function ensureIssue({ title, }) {
     logger_1.logger.warn({ title }, 'Cannot ensure issue');
     // This is used by Renovate when creating its own issues,
@@ -439,8 +450,8 @@ function ensureIssue({ title, }) {
     //
     // Bitbucket Server does not have issues
     return Promise.resolve(null);
-}
-/* istanbul ignore next */
+} /* v8 ignore stop */
+/* v8 ignore start */
 function getIssueList() {
     logger_1.logger.debug(`getIssueList()`);
     // This is used by Renovate when creating its own issues,
@@ -449,8 +460,8 @@ function getIssueList() {
     //
     // Bitbucket Server does not have issues
     return Promise.resolve([]);
-}
-/* istanbul ignore next */
+} /* v8 ignore stop */
+/* v8 ignore start */
 function ensureIssueClosing(title) {
     logger_1.logger.debug(`ensureIssueClosing(${title})`);
     // This is used by Renovate when creating its own issues,
@@ -459,7 +470,7 @@ function ensureIssueClosing(title) {
     //
     // Bitbucket Server does not have issues
     return Promise.resolve();
-}
+} /* v8 ignore stop */
 function addAssignees(iid, assignees) {
     logger_1.logger.debug(`addAssignees(${iid}, [${assignees.join(', ')}])`);
     // This is used by Renovate when creating its own issues,
@@ -610,10 +621,10 @@ async function ensureComment({ number, topic, content, }) {
         }
         return true;
     }
-    catch (err) /* istanbul ignore next */ {
+    catch (err) /* v8 ignore start */ {
         logger_1.logger.warn({ err }, 'Error ensuring comment');
         return false;
-    }
+    } /* v8 ignore stop */
 }
 async function ensureCommentRemoval(deleteConfig) {
     try {
@@ -636,9 +647,9 @@ async function ensureCommentRemoval(deleteConfig) {
             await deleteComment(prNo, commentId);
         }
     }
-    catch (err) /* istanbul ignore next */ {
+    catch (err) /* v8 ignore start */ {
         logger_1.logger.warn({ err }, 'Error ensuring comment removal');
-    }
+    } /* v8 ignore stop */
 }
 // Pull Request
 const escapeHash = (input) => input?.replace((0, regex_1.regEx)(/#/g), '%23');
@@ -670,7 +681,7 @@ async function createPr({ sourceBranch, targetBranch, prTitle: title, prBody: ra
     try {
         prInfoRes = await bitbucketServerHttp.postJson(`./rest/api/1.0/projects/${config.projectKey}/repos/${config.repositorySlug}/pull-requests`, { body });
     }
-    catch (err) /* istanbul ignore next */ {
+    catch (err) /* v8 ignore start */ {
         if (err.body?.errors?.[0]?.exceptionName ===
             'com.atlassian.bitbucket.pull.EmptyPullRequestException') {
             logger_1.logger.debug('Empty pull request - deleting branch so it can be recreated next run');
@@ -678,16 +689,13 @@ async function createPr({ sourceBranch, targetBranch, prTitle: title, prBody: ra
             throw new Error(error_messages_1.REPOSITORY_CHANGED);
         }
         throw err;
-    }
+    } /* v8 ignore stop */
     const pr = {
         ...utils.prInfo(prInfoRes.body),
     };
     // TODO #22198
     updatePrVersion(pr.number, pr.version);
-    // istanbul ignore if
-    if (config.prList) {
-        config.prList.push(pr);
-    }
+    await pr_cache_1.BbsPrCache.setPr(bitbucketServerHttp, config.projectKey, config.repositorySlug, config.ignorePrAuthor, config.username, pr);
     return pr;
 }
 async function updatePr({ number: prNo, prTitle: title, prBody: rawDescription, state, bitbucketInvalidReviewers, targetBranch, }) {
@@ -728,18 +736,8 @@ async function updatePr({ number: prNo, prTitle: title, prBody: rawDescription,
             finalState = state;
             updatePrVersion(pr.number, updatedStatePr.version);
         }
-        if (config.prList) {
-            const bbsPr = utils.prInfo(updatedPr);
-            const existingIndex = config.prList.findIndex((item) => item.number === prNo);
-            // istanbul ignore if: should never happen
-            if (existingIndex === -1) {
-                logger_1.logger.warn({ pr: bbsPr }, 'Possible error: Updated PR was not found in the PRs that were returned from getPrList().');
-                config.prList.push({ ...bbsPr, state: finalState });
-            }
-            else {
-                config.prList[existingIndex] = { ...bbsPr, state: finalState };
-            }
-        }
+        const bbsPr = utils.prInfo(updatedPr);
+        await pr_cache_1.BbsPrCache.setPr(bitbucketServerHttp, config.projectKey, config.repositorySlug, config.ignorePrAuthor, config.username, { ...bbsPr, state: finalState });
     }
     catch (err) {
         logger_1.logger.debug({ err, prNo }, `Failed to update PR`);