remult 0.25.8 → 0.26.0

package/src/remult3/RepositoryImplementation.d.ts

@@ -14,7 +14,7 @@ import { type RepositoryInternal, getInternalKey } from './repository-internals.
 export declare class RepositoryImplementation<entityType> implements Repository<entityType>, RepositoryInternal<entityType> {
     private _entity;
     _remult: Remult;
-    private _dataProvider;
+    _dataProvider: DataProvider;
     private _info;
     private _defaultFindOptions?;
     _notFoundError(id: any): {
@@ -47,7 +47,9 @@ export declare class RepositoryImplementation<entityType> implements Repository<
     insert(item: Partial<MembersOnly<entityType>>): Promise<entityType>;
     get fields(): FieldsMetadata<entityType>;
     validate(entity: Partial<MembersOnly<entityType>>, ...fields: Extract<keyof MembersOnly<entityType>, string>[]): Promise<ErrorInfo<entityType> | undefined>;
-    updateMany(where: EntityFilter<entityType>, set: Partial<MembersOnly<entityType>>): Promise<number>;
+    updateMany({ where }: {
+        where: EntityFilter<entityType>;
+    }, set: Partial<MembersOnly<entityType>>): Promise<number>;
     update(id: idType<entityType>, item: Partial<MembersOnly<entityType>>): Promise<entityType>;
     update(originalItem: Partial<MembersOnly<entityType>>, item: Partial<MembersOnly<entityType>>): Promise<entityType>;
     private _getRefForExistingRow;
@@ -63,7 +65,9 @@ export declare class RepositoryImplementation<entityType> implements Repository<
     toJson(item: entityType | entityType[] | Promise<entityType> | Promise<entityType[]>): any;
     fromJson(json: any, newRow?: boolean): any;
     count(where?: EntityFilter<entityType>): Promise<number>;
-    deleteMany(where: EntityFilter<entityType>): Promise<number>;
+    deleteMany({ where, }: {
+        where: EntityFilter<entityType>;
+    }): Promise<number>;
     private _cache;
     findOne(options?: FindFirstOptions<entityType>, skipOrderByAndLimit?: boolean): Promise<entityType>;
     findFirst(where?: EntityFilter<entityType>, options?: FindFirstOptions<entityType>, skipOrderByAndLimit?: boolean): Promise<entityType>;

package/src/remult3/RepositoryImplementation.js

@@ -18,6 +18,8 @@ var relation_loader_js_1 = require("./relation-loader.js");
 var repository_internals_js_1 = require("./repository-internals.js");
 var filter_consumer_bridge_to_sql_request_js_1 = require("../filter/filter-consumer-bridge-to-sql-request.js");
 var remult_static_js_1 = require("../remult-static.js");
+var validators_js_1 = require("../validators.js");
+var addValidator_js_1 = require("./addValidator.js");
 //import  { remult } from "../remult-proxy";
 var classValidatorValidate = undefined;
 // import ("class-validator".toString())
@@ -435,51 +437,53 @@ var RepositoryImplementation = /** @class */ (function () {
             });
         });
     };
-    RepositoryImplementation.prototype.updateMany = function (where, set) {
-        var _a, e_7, _b, _c;
+    RepositoryImplementation.prototype.updateMany = function (_a, set) {
+        var _b, e_7, _c, _d;
+        var where = _a.where;
         return tslib_1.__awaiter(this, void 0, void 0, function () {
-            var _d, _e, updated, _f, _g, _h, item, e_7_1;
-            return tslib_1.__generator(this, function (_j) {
-                switch (_j.label) {
+            var _e, _f, updated, _g, _h, _j, item, e_7_1;
+            return tslib_1.__generator(this, function (_k) {
+                switch (_k.label) {
                     case 0:
+                        filter_interfaces_js_1.Filter.throwErrorIfFilterIsEmpty(where, 'updateMany');
                         if (!this._dataProvider.isProxy) return [3 /*break*/, 2];
-                        _e = (_d = this._edp).updateMany;
+                        _f = (_e = this._edp).updateMany;
                         return [4 /*yield*/, this._translateWhereToFilter(where)];
-                    case 1: return [2 /*return*/, _e.apply(_d, [_j.sent(), set])];
+                    case 1: return [2 /*return*/, _f.apply(_e, [_k.sent(), set])];
                     case 2:
                         updated = 0;
-                        _j.label = 3;
+                        _k.label = 3;
                     case 3:
-                        _j.trys.push([3, 9, 10, 15]);
-                        _f = true, _g = tslib_1.__asyncValues(this.query({ where: where }));
-                        _j.label = 4;
-                    case 4: return [4 /*yield*/, _g.next()];
+                        _k.trys.push([3, 9, 10, 15]);
+                        _g = true, _h = tslib_1.__asyncValues(this.query({ where: where }));
+                        _k.label = 4;
+                    case 4: return [4 /*yield*/, _h.next()];
                     case 5:
-                        if (!(_h = _j.sent(), _a = _h.done, !_a)) return [3 /*break*/, 8];
-                        _c = _h.value;
-                        _f = false;
-                        item = _c;
+                        if (!(_j = _k.sent(), _b = _j.done, !_b)) return [3 /*break*/, 8];
+                        _d = _j.value;
+                        _g = false;
+                        item = _d;
                         (0, assign_js_1.assign)(item, set);
                         return [4 /*yield*/, (0, getEntityRef_js_1.getEntityRef)(item).save()];
                     case 6:
-                        _j.sent();
+                        _k.sent();
                         updated++;
-                        _j.label = 7;
+                        _k.label = 7;
                     case 7:
-                        _f = true;
+                        _g = true;
                         return [3 /*break*/, 4];
                     case 8: return [3 /*break*/, 15];
                     case 9:
-                        e_7_1 = _j.sent();
+                        e_7_1 = _k.sent();
                         e_7 = { error: e_7_1 };
                         return [3 /*break*/, 15];
                     case 10:
-                        _j.trys.push([10, , 13, 14]);
-                        if (!(!_f && !_a && (_b = _g.return))) return [3 /*break*/, 12];
-                        return [4 /*yield*/, _b.call(_g)];
+                        _k.trys.push([10, , 13, 14]);
+                        if (!(!_g && !_b && (_c = _h.return))) return [3 /*break*/, 12];
+                        return [4 /*yield*/, _c.call(_h)];
                     case 11:
-                        _j.sent();
-                        _j.label = 12;
+                        _k.sent();
+                        _k.label = 12;
                     case 12: return [3 /*break*/, 14];
                     case 13:
                         if (e_7) throw e_7.error;
@@ -1086,50 +1090,52 @@ var RepositoryImplementation = /** @class */ (function () {
             });
         });
     };
-    RepositoryImplementation.prototype.deleteMany = function (where) {
-        var _a, e_18, _b, _c;
+    RepositoryImplementation.prototype.deleteMany = function (_a) {
+        var _b, e_18, _c, _d;
+        var where = _a.where;
         return tslib_1.__awaiter(this, void 0, void 0, function () {
-            var _d, _e, deleted, _f, _g, _h, item, e_18_1;
-            return tslib_1.__generator(this, function (_j) {
-                switch (_j.label) {
+            var _e, _f, deleted, _g, _h, _j, item, e_18_1;
+            return tslib_1.__generator(this, function (_k) {
+                switch (_k.label) {
                     case 0:
+                        filter_interfaces_js_1.Filter.throwErrorIfFilterIsEmpty(where, 'deleteMany');
                         if (!this._dataProvider.isProxy) return [3 /*break*/, 2];
-                        _e = (_d = this._edp).deleteMany;
+                        _f = (_e = this._edp).deleteMany;
                         return [4 /*yield*/, this._translateWhereToFilter(where)];
-                    case 1: return [2 /*return*/, _e.apply(_d, [_j.sent()])];
+                    case 1: return [2 /*return*/, _f.apply(_e, [_k.sent()])];
                     case 2:
                         deleted = 0;
-                        _j.label = 3;
+                        _k.label = 3;
                     case 3:
-                        _j.trys.push([3, 9, 10, 15]);
-                        _f = true, _g = tslib_1.__asyncValues(this.query({ where: where }));
-                        _j.label = 4;
-                    case 4: return [4 /*yield*/, _g.next()];
+                        _k.trys.push([3, 9, 10, 15]);
+                        _g = true, _h = tslib_1.__asyncValues(this.query({ where: where }));
+                        _k.label = 4;
+                    case 4: return [4 /*yield*/, _h.next()];
                     case 5:
-                        if (!(_h = _j.sent(), _a = _h.done, !_a)) return [3 /*break*/, 8];
-                        _c = _h.value;
-                        _f = false;
-                        item = _c;
+                        if (!(_j = _k.sent(), _b = _j.done, !_b)) return [3 /*break*/, 8];
+                        _d = _j.value;
+                        _g = false;
+                        item = _d;
                         return [4 /*yield*/, (0, getEntityRef_js_1.getEntityRef)(item).delete()];
                     case 6:
-                        _j.sent();
+                        _k.sent();
                         deleted++;
-                        _j.label = 7;
+                        _k.label = 7;
                     case 7:
-                        _f = true;
+                        _g = true;
                         return [3 /*break*/, 4];
                     case 8: return [3 /*break*/, 15];
                     case 9:
-                        e_18_1 = _j.sent();
+                        e_18_1 = _k.sent();
                         e_18 = { error: e_18_1 };
                         return [3 /*break*/, 15];
                     case 10:
-                        _j.trys.push([10, , 13, 14]);
-                        if (!(!_f && !_a && (_b = _g.return))) return [3 /*break*/, 12];
-                        return [4 /*yield*/, _b.call(_g)];
+                        _k.trys.push([10, , 13, 14]);
+                        if (!(!_g && !_b && (_c = _h.return))) return [3 /*break*/, 12];
+                        return [4 /*yield*/, _c.call(_h)];
                     case 11:
-                        _j.sent();
-                        _j.label = 12;
+                        _k.sent();
+                        _k.label = 12;
                     case 12: return [3 /*break*/, 14];
                     case 13:
                         if (e_18) throw e_18.error;
@@ -1307,6 +1313,7 @@ var RepositoryImplementation = /** @class */ (function () {
         return tslib_1.__awaiter(this, void 0, void 0, function () {
             var z, z, _c, r;
             var _d;
+            var _this = this;
             return tslib_1.__generator(this, function (_e) {
                 switch (_e.label) {
                     case 0:
@@ -1318,24 +1325,38 @@ var RepositoryImplementation = /** @class */ (function () {
                                 $and: [z, (_b = this._defaultFindOptions) === null || _b === void 0 ? void 0 : _b.where],
                             };
                         }
-                        if (!(this.metadata.options.backendPrefilter && !this._dataProvider.isProxy)) return [3 /*break*/, 2];
+                        if (!!this._dataProvider.isProxy) return [3 /*break*/, 4];
+                        if (!this.metadata.options.backendPreprocessFilter) return [3 /*break*/, 2];
+                        return [4 /*yield*/, this.metadata.options.backendPreprocessFilter(where, {
+                                metadata: this.metadata,
+                                getFilterPreciseValues: function (filter) {
+                                    return filter_interfaces_js_1.Filter.getPreciseValues(_this.metadata, filter || where);
+                                },
+                            })];
+                    case 1:
+                        where = _e.sent();
+                        _e.label = 2;
+                    case 2:
+                        if (!this.metadata.options.backendPrefilter) return [3 /*break*/, 4];
                         z = where;
                         _d = {};
                         _c = [z];
                         return [4 /*yield*/, filter_interfaces_js_1.Filter.resolve(this.metadata.options.backendPrefilter)];
-                    case 1:
-                        where = (_d.$and = _c.concat([_e.sent()]),
-                            _d);
-                        _e.label = 2;
-                    case 2: return [4 /*yield*/, filter_interfaces_js_1.Filter.fromEntityFilter(this.metadata, where)];
                     case 3:
+                        where = (_d.$and = _c.concat([
+                            _e.sent()
+                        ]),
+                            _d);
+                        _e.label = 4;
+                    case 4: return [4 /*yield*/, filter_interfaces_js_1.Filter.fromEntityFilter(this.metadata, where)];
+                    case 5:
                         r = _e.sent();
-                        if (!(r && !this._dataProvider.isProxy)) return [3 /*break*/, 5];
+                        if (!(r && !this._dataProvider.isProxy)) return [3 /*break*/, 7];
                         return [4 /*yield*/, filter_interfaces_js_1.Filter.translateCustomWhere(r, this.metadata, this._remult)];
-                    case 4:
+                    case 6:
                         r = _e.sent();
-                        _e.label = 5;
-                    case 5: return [2 /*return*/, r];
+                        _e.label = 7;
+                    case 7: return [2 /*return*/, r];
                 }
             });
         });
@@ -1954,7 +1975,7 @@ var rowHelperImplementation = /** @class */ (function (_super) {
             return _this.instance[y.key];
         };
         if (this.metadata.idMetadata.field instanceof CompoundIdField_js_1.CompoundIdField)
-            return this.metadata.idMetadata.field.fields.map(getVal).join(',');
+            return this.metadata.idMetadata.field.getId(getVal);
         return getVal(this.metadata.idMetadata.field);
     };
     rowHelperImplementation.prototype.saveMoreOriginalData = function () {
@@ -2063,7 +2084,7 @@ var rowHelperImplementation = /** @class */ (function (_super) {
                     case 2:
                         doNotSave_1 = false;
                         e = this.buildLifeCycleEvent(function () { return (doNotSave_1 = true); });
-                        if (!!this.remult.dataProvider.isProxy) return [3 /*break*/, 12];
+                        if (!!this.repository._dataProvider.isProxy) return [3 /*break*/, 12];
                         _p.label = 3;
                     case 3:
                         _p.trys.push([3, 8, 9, 10]);
@@ -2163,7 +2184,7 @@ var rowHelperImplementation = /** @class */ (function (_super) {
                     case 20: return [4 /*yield*/, this.loadDataFrom(updatedRow)];
                     case 21:
                         _p.sent();
-                        if (!!this.remult.dataProvider.isProxy) return [3 /*break*/, 31];
+                        if (!!this.repository._dataProvider.isProxy) return [3 /*break*/, 31];
                         if (!this.info.entityInfo.saved) return [3 /*break*/, 23];
                         return [4 /*yield*/, this.info.entityInfo.saved(this.instance, e)];
                     case 22:
@@ -2302,7 +2323,7 @@ var rowHelperImplementation = /** @class */ (function (_super) {
                     case 0:
                         this.__clearErrorsAndReportChanged();
                         e = this.buildLifeCycleEvent();
-                        if (!!this.remult.dataProvider.isProxy) return [3 /*break*/, 2];
+                        if (!!this.repository._dataProvider.isProxy) return [3 /*break*/, 2];
                         if (!this.info.entityInfo.deleting) return [3 /*break*/, 2];
                         return [4 /*yield*/, this.info.entityInfo.deleting(this.instance, e)];
                     case 1:
@@ -2316,7 +2337,7 @@ var rowHelperImplementation = /** @class */ (function (_super) {
                         return [4 /*yield*/, this.edp.delete(this.id)];
                     case 4:
                         _d.sent();
-                        if (!!this.remult.dataProvider.isProxy) return [3 /*break*/, 6];
+                        if (!!this.repository._dataProvider.isProxy) return [3 /*break*/, 6];
                         if (!this.info.entityInfo.deleted) return [3 /*break*/, 6];
                         return [4 /*yield*/, this.info.entityInfo.deleted(this.instance, e)];
                     case 5:
@@ -3094,9 +3115,13 @@ var EntityFullInfo = /** @class */ (function () {
                 }
                 if (_this.idMetadata.field instanceof CompoundIdField_js_1.CompoundIdField) {
                     var field_1 = _this.idMetadata.field;
-                    return {
-                        $or: ids.map(function (x) { return field_1.isEqualTo(x); }),
-                    };
+                    if (ids.length == 1) {
+                        return field_1.isEqualTo(ids[0]);
+                    }
+                    else
+                        return {
+                            $or: ids.map(function (x) { return field_1.isEqualTo(x); }),
+                        };
                 }
                 if (ids.length == 1)
                     return _a = {},
@@ -3245,6 +3270,13 @@ function ValueListFieldType() {
                 ;
                 (o.valueConverter = ValueListInfo.get(type)),
                     (o.displayValue = function (item, val) { return val === null || val === void 0 ? void 0 : val.caption; });
+                o.validate = function (entity, ref) {
+                    var values = ValueListInfo.get(type).getValues();
+                    if (ref.value && !values.find(function (v) { return v === ref.value; })) {
+                        ref.value = values.find(function (v) { return v.id === ref.value.id; }) || ref.value;
+                    }
+                    return validators_js_1.Validators.in(values)(entity, ref);
+                };
             }], tslib_1.__read(options), false))(type, context);
     };
 }
@@ -3373,8 +3405,11 @@ function buildOptions(options, remult) {
             if (o) {
                 if (typeof o === 'function')
                     o(r, remult);
-                else
-                    Object.assign(r, o);
+                else {
+                    var validate = o.validate, otherOptions = tslib_1.__rest(o, ["validate"]);
+                    r.validate = (0, addValidator_js_1.addValidator)(r.validate, validate);
+                    Object.assign(r, otherOptions);
+                }
             }
         }
     }
@@ -3392,7 +3427,7 @@ function decorateColumnSettings(settings, remult) {
     if (settings.valueType) {
         var settingsOnTypeLevel = settings.valueType[exports.storableMember];
         if (settingsOnTypeLevel) {
-            settings = tslib_1.__assign(tslib_1.__assign({}, buildOptions(settingsOnTypeLevel, remult)), settings);
+            settings = buildOptions(tslib_1.__spreadArray(tslib_1.__spreadArray([], tslib_1.__read(settingsOnTypeLevel), false), [settings], false), remult);
         }
     }
     if (settings.valueType == String) {

package/src/remult3/addValidator.d.ts

@@ -0,0 +1,2 @@
+import type { FieldOptions } from '../column-interfaces.js';
+export declare function addValidator(validators: FieldOptions['validate'], newValidator: FieldOptions['validate'], atStart?: boolean): import("../column-interfaces.js").FieldValidator<any, any> | import("../column-interfaces.js").FieldValidator<any, any>[];

package/src/remult3/addValidator.js

@@ -0,0 +1,20 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.addValidator = void 0;
+var tslib_1 = require("tslib");
+function addValidator(validators, newValidator, atStart) {
+    if (atStart === void 0) { atStart = false; }
+    if (!newValidator)
+        return validators;
+    var newValidators = Array.isArray(newValidator)
+        ? newValidator
+        : [newValidator];
+    var validatorsArray = Array.isArray(validators)
+        ? validators
+        : validators
+            ? [validators]
+            : [];
+    return atStart
+        ? tslib_1.__spreadArray(tslib_1.__spreadArray([], tslib_1.__read(newValidators), false), tslib_1.__read(validatorsArray), false) : tslib_1.__spreadArray(tslib_1.__spreadArray([], tslib_1.__read(validatorsArray), false), tslib_1.__read(newValidators), false);
+}
+exports.addValidator = addValidator;

package/src/remult3/remult3.d.ts

@@ -315,14 +315,18 @@ export interface Repository<entityType> {
     /**
      * Updates all items that match the `where` condition.
      */
-    updateMany(where: EntityFilter<entityType>, item: Partial<MembersOnly<entityType>>): Promise<number>;
+    updateMany(options: {
+        where: EntityFilter<entityType>;
+    }, item: Partial<MembersOnly<entityType>>): Promise<number>;
     /** Deletes an Item*/
     delete(id: idType<entityType>): Promise<void>;
     delete(item: Partial<MembersOnly<entityType>>): Promise<void>;
     /**
      * Deletes all items that match the `where` condition.
      */
-    deleteMany(where: EntityFilter<entityType>): Promise<number>;
+    deleteMany(options: {
+        where: EntityFilter<entityType>;
+    }): Promise<number>;
     /** Creates an instance of an item. It'll not be saved to the data source unless `save` or `insert` will be called for that item */
     create(item?: Partial<MembersOnly<entityType>>): entityType;
     toJson(item: Promise<entityType[]>): Promise<any[]>;

package/src/remult3/remult3.js

@@ -1,60 +1,40 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-/*y1 - workshop
-
-* Experiment with doing this with version control - so the students can follow changes
-* Prepare stackblitz
-
-
-# influencer:
-  * review react summit
-#
-
-//y1 - getFields didn't work for kobi in the home component
-
-//p1 - processError in remult express
-//p1 - I think there should be a way to throw a forbidden exception
-//p1 - add section to Fields doc, explaining field type in db
-//p1 - add section about union type
-//p1 - add section about value list field type
+//p1 - add documentation for bun sqlite
+//p2 - fix dark background to also work on groups
+//y1 - JY suggestion of having generate as part of the ensure schema - not sure
+//y1 - currently for string fields we default for 255 in knex (which is their default) why not just use text (varchar max) - and only use exact length when one is provided?
+//y1 - consider changing the sql raw filter to return the sql, instead of setting the sql property
+//p2 - create foreign key constraints in user code - https://codesandbox.io/p/devbox/fk-validator-tdshcs
+//p1 - admin url1 - pocketbase use /_ for the admin //{allowed?:Allowed,url?:string}
+//p2 - article auth.js with express - played with it, requires type="module" and a few more configurations - https://github.com/noam-honig/express-auth
+//y1 - fix validators cache
+//y2 - should we validate relations
+//y1 - dependency of live query tables
+//p1 - see why mongo tests do not run anymore
+//y1 - consider the bot that updates dependencies
+//y1 - consider replacing all errors with error classes that extend the base Error class
+//y2 - should enforce integer - currently we probably round / truncate it
+//y1 - talk about filter on objects that are not loaded -  {
+//category: repo(CompoundId).create({ company: 7, index: 3, name: '' }),
+//    }
+//y1 - consider id to also support keyof (id:['company','index'])
+/*y1 - talk about modules in init express with entities/controllers,initRequest,initApi
+ - support get with backend method, with url search params as the first parameter, & url as second parameter
+   - support returning redirect, and plain html (For sign in scenarios)
 
+ */
+//p1 - in this video I'll use remult to turn a frontend app to a fullstack app
 /*y1 - Talk JYC - JYC - add some integrity checks on delete
   - soft delete
   - delete restrict (implicit, or user selected - and if so, how) (delete & update of id)
 
 */
-/*y1 currency.ts:10 Uncaught TypeError: Currency_1 is not a constructor
-// - ValueListFieldType - the decorator gives an error in react vite project - see langulage yedidya
-// happens in target 2022, ts<5.1.6
-//typescript 5.1.6
-@ValueListFieldType()
-export class Currency {
-  constructor(
-    public id: number,
-    public caption: string,
-    public symbol: string
-  ) {}
-  static shekel = new Currency(1, 'Shekel', '₪');
-  static dollar = new Currency(2, 'Dollar', '$');
-  static euro = new Currency(3, 'Euro', '€');
-  static pound = new Currency(4, 'Pound', '£');
-  static yen = new Currency(5, 'Yen', '¥');
-}
-
-*/
-//y1 - allow api read to also support instance and filter. - problem with promise
-//y1 - admin url1 - pocketbase use /_ for the admin
 //y1 - consider sql expression gets a dbnames of it's own (that already has the "tableName" defined correctly) maybe also the filter translator
-/*y1 - talk about modules in init express with entities/controllers,initRequest,initApi
- - support get with backend method, with url search params as the first parameter, & url as second parameter
-   - support returning redirect, and plain html (For sign in scenarios)
-
- */
 //y1 - tried to upgrade vitest, nuxt tests are failing with loading uuid - sounds familiar?
 //y1 - I think that the tests you've setup don't cover next app router - I added to the setup, but not sure where else
 //y1 - talk about the parameter issue with backend methods
 //y1 - select data provider per entity https://discord.com/channels/975754286384418847/976006081748807690/1201415305885397003
-//y1 - migrations
 //y1 - live query refresh of view on table update
 //y1 - main vs master
 //y2 - livequery for findfirst (@JY)
@@ -65,11 +45,9 @@ export class Currency {
   })
   Description = ""*/
 //y2 - get backend methods to work when specifying types for date, and entities as poco's
-//y2 - conside law-q db based on schema issue - I think that while running the dataProvider function, we should have a valid remult - maybe even have a valid remult, that will be valid until api is run
-//y2 - #239 - (@JY) add a way to get from fieldMetadata back to entity repo (like we have in fieldRef)
 //y2 - constraints (@JY)
 /*p2 remult admin
-
+ - when making a change and canceling - the changed value still appears
  - Small thing, I get SvelteKitError: Not found: /vite.svg
  - understand the to many relation for the admin, based on the to one
  - relation from order details to order gave a compound id info - and it is not true - same for the relation to product
@@ -81,11 +59,9 @@ export class Currency {
  - remult-admin didn't show a update for a table with a uniqua that is numeric
 */
 //remult
-//p1 - better support union types (status, etc... so it'll work also in filter etc...)
 //p1 - when a tasks table exists in a different schema - we get many errors
 //p1 - live query with include
 //p1 - adjust angular tutorial starter kit for latest angular (as is in tutorial)
-//p2 - allow find options preprocessor for api calls, to use for authorization
 //p2 - when subscribe is forbidden - the query still runs after the renew process
 //p2 - 'update tasks set  where id = $1
 //p2 - type metadata.key - to keyof entity - based on cwis input
@@ -93,23 +69,18 @@ export class Currency {
 //p2 - when value changes for field with error, clear error - so the user will feel comfortable
 //p2 - allowApiUpdate should be false for include in api false
 //docs
-//p2 - make sure that internal members do not appear in the documentation - try running it on the d.ts instead of the code itself.
 //------
+//y2 - wrap identifier for custom filter & sql expression
+//y2 - Should we create a separate implementation of command - one that the user uses, and another that the database implements (with only the bear necesities) - for example, to provide a second paramter called field for toDb conversions
+//y2 - should we simply inherit from SqlDataProvider - and send the required parameter in the call to the base class - I think that new SqlDatabase(new PostgresDataProvider()) is a bilt combersome
 //y2 - from the crm-demo(https://crm-demo.up.railway.app/deals), after editing a deal: - _updateEntityBasedOnApi
 //y2 - Backend methods are transactions, it's not intuitive and maybe should be optional / opt in
 //y2 - how to run a transaction as a user
-//p2 - enum column
-//y2 - message for invalid value
 //y2 - message for relation that is missing
 //y2 - consider multi tenancies
-//p2 - more column types
-//p2 - document validators
 //p2 - and validators to reference
 //y2 - discuss a default date formatter
 //y2 - add some api testing framework for user unit tests (will help with codesandbox based discussions)
 //[ ] V2 - what to do about for relations count?
 //[ ] V2 - condition? not to fetch if null etc....
-//[ ] V3 - all these fields will also appear in the where etc... in the typescript api - but we will not enforce them
-//y2 - consider if field types should include validation in them by default (string,number that it's not NaN etc...) and if so, what message?
-//y2 - should enforce integer - currently we probably round / truncate it
 //p1 - adjust react tutorial to esm

package/src/server-action.d.ts

@@ -21,7 +21,7 @@ export declare abstract class Action<inParam, outParam> implements ActionInterfa
     __register(reg: (url: string, queue: boolean, allowed: AllowedForInstance<any>, what: (data: any, req: Remult, res: DataApiResponse) => void) => void): void;
 }
 export declare class ForbiddenError extends Error {
-    constructor();
+    constructor(message?: string);
     isForbiddenError: true;
 }
 export declare class myServerAction extends Action<inArgs, result> {

package/src/server-action.js

@@ -98,7 +98,7 @@ var Action = /** @class */ (function () {
                             // got a problem in next with instance of ForbiddenError  - so replaced it with this bool
                             res.forbidden();
                         else
-                            res.error(err_1);
+                            res.error(err_1, undefined);
                         return [3 /*break*/, 3];
                     case 3: return [2 /*return*/];
                 }
@@ -111,8 +111,9 @@ var Action = /** @class */ (function () {
 exports.Action = Action;
 var ForbiddenError = /** @class */ (function (_super) {
     tslib_1.__extends(ForbiddenError, _super);
-    function ForbiddenError() {
-        var _this = _super.call(this, 'Forbidden') || this;
+    function ForbiddenError(message) {
+        if (message === void 0) { message = 'Forbidden'; }
+        var _this = _super.call(this, message) || this;
         _this.isForbiddenError = true;
         return _this;
     }
@@ -381,7 +382,7 @@ function BackendMethod(options) {
                                         // got a problem in next with instance of ForbiddenError  - so replaced it with this bool
                                         res.forbidden();
                                     else
-                                        res.error(err_3);
+                                        res.error(err_3, undefined);
                                     return [3 /*break*/, 4];
                                 case 4: return [2 /*return*/];
                             }

package/src/sql-command.d.ts

@@ -7,16 +7,21 @@ export interface SqlImplementation extends HasWrapIdentifier {
     ensureSchema?(entities: EntityMetadata[]): Promise<void>;
     supportsJsonColumnType?: boolean;
     orderByNullsFirst?: boolean;
+    end(): Promise<void>;
     afterMutation?: VoidFunction;
 }
 export interface HasWrapIdentifier {
     wrapIdentifier?(name: string): string;
 }
+export interface SqlCommandFactory extends HasWrapIdentifier {
+    createCommand(): SqlCommand;
+    execute(sql: string): Promise<SqlResult>;
+}
 export interface SqlCommand extends SqlCommandWithParameters {
     execute(sql: string): Promise<SqlResult>;
 }
 export interface SqlCommandWithParameters {
-    /** @deprecated @deprecated use `param` instead*/
+    /** @deprecated use `param` instead*/
     addParameterAndReturnSqlToken(val: any): string;
     param(val: any): string;
 }

package/src/validators.d.ts

@@ -47,3 +47,4 @@ export type ValidatorWithArgs<valueType, argsType> = (args: argsType, message?:
 export declare function createValidatorWithArgs<valueType, argsType>(validate: (entity: any, e: ValidateFieldEvent<any, valueType>, args: argsType) => Promise<boolean | string> | boolean | string, defaultMessage: ValidationMessage<valueType, argsType>): ValidatorWithArgs<valueType, argsType> & {
     defaultMessage: ValidationMessage<valueType, argsType>;
 };
+export declare function getEnumValues<theEnum = any>(enumObj: theEnum): any[];

package/src/validators.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.createValidatorWithArgs = exports.createValueValidatorWithArgs = exports.createValueValidator = exports.valueValidator = exports.createValidator = exports.Validators = void 0;
+exports.getEnumValues = exports.createValidatorWithArgs = exports.createValueValidatorWithArgs = exports.createValueValidator = exports.valueValidator = exports.createValidator = exports.Validators = void 0;
 var tslib_1 = require("tslib");
 var Validators = /** @class */ (function () {
     function Validators() {
@@ -48,11 +48,12 @@ var Validators = /** @class */ (function () {
     });
     Validators.email = createValueValidator(function (val) { return /^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(val); }, 'Invalid Email');
     Validators.url = createValueValidator(function (val) { return !!new URL(val); }, 'Invalid Url');
-    Validators.in = createValueValidatorWithArgs(function (val, values) { return values.includes(val); }, function (values) { return "Value must be one of ".concat(values.join(', ')); });
+    Validators.in = createValueValidatorWithArgs(function (val, values) { return values.includes(val); }, function (values) { return "Value must be one of ".concat(values.map(function (y) {
+        return typeof y === "object" ? y['id'] !== undefined ? y['id'] : y.toString() : y;
+    }).join(', ')); });
     Validators.notNull = createValueValidator(function (val) { return val != null; }, 'Should not be null');
     Validators.enum = createValueValidatorWithArgs(function (value, enumObj) { return Object.values(enumObj).includes(value); }, function (enumObj) {
-        return "Value must be one of ".concat(Object.values(enumObj)
-            .filter(function (x) { return typeof enumObj[x] !== 'number'; })
+        return "Value must be one of ".concat(getEnumValues(enumObj)
             .join(', '));
     });
     Validators.relationExists = createValidator(function (_, e) { return tslib_1.__awaiter(void 0, void 0, void 0, function () {
@@ -207,3 +208,8 @@ function createValidatorWithArgsInternal(validate, defaultMessage, isValueValida
         },
     });
 }
+function getEnumValues(enumObj) {
+    return Object.values(enumObj)
+        .filter(function (x) { return typeof enumObj[x] !== 'number'; });
+}
+exports.getEnumValues = getEnumValues;