remult 0.25.2 → 0.25.4

package/esm/postgres/schema-builder.js

@@ -1,5 +1,5 @@
 import { allEntities } from '../src/context.js';
-import { dbNamesOf, isDbReadonly, } from '../src/filter/filter-consumer-bridge-to-sql-request.js';
+import { dbNamesOf, shouldNotCreateField, } from '../src/filter/filter-consumer-bridge-to-sql-request.js';
 import { remult as defaultRemult } from '../src/remult-proxy.js';
 import { isAutoIncrement } from '../src/remult3/RepositoryImplementation.js';
 import { ValueConverters } from '../src/valueConverters.js';
@@ -132,7 +132,7 @@ export class PostgresSchemaBuilder {
             if (r.rows.length == 0) {
                 let result = '';
                 for (const x of entity.fields) {
-                    if (!isDbReadonly(x, e) || isAutoIncrement(x)) {
+                    if (!shouldNotCreateField(x, e) || isAutoIncrement(x)) {
                         if (result.length != 0)
                             result += ',';
                         result += '\r\n  ';
@@ -155,7 +155,7 @@ CREATE table ${this.schemaAndName(e)} (${result}\r\n)`;
     }
     async addColumnIfNotExist(entity, c) {
         let e = await dbNamesOf(entity, this.pool.wrapIdentifier);
-        if (isDbReadonly(c(entity), e))
+        if (shouldNotCreateField(c(entity), e))
             return;
         try {
             let cmd = this.pool.createCommand();
@@ -181,7 +181,7 @@ CREATE table ${this.schemaAndName(e)} (${result}\r\n)`;
             let cols = (await cmd.execute(`SELECT column_name FROM information_schema.columns WHERE ` +
                 `${this.whereTableAndSchema(cmd, e)}`)).rows.map((x) => x.column_name.toLocaleLowerCase());
             for (const col of entity.fields) {
-                if (!isDbReadonly(col, e)) {
+                if (!shouldNotCreateField(col, e)) {
                     let colName = e.$dbNameOf(col).toLocaleLowerCase();
                     if (colName.startsWith('"') && colName.endsWith('"'))
                         colName = colName.substring(1, colName.length - 1);

package/esm/remult-knex/index.js

@@ -1,5 +1,5 @@
 import { allEntities } from '../src/context.js';
-import { dbNamesOf, isDbReadonly, } from '../src/filter/filter-consumer-bridge-to-sql-request.js';
+import { dbNamesOf, isDbReadonly, shouldNotCreateField, } from '../src/filter/filter-consumer-bridge-to-sql-request.js';
 import { customDatabaseFilterToken, Filter, } from '../src/filter/filter-interfaces.js';
 import { CompoundIdField } from '../src/CompoundIdField.js';
 import { remult as remultContext } from '../src/remult-proxy.js';
@@ -358,7 +358,7 @@ export class KnexSchemaBuilder {
             for (const f of entity.fields) {
                 cols.set(f, {
                     name: e.$dbNameOf(f),
-                    readonly: isDbReadonly(f, e),
+                    readonly: shouldNotCreateField(f, e),
                 });
             }
             await logSql(this.knex.schema.createTable(e.$entityName, (b) => {
@@ -378,7 +378,7 @@ export class KnexSchemaBuilder {
     }
     async addColumnIfNotExist(entity, c) {
         let e = await dbNamesOf(entity);
-        if (isDbReadonly(c(entity), e))
+        if (shouldNotCreateField(c(entity), e))
             return;
         let col = c(entity);
         let colName = e.$dbNameOf(col);
@@ -392,7 +392,7 @@ export class KnexSchemaBuilder {
         let e = await dbNamesOf(entity);
         try {
             for (const col of entity.fields.toArray()) {
-                if (!isDbReadonly(col, e)) {
+                if (!shouldNotCreateField(col, e)) {
                     await this.addColumnIfNotExist(entity, () => col);
                 }
             }

package/esm/src/filter/filter-consumer-bridge-to-sql-request.js

@@ -154,6 +154,10 @@ export function isDbReadonly(field, dbNames) {
         field.isServerExpression ||
         (field.options.sqlExpression && field.dbName != dbNames.$dbNameOf(field)));
 }
+export function shouldNotCreateField(field, dbNames) {
+    return (field.isServerExpression ||
+        (field.options.sqlExpression && field.dbName != dbNames.$dbNameOf(field)));
+}
 export async function dbNamesOf(repo, wrapIdentifier = (x) => x) {
     var meta = getEntityMetadata(repo);
     const result = {

package/esm/src/remult3/RepositoryImplementation.js

@@ -1639,7 +1639,7 @@ export class FieldRefImplementation {
                     set error(value) {
                         self.error = value;
                     },
-                    isNew: self.rowBase.isNewRow,
+                    isNew: this.entityRef?.isNew(),
                     load: () => self.load(),
                     metadata: self.metadata,
                     originalValue: self.originalValue,

package/esm/src/remult3/remult3.js

@@ -43,6 +43,14 @@ remult.apiClient.url='localhost:3007/api
 
 
 */
+//p1 - investigate angular starter kit init request error
+//p1 - fix angular starter kit await set password
+//p1 - fix angular starter kit to latest version as well
+//p1 -check if checouknt doesn't respect allow read (I think)
+//p1 - fix multiple instances of remult: the defaultRemult and async local hook - and columnsOfType - all can be tests with a vite project loading `remult-admin`
+//p1 - crm demo graphql error
+//p1 - allow api update only for new rows
+//p1 - getFields didn't work for kobi in the home component
 //p2 - document validators
 //p2 - and validators to reference
 //y2 - discuss a default date formatter

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "remult",
-    "version": "0.25.2",
+    "version": "0.25.4",
     "description": "A CRUD framework for full-stack TypeScript",
     "homepage": "https://remult.dev",
     "repository": {

package/postgres/schema-builder.js

@@ -234,7 +234,7 @@ var PostgresSchemaBuilder = /** @class */ (function () {
                                             try {
                                                 for (_a = tslib_1.__values(entity.fields), _b = _a.next(); !_b.done; _b = _a.next()) {
                                                     x = _b.value;
-                                                    if (!(0, filter_consumer_bridge_to_sql_request_js_1.isDbReadonly)(x, e) || (0, RepositoryImplementation_js_1.isAutoIncrement)(x)) {
+                                                    if (!(0, filter_consumer_bridge_to_sql_request_js_1.shouldNotCreateField)(x, e) || (0, RepositoryImplementation_js_1.isAutoIncrement)(x)) {
                                                         if (result.length != 0)
                                                             result += ',';
                                                         result += '\r\n  ';
@@ -281,7 +281,7 @@ var PostgresSchemaBuilder = /** @class */ (function () {
                     case 0: return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity, this.pool.wrapIdentifier)];
                     case 1:
                         e = _a.sent();
-                        if ((0, filter_consumer_bridge_to_sql_request_js_1.isDbReadonly)(c(entity), e))
+                        if ((0, filter_consumer_bridge_to_sql_request_js_1.shouldNotCreateField)(c(entity), e))
                             return [2 /*return*/];
                         _a.label = 2;
                     case 2:
@@ -335,7 +335,7 @@ var PostgresSchemaBuilder = /** @class */ (function () {
                     case 4:
                         if (!!_b.done) return [3 /*break*/, 7];
                         col = _b.value;
-                        if (!!(0, filter_consumer_bridge_to_sql_request_js_1.isDbReadonly)(col, e)) return [3 /*break*/, 6];
+                        if (!!(0, filter_consumer_bridge_to_sql_request_js_1.shouldNotCreateField)(col, e)) return [3 /*break*/, 6];
                         colName = e.$dbNameOf(col).toLocaleLowerCase();
                         if (colName.startsWith('"') && colName.endsWith('"'))
                             colName = colName.substring(1, colName.length - 1);

package/remult-knex/index.js

@@ -719,7 +719,7 @@ var KnexSchemaBuilder = /** @class */ (function () {
                                 f = _b.value;
                                 cols_1.set(f, {
                                     name: e.$dbNameOf(f),
-                                    readonly: (0, filter_consumer_bridge_to_sql_request_js_1.isDbReadonly)(f, e),
+                                    readonly: (0, filter_consumer_bridge_to_sql_request_js_1.shouldNotCreateField)(f, e),
                                 });
                             }
                         }
@@ -771,7 +771,7 @@ var KnexSchemaBuilder = /** @class */ (function () {
                     case 0: return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity)];
                     case 1:
                         e = _a.sent();
-                        if ((0, filter_consumer_bridge_to_sql_request_js_1.isDbReadonly)(c(entity), e))
+                        if ((0, filter_consumer_bridge_to_sql_request_js_1.shouldNotCreateField)(c(entity), e))
                             return [2 /*return*/];
                         col = c(entity);
                         colName = e.$dbNameOf(col);
@@ -805,7 +805,7 @@ var KnexSchemaBuilder = /** @class */ (function () {
                             return tslib_1.__generator(this, function (_e) {
                                 switch (_e.label) {
                                     case 0:
-                                        if (!!(0, filter_consumer_bridge_to_sql_request_js_1.isDbReadonly)(col, e)) return [3 /*break*/, 2];
+                                        if (!!(0, filter_consumer_bridge_to_sql_request_js_1.shouldNotCreateField)(col, e)) return [3 /*break*/, 2];
                                         return [4 /*yield*/, this_2.addColumnIfNotExist(entity, function () { return col; })];
                                     case 1:
                                         _e.sent();

package/src/filter/filter-consumer-bridge-to-sql-request.d.ts

@@ -40,6 +40,7 @@ export declare class CustomSqlFilterBuilder {
     filterToRaw<entityType>(repo: RepositoryOverloads<entityType>, condition: EntityFilter<entityType>): Promise<string>;
 }
 export declare function isDbReadonly<entityType>(field: FieldMetadata, dbNames: EntityDbNames<entityType>): boolean;
+export declare function shouldNotCreateField<entityType>(field: FieldMetadata, dbNames: EntityDbNames<entityType>): boolean;
 export declare type EntityDbNamesBase = {
     $entityName: string;
     $dbNameOf(field: FieldMetadata<any> | string): string;

package/src/filter/filter-consumer-bridge-to-sql-request.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.fieldDbName = exports.entityDbName = exports.dbNamesOf = exports.isDbReadonly = exports.CustomSqlFilterBuilder = exports.FilterConsumerBridgeToSqlRequest = void 0;
+exports.fieldDbName = exports.entityDbName = exports.dbNamesOf = exports.shouldNotCreateField = exports.isDbReadonly = exports.CustomSqlFilterBuilder = exports.FilterConsumerBridgeToSqlRequest = void 0;
 var tslib_1 = require("tslib");
 var sql_database_js_1 = require("../data-providers/sql-database.js");
 var RepositoryImplementation_js_1 = require("../remult3/RepositoryImplementation.js");
@@ -263,6 +263,11 @@ function isDbReadonly(field, dbNames) {
         (field.options.sqlExpression && field.dbName != dbNames.$dbNameOf(field)));
 }
 exports.isDbReadonly = isDbReadonly;
+function shouldNotCreateField(field, dbNames) {
+    return (field.isServerExpression ||
+        (field.options.sqlExpression && field.dbName != dbNames.$dbNameOf(field)));
+}
+exports.shouldNotCreateField = shouldNotCreateField;
 function dbNamesOf(repo, wrapIdentifier) {
     if (wrapIdentifier === void 0) { wrapIdentifier = function (x) { return x; }; }
     return tslib_1.__awaiter(this, void 0, void 0, function () {

package/src/remult3/RepositoryImplementation.js

@@ -2679,14 +2679,15 @@ var FieldRefImplementation = /** @class */ (function () {
         return (JSON.stringify(this.metadata.valueConverter.toJson(this.rowBase.originalValues[this.metadata.key])) != JSON.stringify(this.metadata.valueConverter.toJson(val)));
     };
     FieldRefImplementation.prototype.__performValidation = function () {
+        var _a;
         return tslib_1.__awaiter(this, void 0, void 0, function () {
-            var processValidation, self_1, event_1, _a, _b, v, _c, e_41_1, _d, error_1;
-            var e_41, _e;
+            var processValidation, self_1, event_1, _b, _c, v, _d, e_41_1, _e, error_1;
+            var e_41, _f;
             var _this = this;
-            return tslib_1.__generator(this, function (_f) {
-                switch (_f.label) {
+            return tslib_1.__generator(this, function (_g) {
+                switch (_g.label) {
                     case 0:
-                        _f.trys.push([0, 12, , 13]);
+                        _g.trys.push([0, 12, , 13]);
                         processValidation = function (result) {
                             if (result !== true && result !== undefined && !_this.error) {
                                 if (typeof result === 'string' && result.length > 0)
@@ -2705,7 +2706,7 @@ var FieldRefImplementation = /** @class */ (function () {
                             set error(value) {
                                 self_1.error = value;
                             },
-                            isNew: self_1.rowBase.isNewRow,
+                            isNew: (_a = this.entityRef) === null || _a === void 0 ? void 0 : _a.isNew(),
                             load: function () { return self_1.load(); },
                             metadata: self_1.metadata,
                             originalValue: self_1.originalValue,
@@ -2716,44 +2717,44 @@ var FieldRefImplementation = /** @class */ (function () {
                             isBackend: function () { var _a, _b, _c; return !((_c = (_b = (_a = self_1.rowBase) === null || _a === void 0 ? void 0 : _a.remult) === null || _b === void 0 ? void 0 : _b.dataProvider) === null || _c === void 0 ? void 0 : _c.isProxy); },
                         };
                         if (!Array.isArray(this.settings.validate)) return [3 /*break*/, 9];
-                        _f.label = 1;
+                        _g.label = 1;
                     case 1:
-                        _f.trys.push([1, 6, 7, 8]);
-                        _a = tslib_1.__values(this.settings.validate), _b = _a.next();
-                        _f.label = 2;
+                        _g.trys.push([1, 6, 7, 8]);
+                        _b = tslib_1.__values(this.settings.validate), _c = _b.next();
+                        _g.label = 2;
                     case 2:
-                        if (!!_b.done) return [3 /*break*/, 5];
-                        v = _b.value;
-                        _c = processValidation;
+                        if (!!_c.done) return [3 /*break*/, 5];
+                        v = _c.value;
+                        _d = processValidation;
                         return [4 /*yield*/, v(this.container, event_1)];
                     case 3:
-                        _c.apply(void 0, [_f.sent()]);
-                        _f.label = 4;
+                        _d.apply(void 0, [_g.sent()]);
+                        _g.label = 4;
                     case 4:
-                        _b = _a.next();
+                        _c = _b.next();
                         return [3 /*break*/, 2];
                     case 5: return [3 /*break*/, 8];
                     case 6:
-                        e_41_1 = _f.sent();
+                        e_41_1 = _g.sent();
                         e_41 = { error: e_41_1 };
                         return [3 /*break*/, 8];
                     case 7:
                         try {
-                            if (_b && !_b.done && (_e = _a.return)) _e.call(_a);
+                            if (_c && !_c.done && (_f = _b.return)) _f.call(_b);
                         }
                         finally { if (e_41) throw e_41.error; }
                         return [7 /*endfinally*/];
                     case 8: return [3 /*break*/, 11];
                     case 9:
                         if (!(typeof this.settings.validate === 'function')) return [3 /*break*/, 11];
-                        _d = processValidation;
+                        _e = processValidation;
                         return [4 /*yield*/, this.settings.validate(this.container, event_1)];
                     case 10:
-                        _d.apply(void 0, [_f.sent()]);
-                        _f.label = 11;
+                        _e.apply(void 0, [_g.sent()]);
+                        _g.label = 11;
                     case 11: return [3 /*break*/, 13];
                     case 12:
-                        error_1 = _f.sent();
+                        error_1 = _g.sent();
                         if (typeof error_1 === 'string')
                             this.error = error_1;
                         else

package/src/remult3/remult3.js

@@ -44,6 +44,14 @@ remult.apiClient.url='localhost:3007/api
 
 
 */
+//p1 - investigate angular starter kit init request error
+//p1 - fix angular starter kit await set password
+//p1 - fix angular starter kit to latest version as well
+//p1 -check if checouknt doesn't respect allow read (I think)
+//p1 - fix multiple instances of remult: the defaultRemult and async local hook - and columnsOfType - all can be tests with a vite project loading `remult-admin`
+//p1 - crm demo graphql error
+//p1 - allow api update only for new rows
+//p1 - getFields didn't work for kobi in the home component
 //p2 - document validators
 //p2 - and validators to reference
 //y2 - discuss a default date formatter