remult 0.23.0-exp.7 → 0.23.0-exp.8

package/README.md

@@ -3,7 +3,7 @@
     <img src="https://github.com/remult/remult/raw/master/docs/public/logo.png" width="140" height="140">
   </a>
   <h1>Remult</h1>
-  <p>A CRUD framework for full-stack TypeScript</p>
+  <p>Full-stack CRUD, simplified, with SSOT TypeScript entities</p>
 	<a href="https://circleci.com/gh/remult/remult/tree/master" rel="nofollow">
 		<img alt="CircleCI" src="https://circleci.com/gh/remult/remult/tree/master.svg?style=shield">
 	</a>
@@ -22,9 +22,6 @@
 	<a href="https://discord.gg/GXHk7ZfuG5" rel="nofollow">
 		<img alt="Join Discord" src="https://badgen.net/discord/online-members/GXHk7ZfuG5?icon=discord&label=Discord"/>
 	</a>
-  <a href="https://twitter.com/intent/tweet?text=Remult%20-%20open-source%20CRUD%20framework%20for%20full-stack%20TypeScript%0A%0A%40remultjs%0A&url=https%3A%2F%2Fgithub.com%2Fremult%2Fremult">
-    <img alt="Twitter URL" src="https://img.shields.io/twitter/url?style=social&url=https%3A%2F%2Ftwitter.com%2Fintent%2Ftweet%3Ftext%3DRemult%2520-%2520open-source%2520CRUD%2520framework%2520for%2520full-stack%2520TypeScript%250A%250A%2540remultjs%250A%26url%3Dhttps%253A%252F%252Fgithub.com%252Fremult%252Fremult">
-  </a>
 </div>
 
 <br/>

package/esm/internals.d.ts

@@ -4,3 +4,4 @@ export { getEntitySettings } from './src/remult3/getEntityRef';
 export { __updateEntityBasedOnWhere } from './src/filter/filter-interfaces';
 export { actionInfo } from './src/server-action-info';
 export { RelationInfo } from './src/remult3/remult3';
+export { ClassType } from './classType';

package/esm/server/JsonEntityFileStorage.js

@@ -8,7 +8,7 @@ export class JsonEntityFileStorage {
         if (fs.existsSync(fn)) {
             return fs.readFileSync(fn).toString();
         }
-        return undefined;
+        return null;
     }
     setItem(entityDbName, json) {
         if (!fs.existsSync(this.folderPath)) {

package/esm/src/buildRestDataProvider.d.ts

@@ -1,6 +1,5 @@
 import type { RestDataProviderHttpProvider } from './data-interfaces';
-import { RestDataProviderHttpProviderUsingFetch } from './data-providers/rest-data-provider';
-export declare function buildRestDataProvider(provider: ExternalHttpProvider | typeof fetch): RestDataProviderHttpProviderUsingFetch | RestDataProviderHttpProvider;
+export declare function buildRestDataProvider(provider: ExternalHttpProvider | typeof fetch): RestDataProviderHttpProvider;
 export declare function isExternalHttpProvider(item: any): boolean;
 export declare class HttpProviderBridgeToRestDataProviderHttpProvider implements RestDataProviderHttpProvider {
     private http;

package/esm/src/column.d.ts

@@ -8,7 +8,7 @@ export declare class LookupColumn<T> {
     setId(val: any): void;
     waitLoadOf(id: any): Promise<T>;
     get(id: any): any;
-    storedItem: {
+    storedItem?: {
         item: T;
     };
     set(item: T): void;

package/esm/src/context.d.ts

@@ -15,7 +15,7 @@ export declare class RemultAsyncLocalStorage {
 }
 type myAsyncLocalStorage<T> = {
     run<R>(store: T, callback: (...args: any[]) => R, ...args: any[]): R;
-    getStore(): T;
+    getStore(): T | undefined;
 };
 export declare function isBackend(): boolean;
 export declare class Remult {

package/esm/src/context.js

@@ -90,7 +90,7 @@ export class Remult {
         if (typeof roles === 'boolean')
             return roles;
         if (typeof roles === 'string')
-            if (this.user?.roles?.indexOf(roles.toString()) >= 0)
+            if (this.user?.roles?.includes(roles.toString()))
                 return true;
         return false;
     }
@@ -112,6 +112,7 @@ export class Remult {
         }
         else
             return this.isAllowed(allowed);
+        return undefined;
     }
     /** The current data provider */
     dataProvider = new RestDataProvider(() => this.apiClient);

package/esm/src/data-interfaces.js

@@ -1,7 +1,5 @@
 import { Sort } from './sort';
 export function extractSort(sort) {
-    if (sort instanceof Sort)
-        return sort;
     if (sort instanceof Array) {
         let r = new Sort();
         sort.forEach((i) => {
@@ -9,4 +7,5 @@ export function extractSort(sort) {
         });
         return r;
     }
+    return sort;
 }

package/esm/src/data-providers/array-entity-data-provider.d.ts

@@ -4,8 +4,8 @@ import { Filter } from '../filter/filter-interfaces';
 import type { EntityFilter, EntityMetadata } from '../remult3/remult3';
 export declare class ArrayEntityDataProvider implements EntityDataProvider {
     private entity;
-    private rows?;
     static rawFilter(filter: CustomArrayFilter): EntityFilter<any>;
+    private rows;
     constructor(entity: EntityMetadata, rows?: any[]);
     __names: EntityDbNamesBase;
     init(): Promise<EntityDbNamesBase>;

package/esm/src/data-providers/array-entity-data-provider.js

@@ -3,7 +3,6 @@ import { dbNamesOf, isDbReadonly, } from '../filter/filter-consumer-bridge-to-sq
 import { Filter, customDatabaseFilterToken } from '../filter/filter-interfaces';
 export class ArrayEntityDataProvider {
     entity;
-    rows;
     static rawFilter(filter) {
         return {
             [customDatabaseFilterToken]: {
@@ -11,13 +10,13 @@ export class ArrayEntityDataProvider {
             },
         };
     }
+    rows;
     constructor(entity, rows) {
         this.entity = entity;
-        this.rows = rows;
-        if (!rows)
-            rows = [];
-        else {
-        }
+        if (rows === undefined)
+            this.rows = [];
+        else
+            this.rows = rows;
     }
     __names;
     async init() {
@@ -88,6 +87,7 @@ export class ArrayEntityDataProvider {
             return rows.map((i) => {
                 return this.translateFromJson(i, dbNames);
             });
+        return [];
     }
     translateFromJson(row, dbNames) {
         let result = {};

package/esm/src/data-providers/web-sql-data-provider.js

@@ -116,7 +116,7 @@ class WebSqlBridgeToSQLCommand {
                 });
             t.executeSql(s, v, (t1, r) => resolve(new WebSqlBridgeToSQLQueryResult(r)), (t2, err) => {
                 reject(err.message);
-                return undefined;
+                return false;
             });
         }));
     }
@@ -125,13 +125,13 @@ class WebSqlBridgeToSQLQueryResult {
     r;
     getColumnKeyInResultForIndexInSelect(index) {
         if (this.rows.length == 0)
-            return undefined;
+            throw Error('No rows');
         let i = 0;
         for (let m in this.rows[0]) {
             if (i++ == index)
                 return m;
         }
-        return undefined;
+        throw Error('index not found');
     }
     //@ts-ignore
     constructor(r) {

package/esm/src/filter/filter-interfaces.d.ts

@@ -2,8 +2,8 @@ import type { FieldMetadata } from '../column-interfaces';
 import type { Remult } from '../context';
 import type { EntityFilter, EntityMetadata } from '../remult3/remult3';
 export declare class Filter {
-    private apply?;
-    constructor(apply?: (add: FilterConsumer) => void);
+    private apply;
+    constructor(apply: (add: FilterConsumer) => void);
     __applyToConsumer(add: FilterConsumer): void;
     static resolve<entityType>(filter: EntityFilter<entityType> | (() => EntityFilter<entityType> | Promise<EntityFilter<entityType>>)): Promise<EntityFilter<entityType>>;
     static createCustom<entityType>(rawFilterTranslator: (unused: never, r: Remult) => EntityFilter<entityType> | Promise<EntityFilter<entityType>>, key?: string): (() => EntityFilter<entityType>) & customFilterInfo<entityType>;

package/esm/src/filter/filter-interfaces.js

@@ -4,9 +4,6 @@ export class Filter {
     apply;
     constructor(apply) {
         this.apply = apply;
-        if (!this.apply) {
-            this.apply = () => { };
-        }
     }
     __applyToConsumer(add) {
         this.apply(add);

package/esm/src/live-query/SubscriptionChannel.js

@@ -15,7 +15,7 @@ export class LiveQuerySubscriber {
     async setAllItems(result) {
         const items = await this.repo.fromJsonArray(result, this.query.options);
         this.forListeners((listener) => {
-            listener((x) => {
+            listener(() => {
                 return items;
             });
         }, this.allItemsMessage(items));

package/esm/src/remult3/Fields.d.ts

@@ -23,7 +23,7 @@ export declare class Fields {
 }
 export declare class Relations {
     static toOne<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, options?: RelationOptions<entityType, toEntityType, entityType> | keyof entityType): (target: any, context: string | ClassFieldDecoratorContextStub<entityType, toEntityType>, c?: any) => void;
-    static toMany<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, options: (RelationOptions<entityType, toEntityType, toEntityType, FindOptions<toEntityType>> & {
+    static toMany<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, options?: (RelationOptions<entityType, toEntityType, toEntityType, FindOptions<toEntityType>> & {
         fromEntityType?: ClassType<entityType>;
     }) | keyof toEntityType): (target: any, context: string | ClassFieldDecoratorContextStub<entityType, any>, c?: any) => void;
 }
@@ -40,7 +40,7 @@ export declare class Relations {
  * @Fields.string((options,remult) => options.includeInApi = true)
  * title='';
  */
-export declare function Field<entityType = any, valueType = any>(valueType: () => ClassType<valueType>, ...options: (FieldOptions<entityType, valueType> | ((options: FieldOptions<entityType, valueType>, remult: Remult) => void))[]): (target: any, context: ClassFieldDecoratorContextStub<entityType, valueType | undefined> | string, c?: any) => void;
+export declare function Field<entityType = any, valueType = any>(valueType: (() => ClassType<valueType>) | undefined, ...options: (FieldOptions<entityType, valueType> | ((options: FieldOptions<entityType, valueType>, remult: Remult) => void))[]): (target: any, context: ClassFieldDecoratorContextStub<entityType, valueType | undefined> | string, c?: any) => void;
 export interface StringFieldOptions<entityType = any> extends FieldOptions<entityType, string> {
     maxLength?: number;
 }

package/esm/src/remult3/Fields.js

@@ -193,4 +193,6 @@ export function checkTarget(target) {
     if (!target)
         throw new Error("Set the 'experimentalDecorators:true' option in your 'tsconfig' or 'jsconfig' (target undefined)");
 }
-//[ ] there is a duplicity between the oneToMany and manyToOne - maybe we should allow some derivation from one to another?
+//[ ]  I think JY finds it confusing that the field options and relation options are together - but I still think it's good - not sure if it's a transition faze or not
+//[ ] I wish that when you define a toOne we automagically get the toMany on the other side! 😉
+//[ ] implement to many inference based on to one

package/esm/src/remult3/RepositoryImplementation.d.ts

@@ -50,10 +50,10 @@ export declare class RepositoryImplementation<entityType> implements Repository<
     save(item: Partial<OmitEB<entityType>>[]): Promise<entityType[]>;
     save(item: Partial<OmitEB<entityType>>): Promise<entityType>;
     liveQuery(options?: FindOptions<entityType>): LiveQuery<entityType>;
-    rawFind(options: FindOptions<entityType>, skipOrderByAndLimit: boolean, loader: RelationLoader): Promise<Awaited<entityType>[]>;
+    rawFind(options: FindOptions<entityType>, skipOrderByAndLimit: boolean, loader: RelationLoader): Promise<entityType[]>;
     find(options: FindOptions<entityType>, skipOrderByAndLimit?: boolean): Promise<entityType[]>;
     buildEntityDataProviderFindOptions(options: FindOptions<entityType>): Promise<EntityDataProviderFindOptions>;
-    fromJsonArray(jsonItems: any[], loadOptions: LoadOptions<entityType>): Promise<Awaited<entityType>[]>;
+    fromJsonArray(jsonItems: any[], loadOptions: LoadOptions<entityType>): Promise<entityType[]>;
     private loadManyToOneForManyRows;
     private mapRawDataToResult;
     toJson(item: entityType | entityType[] | Promise<entityType> | Promise<entityType[]>): any;

package/esm/src/remult3/RepositoryImplementation.js

@@ -451,7 +451,7 @@ export class RepositoryImplementation {
         let where = [];
         let findOptions = {};
         let findOptionsSources = [];
-        const options = field.options;
+        let options = field.options;
         if (typeof options.findOptions === 'function') {
             findOptionsSources.push(options.findOptions(row));
         }
@@ -473,6 +473,32 @@ export class RepositoryImplementation {
                     findOptions[key] = source[key];
             }
         }
+        if (rel.type === 'toMany' && !options.field && !options.fields) {
+            for (const field of otherRepo.fields.toArray()) {
+                const rel = getRelationInfo(field.options);
+                const relOp = field.options;
+                if (rel)
+                    if (rel.type === 'reference') {
+                        options = { ...findOptions, field: field.key };
+                    }
+                    else if (rel.type === 'toOne') {
+                        if (relOp.field) {
+                            options = { ...options, field: relOp.field };
+                        }
+                        else if (relOp.fields) {
+                            let fields = {};
+                            for (const key in relOp.fields) {
+                                if (Object.prototype.hasOwnProperty.call(relOp.fields, key)) {
+                                    const keyInMyTable = relOp.fields[key];
+                                    fields[keyInMyTable] = key;
+                                }
+                            }
+                            options = { ...options, fields };
+                        }
+                        break;
+                    }
+            }
+        }
         if (options.field) {
             if (rel.type === 'toOne') {
                 where.push(otherRepo.metadata.idMetadata.getIdFilter(row[options.field]));
@@ -1133,12 +1159,14 @@ export class rowHelperImplementation extends rowHelperBase {
                 await this.__validateEntity();
             let doNotSave = false;
             let e = this.buildLifeCycleEvent(() => (doNotSave = true));
-            for (const col of this.fields) {
-                if (col.metadata.options.saving)
-                    await col.metadata.options.saving(this.instance, e, col);
-            }
-            if (this.info.entityInfo.saving) {
-                await this.info.entityInfo.saving(this.instance, e);
+            if (!this.remult.dataProvider.isProxy) {
+                for (const col of this.fields) {
+                    if (col.metadata.options.saving)
+                        await col.metadata.options.saving(this.instance, e, col);
+                }
+                if (this.info.entityInfo.saving) {
+                    await this.info.entityInfo.saving(this.instance, e);
+                }
             }
             this.__assertValidity();
             let d = this.copyDataToObject();
@@ -1185,12 +1213,14 @@ export class rowHelperImplementation extends rowHelperBase {
                     }
                 }
                 await this.loadDataFrom(updatedRow);
-                if (this.info.entityInfo.saved)
-                    await this.info.entityInfo.saved(this.instance, e);
-                if (this.repository.listeners)
-                    for (const listener of this.repository.listeners.filter((x) => x.saved)) {
-                        await listener.saved(this.instance, isNew);
-                    }
+                if (!this.remult.dataProvider.isProxy) {
+                    if (this.info.entityInfo.saved)
+                        await this.info.entityInfo.saved(this.instance, e);
+                    if (this.repository.listeners)
+                        for (const listener of this.repository.listeners.filter((x) => x.saved)) {
+                            await listener.saved(this.instance, isNew);
+                        }
+                }
                 await this.repository.remult.liveQueryPublisher.itemChanged(this.repository.metadata.key, [{ id: this.getId(), oldId: this.getOriginalId(), deleted: false }]);
                 this.saveOriginalData();
                 this._isNew = false;
@@ -1225,13 +1255,17 @@ export class rowHelperImplementation extends rowHelperBase {
     async delete() {
         this.__clearErrorsAndReportChanged();
         let e = this.buildLifeCycleEvent();
-        if (this.info.entityInfo.deleting)
-            await this.info.entityInfo.deleting(this.instance, e);
+        if (!this.remult.dataProvider.isProxy) {
+            if (this.info.entityInfo.deleting)
+                await this.info.entityInfo.deleting(this.instance, e);
+        }
         this.__assertValidity();
         try {
             await this.edp.delete(this.id);
-            if (this.info.entityInfo.deleted)
-                await this.info.entityInfo.deleted(this.instance, e);
+            if (!this.remult.dataProvider.isProxy) {
+                if (this.info.entityInfo.deleted)
+                    await this.info.entityInfo.deleted(this.instance, e);
+            }
             if (this.repository.listeners)
                 for (const listener of this.repository.listeners.filter((x) => x.deleted)) {
                     await listener.deleted(this.instance);

package/esm/src/remult3/getEntityRef.d.ts

@@ -5,5 +5,5 @@ export declare function getEntityRef<entityType>(entity: entityType, throwExcept
 export declare const entityMember: unique symbol;
 export declare const entityInfo: unique symbol;
 export declare const entityInfo_key: unique symbol;
-export declare function getEntitySettings<T>(entity: ClassType<T>, throwError?: boolean): EntityOptionsFactory;
+export declare function getEntitySettings<T>(entity: ClassType<T>, throwError?: boolean): EntityOptionsFactory | undefined;
 export declare function getEntityKey(entity: ClassType<any>): string;

package/esm/src/remult3/getEntityRef.js

@@ -2,7 +2,7 @@ export function getEntityRef(entity, throwException = true) {
     let x = entity[entityMember];
     if (!x && throwException)
         throw new Error('item ' +
-            entity.constructor.name +
+            (entity.constructor?.name || entity) +
             ' was not initialized using a context');
     return x;
 }

package/esm/src/sort.d.ts

@@ -6,9 +6,9 @@ export declare class Sort {
     Segments: SortSegment[];
     reverse(): Sort;
     compare(a: any, b: any, getFieldKey?: (field: FieldMetadata) => string): number;
-    static translateOrderByToSort<T>(entityDefs: EntityMetadata<T>, orderBy: EntityOrderBy<T>): Sort;
-    static createUniqueSort<T>(entityMetadata: EntityMetadata<T>, orderBy: Sort): Sort;
-    static createUniqueEntityOrderBy<T>(entityMetadata: EntityMetadata<T>, orderBy: EntityOrderBy<T>): EntityOrderBy<T>;
+    static translateOrderByToSort<T>(entityDefs: EntityMetadata<T>, orderBy?: EntityOrderBy<T>): Sort;
+    static createUniqueSort<T>(entityMetadata: EntityMetadata<T>, orderBy?: Sort): Sort;
+    static createUniqueEntityOrderBy<T>(entityMetadata: EntityMetadata<T>, orderBy?: EntityOrderBy<T>): EntityOrderBy<T>;
 }
 export interface SortSegment {
     field: FieldMetadata;

package/esm/src/sort.js

@@ -44,11 +44,8 @@ export class Sort {
         return r;
     }
     static translateOrderByToSort(entityDefs, orderBy) {
-        if (!orderBy)
-            return undefined;
-        let sort;
-        if (orderBy) {
-            sort = new Sort();
+        let sort = new Sort();
+        if (orderBy)
             for (const key in orderBy) {
                 if (Object.prototype.hasOwnProperty.call(orderBy, key)) {
                     const element = orderBy[key];
@@ -85,7 +82,6 @@ export class Sort {
                     }
                 }
             }
-        }
         return sort;
     }
     static createUniqueSort(entityMetadata, orderBy) {

package/internals.d.ts

@@ -4,3 +4,4 @@ export { getEntitySettings } from './src/remult3/getEntityRef';
 export { __updateEntityBasedOnWhere } from './src/filter/filter-interfaces';
 export { actionInfo } from './src/server-action-info';
 export { RelationInfo } from './src/remult3/remult3';
+export { ClassType } from './classType';

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "remult",
-    "version": "0.23.0-exp.7",
+    "version": "0.23.0-exp.8",
     "description": "A CRUD framework for full-stack TypeScript",
     "types": "index.d.ts",
     "module": "esm/index.js",

package/server/JsonEntityFileStorage.js

@@ -14,7 +14,7 @@ var JsonEntityFileStorage = /** @class */ (function () {
         if (fs.existsSync(fn)) {
             return fs.readFileSync(fn).toString();
         }
-        return undefined;
+        return null;
     };
     JsonEntityFileStorage.prototype.setItem = function (entityDbName, json) {
         if (!fs.existsSync(this.folderPath)) {

package/src/buildRestDataProvider.d.ts

@@ -1,6 +1,5 @@
 import type { RestDataProviderHttpProvider } from './data-interfaces';
-import { RestDataProviderHttpProviderUsingFetch } from './data-providers/rest-data-provider';
-export declare function buildRestDataProvider(provider: ExternalHttpProvider | typeof fetch): RestDataProviderHttpProviderUsingFetch | RestDataProviderHttpProvider;
+export declare function buildRestDataProvider(provider: ExternalHttpProvider | typeof fetch): RestDataProviderHttpProvider;
 export declare function isExternalHttpProvider(item: any): boolean;
 export declare class HttpProviderBridgeToRestDataProviderHttpProvider implements RestDataProviderHttpProvider {
     private http;

package/src/column.d.ts

@@ -8,7 +8,7 @@ export declare class LookupColumn<T> {
     setId(val: any): void;
     waitLoadOf(id: any): Promise<T>;
     get(id: any): any;
-    storedItem: {
+    storedItem?: {
         item: T;
     };
     set(item: T): void;

package/src/context.d.ts

@@ -15,7 +15,7 @@ export declare class RemultAsyncLocalStorage {
 }
 type myAsyncLocalStorage<T> = {
     run<R>(store: T, callback: (...args: any[]) => R, ...args: any[]): R;
-    getStore(): T;
+    getStore(): T | undefined;
 };
 export declare function isBackend(): boolean;
 export declare class Remult {

package/src/context.js

@@ -149,7 +149,7 @@ var Remult = /** @class */ (function () {
         if (typeof roles === 'boolean')
             return roles;
         if (typeof roles === 'string')
-            if (((_c = (_b = this.user) === null || _b === void 0 ? void 0 : _b.roles) === null || _c === void 0 ? void 0 : _c.indexOf(roles.toString())) >= 0)
+            if ((_c = (_b = this.user) === null || _b === void 0 ? void 0 : _b.roles) === null || _c === void 0 ? void 0 : _c.includes(roles.toString()))
                 return true;
         return false;
     };
@@ -182,6 +182,7 @@ var Remult = /** @class */ (function () {
         }
         else
             return this.isAllowed(allowed);
+        return undefined;
     };
     //@ts-ignore // type error of typescript regarding args that doesn't appear in my normal development
     /** Used to call a `backendMethod` using a specific `remult` object

package/src/data-interfaces.js

@@ -3,8 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.extractSort = void 0;
 var sort_1 = require("./sort");
 function extractSort(sort) {
-    if (sort instanceof sort_1.Sort)
-        return sort;
     if (sort instanceof Array) {
         var r_1 = new sort_1.Sort();
         sort.forEach(function (i) {
@@ -12,5 +10,6 @@ function extractSort(sort) {
         });
         return r_1;
     }
+    return sort;
 }
 exports.extractSort = extractSort;

package/src/data-providers/array-entity-data-provider.d.ts

@@ -4,8 +4,8 @@ import { Filter } from '../filter/filter-interfaces';
 import type { EntityFilter, EntityMetadata } from '../remult3/remult3';
 export declare class ArrayEntityDataProvider implements EntityDataProvider {
     private entity;
-    private rows?;
     static rawFilter(filter: CustomArrayFilter): EntityFilter<any>;
+    private rows;
     constructor(entity: EntityMetadata, rows?: any[]);
     __names: EntityDbNamesBase;
     init(): Promise<EntityDbNamesBase>;

package/src/data-providers/array-entity-data-provider.js

@@ -8,11 +8,10 @@ var filter_interfaces_1 = require("../filter/filter-interfaces");
 var ArrayEntityDataProvider = /** @class */ (function () {
     function ArrayEntityDataProvider(entity, rows) {
         this.entity = entity;
-        this.rows = rows;
-        if (!rows)
-            rows = [];
-        else {
-        }
+        if (rows === undefined)
+            this.rows = [];
+        else
+            this.rows = rows;
     }
     ArrayEntityDataProvider.rawFilter = function (filter) {
         var _a;
@@ -141,7 +140,7 @@ var ArrayEntityDataProvider = /** @class */ (function () {
                             return [2 /*return*/, rows.map(function (i) {
                                     return _this.translateFromJson(i, dbNames);
                                 })];
-                        return [2 /*return*/];
+                        return [2 /*return*/, []];
                 }
             });
         });

package/src/data-providers/web-sql-data-provider.js

@@ -199,7 +199,7 @@ var WebSqlBridgeToSQLCommand = /** @class */ (function () {
                     });
                 t.executeSql(s, v, function (t1, r) { return resolve(new WebSqlBridgeToSQLQueryResult(r)); }, function (t2, err) {
                     reject(err.message);
-                    return undefined;
+                    return false;
                 });
             });
         });
@@ -217,13 +217,13 @@ var WebSqlBridgeToSQLQueryResult = /** @class */ (function () {
     }
     WebSqlBridgeToSQLQueryResult.prototype.getColumnKeyInResultForIndexInSelect = function (index) {
         if (this.rows.length == 0)
-            return undefined;
+            throw Error('No rows');
         var i = 0;
         for (var m in this.rows[0]) {
             if (i++ == index)
                 return m;
         }
-        return undefined;
+        throw Error('index not found');
     };
     return WebSqlBridgeToSQLQueryResult;
 }());

package/src/filter/filter-interfaces.d.ts

@@ -2,8 +2,8 @@ import type { FieldMetadata } from '../column-interfaces';
 import type { Remult } from '../context';
 import type { EntityFilter, EntityMetadata } from '../remult3/remult3';
 export declare class Filter {
-    private apply?;
-    constructor(apply?: (add: FilterConsumer) => void);
+    private apply;
+    constructor(apply: (add: FilterConsumer) => void);
     __applyToConsumer(add: FilterConsumer): void;
     static resolve<entityType>(filter: EntityFilter<entityType> | (() => EntityFilter<entityType> | Promise<EntityFilter<entityType>>)): Promise<EntityFilter<entityType>>;
     static createCustom<entityType>(rawFilterTranslator: (unused: never, r: Remult) => EntityFilter<entityType> | Promise<EntityFilter<entityType>>, key?: string): (() => EntityFilter<entityType>) & customFilterInfo<entityType>;

package/src/filter/filter-interfaces.js

@@ -7,9 +7,6 @@ var relationInfoMember_1 = require("../remult3/relationInfoMember");
 var Filter = /** @class */ (function () {
     function Filter(apply) {
         this.apply = apply;
-        if (!this.apply) {
-            this.apply = function () { };
-        }
     }
     Filter.prototype.__applyToConsumer = function (add) {
         this.apply(add);

package/src/live-query/SubscriptionChannel.js

@@ -31,7 +31,7 @@ var LiveQuerySubscriber = /** @class */ (function () {
                     case 1:
                         items = _a.sent();
                         this.forListeners(function (listener) {
-                            listener(function (x) {
+                            listener(function () {
                                 return items;
                             });
                         }, this.allItemsMessage(items));

package/src/remult3/Fields.d.ts

@@ -23,7 +23,7 @@ export declare class Fields {
 }
 export declare class Relations {
     static toOne<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, options?: RelationOptions<entityType, toEntityType, entityType> | keyof entityType): (target: any, context: string | ClassFieldDecoratorContextStub<entityType, toEntityType>, c?: any) => void;
-    static toMany<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, options: (RelationOptions<entityType, toEntityType, toEntityType, FindOptions<toEntityType>> & {
+    static toMany<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, options?: (RelationOptions<entityType, toEntityType, toEntityType, FindOptions<toEntityType>> & {
         fromEntityType?: ClassType<entityType>;
     }) | keyof toEntityType): (target: any, context: string | ClassFieldDecoratorContextStub<entityType, any>, c?: any) => void;
 }
@@ -40,7 +40,7 @@ export declare class Relations {
  * @Fields.string((options,remult) => options.includeInApi = true)
  * title='';
  */
-export declare function Field<entityType = any, valueType = any>(valueType: () => ClassType<valueType>, ...options: (FieldOptions<entityType, valueType> | ((options: FieldOptions<entityType, valueType>, remult: Remult) => void))[]): (target: any, context: ClassFieldDecoratorContextStub<entityType, valueType | undefined> | string, c?: any) => void;
+export declare function Field<entityType = any, valueType = any>(valueType: (() => ClassType<valueType>) | undefined, ...options: (FieldOptions<entityType, valueType> | ((options: FieldOptions<entityType, valueType>, remult: Remult) => void))[]): (target: any, context: ClassFieldDecoratorContextStub<entityType, valueType | undefined> | string, c?: any) => void;
 export interface StringFieldOptions<entityType = any> extends FieldOptions<entityType, string> {
     maxLength?: number;
 }

package/src/remult3/Fields.js

@@ -257,4 +257,6 @@ function checkTarget(target) {
         throw new Error("Set the 'experimentalDecorators:true' option in your 'tsconfig' or 'jsconfig' (target undefined)");
 }
 exports.checkTarget = checkTarget;
-//[ ] there is a duplicity between the oneToMany and manyToOne - maybe we should allow some derivation from one to another?
+//[ ]  I think JY finds it confusing that the field options and relation options are together - but I still think it's good - not sure if it's a transition faze or not
+//[ ] I wish that when you define a toOne we automagically get the toMany on the other side! 😉
+//[ ] implement to many inference based on to one