remult 0.23.0-exp.30 → 0.23.0-exp.32

package/esm/index.d.ts

@@ -1,5 +1,6 @@
 import type { ClassType } from './classType';
-export { OmitEB, FieldsMetadata, FieldRef, IdFieldRef, FieldsRef, EntityMetadata, EntityOrderBy, EntityFilter, FindOptions, QueryResult, QueryOptions, Repository, FindFirstOptions, ComparisonValueFilter, ValueFilter, IdFilter, ContainsStringValueFilter, EntityRef, SortSegments, Paginator, LiveQuery, LiveQueryChangeInfo, Subscribable, RefSubscriber, RefSubscriberBase, RelationOptions, ObjectMembersOnly, MembersToInclude, RepositoryRelations, EntityIdFields, ClassFieldDecorator as MemberDecorator, ClassFieldDecoratorContextStub, } from './src/remult3/remult3';
+export { OmitEB, FieldsMetadata, FieldRef, IdFieldRef, FieldsRef, EntityMetadata, EntityOrderBy, EntityFilter, FindOptions, QueryResult, QueryOptions, Repository, FindFirstOptions, ComparisonValueFilter, ValueFilter, IdFilter, ContainsStringValueFilter, EntityRef, SortSegments, Paginator, LiveQuery, LiveQueryChangeInfo, Subscribable, RefSubscriber, RefSubscriberBase, RelationOptions, ObjectMembersOnly, MembersToInclude, RepositoryRelations, EntityIdFields, ClassFieldDecorator, ClassFieldDecoratorContextStub, //n1 consider removing in ts5
+LifecycleEvent, } from './src/remult3/remult3';
 export { EntityBase, ControllerBase, FieldType, getFields, ValueListFieldType, getValueList, ValueListFieldOptions, ValueListInfo, CaptionTransformer, } from './src/remult3/RepositoryImplementation';
 export { Entity } from './src/remult3/entity';
 export { getEntityRef } from './src/remult3/getEntityRef';

package/esm/server/expressBridge.js

@@ -763,7 +763,7 @@ export class EntityQueueStorage {
         return (this.sync = this.sync.then(() => what()));
     }
     async getJobInfo(queuedJobId) {
-        let q = await this.repo.findId(queuedJobId, { useCache: false });
+        let q = await this.repo.findId(queuedJobId);
         let lastProgress = undefined;
         return {
             userId: q.userId,
@@ -992,4 +992,3 @@ JobsInQueueEntity = __decorate([
 ], JobsInQueueEntity);
 export { JobsInQueueEntity };
 allEntities.splice(allEntities.indexOf(JobsInQueueEntity), 1);
-//p1 - implement dbname based on related field https://codesandbox.io/p/sandbox/fervent-yalow-66m78n?file=%2Fsrc%2Findex.ts%3A35%2C93

package/esm/src/column-interfaces.d.ts

@@ -37,7 +37,7 @@ export interface FieldOptions<entityType = any, valueType = any> {
      */
     validate?: ((entity: entityType, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>) | ((entity: entityType, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>)[];
     /** Will be fired before this field is saved to the server/database */
-    saving?: (entity: entityType, e: LifecycleEvent<entityType>, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>;
+    saving?: (entity: entityType, fieldRef: FieldRef<entityType, valueType>, e: LifecycleEvent<entityType>) => any | Promise<any>;
     /**  An expression that will determine this fields value on the backend and be provided to the front end*/
     serverExpression?: (entity: entityType) => valueType | Promise<valueType>;
     /** The name of the column in the database that holds the data for this field. If no name is set, the key will be used instead.

package/esm/src/context.js

@@ -286,7 +286,5 @@ class transactionLiveQueryPublisher {
         }
     }
 }
-//p1 - seems that after backend methods relations are loaded for some reason - see trempim - intake doRequest backend method
-//p1 - reconsider the case in tremping where create user id was updated with some user and not the actual user
-//[ ] - when value changes for field with error, clear error - so the user will feel comfortable
+//p2 - when value changes for field with error, clear error - so the user will feel comfortable
 //y2 - require filter argument - and perform validation checks for it - site, id etc.. changelog, status changes etc...,

package/esm/src/remult3/Fields.js

@@ -46,7 +46,7 @@ export class Fields {
     static createdAt(...options) {
         return Field(() => Date, {
             allowApiUpdate: false,
-            saving: (_, { isNew }, ref) => {
+            saving: (_, ref, { isNew }) => {
                 if (isNew)
                     ref.value = new Date();
             },
@@ -55,7 +55,7 @@ export class Fields {
     static updatedAt(...options) {
         return Field(() => Date, {
             allowApiUpdate: false,
-            saving: (_, _1, ref) => {
+            saving: (_, ref) => {
                 ref.value = new Date();
             },
         }, ...options);
@@ -64,7 +64,7 @@ export class Fields {
         return Field(() => String, {
             allowApiUpdate: false,
             defaultValue: () => uuid(),
-            saving: (_, _1, r) => {
+            saving: (_, r) => {
                 if (!r.value)
                     r.value = uuid();
             },
@@ -74,7 +74,7 @@ export class Fields {
         return Field(() => String, {
             allowApiUpdate: false,
             defaultValue: () => createId(),
-            saving: (_, _1, r) => {
+            saving: (_, r) => {
                 if (!r.value)
                     r.value = createId();
             },

package/esm/src/remult3/RepositoryImplementation.js

@@ -81,13 +81,17 @@ export class RepositoryImplementation {
                 if (!rel)
                     throw Error(key + ' is not a relation');
                 let repo = this.remult.repo(rel.toType());
-                let { findOptions } = this.findOptionsBasedOnRelation(rel, field, undefined, item, repo);
+                let { findOptions, returnNull, returnUndefined } = this.findOptionsBasedOnRelation(rel, field, undefined, item, repo);
                 const toRepo = new RepositoryImplementation(repo.entity, repo.remult, repo.dataProvider, repo._info, findOptions);
                 if (rel.type === 'toMany')
                     return toRepo;
                 else
                     return {
                         findOne: (options) => {
+                            if (returnNull)
+                                return Promise.resolve(null);
+                            if (returnUndefined)
+                                return Promise.resolve(undefined);
                             return toRepo.findFirst({}, options);
                         },
                     };
@@ -439,6 +443,8 @@ export class RepositoryImplementation {
                             metadata: toRepo.metadata,
                         }, findOptions)
                             .then((result) => {
+                            if (result.length == 0 && rel.type == 'toOne')
+                                return;
                             row[col.key] =
                                 rel.type !== 'toMany'
                                     ? result.length == 0
@@ -455,6 +461,7 @@ export class RepositoryImplementation {
     /*@internal */
     findOptionsBasedOnRelation(rel, field, moreFindOptions, row, otherRepo) {
         let returnNull = false;
+        let returnUndefined = false;
         let where = [];
         let findOptions = {};
         let findOptionsSources = [];
@@ -527,6 +534,8 @@ export class RepositoryImplementation {
                 const val = row[options.field];
                 if (val === null)
                     returnNull = true;
+                if (val === undefined)
+                    returnUndefined = true;
                 else
                     where.push(otherRepo.metadata.idMetadata.getIdFilter(val));
             }
@@ -552,6 +561,8 @@ export class RepositoryImplementation {
                 : row[field.key];
             if (val === null)
                 returnNull = true;
+            if (val === undefined)
+                returnUndefined = true;
             else if (typeof val === 'object')
                 where.push(otherRepo.metadata.idMetadata.getIdFilter(otherRepo.metadata.idMetadata.getId(val)));
             else
@@ -562,7 +573,7 @@ export class RepositoryImplementation {
             findOptions.orderBy // I deduce from this that there may be more than one row and we want only the first
         )
             findOptions.limit = 1;
-        return { findOptions, returnNull };
+        return { findOptions, returnNull, returnUndefined };
     }
     async mapRawDataToResult(r, loadFields) {
         if (!r)
@@ -723,7 +734,6 @@ export class RepositoryImplementation {
         if (typeof id !== 'string' && typeof id !== 'number')
             throw new Error('id can be either number or string, but got: ' + typeof id);
         return this.findFirst({}, {
-            useCache: true,
             ...options,
             where: this.metadata.idMetadata.getIdFilter(id),
         }, true);
@@ -1199,7 +1209,7 @@ export class rowHelperImplementation extends rowHelperBase {
             if (!this.remult.dataProvider.isProxy) {
                 for (const col of this.fields) {
                     if (col.metadata.options.saving)
-                        await col.metadata.options.saving(this.instance, e, col);
+                        await col.metadata.options.saving(this.instance, col, e);
                 }
                 if (this.info.entityInfo.saving) {
                     await this.info.entityInfo.saving(this.instance, e);
@@ -1355,8 +1365,10 @@ export class rowHelperImplementation extends rowHelperBase {
     wasChanged() {
         this._subscribers?.reportObserved();
         for (const col of this.fields) {
-            if (col.valueChanged())
-                return true;
+            const rel = getRelationInfo(col.metadata.options);
+            if (!rel || rel.type == 'reference')
+                if (col.valueChanged())
+                    return true;
         }
         return false;
     }
@@ -1472,8 +1484,10 @@ export class FieldRefImplementation {
                     .relations(this.container)[this.metadata.key].find());
             }
             else {
-                return (this.container[this.metadata.key] = await this.helper.repository
-                    .relations(this.container)[this.metadata.key].findOne());
+                let val = await this.helper.repository
+                    .relations(this.container)[this.metadata.key].findOne();
+                if (val)
+                    this.container[this.metadata.key] = val;
             }
         }
         else if (lu) {
@@ -1665,6 +1679,14 @@ export class columnDefsImpl {
                     return this.settings.dbName;
                 return result;
             }
+            const rel = getRelationInfo(this.settings);
+            let field = rel?.type === 'toOne' &&
+                this.settings.field;
+            if (field) {
+                let fInfo = this.entityDefs.fields.find(field);
+                if (fInfo)
+                    return fInfo.getDbName();
+            }
             return this.settings.dbName;
         }
         finally {

package/esm/src/remult3/remult3.d.ts

@@ -551,7 +551,7 @@ export interface ClassDecoratorContextStub<Class extends new (...args: any) => a
 }
 export type ClassFieldDecorator<entityType, valueType> = (target: any, context: string | ClassFieldDecoratorContextStub<entityType, valueType | undefined>, c?: any) => void;
 /**
- * //p1 - doc this
+ * //p2 - doc this
 remult.apiClient.httpClient = (
   input: RequestInfo | URL,
   init?: RequestInit

package/esm/src/remult3/remult3.js

@@ -1,21 +1,14 @@
 export {};
-//p1 - include relations in the api docs
-//p1 - include Relation options in the api docs
-//p1 - fix { allowApiRead: r => r.user.name === 'superman' } } in allowed for instace docs
-//p1 - fix seeallowed in ref_entity
 //p2 - write doc about controlling updates of rows...
 //p2 - need a way to extract the fields from the relation - for generating relation based sql
-//p1 - omit functions from fields and relations
-//p1 - active record with include thinks that the row was change!
 //p2 - add docs for apply changes
-//p1 - when the include doesn't find the many to one - it deletes the id!!!
 //y2 - discuss a default date formatter
 //[ ] - consider using this in saving etc...
 //p2 - when subscribe is forbidden - the query still runs after the renew process
 //p2 - JSON FIELD LOST JSON STORAGE WHEN SET INPUT VALUE
 //p2 - doc this:
 /**
- * //p1 - doc this
+ * //p2 - doc this
 remult.apiClient.httpClient = (
   input: RequestInfo | URL,
   init?: RequestInit
@@ -40,20 +33,24 @@ remult.apiClient.url='localhost:3007/api
 //p2 - Operator '>' cannot be applied to types 'Number' and 'number'.ts(2365) - change fields to <entityType,number> (now it's Number)
 //p2 - Field(()=>String) - doesn't play nice with strict mode - it prevents people from extending basic types
 //p2 - with remult for remultexpress
-//p1 - Add a with remult promise to Remult!
-//p1 - YONI field didn't appear in intelisence of manyToNe
-//p1 - YONI with relation to one, fields doesn't appear well in the overload options when trying to set driver phone on trempim
-//p1 - YONI why didn't this._.relations.statusChanges.insert({})work?
-//p1 - YONI 'taskid' toOne field parameter did not autocomplete in task app - C:\repos\help-zahal\src\app\events\volunteerInTask.ts 49
+//p2 - Add a with remult promise to Remult!
+//y1 - YONI field didn't appear in intelisence of manyToNe
+//y1 - YONI with relation to one, fields doesn't appear well in the overload options when trying to set driver phone on trempim
+//y1 - YONI why didn't this._.relations.statusChanges.insert({})work?
+//y1 - YONI 'taskid' toOne field parameter did not autocomplete in task app - C:\repos\help-zahal\src\app\events\volunteerInTask.ts 49
+//y1 - YONI omit functions from fields and relations
 //p2 - filterToRaw should get a dbnames of - and we should create a dbnames of that supports an alias
-//p1 - DO NOT BREAK - move fieldref to second parameter, and lifecycle to 3rd consider the breaking signature change of saving on field options - the field becomes the 3rd parameter.
-//p1 - test what happens with a many to one relation where the one no longer exist, in all 3 cases (toOne,reference,toone with fields)
-//p1 - findid by default has cache - it sucks!
 //y2 - livequery for findfirst (@JY)
 //y2 - #239 - (@JY) add a way to get from fieldMetadata back to entity repo (like we have in fieldRef)
 //p2 - constraints (@JY)
 //p2 - Add ability to process query that comes from the api
 //p2 - too much data by mistake
 //p2 - postgres case sensitive
-//y1 - consider http status code for errors
 //p2 - fix sql log to console to make more sense
+//p2 - type metadata.key - to keyof entity - based on cwis input
+//p2 - processError in remult express
+//y1 - should we change relations to be a static const instead of a class (also for fields maybe) what's the point of doing new Relations
+//y1 - add Class type to index of remult - it is used in repo and is important
+//y2 - Backend methods are transactions, it's not intuitive and maybe should be optional / opt in
+//p2 - get backend methods to work when specifying types for date, and entities as poco's
+//p2 - allow find options preprocessor for api calls, to use for authorization

package/index.d.ts

@@ -1,5 +1,6 @@
 import type { ClassType } from './classType';
-export { OmitEB, FieldsMetadata, FieldRef, IdFieldRef, FieldsRef, EntityMetadata, EntityOrderBy, EntityFilter, FindOptions, QueryResult, QueryOptions, Repository, FindFirstOptions, ComparisonValueFilter, ValueFilter, IdFilter, ContainsStringValueFilter, EntityRef, SortSegments, Paginator, LiveQuery, LiveQueryChangeInfo, Subscribable, RefSubscriber, RefSubscriberBase, RelationOptions, ObjectMembersOnly, MembersToInclude, RepositoryRelations, EntityIdFields, ClassFieldDecorator as MemberDecorator, ClassFieldDecoratorContextStub, } from './src/remult3/remult3';
+export { OmitEB, FieldsMetadata, FieldRef, IdFieldRef, FieldsRef, EntityMetadata, EntityOrderBy, EntityFilter, FindOptions, QueryResult, QueryOptions, Repository, FindFirstOptions, ComparisonValueFilter, ValueFilter, IdFilter, ContainsStringValueFilter, EntityRef, SortSegments, Paginator, LiveQuery, LiveQueryChangeInfo, Subscribable, RefSubscriber, RefSubscriberBase, RelationOptions, ObjectMembersOnly, MembersToInclude, RepositoryRelations, EntityIdFields, ClassFieldDecorator, ClassFieldDecoratorContextStub, //n1 consider removing in ts5
+LifecycleEvent, } from './src/remult3/remult3';
 export { EntityBase, ControllerBase, FieldType, getFields, ValueListFieldType, getValueList, ValueListFieldOptions, ValueListInfo, CaptionTransformer, } from './src/remult3/RepositoryImplementation';
 export { Entity } from './src/remult3/entity';
 export { getEntityRef } from './src/remult3/getEntityRef';

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "remult",
-    "version": "0.23.0-exp.30",
+    "version": "0.23.0-exp.32",
     "description": "A CRUD framework for full-stack TypeScript",
     "types": "index.d.ts",
     "module": "esm/index.js",

package/server/expressBridge.js

@@ -1125,7 +1125,7 @@ var EntityQueueStorage = /** @class */ (function () {
             var _this = this;
             return tslib_1.__generator(this, function (_a) {
                 switch (_a.label) {
-                    case 0: return [4 /*yield*/, this.repo.findId(queuedJobId, { useCache: false })];
+                    case 0: return [4 /*yield*/, this.repo.findId(queuedJobId)];
                     case 1:
                         q = _a.sent();
                         lastProgress = undefined;
@@ -1406,4 +1406,3 @@ var JobsInQueueEntity = /** @class */ (function (_super) {
 }(IdEntity_1.IdEntity));
 exports.JobsInQueueEntity = JobsInQueueEntity;
 context_1.allEntities.splice(context_1.allEntities.indexOf(JobsInQueueEntity), 1);
-//p1 - implement dbname based on related field https://codesandbox.io/p/sandbox/fervent-yalow-66m78n?file=%2Fsrc%2Findex.ts%3A35%2C93

package/src/column-interfaces.d.ts

@@ -37,7 +37,7 @@ export interface FieldOptions<entityType = any, valueType = any> {
      */
     validate?: ((entity: entityType, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>) | ((entity: entityType, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>)[];
     /** Will be fired before this field is saved to the server/database */
-    saving?: (entity: entityType, e: LifecycleEvent<entityType>, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>;
+    saving?: (entity: entityType, fieldRef: FieldRef<entityType, valueType>, e: LifecycleEvent<entityType>) => any | Promise<any>;
     /**  An expression that will determine this fields value on the backend and be provided to the front end*/
     serverExpression?: (entity: entityType) => valueType | Promise<valueType>;
     /** The name of the column in the database that holds the data for this field. If no name is set, the key will be used instead.

package/src/context.js

@@ -450,7 +450,5 @@ var transactionLiveQueryPublisher = /** @class */ (function () {
     };
     return transactionLiveQueryPublisher;
 }());
-//p1 - seems that after backend methods relations are loaded for some reason - see trempim - intake doRequest backend method
-//p1 - reconsider the case in tremping where create user id was updated with some user and not the actual user
-//[ ] - when value changes for field with error, clear error - so the user will feel comfortable
+//p2 - when value changes for field with error, clear error - so the user will feel comfortable
 //y2 - require filter argument - and perform validation checks for it - site, id etc.. changelog, status changes etc...,

package/src/remult3/Fields.js

@@ -86,7 +86,7 @@ var Fields = /** @class */ (function () {
         return Field.apply(void 0, tslib_1.__spreadArray([function () { return Date; },
             {
                 allowApiUpdate: false,
-                saving: function (_, _a, ref) {
+                saving: function (_, ref, _a) {
                     var isNew = _a.isNew;
                     if (isNew)
                         ref.value = new Date();
@@ -101,7 +101,7 @@ var Fields = /** @class */ (function () {
         return Field.apply(void 0, tslib_1.__spreadArray([function () { return Date; },
             {
                 allowApiUpdate: false,
-                saving: function (_, _1, ref) {
+                saving: function (_, ref) {
                     ref.value = new Date();
                 },
             }], tslib_1.__read(options), false));
@@ -115,7 +115,7 @@ var Fields = /** @class */ (function () {
             {
                 allowApiUpdate: false,
                 defaultValue: function () { return (0, uuid_1.v4)(); },
-                saving: function (_, _1, r) {
+                saving: function (_, r) {
                     if (!r.value)
                         r.value = (0, uuid_1.v4)();
                 },
@@ -130,7 +130,7 @@ var Fields = /** @class */ (function () {
             {
                 allowApiUpdate: false,
                 defaultValue: function () { return (0, cuid2_1.createId)(); },
-                saving: function (_, _1, r) {
+                saving: function (_, r) {
                     if (!r.value)
                         r.value = (0, cuid2_1.createId)();
                 },

package/src/remult3/RepositoryImplementation.js

@@ -126,13 +126,17 @@ var RepositoryImplementation = /** @class */ (function () {
                 if (!rel)
                     throw Error(key + ' is not a relation');
                 var repo = _this.remult.repo(rel.toType());
-                var findOptions = _this.findOptionsBasedOnRelation(rel, field, undefined, item, repo).findOptions;
+                var _a = _this.findOptionsBasedOnRelation(rel, field, undefined, item, repo), findOptions = _a.findOptions, returnNull = _a.returnNull, returnUndefined = _a.returnUndefined;
                 var toRepo = new RepositoryImplementation(repo.entity, repo.remult, repo.dataProvider, repo._info, findOptions);
                 if (rel.type === 'toMany')
                     return toRepo;
                 else
                     return {
                         findOne: function (options) {
+                            if (returnNull)
+                                return Promise.resolve(null);
+                            if (returnUndefined)
+                                return Promise.resolve(undefined);
                             return toRepo.findFirst({}, options);
                         },
                     };
@@ -731,6 +735,8 @@ var RepositoryImplementation = /** @class */ (function () {
                                             metadata: toRepo_1.metadata,
                                         }, findOptions)
                                             .then(function (result) {
+                                            if (result.length == 0 && rel.type == 'toOne')
+                                                return;
                                             row[col.key] =
                                                 rel.type !== 'toMany'
                                                     ? result.length == 0
@@ -778,6 +784,7 @@ var RepositoryImplementation = /** @class */ (function () {
     RepositoryImplementation.prototype.findOptionsBasedOnRelation = function (rel, field, moreFindOptions, row, otherRepo) {
         var e_13, _a, e_14, _b, e_15, _c, _d, _e;
         var returnNull = false;
+        var returnUndefined = false;
         var where = [];
         var findOptions = {};
         var findOptionsSources = [];
@@ -880,6 +887,8 @@ var RepositoryImplementation = /** @class */ (function () {
                 var val = row[options.field];
                 if (val === null)
                     returnNull = true;
+                if (val === undefined)
+                    returnUndefined = true;
                 else
                     where.push(otherRepo.metadata.idMetadata.getIdFilter(val));
             }
@@ -905,6 +914,8 @@ var RepositoryImplementation = /** @class */ (function () {
                 : row[field.key];
             if (val === null)
                 returnNull = true;
+            if (val === undefined)
+                returnUndefined = true;
             else if (typeof val === 'object')
                 where.push(otherRepo.metadata.idMetadata.getIdFilter(otherRepo.metadata.idMetadata.getId(val)));
             else
@@ -915,7 +926,7 @@ var RepositoryImplementation = /** @class */ (function () {
             findOptions.orderBy // I deduce from this that there may be more than one row and we want only the first
         )
             findOptions.limit = 1;
-        return { findOptions: findOptions, returnNull: returnNull };
+        return { findOptions: findOptions, returnNull: returnNull, returnUndefined: returnUndefined };
     };
     RepositoryImplementation.prototype.mapRawDataToResult = function (r, loadFields) {
         return tslib_1.__awaiter(this, void 0, void 0, function () {
@@ -1157,7 +1168,7 @@ var RepositoryImplementation = /** @class */ (function () {
             return null;
         if (typeof id !== 'string' && typeof id !== 'number')
             throw new Error('id can be either number or string, but got: ' + typeof id);
-        return this.findFirst({}, tslib_1.__assign(tslib_1.__assign({ useCache: true }, options), { where: this.metadata.idMetadata.getIdFilter(id) }), true);
+        return this.findFirst({}, tslib_1.__assign(tslib_1.__assign({}, options), { where: this.metadata.idMetadata.getIdFilter(id) }), true);
     };
     /* @internal*/
     RepositoryImplementation.prototype.translateWhereToFilter = function (where) {
@@ -1905,7 +1916,7 @@ var rowHelperImplementation = /** @class */ (function (_super) {
                         if (!!_c.done) return [3 /*break*/, 7];
                         col = _c.value;
                         if (!col.metadata.options.saving) return [3 /*break*/, 6];
-                        return [4 /*yield*/, col.metadata.options.saving(this.instance, e, col)];
+                        return [4 /*yield*/, col.metadata.options.saving(this.instance, col, e)];
                     case 5:
                         _l.sent();
                         _l.label = 6;
@@ -2253,8 +2264,10 @@ var rowHelperImplementation = /** @class */ (function (_super) {
         try {
             for (var _c = tslib_1.__values(this.fields), _d = _c.next(); !_d.done; _d = _c.next()) {
                 var col = _d.value;
-                if (col.valueChanged())
-                    return true;
+                var rel = (0, relationInfoMember_1.getRelationInfo)(col.metadata.options);
+                if (!rel || rel.type == 'reference')
+                    if (col.valueChanged())
+                        return true;
             }
         }
         catch (e_36_1) { e_36 = { error: e_36_1 }; }
@@ -2473,9 +2486,9 @@ var FieldRefImplementation = /** @class */ (function () {
     };
     FieldRefImplementation.prototype.load = function () {
         return tslib_1.__awaiter(this, void 0, void 0, function () {
-            var lu, rel, _a, _b, _c, _d;
-            return tslib_1.__generator(this, function (_e) {
-                switch (_e.label) {
+            var lu, rel, _a, _b, val;
+            return tslib_1.__generator(this, function (_c) {
+                switch (_c.label) {
                     case 0:
                         lu = this.rowBase.lookups.get(this.metadata.key);
                         rel = (0, relationInfoMember_1.getRelationInfo)(this.metadata.options);
@@ -2485,23 +2498,24 @@ var FieldRefImplementation = /** @class */ (function () {
                         _b = this.metadata.key;
                         return [4 /*yield*/, this.helper.repository
                                 .relations(this.container)[this.metadata.key].find()];
-                    case 1: return [2 /*return*/, (_a[_b] = _e.sent())];
-                    case 2:
-                        _c = this.container;
-                        _d = this.metadata.key;
-                        return [4 /*yield*/, this.helper.repository
-                                .relations(this.container)[this.metadata.key].findOne()];
-                    case 3: return [2 /*return*/, (_c[_d] = _e.sent())];
+                    case 1: return [2 /*return*/, (_a[_b] = _c.sent())];
+                    case 2: return [4 /*yield*/, this.helper.repository
+                            .relations(this.container)[this.metadata.key].findOne()];
+                    case 3:
+                        val = _c.sent();
+                        if (val)
+                            this.container[this.metadata.key] = val;
+                        _c.label = 4;
                     case 4: return [3 /*break*/, 9];
                     case 5:
                         if (!lu) return [3 /*break*/, 9];
                         if (!this.valueChanged()) return [3 /*break*/, 7];
                         return [4 /*yield*/, lu.waitLoadOf(this.rawOriginalValue())];
                     case 6:
-                        _e.sent();
-                        _e.label = 7;
+                        _c.sent();
+                        _c.label = 7;
                     case 7: return [4 /*yield*/, lu.waitLoad()];
-                    case 8: return [2 /*return*/, _e.sent()];
+                    case 8: return [2 /*return*/, _c.sent()];
                     case 9: return [2 /*return*/, this.value];
                 }
             });
@@ -2743,7 +2757,7 @@ var columnDefsImpl = /** @class */ (function () {
     };
     columnDefsImpl.prototype.getDbName = function () {
         return tslib_1.__awaiter(this, void 0, void 0, function () {
-            var result;
+            var result, rel, field, fInfo;
             return tslib_1.__generator(this, function (_a) {
                 switch (_a.label) {
                     case 0:
@@ -2762,7 +2776,16 @@ var columnDefsImpl = /** @class */ (function () {
                         if (!result)
                             return [2 /*return*/, this.settings.dbName];
                         return [2 /*return*/, result];
-                    case 4: return [2 /*return*/, this.settings.dbName];
+                    case 4:
+                        rel = (0, relationInfoMember_1.getRelationInfo)(this.settings);
+                        field = (rel === null || rel === void 0 ? void 0 : rel.type) === 'toOne' &&
+                            this.settings.field;
+                        if (field) {
+                            fInfo = this.entityDefs.fields.find(field);
+                            if (fInfo)
+                                return [2 /*return*/, fInfo.getDbName()];
+                        }
+                        return [2 /*return*/, this.settings.dbName];
                     case 5: return [7 /*endfinally*/];
                     case 6: return [2 /*return*/];
                 }

package/src/remult3/remult3.d.ts

@@ -551,7 +551,7 @@ export interface ClassDecoratorContextStub<Class extends new (...args: any) => a
 }
 export type ClassFieldDecorator<entityType, valueType> = (target: any, context: string | ClassFieldDecoratorContextStub<entityType, valueType | undefined>, c?: any) => void;
 /**
- * //p1 - doc this
+ * //p2 - doc this
 remult.apiClient.httpClient = (
   input: RequestInfo | URL,
   init?: RequestInit

package/src/remult3/remult3.js

@@ -1,22 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-//p1 - include relations in the api docs
-//p1 - include Relation options in the api docs
-//p1 - fix { allowApiRead: r => r.user.name === 'superman' } } in allowed for instace docs
-//p1 - fix seeallowed in ref_entity
 //p2 - write doc about controlling updates of rows...
 //p2 - need a way to extract the fields from the relation - for generating relation based sql
-//p1 - omit functions from fields and relations
-//p1 - active record with include thinks that the row was change!
 //p2 - add docs for apply changes
-//p1 - when the include doesn't find the many to one - it deletes the id!!!
 //y2 - discuss a default date formatter
 //[ ] - consider using this in saving etc...
 //p2 - when subscribe is forbidden - the query still runs after the renew process
 //p2 - JSON FIELD LOST JSON STORAGE WHEN SET INPUT VALUE
 //p2 - doc this:
 /**
- * //p1 - doc this
+ * //p2 - doc this
 remult.apiClient.httpClient = (
   input: RequestInfo | URL,
   init?: RequestInit
@@ -41,20 +34,24 @@ remult.apiClient.url='localhost:3007/api
 //p2 - Operator '>' cannot be applied to types 'Number' and 'number'.ts(2365) - change fields to <entityType,number> (now it's Number)
 //p2 - Field(()=>String) - doesn't play nice with strict mode - it prevents people from extending basic types
 //p2 - with remult for remultexpress
-//p1 - Add a with remult promise to Remult!
-//p1 - YONI field didn't appear in intelisence of manyToNe
-//p1 - YONI with relation to one, fields doesn't appear well in the overload options when trying to set driver phone on trempim
-//p1 - YONI why didn't this._.relations.statusChanges.insert({})work?
-//p1 - YONI 'taskid' toOne field parameter did not autocomplete in task app - C:\repos\help-zahal\src\app\events\volunteerInTask.ts 49
+//p2 - Add a with remult promise to Remult!
+//y1 - YONI field didn't appear in intelisence of manyToNe
+//y1 - YONI with relation to one, fields doesn't appear well in the overload options when trying to set driver phone on trempim
+//y1 - YONI why didn't this._.relations.statusChanges.insert({})work?
+//y1 - YONI 'taskid' toOne field parameter did not autocomplete in task app - C:\repos\help-zahal\src\app\events\volunteerInTask.ts 49
+//y1 - YONI omit functions from fields and relations
 //p2 - filterToRaw should get a dbnames of - and we should create a dbnames of that supports an alias
-//p1 - DO NOT BREAK - move fieldref to second parameter, and lifecycle to 3rd consider the breaking signature change of saving on field options - the field becomes the 3rd parameter.
-//p1 - test what happens with a many to one relation where the one no longer exist, in all 3 cases (toOne,reference,toone with fields)
-//p1 - findid by default has cache - it sucks!
 //y2 - livequery for findfirst (@JY)
 //y2 - #239 - (@JY) add a way to get from fieldMetadata back to entity repo (like we have in fieldRef)
 //p2 - constraints (@JY)
 //p2 - Add ability to process query that comes from the api
 //p2 - too much data by mistake
 //p2 - postgres case sensitive
-//y1 - consider http status code for errors
 //p2 - fix sql log to console to make more sense
+//p2 - type metadata.key - to keyof entity - based on cwis input
+//p2 - processError in remult express
+//y1 - should we change relations to be a static const instead of a class (also for fields maybe) what's the point of doing new Relations
+//y1 - add Class type to index of remult - it is used in repo and is important
+//y2 - Backend methods are transactions, it's not intuitive and maybe should be optional / opt in
+//p2 - get backend methods to work when specifying types for date, and entities as poco's
+//p2 - allow find options preprocessor for api calls, to use for authorization