remult 0.23.0-exp.26 → 0.23.0-exp.28

package/esm/remult-mongo.d.ts

@@ -1,4 +1,4 @@
-import type { ClientSession, Db, MongoClient } from 'mongodb';
+import { type ClientSession, type Db, type MongoClient } from 'mongodb';
 import type { DataProvider, EntityDataProvider, EntityFilter, EntityMetadata, Remult } from '.';
 import type { RepositoryOverloads } from './src/remult3/RepositoryImplementation';
 export declare class MongoDataProvider implements DataProvider {

package/esm/remult-mongo.js

@@ -1,3 +1,4 @@
+import { ObjectId, } from 'mongodb';
 import { CompoundIdField, Filter } from '.';
 import { dbNamesOf } from './src/filter/filter-consumer-bridge-to-sql-request';
 import { remult as remultContext } from './src/remult-proxy';
@@ -75,14 +76,14 @@ class MongoEntityDataProvider {
             let val = row[nameProvider.$dbNameOf(col)];
             if (isNull(val))
                 val = null;
-            result[col.key] = col.valueConverter.fromDb(val);
+            result[col.key] = fromDb(col, val);
         }
         return result;
     }
     translateToDb(row, nameProvider) {
         let result = {};
         for (const col of this.entity.fields) {
-            let val = col.valueConverter.toDb(row[col.key]);
+            let val = toDb(col, row[col.key]);
             if (val === null)
                 val = NULL;
             result[nameProvider.$dbNameOf(col)] = val;
@@ -221,7 +222,7 @@ class FilterConsumerBridgeToMongo {
     isIn(col, val) {
         this.result.push(() => ({
             [this.nameProvider.$dbNameOf(col)]: {
-                $in: val.map((x) => col.valueConverter.toDb(x)),
+                $in: val.map((x) => toDb(col, x)),
             },
         }));
     }
@@ -253,7 +254,7 @@ class FilterConsumerBridgeToMongo {
     add(col, val, operator) {
         this.result.push(() => ({
             [this.nameProvider.$dbNameOf(col)]: {
-                [operator]: isNull(val) ? val : col.valueConverter.toDb(val),
+                [operator]: isNull(val) ? val : toDb(col, val),
             },
         }));
     }
@@ -270,3 +271,13 @@ class FilterConsumerBridgeToMongo {
         //   })());
     }
 }
+function toDb(col, val) {
+    if (col.valueConverter.fieldTypeInDb == 'dbid')
+        return val ? new ObjectId(val) : val === null ? null : undefined;
+    return col.valueConverter.toDb(val);
+}
+function fromDb(col, val) {
+    if (col.valueConverter.fieldTypeInDb == 'dbid')
+        return val ? val.toHexString() : val === null ? null : undefined;
+    return col.valueConverter.fromDb(val);
+}

package/esm/server/expressBridge.js

@@ -992,4 +992,4 @@ JobsInQueueEntity = __decorate([
 ], JobsInQueueEntity);
 export { JobsInQueueEntity };
 allEntities.splice(allEntities.indexOf(JobsInQueueEntity), 1);
-//p1 - https://codesandbox.io/p/sandbox/fervent-yalow-66m78n?file=%2Fsrc%2Findex.ts%3A35%2C93
+//p1 - implement dbname based on related field https://codesandbox.io/p/sandbox/fervent-yalow-66m78n?file=%2Fsrc%2Findex.ts%3A35%2C93

package/esm/src/context.js

@@ -289,4 +289,4 @@ class transactionLiveQueryPublisher {
 //p1 - seems that after backend methods relations are loaded for some reason - see trempim - intake doRequest backend method
 //p1 - reconsider the case in tremping where create user id was updated with some user and not the actual user
 //[ ] - when value changes for field with error, clear error - so the user will feel comfortable
-//y1 - require filter argument - and perform validation checks for it - site, id etc.. changelog, status changes etc...,
+//y2 - require filter argument - and perform validation checks for it - site, id etc.. changelog, status changes etc...,

package/esm/src/remult3/Fields.d.ts

@@ -54,26 +54,6 @@ export declare class Relations {
      * ```
      */
     static toOne<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, fieldInMyEntity?: keyof entityType): ClassFieldDecorator<entityType, toEntityType | undefined>;
-    /**
-     * Define a to-one relation between entities, indicating a one-to-one relationship.
-     * This overload allows you to define the relation using options.
-     * If no field or fields are provided, it will automatically create a field in the database
-     * to represent the relation.
-     *
-     * @param toEntityType A function that returns the target entity type.
-     * @param options An object containing options for configuring the to-one relation.
-     *                - field (Optional): The name of the field in the related entity that corresponds to this relation.
-     * @returns A decorator function to apply the virtual to-one relation to an entity field.
-     *
-     * Example usage:
-     * ```
-     * @Relations.toOne(() => Customer, {
-     *   field: "customerId",
-     * })
-     * customer?: Customer;
-     * ```
-     */
-    static toOne<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, fieldInMyEntity?: keyof entityType): ClassFieldDecorator<entityType, toEntityType | undefined>;
     /**
      * Define a to-one relation between entities, indicating a one-to-one relationship.
      * If no field or fields are provided, it will automatically create a field in the database

package/esm/src/remult3/RepositoryImplementation.js

@@ -524,7 +524,11 @@ export class RepositoryImplementation {
         if (options.field) {
             if (rel.type === 'toOne') {
                 requireField(options.field, this.metadata);
-                where.push(otherRepo.metadata.idMetadata.getIdFilter(row[options.field]));
+                const val = row[options.field];
+                if (val === null)
+                    returnNull = true;
+                else
+                    where.push(otherRepo.metadata.idMetadata.getIdFilter(val));
             }
             else {
                 requireField(options.field, otherRepo.metadata);

package/esm/src/remult3/remult3.js

@@ -3,35 +3,17 @@ export {};
 //p1 - include Relation options in the api docs
 //p1 - fix { allowApiRead: r => r.user.name === 'superman' } } in allowed for instace docs
 //p1 - fix seeallowed in ref_entity
-//p1 - write doc about controlling updates of rows...
-//p1 - 'eventId' autocomplete in task app did not work
-//p1 - need a way to extract the fields from the relation - for generating relation based sql
-//p1 - remult object was used outside context
-// ```
-// sqlExpression: async (e) => {
-//   const v = await dbNamesOf(volunteerInTask)
-//   return `select true from ${v} where ${
-//     v.task
-//   }=${await e.getDbName()}.${await e.fields.id.getDbName()} and ${SqlDatabase.filterToRaw<volunteerInTask>(
-//     repo(volunteerInTask),
-//     {
-//       canceled: false,
-//     }
-//   )}`
-// },
-// })
-// ```
-//p2 - consider includeInApi as AllowedForInstance
-//p1 - why didn't this._.relations.statusChanges.insert({})work?
+//p2 - write doc about controlling updates of rows...
+//p2 - need a way to extract the fields from the relation - for generating relation based sql
+//p1 - omit functions from fields and relations
 //p1 - active record with include thinks that the row was change!
-//p1 - add docs for apply changes
-//p1 - update related field with null should respect it's allowed null - otherwise we get a null error for that field.
+//p2 - add docs for apply changes
 //p1 - when the include doesn't find the many to one - it deletes the id!!!
-//y1 - discuss a default date formatter
-//p1 - consider using this in saving etc...
-//p1 - when subscribe is forbidden - the query still runs after the renew process
-//p1 - JSON FIELD LOST JSON STORAGE WHEN SET INPUT VALUE
-//p1 - doc this:
+//y2 - discuss a default date formatter
+//[ ] - consider using this in saving etc...
+//p2 - when subscribe is forbidden - the query still runs after the renew process
+//p2 - JSON FIELD LOST JSON STORAGE WHEN SET INPUT VALUE
+//p2 - doc this:
 /**
  * //p1 - doc this
 remult.apiClient.httpClient = (
@@ -52,6 +34,26 @@ remult.apiClient.url='localhost:3007/api
 
 
  */
-//p1 - with remult promise for remultexpress
-//p1 - 'update tasks set  where id = $1
-//p1 - live query refresh of view on table update
+//p2 - with remult promise for remultexpress
+//p2 - 'update tasks set  where id = $1
+//p2 - live query refresh of view on table update
+//p2 - Operator '>' cannot be applied to types 'Number' and 'number'.ts(2365) - change fields to <entityType,number> (now it's Number)
+//p2 - Field(()=>String) - doesn't play nice with strict mode - it prevents people from extending basic types
+//p2 - with remult for remultexpress
+//p1 - Add a with remult promise to Remult!
+//p1 - YONI field didn't appear in intelisence of manyToNe
+//p1 - YONI with relation to one, fields doesn't appear well in the overload options when trying to set driver phone on trempim
+//p1 - YONI why didn't this._.relations.statusChanges.insert({})work?
+//p1 - YONI 'taskid' toOne field parameter did not autocomplete in task app - C:\repos\help-zahal\src\app\events\volunteerInTask.ts 49
+//p2 - filterToRaw should get a dbnames of - and we should create a dbnames of that supports an alias
+//p1 - DO NOT BREAK - move fieldref to second parameter, and lifecycle to 3rd consider the breaking signature change of saving on field options - the field becomes the 3rd parameter.
+//p1 - test what happens with a many to one relation where the one no longer exist, in all 3 cases (toOne,reference,toone with fields)
+//p1 - findid by default has cache - it sucks!
+//p1 - mongo db relation based on _id did not work - https://codesandbox.io/p/devbox/mong-db-remult-pch8zc?file=%2Fsrc%2Findex.ts%3A53%2C51
+//y2 - livequery for findfirst (@JY)
+//y2 - #239 - (@JY) add a way to get from fieldMetadata back to entity repo (like we have in fieldRef)
+//p2 - constraints (@JY)
+//p2 - Add ability to process query that comes from the api
+//p2 - too much data by mistake
+//p2 - postgres case sensitive
+//p1 - talk about mongo object id

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "remult",
-    "version": "0.23.0-exp.26",
+    "version": "0.23.0-exp.28",
     "description": "A CRUD framework for full-stack TypeScript",
     "types": "index.d.ts",
     "module": "esm/index.js",

package/remult-mongo.d.ts

@@ -1,4 +1,4 @@
-import type { ClientSession, Db, MongoClient } from 'mongodb';
+import { type ClientSession, type Db, type MongoClient } from 'mongodb';
 import type { DataProvider, EntityDataProvider, EntityFilter, EntityMetadata, Remult } from '.';
 import type { RepositoryOverloads } from './src/remult3/RepositoryImplementation';
 export declare class MongoDataProvider implements DataProvider {

package/remult-mongo.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.MongoDataProvider = void 0;
 var tslib_1 = require("tslib");
+var mongodb_1 = require("mongodb");
 var _1 = require(".");
 var filter_consumer_bridge_to_sql_request_1 = require("./src/filter/filter-consumer-bridge-to-sql-request");
 var remult_proxy_1 = require("./src/remult-proxy");
@@ -115,7 +116,7 @@ var MongoEntityDataProvider = /** @class */ (function () {
                 var val = row[nameProvider.$dbNameOf(col)];
                 if (isNull(val))
                     val = null;
-                result[col.key] = col.valueConverter.fromDb(val);
+                result[col.key] = fromDb(col, val);
             }
         }
         catch (e_1_1) { e_1 = { error: e_1_1 }; }
@@ -133,7 +134,7 @@ var MongoEntityDataProvider = /** @class */ (function () {
         try {
             for (var _b = tslib_1.__values(this.entity.fields), _c = _b.next(); !_c.done; _c = _b.next()) {
                 var col = _c.value;
-                var val = col.valueConverter.toDb(row[col.key]);
+                var val = toDb(col, row[col.key]);
                 if (val === null)
                     val = NULL;
                 result[nameProvider.$dbNameOf(col)] = val;
@@ -462,7 +463,7 @@ var FilterConsumerBridgeToMongo = /** @class */ (function () {
             var _a;
             return (_a = {},
                 _a[_this.nameProvider.$dbNameOf(col)] = {
-                    $in: val.map(function (x) { return col.valueConverter.toDb(x); }),
+                    $in: val.map(function (x) { return toDb(col, x); }),
                 },
                 _a);
         });
@@ -498,7 +499,7 @@ var FilterConsumerBridgeToMongo = /** @class */ (function () {
             var _a, _b;
             return (_a = {},
                 _a[_this.nameProvider.$dbNameOf(col)] = (_b = {},
-                    _b[operator] = isNull(val) ? val : col.valueConverter.toDb(val),
+                    _b[operator] = isNull(val) ? val : toDb(col, val),
                     _b),
                 _a);
         });
@@ -517,3 +518,13 @@ var FilterConsumerBridgeToMongo = /** @class */ (function () {
     };
     return FilterConsumerBridgeToMongo;
 }());
+function toDb(col, val) {
+    if (col.valueConverter.fieldTypeInDb == 'dbid')
+        return val ? new mongodb_1.ObjectId(val) : val === null ? null : undefined;
+    return col.valueConverter.toDb(val);
+}
+function fromDb(col, val) {
+    if (col.valueConverter.fieldTypeInDb == 'dbid')
+        return val ? val.toHexString() : val === null ? null : undefined;
+    return col.valueConverter.fromDb(val);
+}

package/server/expressBridge.js

@@ -1406,4 +1406,4 @@ var JobsInQueueEntity = /** @class */ (function (_super) {
 }(IdEntity_1.IdEntity));
 exports.JobsInQueueEntity = JobsInQueueEntity;
 context_1.allEntities.splice(context_1.allEntities.indexOf(JobsInQueueEntity), 1);
-//p1 - https://codesandbox.io/p/sandbox/fervent-yalow-66m78n?file=%2Fsrc%2Findex.ts%3A35%2C93
+//p1 - implement dbname based on related field https://codesandbox.io/p/sandbox/fervent-yalow-66m78n?file=%2Fsrc%2Findex.ts%3A35%2C93

package/src/context.js

@@ -453,4 +453,4 @@ var transactionLiveQueryPublisher = /** @class */ (function () {
 //p1 - seems that after backend methods relations are loaded for some reason - see trempim - intake doRequest backend method
 //p1 - reconsider the case in tremping where create user id was updated with some user and not the actual user
 //[ ] - when value changes for field with error, clear error - so the user will feel comfortable
-//y1 - require filter argument - and perform validation checks for it - site, id etc.. changelog, status changes etc...,
+//y2 - require filter argument - and perform validation checks for it - site, id etc.. changelog, status changes etc...,

package/src/remult3/Fields.d.ts

@@ -54,26 +54,6 @@ export declare class Relations {
      * ```
      */
     static toOne<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, fieldInMyEntity?: keyof entityType): ClassFieldDecorator<entityType, toEntityType | undefined>;
-    /**
-     * Define a to-one relation between entities, indicating a one-to-one relationship.
-     * This overload allows you to define the relation using options.
-     * If no field or fields are provided, it will automatically create a field in the database
-     * to represent the relation.
-     *
-     * @param toEntityType A function that returns the target entity type.
-     * @param options An object containing options for configuring the to-one relation.
-     *                - field (Optional): The name of the field in the related entity that corresponds to this relation.
-     * @returns A decorator function to apply the virtual to-one relation to an entity field.
-     *
-     * Example usage:
-     * ```
-     * @Relations.toOne(() => Customer, {
-     *   field: "customerId",
-     * })
-     * customer?: Customer;
-     * ```
-     */
-    static toOne<entityType, toEntityType>(toEntityType: () => ClassType<toEntityType>, fieldInMyEntity?: keyof entityType): ClassFieldDecorator<entityType, toEntityType | undefined>;
     /**
      * Define a to-one relation between entities, indicating a one-to-one relationship.
      * If no field or fields are provided, it will automatically create a field in the database

package/src/remult3/RepositoryImplementation.js

@@ -877,7 +877,11 @@ var RepositoryImplementation = /** @class */ (function () {
         if (options.field) {
             if (rel.type === 'toOne') {
                 requireField(options.field, this.metadata);
-                where.push(otherRepo.metadata.idMetadata.getIdFilter(row[options.field]));
+                var val = row[options.field];
+                if (val === null)
+                    returnNull = true;
+                else
+                    where.push(otherRepo.metadata.idMetadata.getIdFilter(val));
             }
             else {
                 requireField(options.field, otherRepo.metadata);

package/src/remult3/remult3.js

@@ -4,35 +4,17 @@ Object.defineProperty(exports, "__esModule", { value: true });
 //p1 - include Relation options in the api docs
 //p1 - fix { allowApiRead: r => r.user.name === 'superman' } } in allowed for instace docs
 //p1 - fix seeallowed in ref_entity
-//p1 - write doc about controlling updates of rows...
-//p1 - 'eventId' autocomplete in task app did not work
-//p1 - need a way to extract the fields from the relation - for generating relation based sql
-//p1 - remult object was used outside context
-// ```
-// sqlExpression: async (e) => {
-//   const v = await dbNamesOf(volunteerInTask)
-//   return `select true from ${v} where ${
-//     v.task
-//   }=${await e.getDbName()}.${await e.fields.id.getDbName()} and ${SqlDatabase.filterToRaw<volunteerInTask>(
-//     repo(volunteerInTask),
-//     {
-//       canceled: false,
-//     }
-//   )}`
-// },
-// })
-// ```
-//p2 - consider includeInApi as AllowedForInstance
-//p1 - why didn't this._.relations.statusChanges.insert({})work?
+//p2 - write doc about controlling updates of rows...
+//p2 - need a way to extract the fields from the relation - for generating relation based sql
+//p1 - omit functions from fields and relations
 //p1 - active record with include thinks that the row was change!
-//p1 - add docs for apply changes
-//p1 - update related field with null should respect it's allowed null - otherwise we get a null error for that field.
+//p2 - add docs for apply changes
 //p1 - when the include doesn't find the many to one - it deletes the id!!!
-//y1 - discuss a default date formatter
-//p1 - consider using this in saving etc...
-//p1 - when subscribe is forbidden - the query still runs after the renew process
-//p1 - JSON FIELD LOST JSON STORAGE WHEN SET INPUT VALUE
-//p1 - doc this:
+//y2 - discuss a default date formatter
+//[ ] - consider using this in saving etc...
+//p2 - when subscribe is forbidden - the query still runs after the renew process
+//p2 - JSON FIELD LOST JSON STORAGE WHEN SET INPUT VALUE
+//p2 - doc this:
 /**
  * //p1 - doc this
 remult.apiClient.httpClient = (
@@ -53,6 +35,26 @@ remult.apiClient.url='localhost:3007/api
 
 
  */
-//p1 - with remult promise for remultexpress
-//p1 - 'update tasks set  where id = $1
-//p1 - live query refresh of view on table update
+//p2 - with remult promise for remultexpress
+//p2 - 'update tasks set  where id = $1
+//p2 - live query refresh of view on table update
+//p2 - Operator '>' cannot be applied to types 'Number' and 'number'.ts(2365) - change fields to <entityType,number> (now it's Number)
+//p2 - Field(()=>String) - doesn't play nice with strict mode - it prevents people from extending basic types
+//p2 - with remult for remultexpress
+//p1 - Add a with remult promise to Remult!
+//p1 - YONI field didn't appear in intelisence of manyToNe
+//p1 - YONI with relation to one, fields doesn't appear well in the overload options when trying to set driver phone on trempim
+//p1 - YONI why didn't this._.relations.statusChanges.insert({})work?
+//p1 - YONI 'taskid' toOne field parameter did not autocomplete in task app - C:\repos\help-zahal\src\app\events\volunteerInTask.ts 49
+//p2 - filterToRaw should get a dbnames of - and we should create a dbnames of that supports an alias
+//p1 - DO NOT BREAK - move fieldref to second parameter, and lifecycle to 3rd consider the breaking signature change of saving on field options - the field becomes the 3rd parameter.
+//p1 - test what happens with a many to one relation where the one no longer exist, in all 3 cases (toOne,reference,toone with fields)
+//p1 - findid by default has cache - it sucks!
+//p1 - mongo db relation based on _id did not work - https://codesandbox.io/p/devbox/mong-db-remult-pch8zc?file=%2Fsrc%2Findex.ts%3A53%2C51
+//y2 - livequery for findfirst (@JY)
+//y2 - #239 - (@JY) add a way to get from fieldMetadata back to entity repo (like we have in fieldRef)
+//p2 - constraints (@JY)
+//p2 - Add ability to process query that comes from the api
+//p2 - too much data by mistake
+//p2 - postgres case sensitive
+//p1 - talk about mongo object id