remult 0.23.0-exp.2 → 0.23.0-exp.20

package/README.md

@@ -22,7 +22,6 @@
 	<a href="https://discord.gg/GXHk7ZfuG5" rel="nofollow">
 		<img alt="Join Discord" src="https://badgen.net/discord/online-members/GXHk7ZfuG5?icon=discord&label=Discord"/>
 	</a>
-  </a>
 </div>
 
 <br/>
@@ -101,14 +100,14 @@ npm i remult
 ```ts
 // shared/product.ts
 
-import { Entity, Fields } from "remult"
+import { Entity, Fields } from 'remult'
 
-@Entity("products", {
-  allowApiCrud: true
+@Entity('products', {
+  allowApiCrud: true,
 })
 export class Product {
   @Fields.string()
-  name = ""
+  name = ''
 
   @Fields.number()
   unitPrice = 0
@@ -120,17 +119,17 @@ export class Product {
 ```ts
 // backend/index.ts
 
-import express from "express"
-import { remultExpress } from "remult/remult-express"
-import { Product } from "../shared/product"
+import express from 'express'
+import { remultExpress } from 'remult/remult-express'
+import { Product } from '../shared/product'
 
 const port = 3001
 const app = express()
 
 app.use(
   remultExpress({
-    entities: [Product]
-  })
+    entities: [Product],
+  }),
 )
 
 app.listen(port, () => {
@@ -151,13 +150,13 @@ app.listen(port, () => {
 ```ts
 // frontend/code.ts
 
-import { remult } from "remult"
-import { Product } from "../shared/product"
+import { remult } from 'remult'
+import { Product } from '../shared/product'
 
 async function increasePriceOfTofu(priceIncrease: number) {
   const productsRepo = remult.repo(Product)
 
-  const product = await productsRepo.findFirst({ name: "Tofu" }) // filter is passed through API request all the way to the db
+  const product = await productsRepo.findFirst({ name: 'Tofu' }) // filter is passed through API request all the way to the db
   product.unitPrice += priceIncrease
   productsRepo.save(product) // mutation request updates the db with no boilerplate code
 }
@@ -179,32 +178,32 @@ static async increasePriceOfTofu(priceIncrease: number) {
 ### :ballot_box_with_check: Data validation and constraints - defined once
 
 ```ts
-import { Entity, Fields, Validators } from "remult"
+import { Entity, Fields, Validators } from 'remult'
 
-@Entity("products", {
-  allowApiCrud: true
+@Entity('products', {
+  allowApiCrud: true,
 })
 export class Product {
   @Fields.string({
-    validate: Validators.required
+    validate: Validators.required,
   })
-  name = ""
+  name = ''
 
   @Fields.string<Product>({
     validate: (product) => {
       if (product.description.trim().length < 50) {
-        throw "too short"
+        throw 'too short'
       }
-    }
+    },
   })
-  description = ""
+  description = ''
 
   @Fields.number({
     validate: (_, field) => {
       if (field.value < 0) {
-        field.error = "must not be less than 0" // or: throw "must not be less than 0";
+        field.error = 'must not be less than 0' // or: throw "must not be less than 0";
       }
-    }
+    },
   })
   unitPrice = 0
 }
@@ -233,20 +232,20 @@ try {
 ### :lock: Secure the API with fine-grained authorization
 
 ```ts
-@Entity<Article>("Articles", {
+@Entity<Article>('Articles', {
   allowApiRead: true,
   allowApiInsert: (_, remult) => remult.authenticated(),
-  allowApiUpdate: (article, remult) => article.author.id == remult.user.id
+  allowApiUpdate: (article, remult) => article.author.id == remult.user.id,
 })
 export class Article {
   @Fields.string({ allowApiUpdate: false })
-  slug = ""
+  slug = ''
 
   @Field(() => Profile, { allowApiUpdate: false })
   author!: Profile
 
   @Fields.string()
-  content = ""
+  content = ''
 }
 ```
 

package/esm/graphql.js

@@ -1,3 +1,4 @@
+import { getRelationInfo } from './internals';
 import { Remult, remult } from './index';
 import { DataApi } from './src/data-api';
 const v2ConnectionAndPagination = false;
@@ -447,6 +448,11 @@ Select a dedicated page.`,
             }
             const whereTypeFields = [];
             for (const f of meta.fields) {
+                const ri = getRelationInfo(f.options);
+                // let's not consider toMany relations for now
+                if (ri?.type === 'toMany') {
+                    break;
+                }
                 if (f.options.includeInApi === false)
                     continue;
                 let type = 'String';
@@ -788,7 +794,7 @@ export function translateWhereToRestBody(fields, { where }) {
         return undefined;
     const result = {};
     for (const field of fields) {
-        if (field.includedInApi === false)
+        if (field.options.includeInApi === false)
             continue;
         const condition = where[field.key];
         if (condition) {

package/esm/index.d.ts

@@ -1,8 +1,9 @@
-export { OmitEB, FieldsMetadata, FieldRef, IdFieldRef, FieldsRef, EntityMetadata, EntityOrderBy, EntityFilter, FindOptions, QueryResult, QueryOptions, Repository, FindFirstOptions, ComparisonValueFilter, ValueFilter, IdFilter, ContainsStringValueFilter, EntityRef, SortSegments, Paginator, LiveQuery, LiveQueryChangeInfo, Subscribable, RefSubscriber, RefSubscriberBase, RelationOptions, RelationOptionsBase, ObjectMembersOnly, MembersToInclude, RepositoryRelations, } from './src/remult3/remult3';
+import type { ClassType } from './classType';
+export { OmitEB, FieldsMetadata, FieldRef, IdFieldRef, FieldsRef, EntityMetadata, EntityOrderBy, EntityFilter, FindOptions, QueryResult, QueryOptions, Repository, FindFirstOptions, ComparisonValueFilter, ValueFilter, IdFilter, ContainsStringValueFilter, EntityRef, SortSegments, Paginator, LiveQuery, LiveQueryChangeInfo, Subscribable, RefSubscriber, RefSubscriberBase, RelationOptions, ObjectMembersOnly, MembersToInclude, RepositoryRelations, EntityIdFields, ClassFieldDecorator as MemberDecorator, ClassFieldDecoratorContextStub, } from './src/remult3/remult3';
 export { EntityBase, ControllerBase, FieldType, getFields, ValueListFieldType, getValueList, ValueListFieldOptions, ValueListInfo, CaptionTransformer, } from './src/remult3/RepositoryImplementation';
 export { Entity } from './src/remult3/entity';
 export { getEntityRef } from './src/remult3/getEntityRef';
-export { Field, Fields, StringFieldOptions } from './src/remult3/Fields';
+export { Field, Fields, StringFieldOptions, Relations, } from './src/remult3/Fields';
 export { IdEntity } from './src/remult3/IdEntity';
 export { describeClass } from './src/remult3/DecoratorReplacer';
 export { EntityOptions } from './src/entity';
@@ -21,7 +22,6 @@ export { Controller, BackendMethodOptions, BackendMethod, ProgressListener, } fr
 export { Allowed, Allow, Remult, RemultContext, ApiClient, isBackend, AllowedForInstance, EventDispatcher, EventSource, UserInfo, } from './src/context';
 export { ExternalHttpProvider } from './src/buildRestDataProvider';
 export { SortSegment, Sort } from './src/sort';
-export { OneToMany } from './src/column';
 export { CompoundIdField } from './src/CompoundIdField';
 export { Filter } from './src/filter/filter-interfaces';
 export { UrlBuilder } from './urlBuilder';
@@ -30,3 +30,16 @@ export { ValueConverters } from './src/valueConverters';
 export { remult } from './src/remult-proxy';
 export { SubscriptionServer, LiveQueryStorage, StoredQuery, InMemoryLiveQueryStorage, } from './src/live-query/SubscriptionServer';
 export { SubscriptionListener, SubscriptionClientConnection, SubscriptionClient, SubscriptionChannel, LiveQueryChange, Unsubscribe, } from './src/live-query/SubscriptionChannel';
+/**
+ * A convenient shortcut function to quickly obtain a repository for a specific entity type in Remult.
+ *
+ * @param entity The entity class type for which you want to get a repository.
+ * @returns A repository instance for the specified entity type.
+ *
+ * Example usage:
+ * ```ts
+ * await repo(Task).find()
+ * await repo(Customer).insert()
+ * ```
+ */
+export declare function repo<entityType>(entity: ClassType<entityType>): import("./src/remult3/remult3").Repository<entityType>;

package/esm/index.js

@@ -1,7 +1,7 @@
 export { EntityBase, ControllerBase, FieldType, getFields, ValueListFieldType, getValueList, ValueListInfo, CaptionTransformer, } from './src/remult3/RepositoryImplementation';
 export { Entity } from './src/remult3/entity';
 export { getEntityRef } from './src/remult3/getEntityRef';
-export { Field, Fields } from './src/remult3/Fields';
+export { Field, Fields, Relations, } from './src/remult3/Fields';
 export { IdEntity } from './src/remult3/IdEntity';
 export { describeClass } from './src/remult3/DecoratorReplacer';
 export { RestDataProvider } from './src/data-providers/rest-data-provider'; //V
@@ -15,13 +15,28 @@ export { JsonDataProvider, } from './src/data-providers/json-data-provider'; //V
 export { Controller, BackendMethod, ProgressListener, } from './src/server-action';
 export { Allow, Remult, isBackend, EventSource, } from './src/context';
 export { Sort } from './src/sort';
-export { OneToMany } from './src/column';
 export { CompoundIdField } from './src/CompoundIdField';
 export { Filter } from './src/filter/filter-interfaces';
 export { UrlBuilder } from './urlBuilder';
 export { Validators } from './src/validators';
 export { ValueConverters } from './src/valueConverters';
 export { remult } from './src/remult-proxy';
+import { remult } from './src/remult-proxy';
 //export { getId } from './src/remult3/getId';
 export { InMemoryLiveQueryStorage, } from './src/live-query/SubscriptionServer';
 export { SubscriptionChannel, } from './src/live-query/SubscriptionChannel';
+/**
+ * A convenient shortcut function to quickly obtain a repository for a specific entity type in Remult.
+ *
+ * @param entity The entity class type for which you want to get a repository.
+ * @returns A repository instance for the specified entity type.
+ *
+ * Example usage:
+ * ```ts
+ * await repo(Task).find()
+ * await repo(Customer).insert()
+ * ```
+ */
+export function repo(entity) {
+    return remult.repo(entity);
+}

package/esm/internals.d.ts

@@ -1,6 +1,7 @@
 export { getRelationInfo } from './src/remult3/relationInfoMember';
-export { decorateColumnSettings } from './src/remult3/RepositoryImplementation';
+export { decorateColumnSettings, controllerRefImpl, getControllerRef, } from './src/remult3/RepositoryImplementation';
 export { getEntitySettings } from './src/remult3/getEntityRef';
 export { __updateEntityBasedOnWhere } from './src/filter/filter-interfaces';
 export { actionInfo } from './src/server-action-info';
 export { RelationInfo } from './src/remult3/remult3';
+export { ClassType } from './classType';

package/esm/internals.js

@@ -1,5 +1,5 @@
 export { getRelationInfo } from './src/remult3/relationInfoMember';
-export { decorateColumnSettings } from './src/remult3/RepositoryImplementation';
+export { decorateColumnSettings, controllerRefImpl, getControllerRef, } from './src/remult3/RepositoryImplementation';
 export { getEntitySettings } from './src/remult3/getEntityRef';
 export { __updateEntityBasedOnWhere } from './src/filter/filter-interfaces';
 export { actionInfo } from './src/server-action-info';

package/esm/remult-express.js

@@ -21,6 +21,6 @@ export function remultExpress(options) {
         getRemult: (req) => server.getRemult(req),
         openApiDoc: (options) => server.openApiDoc(options),
         withRemult: (req, res, next) => server.withRemult(req, res, next),
-        // [ ]- add with remult promise
+        // [ ] V1.5 add with remult promise
     });
 }

package/esm/remult-knex/index.js

@@ -7,6 +7,7 @@ import { getRepository, isAutoIncrement, } from '../src/remult3/RepositoryImplem
 import { Sort } from '../src/sort';
 import { ValueConverters } from '../src/valueConverters';
 import { resultCompoundIdFilter as resultCompoundIdFilter } from '../src/resultCompoundIdFilter';
+import { getRepositoryInternals } from '../src/remult3/repository-internals';
 export class KnexDataProvider {
     knex;
     constructor(knex) {
@@ -54,7 +55,7 @@ export class KnexDataProvider {
         const repo = getRepository(entity);
         var b = new FilterConsumerBridgeToKnexRequest(await dbNamesOf(repo.metadata));
         b._addWhere = false;
-        await (await repo.translateWhereToFilter(condition)).__applyToConsumer(b);
+        await (await getRepositoryInternals(repo).translateWhereToFilter(condition)).__applyToConsumer(b);
         let r = await b.resolveWhere();
         return (knex) => r.forEach((y) => y(knex));
     }

package/esm/remult-mongo.js

@@ -3,6 +3,7 @@ import { dbNamesOf } from './src/filter/filter-consumer-bridge-to-sql-request';
 import { remult as remultContext } from './src/remult-proxy';
 import { getRepository } from './src/remult3/RepositoryImplementation';
 import { resultCompoundIdFilter } from './src/resultCompoundIdFilter';
+import { getRepositoryInternals } from './src/remult3/repository-internals';
 export class MongoDataProvider {
     db;
     client;
@@ -50,7 +51,7 @@ export class MongoDataProvider {
         const repo = getRepository(entity);
         var b = new FilterConsumerBridgeToMongo(await dbNamesOf(repo.metadata));
         b._addWhere = false;
-        await (await repo.translateWhereToFilter(condition)).__applyToConsumer(b);
+        await (await getRepositoryInternals(repo).translateWhereToFilter(condition)).__applyToConsumer(b);
         let r = await b.resolveWhere();
         return r;
     }

package/esm/server/JsonEntityFileStorage.js

@@ -8,7 +8,7 @@ export class JsonEntityFileStorage {
         if (fs.existsSync(fn)) {
             return fs.readFileSync(fn).toString();
         }
-        return undefined;
+        return null;
     }
     setItem(entityDbName, json) {
         if (!fs.existsSync(this.folderPath)) {

package/esm/server/expressBridge.js

@@ -116,7 +116,7 @@ export class RemultServerImplementation {
         });
     }
     getEntities() {
-        //TODO - consider using entitiesMetaData - but it may require making it all awaitable
+        //TODO V2 - consider using entitiesMetaData - but it may require making it all awaitable
         var r = new Remult();
         return this.options.entities.map((x) => r.repo(x).metadata);
     }

package/esm/src/CompoundIdField.d.ts

@@ -6,7 +6,7 @@ export declare class CompoundIdField implements FieldMetadata<string> {
     constructor(...columns: FieldMetadata[]);
     apiUpdateAllowed(item: any): boolean;
     displayValue(item: any): string;
-    includedInApi: boolean;
+    includedInApi(item: any): boolean;
     toInput(value: string, inputType?: string): string;
     fromInput(inputValue: string, inputType?: string): string;
     getDbName(): Promise<string>;

package/esm/src/CompoundIdField.js

@@ -9,7 +9,9 @@ export class CompoundIdField {
     displayValue(item) {
         throw new Error('Method not implemented.');
     }
-    includedInApi;
+    includedInApi(item) {
+        throw new Error('Method not implemented.');
+    }
     toInput(value, inputType) {
         throw new Error('Method not implemented.');
     }

package/esm/src/buildRestDataProvider.d.ts

@@ -1,6 +1,5 @@
 import type { RestDataProviderHttpProvider } from './data-interfaces';
-import { RestDataProviderHttpProviderUsingFetch } from './data-providers/rest-data-provider';
-export declare function buildRestDataProvider(provider: ExternalHttpProvider | typeof fetch): RestDataProviderHttpProviderUsingFetch | RestDataProviderHttpProvider;
+export declare function buildRestDataProvider(provider: ExternalHttpProvider | typeof fetch): RestDataProviderHttpProvider;
 export declare function isExternalHttpProvider(item: any): boolean;
 export declare class HttpProviderBridgeToRestDataProviderHttpProvider implements RestDataProviderHttpProvider {
     private http;

package/esm/src/column-interfaces.d.ts

@@ -1,6 +1,6 @@
 import type { ClassType } from '../classType';
-import type { Allowed, AllowedForInstance } from './context';
-import type { EntityMetadata, FieldRef, OmitEB } from './remult3/remult3';
+import type { AllowedForInstance } from './context';
+import type { EntityMetadata, FieldRef, LifecycleEvent, OmitEB } from './remult3/remult3';
 export interface FieldOptions<entityType = any, valueType = any> {
     /** A human readable name for the field. Can be used to achieve a consistent caption for a field throughout the app
      * @example
@@ -11,7 +11,7 @@ export interface FieldOptions<entityType = any, valueType = any> {
     allowNull?: boolean;
     /** If this field data is included in the api.
      * @see [allowed](http://remult.dev/docs/allowed.html)*/
-    includeInApi?: Allowed;
+    includeInApi?: AllowedForInstance<entityType>;
     /** If this field data can be updated in the api.
      * @see [allowed](http://remult.dev/docs/allowed.html)*/
     allowApiUpdate?: AllowedForInstance<entityType>;
@@ -37,7 +37,7 @@ export interface FieldOptions<entityType = any, valueType = any> {
      */
     validate?: ((entity: entityType, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>) | ((entity: entityType, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>)[];
     /** Will be fired before this field is saved to the server/database */
-    saving?: (entity: entityType, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>;
+    saving?: (entity: entityType, e: LifecycleEvent<entityType>, fieldRef: FieldRef<entityType, valueType>) => any | Promise<any>;
     /**  An expression that will determine this fields value on the backend and be provided to the front end*/
     serverExpression?: (entity: entityType) => valueType | Promise<valueType>;
     /** The name of the column in the database that holds the data for this field. If no name is set, the key will be used instead.
@@ -69,8 +69,20 @@ export interface FieldOptions<entityType = any, valueType = any> {
     defaultValue?: (entity: entityType) => valueType | Promise<valueType>;
     /** The html input type for this field */
     inputType?: string;
-    /** Determines if the referenced entity will be loaded immediately or on demand.
-     * @see[Lazy loading of related entities](http://remult.dev/docs/lazy-loading-of-related-entities.html)
+    /**
+     * @deprecated The 'lazy' option is deprecated and will be removed in future versions.
+     * Use 'Relations.toOne' instead.
+     *
+     * Example usage:
+     * ```
+     * // Deprecated usage with 'lazy' option
+     * @Field(() => Customer, { lazy: true })
+     * customer?: Customer;
+     *
+     * // Preferred usage with 'Relations.toOne'
+     * @Relations.toOne(() => Customer)
+     * customer?: Customer;
+     * ```
      */
     lazy?: boolean;
     /** The value type for this field */
@@ -122,7 +134,7 @@ export interface FieldMetadata<valueType = any, entityType = any> {
      */
     displayValue(item: Partial<OmitEB<entityType>>): string;
     apiUpdateAllowed(item?: Partial<OmitEB<entityType>>): boolean;
-    readonly includedInApi: boolean;
+    includedInApi(item?: Partial<OmitEB<entityType>>): boolean;
     /** Adapts the value for usage with html input
      * @example
      * @Fields.dateOnly()

package/esm/src/column.d.ts

@@ -1,32 +1,18 @@
-import type { FindOptions, idType, Repository } from './remult3/remult3';
-import type { RepositoryImplementation } from './remult3/RepositoryImplementation';
+import type { idType, Repository } from './remult3/remult3';
 export declare function makeTitle(name: string): string;
 export declare class LookupColumn<T> {
     private repository;
-    private isManyToOneRelation;
+    private isReferenceRelation;
     toJson(): any;
     setId(val: any): void;
     waitLoadOf(id: any): Promise<T>;
     get(id: any): any;
-    storedItem: {
+    storedItem?: {
         item: T;
     };
     set(item: T): void;
     id: idType<T>;
-    constructor(repository: RepositoryImplementation<T>, isManyToOneRelation: any);
+    constructor(repository: Repository<T>, isReferenceRelation: any);
     get item(): T;
     waitLoad(): Promise<T>;
 }
-export declare class OneToMany<T> {
-    private provider;
-    private settings?;
-    constructor(provider: Repository<T>, settings?: {
-        create?: (newItem: T) => void;
-    } & FindOptions<T>);
-    private _items;
-    private _currentPromise;
-    get lazyItems(): T[];
-    load(): Promise<T[]>;
-    private find;
-    create(item?: Partial<T>): T;
-}

package/esm/src/column.js

@@ -1,6 +1,5 @@
-import { assign } from '../assign';
-import { __updateEntityBasedOnWhere } from './remult3/__updateEntityBasedOnWhere';
 import { getEntityRef } from './remult3/getEntityRef';
+import { getRepositoryInternals } from './remult3/repository-internals';
 export function makeTitle(name) {
     // insert a space before all caps
     return (name
@@ -12,7 +11,7 @@ export function makeTitle(name) {
 }
 export class LookupColumn {
     repository;
-    isManyToOneRelation;
+    isReferenceRelation;
     toJson() {
         if (!this.storedItem)
             return undefined;
@@ -28,12 +27,14 @@ export class LookupColumn {
     waitLoadOf(id) {
         if (id === undefined || id === null)
             return null;
-        return this.repository.getCachedByIdAsync(id, false);
+        return getRepositoryInternals(this.repository).getCachedByIdAsync(id, false);
     }
     get(id) {
         if (id === undefined || id === null)
             return null;
-        return this.repository.getCachedById(id, this.isManyToOneRelation);
+        if (this.isReferenceRelation && !this.storedItem)
+            return undefined;
+        return getRepositoryInternals(this.repository).getCachedById(id, this.isReferenceRelation);
     }
     storedItem;
     set(item) {
@@ -43,8 +44,8 @@ export class LookupColumn {
                 this.id = item;
             else {
                 let eo = getEntityRef(item, false);
-                if (eo) {
-                    this.repository.addToCache(item);
+                if (eo && !this.isReferenceRelation) {
+                    getRepositoryInternals(this.repository).addToCache(item);
                     this.id = eo.getId();
                 }
                 else {
@@ -61,9 +62,9 @@ export class LookupColumn {
         }
     }
     id;
-    constructor(repository, isManyToOneRelation) {
+    constructor(repository, isReferenceRelation) {
         this.repository = repository;
-        this.isManyToOneRelation = isManyToOneRelation;
+        this.isReferenceRelation = isReferenceRelation;
     }
     get item() {
         if (this.storedItem)
@@ -74,38 +75,3 @@ export class LookupColumn {
         return this.waitLoadOf(this.id);
     }
 }
-9000;
-export class OneToMany {
-    provider;
-    settings;
-    constructor(provider, settings) {
-        this.provider = provider;
-        this.settings = settings;
-    }
-    _items;
-    _currentPromise;
-    get lazyItems() {
-        this.load();
-        return this._items;
-    }
-    async load() {
-        if (this._currentPromise != null)
-            return this._currentPromise;
-        if (this._items === undefined)
-            this._items = [];
-        return (this._currentPromise = this.find().then((x) => {
-            this._items.splice(0);
-            this._items.push(...x);
-            return this._items;
-        }));
-    }
-    async find() {
-        return this.provider.find(this.settings);
-    }
-    create(item) {
-        let r = this.provider.create();
-        __updateEntityBasedOnWhere(this.provider.metadata, this.settings.where, r);
-        assign(r, item);
-        return r;
-    }
-}

package/esm/src/context.d.ts

@@ -15,7 +15,7 @@ export declare class RemultAsyncLocalStorage {
 }
 type myAsyncLocalStorage<T> = {
     run<R>(store: T, callback: (...args: any[]) => R, ...args: any[]): R;
-    getStore(): T;
+    getStore(): T | undefined;
 };
 export declare function isBackend(): boolean;
 export declare class Remult {

package/esm/src/context.js

@@ -90,7 +90,7 @@ export class Remult {
         if (typeof roles === 'boolean')
             return roles;
         if (typeof roles === 'string')
-            if (this.user?.roles?.indexOf(roles.toString()) >= 0)
+            if (this.user?.roles?.includes(roles.toString()))
                 return true;
         return false;
     }
@@ -112,6 +112,7 @@ export class Remult {
         }
         else
             return this.isAllowed(allowed);
+        return undefined;
     }
     /** The current data provider */
     dataProvider = new RestDataProvider(() => this.apiClient);
@@ -285,3 +286,6 @@ class transactionLiveQueryPublisher {
         }
     }
 }
+//p1 - seems that after backend methods relations are loaded for some reason - see trempim - intake doRequest backend method
+//p1 - reconsider the case in tremping where create user id was updated with some user and not the actual user
+//[ ] - when value changes for field with error, clear error - so the user will feel comfortable

package/esm/src/data-interfaces.js

@@ -1,7 +1,5 @@
 import { Sort } from './sort';
 export function extractSort(sort) {
-    if (sort instanceof Sort)
-        return sort;
     if (sort instanceof Array) {
         let r = new Sort();
         sort.forEach((i) => {
@@ -9,4 +7,5 @@ export function extractSort(sort) {
         });
         return r;
     }
+    return sort;
 }

package/esm/src/data-providers/array-entity-data-provider.d.ts

@@ -4,8 +4,8 @@ import { Filter } from '../filter/filter-interfaces';
 import type { EntityFilter, EntityMetadata } from '../remult3/remult3';
 export declare class ArrayEntityDataProvider implements EntityDataProvider {
     private entity;
-    private rows?;
     static rawFilter(filter: CustomArrayFilter): EntityFilter<any>;
+    private rows;
     constructor(entity: EntityMetadata, rows?: any[]);
     __names: EntityDbNamesBase;
     init(): Promise<EntityDbNamesBase>;

package/esm/src/data-providers/array-entity-data-provider.js

@@ -3,7 +3,6 @@ import { dbNamesOf, isDbReadonly, } from '../filter/filter-consumer-bridge-to-sq
 import { Filter, customDatabaseFilterToken } from '../filter/filter-interfaces';
 export class ArrayEntityDataProvider {
     entity;
-    rows;
     static rawFilter(filter) {
         return {
             [customDatabaseFilterToken]: {
@@ -11,13 +10,13 @@ export class ArrayEntityDataProvider {
             },
         };
     }
+    rows;
     constructor(entity, rows) {
         this.entity = entity;
-        this.rows = rows;
-        if (!rows)
-            rows = [];
-        else {
-        }
+        if (rows === undefined)
+            this.rows = [];
+        else
+            this.rows = rows;
     }
     __names;
     async init() {
@@ -88,6 +87,7 @@ export class ArrayEntityDataProvider {
             return rows.map((i) => {
                 return this.translateFromJson(i, dbNames);
             });
+        return [];
     }
     translateFromJson(row, dbNames) {
         let result = {};

package/esm/src/data-providers/sql-database.js

@@ -5,6 +5,7 @@ import { remult as defaultRemult } from '../remult-proxy';
 import { getRepository } from '../remult3/RepositoryImplementation';
 import { Sort } from '../sort';
 import { ValueConverters } from '../valueConverters';
+import { getRepositoryInternals } from '../remult3/repository-internals';
 // @dynamic
 export class SqlDatabase {
     sql;
@@ -89,7 +90,7 @@ export class SqlDatabase {
         const r = getRepository(repo);
         var b = new FilterConsumerBridgeToSqlRequest(sqlCommand, await dbNamesOf(r.metadata));
         b._addWhere = false;
-        await (await r.translateWhereToFilter(condition)).__applyToConsumer(b);
+        await (await getRepositoryInternals(r).translateWhereToFilter(condition)).__applyToConsumer(b);
         return await b.resolveWhere();
     }
     /**