remult 0.19.2 → 0.19.3

package/esm/src/remult3/RepositoryImplementation.js

@@ -1711,10 +1711,7 @@ export function decorateColumnSettings(settings, remult) {
     if (settings.valueType == String) {
         let x = settings;
         if (!settings.valueConverter)
-            x.valueConverter = {
-                toJson: x => x,
-                fromJson: x => x
-            };
+            x.valueConverter = ValueConverters.String;
     }
     if (settings.valueType == Number) {
         let x = settings;

package/esm/src/shared-tests/db-tests.db-tests.js

@@ -25,6 +25,14 @@ testAll("what", async ({ remult, createEntity }) => {
     await (await createEntity(stam)).create({ id: 1, title: 'noam' }).save();
     expect(await remult.repo(stam).count()).toBe(1);
 }, false);
+testAll("data types", async ({ remult, createEntity }) => {
+    let r = await (await createEntity(stam)).create({
+        id: 1,
+        //@ts-ignore
+        title: 42
+    }).save();
+    expect(r.title).toEqual("42");
+}, false);
 testAll("filter works on all db", async ({ createEntity }) => {
     let s = await entityWithValidations.create4RowsInDp(createEntity);
     expect((await s.find({ where: { myId: [1, 3] } })).length).toBe(2);

package/esm/src/valueConverters.d.ts

@@ -5,6 +5,7 @@ export declare class ValueConverters {
     static readonly DateOnlyString: ValueConverter<Date>;
     static readonly Boolean: ValueConverter<Boolean>;
     static readonly Number: ValueConverter<number>;
+    static readonly String: ValueConverter<String>;
     static readonly Integer: ValueConverter<number>;
     static readonly Default: Required<ValueConverter<any>>;
     static readonly JsonString: ValueConverter<any>;

package/esm/src/valueConverters.js

@@ -141,6 +141,14 @@ ValueConverters.Number = {
     },
     inputType: InputTypes.number
 };
+ValueConverters.String = {
+    fromDb: enforceString,
+    toDb: enforceString,
+    fromJson: enforceString,
+    toJson: enforceString,
+    fromInput: enforceString,
+    toInput: enforceString,
+};
 ValueConverters.Integer = {
     ...ValueConverters.Number,
     toJson: value => {
@@ -180,3 +188,10 @@ ValueConverters.JsonValue = {
     toInput: x => ValueConverters.JsonString.toJson(x),
     fieldTypeInDb: 'json'
 };
+function enforceString(value) {
+    if (value === null || value === undefined)
+        return value;
+    if (typeof (value) !== "string")
+        return value.toString();
+    return value;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "remult",
-    "version": "0.19.2",
+    "version": "0.19.3",
     "description": "A CRUD framework for full-stack TypeScript",
     "main": "index.js",
     "types": "index.d.ts",

package/src/remult3/RepositoryImplementation.js

@@ -2896,10 +2896,7 @@ function decorateColumnSettings(settings, remult) {
     if (settings.valueType == String) {
         var x = settings;
         if (!settings.valueConverter)
-            x.valueConverter = {
-                toJson: function (x) { return x; },
-                fromJson: function (x) { return x; }
-            };
+            x.valueConverter = valueConverters_1.ValueConverters.String;
     }
     if (settings.valueType == Number) {
         var x = settings;

package/src/shared-tests/db-tests.db-tests.js

@@ -43,6 +43,26 @@ db_tests_setup_1.testAll("what", function (_a) {
         });
     });
 }, false);
+db_tests_setup_1.testAll("data types", function (_a) {
+    var remult = _a.remult, createEntity = _a.createEntity;
+    return tslib_1.__awaiter(void 0, void 0, void 0, function () {
+        var r;
+        return tslib_1.__generator(this, function (_b) {
+            switch (_b.label) {
+                case 0: return [4 /*yield*/, createEntity(stam)];
+                case 1: return [4 /*yield*/, (_b.sent()).create({
+                        id: 1,
+                        //@ts-ignore
+                        title: 42
+                    }).save()];
+                case 2:
+                    r = _b.sent();
+                    expect(r.title).toEqual("42");
+                    return [2 /*return*/];
+            }
+        });
+    });
+}, false);
 db_tests_setup_1.testAll("filter works on all db", function (_a) {
     var createEntity = _a.createEntity;
     return tslib_1.__awaiter(void 0, void 0, void 0, function () {

package/src/valueConverters.d.ts

@@ -5,6 +5,7 @@ export declare class ValueConverters {
     static readonly DateOnlyString: ValueConverter<Date>;
     static readonly Boolean: ValueConverter<Boolean>;
     static readonly Number: ValueConverter<number>;
+    static readonly String: ValueConverter<String>;
     static readonly Integer: ValueConverter<number>;
     static readonly Default: Required<ValueConverter<any>>;
     static readonly JsonString: ValueConverter<any>;

package/src/valueConverters.js

@@ -142,6 +142,14 @@ var ValueConverters = /** @class */ (function () {
         },
         inputType: inputTypes_1.InputTypes.number
     };
+    ValueConverters.String = {
+        fromDb: enforceString,
+        toDb: enforceString,
+        fromJson: enforceString,
+        toJson: enforceString,
+        fromInput: enforceString,
+        toInput: enforceString,
+    };
     ValueConverters.Integer = tslib_1.__assign(tslib_1.__assign({}, ValueConverters.Number), { toJson: function (value) {
             var val = ValueConverters.Number.toDb(value);
             if (!val)
@@ -179,3 +187,10 @@ var ValueConverters = /** @class */ (function () {
     return ValueConverters;
 }());
 exports.ValueConverters = ValueConverters;
+function enforceString(value) {
+    if (value === null || value === undefined)
+        return value;
+    if (typeof (value) !== "string")
+        return value.toString();
+    return value;
+}