remove-markdown 0.5.5 → 0.6.0

package/README.md

@@ -1,3 +1,5 @@
+- ![default workflow](https://github.com/stiang/remove-markdown/actions/workflows/default.yaml/badge.svg)
+
 ## What is it?
 **remove-markdown** is a node.js module that will remove (strip) Markdown formatting from text.
 *Markdown formatting* means pretty much anything that doesn’t look like regular text, like square brackets, asterisks etc.

package/index.js

@@ -12,7 +12,7 @@ module.exports = function(md, options) {
   var output = md || '';
 
   // Remove horizontal rules (stripListHeaders conflict with this rule, which is why it has been moved to the top)
-  output = output.replace(/^(-\s*?|\*\s*?|_\s*?){3,}\s*/gm, '');
+  output = output.replace(/^ {0,3}((?:-[\t ]*){3,}|(?:_[ \t]*){3,}|(?:\*[ \t]*){3,})(?:\n+|$)/gm, '');
 
   try {
     if (options.stripListLeaders) {
@@ -36,22 +36,15 @@ module.exports = function(md, options) {
       // Remove abbreviations
       output = output.replace(/\*\[.*\]:.*\n/, '');
     }
-    output = output
-    // Remove HTML tags
-      .replace(/<[^>]*>/g, '')
-
-    var htmlReplaceRegex = new RegExp('<[^>]*>', 'g');
-    if (options.htmlTagsToSkip.length > 0) {
-      // Using negative lookahead. Eg. (?!sup|sub) will not match 'sup' and 'sub' tags.
-      var joinedHtmlTagsToSkip = '(?!' + options.htmlTagsToSkip.join("|") + ')';
-
-      // Adding the lookahead literal with the default regex for html. Eg./<(?!sup|sub)[^>]*>/ig
+    
+    let htmlReplaceRegex = /<[^>]*>/g
+    if (options.htmlTagsToSkip && options.htmlTagsToSkip.length > 0) {
+      // Create a regex that matches tags not in htmlTagsToSkip
+      const joinedHtmlTagsToSkip = options.htmlTagsToSkip.join('|')
       htmlReplaceRegex = new RegExp(
-          '<' +
-          joinedHtmlTagsToSkip +
-          '[^>]*>', 
-          'ig'
-      );
+        `<(?!\/?(${joinedHtmlTagsToSkip})(?=>|\s[^>]*>))[^>]*>`,
+        'g',
+      )
     }
 
     output = output

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "remove-markdown",
-  "version": "0.5.5",
+  "version": "0.6.0",
   "description": "Remove Markdown formatting from text",
   "main": "index.js",
   "scripts": {

package/test/remove-markdown.js

@@ -87,6 +87,12 @@ describe('remove Markdown', function () {
       expect(removeMd(string)).to.equal(expected);
     });
 
+    it('should not mistake a horizontal rule when symbols are mixed ', function () {
+      const string = 'Some text on a line\n\n--*\n\nA line below';
+      const expected = 'Some text on a line\n\n--*\n\nA line below';
+      expect(removeMd(string)).to.equal(expected);
+    });
+
     it('should remove horizontal rules', function () {
       const string = 'Some text on a line\n\n---\n\nA line below';
       const expected = 'Some text on a line\n\nA line below';
@@ -161,6 +167,12 @@ describe('remove Markdown', function () {
       expect(removeMd(string)).to.equal(expected);
     });
 
+    it('should strip list items with bold word in the beginning', function () {
+      const string = 'Some text on a line\n\n- **A** list Item\n- **Another** list item';
+      const expected = 'Some text on a line\n\nA list Item\nAnother list item';
+      expect(removeMd(string)).to.equal(expected);
+    });
+
     it('should handle paragraphs with markdown', function () {
       const paragraph = '\n## This is a heading ##\n\nThis is a paragraph with [a link](http://www.disney.com/).\n\n### This is another heading\n\nIn `Getting Started` we set up `something` foo.\n\n  * Some list\n  * With items\n    * Even indented';
       const expected = '\nThis is a heading\n\nThis is a paragraph with a link.\n\nThis is another heading\n\nIn Getting Started we set up something foo.\n\n  Some list\n  With items\n    Even indented';
@@ -195,5 +207,16 @@ describe('remove Markdown', function () {
       const expected = 'Heading in italic';
       expect(removeMd(string)).to.equal(expected);
     });
+
+    it('should skip specified HTML tags when htmlTagsToSkip option is provided', () => {
+      const markdown =
+        '<div>HTML content <sub>Superscript</sub> <span>span text</span></div>'
+      const result = removeMd(markdown, {htmlTagsToSkip: ['sub']})
+      expect(result).to.equal('HTML content <sub>Superscript</sub> span text')
+      const result2 = removeMd(markdown, {htmlTagsToSkip: ['sub', 'span']})
+      expect(result2).to.equal(
+        'HTML content <sub>Superscript</sub> <span>span text</span>',
+      )
+    })
   });
 });