remotion 4.0.295 → 4.0.296

package/dist/cjs/Artifact.d.ts

@@ -1,8 +1,10 @@
 import type React from 'react';
+import type { DownloadBehavior } from './download-behavior';
 declare const ArtifactThumbnail: unique symbol;
 export declare const Artifact: React.FC<{
     readonly filename: string;
     readonly content: string | Uint8Array | typeof ArtifactThumbnail;
+    readonly downloadBehavior?: DownloadBehavior | null;
 }> & {
     Thumbnail: typeof ArtifactThumbnail;
 };

package/dist/cjs/Artifact.js

@@ -6,7 +6,7 @@ const RenderAssetManager_1 = require("./RenderAssetManager");
 const get_remotion_environment_1 = require("./get-remotion-environment");
 const use_current_frame_1 = require("./use-current-frame");
 const ArtifactThumbnail = Symbol('Thumbnail');
-const Artifact = ({ filename, content }) => {
+const Artifact = ({ filename, content, downloadBehavior }) => {
     const { registerRenderAsset, unregisterRenderAsset } = (0, react_1.useContext)(RenderAssetManager_1.RenderAssetManager);
     const [env] = (0, react_1.useState)(() => (0, get_remotion_environment_1.getRemotionEnvironment)());
     const frame = (0, use_current_frame_1.useCurrentFrame)();
@@ -25,6 +25,7 @@ const Artifact = ({ filename, content }) => {
                 filename,
                 frame,
                 contentType: 'binary',
+                downloadBehavior: downloadBehavior !== null && downloadBehavior !== void 0 ? downloadBehavior : null,
             });
         }
         else if (content === ArtifactThumbnail) {
@@ -34,6 +35,7 @@ const Artifact = ({ filename, content }) => {
                 filename,
                 frame,
                 contentType: 'thumbnail',
+                downloadBehavior: downloadBehavior !== null && downloadBehavior !== void 0 ? downloadBehavior : null,
             });
         }
         else {
@@ -44,6 +46,7 @@ const Artifact = ({ filename, content }) => {
                 filename,
                 frame,
                 contentType: 'text',
+                downloadBehavior: downloadBehavior !== null && downloadBehavior !== void 0 ? downloadBehavior : null,
             });
         }
         return () => {
@@ -57,6 +60,7 @@ const Artifact = ({ filename, content }) => {
         id,
         registerRenderAsset,
         unregisterRenderAsset,
+        downloadBehavior,
     ]);
     return null;
 };

package/dist/cjs/CompositionManager.d.ts

@@ -3,6 +3,7 @@ import React from 'react';
 import type { AnyZodObject } from 'zod';
 import type { CalculateMetadataFunction } from './Composition.js';
 import type { BaseMetadata } from './CompositionManagerContext.js';
+import type { DownloadBehavior } from './download-behavior.js';
 import type { InferProps, PropsIfHasProps } from './props-if-has-props.js';
 export type TComposition<Schema extends AnyZodObject, Props extends Record<string, unknown>> = {
     width: number | undefined;
@@ -81,6 +82,7 @@ export type ArtifactAsset = {
     id: string;
     filename: string;
     frame: number;
+    downloadBehavior: DownloadBehavior | null;
 } & DiscriminatedArtifact;
 export type TRenderAsset = AudioOrVideoAsset | ArtifactAsset;
 export declare const compositionsRef: React.RefObject<{

package/dist/cjs/buffer-until-first-frame.js

@@ -8,6 +8,11 @@ const isSafariWebkit = () => {
     const isSafari = /^((?!chrome|android).)*safari/i.test(window.navigator.userAgent);
     return isSafari;
 };
+const isDesktopChrome = () => {
+    const isChrome = /chrome/i.test(window.navigator.userAgent);
+    const isDesktop = !/mobile/i.test(window.navigator.userAgent);
+    return isChrome && isDesktop;
+};
 const useBufferUntilFirstFrame = ({ mediaRef, mediaType, onVariableFpsVideoDetected, pauseWhenBuffering, logLevel, mountTime, }) => {
     const bufferingRef = (0, react_1.useRef)(false);
     const { delayPlayback } = (0, use_buffer_state_1.useBufferState)();
@@ -23,10 +28,16 @@ const useBufferUntilFirstFrame = ({ mediaRef, mediaType, onVariableFpsVideoDetec
         if (!current) {
             return;
         }
-        if (current.readyState >= current.HAVE_ENOUGH_DATA && !isSafariWebkit()) {
+        if (current.readyState >= current.HAVE_ENOUGH_DATA &&
+            !isSafariWebkit() &&
+            // In Desktop Chrome, the video might switch to playing
+            // but does not play due to Bluetooth headphones
+            // Enabling back this flag for Chrome without extensive testing
+            // because we never had big problems on Chrome
+            !isDesktopChrome()) {
             (0, playback_logging_1.playbackLogging)({
                 logLevel,
-                message: `Not using buffer until first frame, because readyState is ${current.readyState} and is not Safari`,
+                message: `Not using buffer until first frame, because readyState is ${current.readyState} and is not Safari or Desktop Chrome`,
                 mountTime,
                 tag: 'buffer',
             });

package/dist/cjs/download-behavior.d.ts

@@ -0,0 +1,6 @@
+export type DownloadBehavior = {
+    type: 'play-in-browser';
+} | {
+    type: 'download';
+    fileName: string | null;
+};

package/dist/cjs/download-behavior.js

@@ -0,0 +1,2 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });

package/dist/cjs/index.d.ts

@@ -83,6 +83,7 @@ export { CalculateMetadataFunction, Composition, CompositionProps, CompProps, St
 export type { CanvasContent } from './CompositionManagerContext.js';
 export { getInputProps } from './config/input-props.js';
 export { continueRender, delayRender } from './delay-render.js';
+export { DownloadBehavior } from './download-behavior.js';
 export * from './easing.js';
 export * from './Folder.js';
 export * from './freeze.js';

package/dist/cjs/no-react.d.ts

@@ -1,4 +1,5 @@
 export type { ArtifactAsset, AudioOrVideoAsset, TRenderAsset, } from './CompositionManager';
+export { DownloadBehavior } from './download-behavior';
 export { EasingFunction, ExtrapolateType, interpolate, InterpolateOptions, } from './interpolate';
 export { random, RandomSeed } from './random.js';
 export type { VideoConfig } from './video-config';

package/dist/cjs/use-media-buffering.d.ts

@@ -1,9 +1,10 @@
 import type React from 'react';
 import type { LogLevel } from './log';
-export declare const useMediaBuffering: ({ element, shouldBuffer, isPremounting, logLevel, mountTime, }: {
+export declare const useMediaBuffering: ({ element, shouldBuffer, isPremounting, logLevel, mountTime, src, }: {
     element: React.RefObject<HTMLVideoElement | HTMLAudioElement | null>;
     shouldBuffer: boolean;
     isPremounting: boolean;
     logLevel: LogLevel;
     mountTime: number;
+    src: string | null;
 }) => boolean;

package/dist/cjs/use-media-buffering.js

@@ -4,7 +4,7 @@ exports.useMediaBuffering = void 0;
 const react_1 = require("react");
 const playback_logging_1 = require("./playback-logging");
 const use_buffer_state_1 = require("./use-buffer-state");
-const useMediaBuffering = ({ element, shouldBuffer, isPremounting, logLevel, mountTime, }) => {
+const useMediaBuffering = ({ element, shouldBuffer, isPremounting, logLevel, mountTime, src, }) => {
     const buffer = (0, use_buffer_state_1.useBufferState)();
     const [isBuffering, setIsBuffering] = (0, react_1.useState)(false);
     // Buffer state based on `waiting` and `canplay`
@@ -114,7 +114,7 @@ const useMediaBuffering = ({ element, shouldBuffer, isPremounting, logLevel, mou
                 if (!navigator.userAgent.includes('Firefox/')) {
                     (0, playback_logging_1.playbackLogging)({
                         logLevel,
-                        message: `Calling .load() on ${current.src} because readyState is ${current.readyState} and it is not Firefox.`,
+                        message: `Calling .load() on ${src} because readyState is ${current.readyState} and it is not Firefox.`,
                         tag: 'load',
                         mountTime,
                     });
@@ -135,7 +135,11 @@ const useMediaBuffering = ({ element, shouldBuffer, isPremounting, logLevel, mou
         return () => {
             cleanup('element was unmounted or prop changed');
         };
-    }, [buffer, element, isPremounting, logLevel, shouldBuffer, mountTime]);
+        // dependencies array:
+        // `src` should be in it, because if changing the source and pausing at the same time,
+        // it gives the chance to load the new source.
+        // https://github.com/remotion-dev/remotion/issues/5218
+    }, [buffer, src, element, isPremounting, logLevel, shouldBuffer, mountTime]);
     return isBuffering;
 };
 exports.useMediaBuffering = useMediaBuffering;

package/dist/cjs/use-media-playback.js

@@ -59,6 +59,7 @@ const useMediaPlayback = ({ mediaRef, src, mediaType, playbackRate: localPlaybac
         isPremounting,
         logLevel,
         mountTime,
+        src: src !== null && src !== void 0 ? src : null,
     });
     const { bufferUntilFirstFrame, isBuffering } = (0, buffer_until_first_frame_js_1.useBufferUntilFirstFrame)({
         mediaRef,

package/dist/cjs/version.d.ts

@@ -3,4 +3,4 @@
  * @see [Documentation](https://remotion.dev/docs/version)
  * @returns {string} The current version of the remotion package
  */
-export declare const VERSION = "4.0.295";
+export declare const VERSION = "4.0.296";

package/dist/cjs/version.js

@@ -7,4 +7,4 @@ exports.VERSION = void 0;
  * @see [Documentation](https://remotion.dev/docs/version)
  * @returns {string} The current version of the remotion package
  */
-exports.VERSION = '4.0.295';
+exports.VERSION = '4.0.296';

package/dist/esm/index.mjs

@@ -104,7 +104,7 @@ function truthy(value) {
 }
 
 // src/version.ts
-var VERSION = "4.0.295";
+var VERSION = "4.0.296";
 
 // src/multiple-versions-warning.ts
 var checkMultipleRemotionVersions = () => {
@@ -2072,7 +2072,7 @@ var RenderAssetManagerProvider = ({ children }) => {
 
 // src/Artifact.tsx
 var ArtifactThumbnail = Symbol("Thumbnail");
-var Artifact = ({ filename, content }) => {
+var Artifact = ({ filename, content, downloadBehavior }) => {
   const { registerRenderAsset, unregisterRenderAsset } = useContext11(RenderAssetManager);
   const [env] = useState7(() => getRemotionEnvironment());
   const frame = useCurrentFrame();
@@ -2090,7 +2090,8 @@ var Artifact = ({ filename, content }) => {
         content: btoa(new TextDecoder("utf8").decode(content)),
         filename,
         frame,
-        contentType: "binary"
+        contentType: "binary",
+        downloadBehavior: downloadBehavior ?? null
       });
     } else if (content === ArtifactThumbnail) {
       registerRenderAsset({
@@ -2098,7 +2099,8 @@ var Artifact = ({ filename, content }) => {
         id,
         filename,
         frame,
-        contentType: "thumbnail"
+        contentType: "thumbnail",
+        downloadBehavior: downloadBehavior ?? null
       });
     } else {
       registerRenderAsset({
@@ -2107,7 +2109,8 @@ var Artifact = ({ filename, content }) => {
         content,
         filename,
         frame,
-        contentType: "text"
+        contentType: "text",
+        downloadBehavior: downloadBehavior ?? null
       });
     }
     return () => {
@@ -2120,7 +2123,8 @@ var Artifact = ({ filename, content }) => {
     frame,
     id,
     registerRenderAsset,
-    unregisterRenderAsset
+    unregisterRenderAsset,
+    downloadBehavior
   ]);
   return null;
 };
@@ -3052,6 +3056,11 @@ var isSafariWebkit = () => {
   const isSafari = /^((?!chrome|android).)*safari/i.test(window.navigator.userAgent);
   return isSafari;
 };
+var isDesktopChrome = () => {
+  const isChrome = /chrome/i.test(window.navigator.userAgent);
+  const isDesktop = !/mobile/i.test(window.navigator.userAgent);
+  return isChrome && isDesktop;
+};
 var useBufferUntilFirstFrame = ({
   mediaRef,
   mediaType,
@@ -3073,10 +3082,10 @@ var useBufferUntilFirstFrame = ({
     if (!current) {
       return;
     }
-    if (current.readyState >= current.HAVE_ENOUGH_DATA && !isSafariWebkit()) {
+    if (current.readyState >= current.HAVE_ENOUGH_DATA && !isSafariWebkit() && !isDesktopChrome()) {
       playbackLogging({
         logLevel,
-        message: `Not using buffer until first frame, because readyState is ${current.readyState} and is not Safari`,
+        message: `Not using buffer until first frame, because readyState is ${current.readyState} and is not Safari or Desktop Chrome`,
         mountTime,
         tag: "buffer"
       });
@@ -3268,7 +3277,8 @@ var useMediaBuffering = ({
   shouldBuffer,
   isPremounting,
   logLevel,
-  mountTime
+  mountTime,
+  src
 }) => {
   const buffer = useBufferState();
   const [isBuffering, setIsBuffering] = useState11(false);
@@ -3362,7 +3372,7 @@ var useMediaBuffering = ({
         if (!navigator.userAgent.includes("Firefox/")) {
           playbackLogging({
             logLevel,
-            message: `Calling .load() on ${current.src} because readyState is ${current.readyState} and it is not Firefox.`,
+            message: `Calling .load() on ${src} because readyState is ${current.readyState} and it is not Firefox.`,
             tag: "load",
             mountTime
           });
@@ -3382,7 +3392,7 @@ var useMediaBuffering = ({
     return () => {
       cleanup("element was unmounted or prop changed");
     };
-  }, [buffer, element, isPremounting, logLevel, shouldBuffer, mountTime]);
+  }, [buffer, src, element, isPremounting, logLevel, shouldBuffer, mountTime]);
   return isBuffering;
 };
 
@@ -3656,7 +3666,8 @@ var useMediaPlayback = ({
     shouldBuffer: pauseWhenBuffering,
     isPremounting,
     logLevel,
-    mountTime
+    mountTime,
+    src: src ?? null
   });
   const { bufferUntilFirstFrame, isBuffering } = useBufferUntilFirstFrame({
     mediaRef,

package/dist/esm/version.mjs

@@ -1,5 +1,5 @@
 // src/version.ts
-var VERSION = "4.0.295";
+var VERSION = "4.0.296";
 export {
   VERSION
 };

package/package.json

@@ -3,7 +3,7 @@
     "url": "https://github.com/remotion-dev/remotion/tree/main/packages/core"
   },
   "name": "remotion",
-  "version": "4.0.295",
+  "version": "4.0.296",
   "description": "Make videos programmatically",
   "main": "dist/cjs/index.js",
   "types": "dist/cjs/index.d.ts",
@@ -28,7 +28,7 @@
     "webpack": "5.96.1",
     "zod": "3.22.3",
     "eslint": "9.19.0",
-    "@remotion/eslint-config-internal": "4.0.295"
+    "@remotion/eslint-config-internal": "4.0.296"
   },
   "keywords": [
     "remotion",