remix-validated-form 3.2.1 → 3.2.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/browser/ValidatedForm.js +15 -5
- package/build/ValidatedForm.js +15 -5
- package/package.json +1 -1
- package/src/ValidatedForm.tsx +14 -5
package/browser/ValidatedForm.js
CHANGED
@@ -123,14 +123,24 @@ export function ValidatedForm({ validator, onSubmit, children, fetcher, action,
|
|
123
123
|
validateField: (fieldName) => {
|
124
124
|
invariant(formRef.current, "Cannot find reference to form");
|
125
125
|
const { error } = validator.validateField(getDataFromForm(formRef.current), fieldName);
|
126
|
+
// By checking and returning `prev` here, we can avoid a re-render
|
127
|
+
// if the validation state is the same.
|
126
128
|
if (error) {
|
127
|
-
setFieldErrors((prev) =>
|
128
|
-
|
129
|
-
|
130
|
-
|
129
|
+
setFieldErrors((prev) => {
|
130
|
+
if (prev[fieldName] === error)
|
131
|
+
return prev;
|
132
|
+
return {
|
133
|
+
...prev,
|
134
|
+
[fieldName]: error,
|
135
|
+
};
|
136
|
+
});
|
131
137
|
}
|
132
138
|
else {
|
133
|
-
setFieldErrors((prev) =>
|
139
|
+
setFieldErrors((prev) => {
|
140
|
+
if (!(fieldName in prev))
|
141
|
+
return prev;
|
142
|
+
return omit(prev, fieldName);
|
143
|
+
});
|
134
144
|
}
|
135
145
|
},
|
136
146
|
registerReceiveFocus: (fieldName, handler) => {
|
package/build/ValidatedForm.js
CHANGED
@@ -129,14 +129,24 @@ function ValidatedForm({ validator, onSubmit, children, fetcher, action, default
|
|
129
129
|
validateField: (fieldName) => {
|
130
130
|
(0, tiny_invariant_1.default)(formRef.current, "Cannot find reference to form");
|
131
131
|
const { error } = validator.validateField(getDataFromForm(formRef.current), fieldName);
|
132
|
+
// By checking and returning `prev` here, we can avoid a re-render
|
133
|
+
// if the validation state is the same.
|
132
134
|
if (error) {
|
133
|
-
setFieldErrors((prev) =>
|
134
|
-
|
135
|
-
|
136
|
-
|
135
|
+
setFieldErrors((prev) => {
|
136
|
+
if (prev[fieldName] === error)
|
137
|
+
return prev;
|
138
|
+
return {
|
139
|
+
...prev,
|
140
|
+
[fieldName]: error,
|
141
|
+
};
|
142
|
+
});
|
137
143
|
}
|
138
144
|
else {
|
139
|
-
setFieldErrors((prev) =>
|
145
|
+
setFieldErrors((prev) => {
|
146
|
+
if (!(fieldName in prev))
|
147
|
+
return prev;
|
148
|
+
return (0, util_1.omit)(prev, fieldName);
|
149
|
+
});
|
140
150
|
}
|
141
151
|
},
|
142
152
|
registerReceiveFocus: (fieldName, handler) => {
|
package/package.json
CHANGED
package/src/ValidatedForm.tsx
CHANGED
@@ -229,13 +229,22 @@ export function ValidatedForm<DataType>({
|
|
229
229
|
getDataFromForm(formRef.current),
|
230
230
|
fieldName as any
|
231
231
|
);
|
232
|
+
|
233
|
+
// By checking and returning `prev` here, we can avoid a re-render
|
234
|
+
// if the validation state is the same.
|
232
235
|
if (error) {
|
233
|
-
setFieldErrors((prev) =>
|
234
|
-
|
235
|
-
|
236
|
-
|
236
|
+
setFieldErrors((prev) => {
|
237
|
+
if (prev[fieldName] === error) return prev;
|
238
|
+
return {
|
239
|
+
...prev,
|
240
|
+
[fieldName]: error,
|
241
|
+
};
|
242
|
+
});
|
237
243
|
} else {
|
238
|
-
setFieldErrors((prev) =>
|
244
|
+
setFieldErrors((prev) => {
|
245
|
+
if (!(fieldName in prev)) return prev;
|
246
|
+
return omit(prev, fieldName);
|
247
|
+
});
|
239
248
|
}
|
240
249
|
},
|
241
250
|
registerReceiveFocus: (fieldName, handler) => {
|