release-please 16.11.0 → 16.12.0

package/build/src/index.d.ts

@@ -14,4 +14,4 @@ export { Logger, setLogger } from './util/logger';
 export { GitHub } from './github';
 export declare const configSchema: any;
 export declare const manifestSchema: any;
-export declare const VERSION = "16.11.0";
+export declare const VERSION = "16.12.0";

package/build/src/index.js

@@ -36,6 +36,6 @@ Object.defineProperty(exports, "GitHub", { enumerable: true, get: function () {
 exports.configSchema = require('../../schemas/config.json');
 exports.manifestSchema = require('../../schemas/manifest.json');
 // x-release-please-start-version
-exports.VERSION = '16.11.0';
+exports.VERSION = '16.12.0';
 // x-release-please-end
 //# sourceMappingURL=index.js.map

package/build/src/manifest.js

@@ -687,7 +687,11 @@ class Manifest {
         this.logger.info(`Creating ${releases.length} releases for pull #${pullRequest.number}`);
         const duplicateReleases = [];
         const githubReleases = [];
+        let error;
         for (const release of releases) {
+            // stop releasing once we hit an error
+            if (error)
+                continue;
             try {
                 githubReleases.push(await this.createRelease(release));
             }
@@ -697,10 +701,21 @@ class Manifest {
                     duplicateReleases.push(err);
                 }
                 else {
-                    throw err;
+                    error = err;
                 }
             }
         }
+        if (githubReleases.length > 0) {
+            // comment on pull request about the successful releases
+            const releaseList = githubReleases
+                .map(({ tagName, url }) => `- [${tagName}](${url})`)
+                .join('\n');
+            const comment = `:robot: Created releases:\n${releaseList}\n:sunflower:`;
+            await this.github.commentOnIssue(comment, pullRequest.number);
+        }
+        if (error) {
+            throw error;
+        }
         if (duplicateReleases.length > 0) {
             if (duplicateReleases.length + githubReleases.length ===
                 releases.length) {
@@ -726,9 +741,6 @@ class Manifest {
             draft: release.draft,
             prerelease: release.prerelease,
         });
-        // comment on pull request
-        const comment = `:robot: Release is at ${githubRelease.url} :sunflower:`;
-        await this.github.commentOnIssue(comment, release.pullRequest.number);
         return {
             ...githubRelease,
             path: release.path,

package/build/src/updaters/node/package-json.d.ts

@@ -35,6 +35,7 @@ export declare class PackageJson extends DefaultUpdater {
  * @param {Version} newVersion The new version to update with
  */
 export declare function newVersionWithRange(oldVersion: string, newVersion: Version): string;
+export declare const NPM_PROTOCOL_REGEXP: RegExp;
 /**
  * Helper function to update dependency versions for all new versions specified
  * in the updated versions map. Note that this mutates the existing input.

package/build/src/updaters/node/package-json.js

@@ -13,7 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.updateDependencies = exports.newVersionWithRange = exports.PackageJson = void 0;
+exports.updateDependencies = exports.NPM_PROTOCOL_REGEXP = exports.newVersionWithRange = exports.PackageJson = void 0;
 const json_stringify_1 = require("../../util/json-stringify");
 const logger_1 = require("../../util/logger");
 const default_1 = require("../default");
@@ -82,6 +82,7 @@ function newVersionWithRange(oldVersion, newVersion) {
     return newVersion.toString();
 }
 exports.newVersionWithRange = newVersionWithRange;
+exports.NPM_PROTOCOL_REGEXP = /^[a-z]+:/;
 /**
  * Helper function to update dependency versions for all new versions specified
  * in the updated versions map. Note that this mutates the existing input.
@@ -91,9 +92,12 @@ exports.newVersionWithRange = newVersionWithRange;
  */
 function updateDependencies(dependencies, updatedVersions) {
     for (const depName of Object.keys(dependencies)) {
+        const oldVersion = dependencies[depName];
+        if (exports.NPM_PROTOCOL_REGEXP.test(oldVersion)) {
+            continue;
+        }
         const newVersion = updatedVersions.get(depName);
         if (newVersion) {
-            const oldVersion = dependencies[depName];
             dependencies[depName] = newVersionWithRange(oldVersion, newVersion);
         }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "16.11.0",
+  "version": "16.12.0",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",