release-please 15.8.2 → 15.9.1

package/CHANGELOG.md

@@ -4,6 +4,26 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [15.9.1](https://github.com/googleapis/release-please/compare/v15.9.0...v15.9.1) (2023-03-14)
+
+
+### Bug Fixes
+
+* **cargo-workspace:** Validate Cargo.toml version field ([#1877](https://github.com/googleapis/release-please/issues/1877)) ([0303e2e](https://github.com/googleapis/release-please/commit/0303e2eb9fb082bd9657baa117961d8567eba7e6))
+
+## [15.9.0](https://github.com/googleapis/release-please/compare/v15.8.2...v15.9.0) (2023-03-14)
+
+
+### Features
+
+* Support for "@" sign in component name ([#1873](https://github.com/googleapis/release-please/issues/1873)) ([d3b2f2f](https://github.com/googleapis/release-please/commit/d3b2f2f72c5aada66d3297d38b26d4aa3661177c))
+
+
+### Bug Fixes
+
+* Allow linked-versions to skip merging pull requests ([#1779](https://github.com/googleapis/release-please/issues/1779)) ([dc48b55](https://github.com/googleapis/release-please/commit/dc48b55b459754493513da30f68dc2588d3e30d4))
+* **refactor:** Rename Salesforce to sfdx ([#1829](https://github.com/googleapis/release-please/issues/1829)) ([122820d](https://github.com/googleapis/release-please/commit/122820d5a38a401e1bbdc4878b02f94cf405ad0e))
+
 ## [15.8.2](https://github.com/googleapis/release-please/compare/v15.8.1...v15.8.2) (2023-03-13)
 
 

package/README.md

@@ -150,7 +150,7 @@ Release Please automates releases for the following flavors of repositories:
 | `python`            | [A Python repository, with a setup.py, setup.cfg, CHANGELOG.md](https://github.com/googleapis/python-storage) and optionally a pyproject.toml and a <project>/\_\_init\_\_.py |
 | `ruby`              | A repository with a version.rb and a CHANGELOG.md |
 | `rust`              | A Rust repository, with a Cargo.toml (either as a crate or workspace) and a CHANGELOG.md |
-| `salesforce`        | A repository with a sfdx-project.json and a CHANGELOG.md |
+| `sfdx`              | A repository with a [sfdx-project.json](https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_ws_config.htm) and a CHANGELOG.md |
 | `simple`            | [A repository with a version.txt and a CHANGELOG.md](https://github.com/googleapis/gapic-generator) |
 | `terraform-module`  | [A terraform module, with a version in the README.md, and a CHANGELOG.md](https://github.com/terraform-google-modules/terraform-google-project-factory) |
 

package/build/src/factories/plugin-factory.js

@@ -22,7 +22,10 @@ const errors_1 = require("../errors");
 const sentence_case_1 = require("../plugins/sentence-case");
 const group_priority_1 = require("../plugins/group-priority");
 const pluginFactories = {
-    'linked-versions': options => new linked_versions_1.LinkedVersions(options.github, options.targetBranch, options.repositoryConfig, options.type.groupName, options.type.components),
+    'linked-versions': options => new linked_versions_1.LinkedVersions(options.github, options.targetBranch, options.repositoryConfig, options.type.groupName, options.type.components, {
+        ...options,
+        ...options.type,
+    }),
     'cargo-workspace': options => new cargo_workspace_1.CargoWorkspace(options.github, options.targetBranch, options.repositoryConfig, {
         ...options,
         ...options.type,

package/build/src/factory.js

@@ -40,7 +40,7 @@ const python_1 = require("./strategies/python");
 const ruby_1 = require("./strategies/ruby");
 const ruby_yoshi_1 = require("./strategies/ruby-yoshi");
 const rust_1 = require("./strategies/rust");
-const salesforce_1 = require("./strategies/salesforce");
+const sfdx_1 = require("./strategies/sfdx");
 const simple_1 = require("./strategies/simple");
 const terraform_module_1 = require("./strategies/terraform-module");
 const helm_1 = require("./strategies/helm");
@@ -93,7 +93,8 @@ const releasers = {
     ruby: options => new ruby_1.Ruby(options),
     'ruby-yoshi': options => new ruby_yoshi_1.RubyYoshi(options),
     rust: options => new rust_1.Rust(options),
-    salesforce: options => new salesforce_1.Salesforce(options),
+    salesforce: options => new sfdx_1.Sfdx(options),
+    sfdx: options => new sfdx_1.Sfdx(options),
     simple: options => new simple_1.Simple(options),
     'terraform-module': options => new terraform_module_1.TerraformModule(options),
     helm: options => new helm_1.Helm(options),

package/build/src/plugins/cargo-workspace.js

@@ -26,6 +26,7 @@ const pull_request_body_1 = require("../util/pull-request-body");
 const branch_name_1 = require("../util/branch-name");
 const versioning_strategy_1 = require("../versioning-strategy");
 const cargo_lock_1 = require("../updaters/rust/cargo-lock");
+const errors_1 = require("../errors");
 /**
  * The plugin analyzed a cargo workspace and will bump dependencies
  * of managed packages if those dependencies are being updated.
@@ -64,7 +65,10 @@ class CargoWorkspace extends workspace_1.WorkspacePlugin {
             }
             const version = (_d = manifest.package) === null || _d === void 0 ? void 0 : _d.version;
             if (!version) {
-                throw new Error(`package manifest at ${manifestPath} is missing [package.version]`);
+                throw new errors_1.ConfigurationError(`package manifest at ${manifestPath} is missing [package.version]`, 'cargo-workspace', `${this.github.repository.owner}/${this.github.repository.repo}`);
+            }
+            else if (typeof version !== 'string') {
+                throw new errors_1.ConfigurationError(`package manifest at ${manifestPath} has an invalid [package.version]`, 'cargo-workspace', `${this.github.repository.owner}/${this.github.repository.repo}`);
             }
             allCrates.push({
                 path,

package/build/src/strategies/{salesforce.d.ts → sfdx.d.ts}

@@ -1,7 +1,7 @@
 import { BaseStrategy, BuildUpdatesOptions } from './base';
 import { Update } from '../update';
 import { GitHubFileContents } from '@google-automations/git-file-utils';
-export declare class Salesforce extends BaseStrategy {
+export declare class Sfdx extends BaseStrategy {
     private sfdxProjectJsonContents?;
     protected buildUpdates(options: BuildUpdatesOptions): Promise<Update[]>;
     getDefaultPackageName(): Promise<string | undefined>;

package/build/src/strategies/{salesforce.js → sfdx.js}

@@ -13,13 +13,13 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Salesforce = void 0;
+exports.Sfdx = void 0;
 const base_1 = require("./base");
 const changelog_1 = require("../updaters/changelog");
 const errors_1 = require("../errors");
-const sfdx_project_json_1 = require("../updaters/salesforce/sfdx-project-json");
+const sfdx_project_json_1 = require("../updaters/sfdx/sfdx-project-json");
 const sfdxProjectJsonFileName = 'sfdx-project.json';
-class Salesforce extends base_1.BaseStrategy {
+class Sfdx extends base_1.BaseStrategy {
     async buildUpdates(options) {
         const updates = [];
         const version = options.newVersion;
@@ -54,7 +54,7 @@ class Salesforce extends base_1.BaseStrategy {
             }
             catch (e) {
                 if (e instanceof errors_1.FileNotFoundError) {
-                    throw new errors_1.MissingRequiredFileError(this.addPath(sfdxProjectJsonFileName), 'salesforce', `${this.repository.owner}/${this.repository.repo}`);
+                    throw new errors_1.MissingRequiredFileError(this.addPath(sfdxProjectJsonFileName), 'sfdx', `${this.repository.owner}/${this.repository.repo}`);
                 }
                 throw e;
             }
@@ -62,5 +62,5 @@ class Salesforce extends base_1.BaseStrategy {
         return this.sfdxProjectJsonContents;
     }
 }
-exports.Salesforce = Salesforce;
-//# sourceMappingURL=salesforce.js.map
+exports.Sfdx = Sfdx;
+//# sourceMappingURL=sfdx.js.map

package/build/src/updaters/{salesforce → sfdx}/sfdx-project-json.d.ts

@@ -9,7 +9,7 @@ export type SfdxProjectFile = {
     name: string;
 };
 /**
- * This updates a Salesfore sfdx-project.json file's main version.
+ * This updates a sfdx sfdx-project.json file's main version.
  */
 export declare class SfdxProjectJson extends DefaultUpdater {
     /**

package/build/src/updaters/{salesforce → sfdx}/sfdx-project-json.js

@@ -18,7 +18,7 @@ const json_stringify_1 = require("../../util/json-stringify");
 const logger_1 = require("../../util/logger");
 const default_1 = require("../default");
 /**
- * This updates a Salesfore sfdx-project.json file's main version.
+ * This updates a sfdx sfdx-project.json file's main version.
  */
 class SfdxProjectJson extends default_1.DefaultUpdater {
     /**

package/build/src/util/pull-request-title.js

@@ -36,7 +36,7 @@ function generateMatchPattern(pullRequestTitlePattern, logger = logger_1.logger)
         .replace('(', '\\(')
         .replace(')', '\\)')
         .replace('${scope}', '(\\((?<branch>[\\w-./]+)\\))?')
-        .replace('${component}', ' ?(?<component>[\\w-./]*)?')
+        .replace('${component}', ' ?(?<component>@?[\\w-./]*)?')
         .replace('${version}', 'v?(?<version>[0-9].*)')
         .replace('${branch}', '(?<branch>[\\w-./]+)?')}$`);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "15.8.2",
+  "version": "15.9.1",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",