release-please 15.12.0 → 16.0.0

package/CHANGELOG.md

@@ -4,6 +4,35 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [16.0.0](https://github.com/googleapis/release-please/compare/v15.13.0...v16.0.0) (2023-09-18)
+
+
+### ⚠ BREAKING CHANGES
+
+* require node 18+ ([#2069](https://github.com/googleapis/release-please/issues/2069))
+
+### Features
+
+* Fallback to root package version if package ignores github release ([#1935](https://github.com/googleapis/release-please/issues/1935)) ([0e11d4c](https://github.com/googleapis/release-please/commit/0e11d4c019f1e33cd713a237e037f31397d5371a))
+* Require node 18+ ([#2069](https://github.com/googleapis/release-please/issues/2069)) ([5a50247](https://github.com/googleapis/release-please/commit/5a5024727b93d0ba557b6f7ee5c6c1bab8d723d6))
+* Support pnpm workspaces ([#2058](https://github.com/googleapis/release-please/issues/2058)) ([13cba14](https://github.com/googleapis/release-please/commit/13cba14225cb836c74199d726a996f83122fab07))
+* Use default updaters based on file extension ([#2072](https://github.com/googleapis/release-please/issues/2072)) ([1ee162b](https://github.com/googleapis/release-please/commit/1ee162b3344e986afd09275f6762624e4a49faae))
+
+
+### Bug Fixes
+
+* **deps:** Bump semver dependency version ([#2068](https://github.com/googleapis/release-please/issues/2068)) ([cd0bd85](https://github.com/googleapis/release-please/commit/cd0bd853ac23087e5d5348c22f032fe0e533451d))
+* **deps:** Replace lerna dependency with lerna-lite ([13cba14](https://github.com/googleapis/release-please/commit/13cba14225cb836c74199d726a996f83122fab07))
+* **deps:** Upgrade http-proxy-agent to v7 ([#2071](https://github.com/googleapis/release-please/issues/2071)) ([cc50a34](https://github.com/googleapis/release-please/commit/cc50a34dee16115c07e574b05552678108f9e0c3))
+* **deps:** Upgrade https-proxy-agent to v7 ([cc50a34](https://github.com/googleapis/release-please/commit/cc50a34dee16115c07e574b05552678108f9e0c3))
+
+## [15.13.0](https://github.com/googleapis/release-please/compare/v15.12.0...v15.13.0) (2023-08-18)
+
+
+### Features
+
+* Adds metadata versioning for terraform modules ([#2041](https://github.com/googleapis/release-please/issues/2041)) ([49b33c7](https://github.com/googleapis/release-please/commit/49b33c73b2571699ad8362f8b6b934154a6ce375))
+
 ## [15.12.0](https://github.com/googleapis/release-please/compare/v15.11.2...v15.12.0) (2023-07-11)
 
 

package/README.md

@@ -139,7 +139,7 @@ recommend using squash-merge instead](#linear-git-commit-history-use-squash-merg
 
 ## Release Please bot does not create a release PR. Why?
 
-### Releasable Units
+### Step 1: Ensure releasable units are merged
 
 Release Please creates a release pull request after it notices the default branch
 contains "releasable units" since the last release.
@@ -150,15 +150,15 @@ prefixes: "feat", "fix", and "deps".
 Some languages have their specific releasable unit configuration. For example,
 "docs" is a prefix for releasable units in Java and Python.
 
-### Re-run Release Please
+### Step 2: Ensure no `autorelease: pending` or `autorelease: triggered` label in an old PR
 
-If you think Release Please missed creating a release PR after a pull request
-with a releasable unit has been merged, please re-run `release-please`. If you are using
-the GitHub application, add `release-please:force-run` label to the merged pull request. If
-you are using the action, look for the failed invocation and retry the workflow run.
-Release Please will process the pull request immediately to find releasable units.
-
-### Existing Pull Requests with "autorelease: pending" label
+Check existing pull requests labelled with `autorelease: pending` or
+`autorelease: triggered` label.
+Due to GitHub API failures, it's possible that the tag was not removed
+correctly upon a previous release and Release Please thinks that the previous release is
+still pending.
+If you're certain that there's no pending release, remove the
+`autorelease: pending` or `autorelease: triggered` label.
 
 For the GitHub application users, Release Please will not create a new pull request
 if there's an existing pull request labeled as `autorelease: pending`.
@@ -168,6 +168,14 @@ If you find a release pull request with the label and it is not going to be rele
 (or already released), then remove the `autorelease: pending` label and re-run Release
 Please.
 
+### Step 3: Rerun Release Please
+
+If you think Release Please missed creating a release PR after a pull request
+with a releasable unit has been merged, please re-run `release-please`. If you are using
+the GitHub application, add `release-please:force-run` label to the merged pull request. If
+you are using the action, look for the failed invocation and retry the workflow run.
+Release Please will process the pull request immediately to find releasable units.
+
 ## Strategy (Language) types supported
 
 Release Please automates releases for the following flavors of repositories:

package/build/src/github.d.ts

@@ -11,6 +11,8 @@ import { Update } from './update';
 import { Release } from './release';
 import { GitHubFileContents } from '@google-automations/git-file-utils';
 import { Logger } from 'code-suggester/build/src/types';
+import { HttpsProxyAgent } from 'https-proxy-agent';
+import { HttpProxyAgent } from 'http-proxy-agent';
 import { PullRequestOverflowHandler } from './util/pull-request-overflow-handler';
 type RequestBuilderType = typeof request;
 type DefaultFunctionType = RequestBuilderType['defaults'];
@@ -87,7 +89,7 @@ export declare class GitHub {
     private fileCache;
     private logger;
     private constructor();
-    static createDefaultAgent(baseUrl: string, defaultProxy?: ProxyOption): import("https-proxy-agent/dist/agent").default | import("http-proxy-agent/dist/agent").default | undefined;
+    static createDefaultAgent(baseUrl: string, defaultProxy?: ProxyOption): HttpProxyAgent<`http://${string}:${number}`> | HttpsProxyAgent<`https://${string}:${number}`> | undefined;
     /**
      * Build a new GitHub client with auto-detected default branch.
      *

package/build/src/github.js

@@ -369,15 +369,12 @@ class GitHub {
             return undefined;
         }
         const { host, port } = defaultProxy;
-        return new URL(baseUrl).protocol.replace(':', '') === 'http'
-            ? new http_proxy_agent_1.HttpProxyAgent({
-                host,
-                port,
-            })
-            : new https_proxy_agent_1.HttpsProxyAgent({
-                host,
-                port,
-            });
+        if (new URL(baseUrl).protocol.replace(':', '') === 'http') {
+            return new http_proxy_agent_1.HttpProxyAgent(`http://${host}:${port}`);
+        }
+        else {
+            return new https_proxy_agent_1.HttpsProxyAgent(`https://${host}:${port}`);
+        }
     }
     /**
      * Build a new GitHub client with auto-detected default branch.

package/build/src/manifest.js

@@ -405,6 +405,24 @@ class Manifest {
                     notes: '',
                 };
             }
+            else {
+                if (strategiesByPath[exports.ROOT_PROJECT_PATH] &&
+                    this.repositoryConfig[path].skipGithubRelease) {
+                    this.logger.debug('could not find release, checking root package');
+                    const rootComponent = await strategiesByPath[exports.ROOT_PROJECT_PATH].getComponent();
+                    const rootTag = new tag_name_1.TagName(expectedVersion, rootComponent, this.repositoryConfig[exports.ROOT_PROJECT_PATH].tagSeparator, this.repositoryConfig[exports.ROOT_PROJECT_PATH].includeVInTag);
+                    const foundTag = allTags[rootTag.toString()];
+                    if (foundTag) {
+                        this.logger.debug(`found rootTag: ${foundTag.name} ${foundTag.sha}`);
+                        releasesByPath[path] = {
+                            name: foundTag.name,
+                            tag: rootTag,
+                            sha: foundTag.sha,
+                            notes: '',
+                        };
+                    }
+                }
+            }
         }
         return releasesByPath;
     }

package/build/src/plugins/node-workspace.d.ts

@@ -1,4 +1,4 @@
-import { Package as LernaPackage, RawManifest as PackageJson } from '@lerna/package';
+import { Package as LernaPackage, RawManifest as PackageJson } from '@lerna-lite/core';
 import { GitHub } from '../github';
 import { CandidateReleasePullRequest, RepositoryConfig } from '../manifest';
 import { Version, VersionsMap } from '../version';

package/build/src/plugins/node-workspace.js

@@ -14,8 +14,8 @@
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.NodeWorkspace = void 0;
-const package_graph_1 = require("@lerna/package-graph");
-const package_1 = require("@lerna/package");
+const core_1 = require("@lerna-lite/core");
+const core_2 = require("@lerna-lite/core");
 const version_1 = require("../version");
 const raw_content_1 = require("../updaters/raw-content");
 const pull_request_title_1 = require("../util/pull-request-title");
@@ -25,7 +25,7 @@ const json_stringify_1 = require("../util/json-stringify");
 const changelog_1 = require("../updaters/changelog");
 const workspace_1 = require("./workspace");
 const versioning_strategy_1 = require("../versioning-strategy");
-class Package extends package_1.Package {
+class Package extends core_2.Package {
     constructor(rawContent, location, pkg) {
         super(pkg !== null && pkg !== void 0 ? pkg : JSON.parse(rawContent), location);
         this.rawContent = rawContent;
@@ -83,7 +83,7 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
             }
         }
         const allPackages = Array.from(packagesByPath.values());
-        this.packageGraph = new package_graph_1.PackageGraph(allPackages, 'allDependencies', this.alwaysLinkLocal);
+        this.packageGraph = new core_1.PackageGraph(allPackages, 'allDependencies', this.alwaysLinkLocal);
         return {
             allPackages,
             candidatesByPackage,

package/build/src/strategies/base.js

@@ -249,6 +249,36 @@ class BaseStrategy {
                     }
                 }
             }
+            else if (extraFile.endsWith('.json')) {
+                extraFileUpdates.push({
+                    path: this.addPath(extraFile),
+                    createIfMissing: false,
+                    updater: new composite_1.CompositeUpdater(new generic_json_1.GenericJson('$.version', version), new generic_1.Generic({ version, versionsMap })),
+                });
+            }
+            else if (extraFile.endsWith('.yaml') || extraFile.endsWith('.yml')) {
+                extraFileUpdates.push({
+                    path: this.addPath(extraFile),
+                    createIfMissing: false,
+                    updater: new composite_1.CompositeUpdater(new generic_yaml_1.GenericYaml('$.version', version), new generic_1.Generic({ version, versionsMap })),
+                });
+            }
+            else if (extraFile.endsWith('.toml')) {
+                extraFileUpdates.push({
+                    path: this.addPath(extraFile),
+                    createIfMissing: false,
+                    updater: new composite_1.CompositeUpdater(new generic_toml_1.GenericToml('$.version', version), new generic_1.Generic({ version, versionsMap })),
+                });
+            }
+            else if (extraFile.endsWith('.xml')) {
+                extraFileUpdates.push({
+                    path: this.addPath(extraFile),
+                    createIfMissing: false,
+                    updater: new composite_1.CompositeUpdater(
+                    // Updates "version" element that is a child of the root element.
+                    new generic_xml_1.GenericXml('/*/version', version), new generic_1.Generic({ version, versionsMap })),
+                });
+            }
             else {
                 extraFileUpdates.push({
                     path: this.addPath(extraFile),

package/build/src/strategies/terraform-module.js

@@ -19,6 +19,7 @@ const changelog_1 = require("../updaters/changelog");
 // Terraform specific.
 const readme_1 = require("../updaters/terraform/readme");
 const module_version_1 = require("../updaters/terraform/module-version");
+const metadata_version_1 = require("../updaters/terraform/metadata-version");
 const base_1 = require("./base");
 const version_1 = require("../version");
 class TerraformModule extends base_1.BaseStrategy {
@@ -67,6 +68,17 @@ class TerraformModule extends base_1.BaseStrategy {
                 }),
             });
         });
+        // Update metadata.yaml to current candidate version.
+        const metadataFiles = await this.github.findFilesByFilenameAndRef('metadata.yaml', this.targetBranch, this.path);
+        metadataFiles.forEach(path => {
+            updates.push({
+                path: this.addPath(path),
+                createIfMissing: false,
+                updater: new metadata_version_1.MetadataVersion({
+                    version,
+                }),
+            });
+        });
         return updates;
     }
     initialReleaseVersion() {

package/build/src/updaters/terraform/metadata-version.d.ts

@@ -0,0 +1,13 @@
+import { Logger } from '../../util/logger';
+import { DefaultUpdater } from '../default';
+/**
+ * Updates a Terraform metadata.yaml or metadata.display.yaml file(s).
+ */
+export declare class MetadataVersion extends DefaultUpdater {
+    /**
+     * Given initial file contents, return updated contents.
+     * @param {string} content The initial content
+     * @returns {string} The updated content
+     */
+    updateContent(content: string, logger?: Logger): string;
+}

package/build/src/updaters/terraform/metadata-version.js

@@ -0,0 +1,37 @@
+"use strict";
+// Copyright 2023 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.MetadataVersion = void 0;
+const logger_1 = require("../../util/logger");
+const default_1 = require("../default");
+/**
+ * Updates a Terraform metadata.yaml or metadata.display.yaml file(s).
+ */
+class MetadataVersion extends default_1.DefaultUpdater {
+    /**
+     * Given initial file contents, return updated contents.
+     * @param {string} content The initial content
+     * @returns {string} The updated content
+     */
+    updateContent(content, logger = logger_1.logger) {
+        const oldVersion = content.match(/version: [0-9]+\.[0-9]+\.[0-9]+(-\w+)?/);
+        if (oldVersion) {
+            logger.info(`updating from ${oldVersion} to v${this.version}`);
+        }
+        return content.replace(/version: [0-9]+\.[0-9]+\.[0-9]+(-\w+)?/g, `version: ${this.version}`);
+    }
+}
+exports.MetadataVersion = MetadataVersion;
+//# sourceMappingURL=metadata-version.js.map

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "release-please",
-  "version": "15.12.0",
+  "version": "16.0.0",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
   "scripts": {
-    "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test",
+    "test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test",
     "docs": "echo add docs tests",
     "test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test",
     "clean": "gts clean",
@@ -42,14 +42,12 @@
     "@types/chai": "^4.1.7",
     "@types/diff": "^5.0.2",
     "@types/iarna__toml": "^2.0.1",
+    "@types/inquirer": "^9.0.3",
     "@types/js-yaml": "^4.0.0",
     "@types/jsonpath": "^0.2.0",
-    "@types/lerna__collect-updates": "^5.1.0",
-    "@types/lerna__package": "^5.1.0",
-    "@types/lerna__package-graph": "^5.1.0",
-    "@types/lerna__run-topologically": "^5.1.0",
     "@types/mocha": "^9.0.0",
     "@types/node": "^18.0.0",
+    "@types/npmlog": "^4.1.4",
     "@types/pino": "^7.0.0",
     "@types/semver": "^7.0.0",
     "@types/sinon": "^10.0.0",
@@ -59,21 +57,19 @@
     "ajv-formats": "^2.1.1",
     "c8": "^8.0.0",
     "chai": "^4.2.0",
+    "config-chain": "^1.1.13",
     "cross-env": "^7.0.0",
     "gts": "^3.1.0",
     "mocha": "^9.2.2",
     "nock": "^13.0.0",
-    "sinon": "15.2.0",
+    "sinon": "16.0.0",
     "snap-shot-it": "^7.0.0"
   },
   "dependencies": {
     "@conventional-commits/parser": "^0.4.1",
     "@google-automations/git-file-utils": "^1.2.5",
     "@iarna/toml": "^3.0.0",
-    "@lerna/collect-updates": "^6.4.1",
-    "@lerna/package": "^6.4.1",
-    "@lerna/package-graph": "^6.4.1",
-    "@lerna/run-topologically": "^6.4.1",
+    "@lerna-lite/core": "1.17.0",
     "@octokit/graphql": "^5.0.0",
     "@octokit/request": "^6.0.0",
     "@octokit/request-error": "^3.0.0",
@@ -88,13 +84,13 @@
     "detect-indent": "^6.1.0",
     "diff": "^5.0.0",
     "figures": "^3.0.0",
-    "http-proxy-agent": "^5.0.0",
-    "https-proxy-agent": "^5.0.1",
+    "http-proxy-agent": "^7.0.0",
+    "https-proxy-agent": "^7.0.0",
     "js-yaml": "^4.0.0",
     "jsonpath": "^1.1.1",
     "node-html-parser": "^6.0.0",
     "parse-github-repo-url": "^1.4.1",
-    "semver": "^7.0.0",
+    "semver": "^7.5.3",
     "type-fest": "^3.0.0",
     "typescript": "^4.6.4",
     "unist-util-visit": "^2.0.3",
@@ -104,6 +100,6 @@
     "yargs": "^17.0.0"
   },
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=18.0.0"
   }
 }