release-please 14.7.0 → 14.7.1

package/CHANGELOG.md

@@ -4,6 +4,14 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [14.7.1](https://github.com/googleapis/release-please/compare/v14.7.0...v14.7.1) (2022-09-22)
+
+
+### Bug Fixes
+
+* Handle pull request files returned as null ([#1651](https://github.com/googleapis/release-please/issues/1651)) ([4cea3dd](https://github.com/googleapis/release-please/commit/4cea3dd1b17ee31e27c1d246e83fcf39f28f0677))
+* **node:** Rethrow missing file error for package.json as a configuration error ([#1652](https://github.com/googleapis/release-please/issues/1652)) ([65ee57b](https://github.com/googleapis/release-please/commit/65ee57b433f67d87db3c2530dad4207218dae6d2))
+
 ## [14.7.0](https://github.com/googleapis/release-please/compare/v14.6.1...v14.7.0) (2022-09-20)
 
 

package/build/src/github.js

@@ -490,7 +490,7 @@ class GitHub {
         }
     }
     async mergeCommitsGraphQL(targetBranch, cursor, options = {}) {
-        var _a, _b;
+        var _a, _b, _c, _d;
         this.logger.debug(`Fetching merge commits on branch ${targetBranch} with cursor: ${cursor}`);
         const query = `query pullRequestsSince($owner: String!, $repo: String!, $num: Int!, $maxFilesChanged: Int, $targetBranch: String!, $cursor: String) {
       repository(owner: $owner, name: $repo) {
@@ -571,7 +571,7 @@ class GitHub {
                 return pr.mergeCommit && pr.mergeCommit.oid === graphCommit.sha;
             });
             if (pullRequest) {
-                const files = pullRequest.files.nodes.map(node => node.path);
+                const files = (((_b = pullRequest.files) === null || _b === void 0 ? void 0 : _b.nodes) || []).map(node => node.path);
                 commit.pullRequest = {
                     sha: commit.sha,
                     number: pullRequest.number,
@@ -582,7 +582,7 @@ class GitHub {
                     labels: pullRequest.labels.nodes.map(node => node.name),
                     files,
                 };
-                if (((_b = pullRequest.files.pageInfo) === null || _b === void 0 ? void 0 : _b.hasNextPage) && options.backfillFiles) {
+                if (((_d = (_c = pullRequest.files) === null || _c === void 0 ? void 0 : _c.pageInfo) === null || _d === void 0 ? void 0 : _d.hasNextPage) && options.backfillFiles) {
                     this.logger.info(`PR #${pullRequest.number} has many files, backfilling`);
                     commit.files = await this.getCommitFiles(graphCommit.sha);
                 }

package/build/src/strategies/node.js

@@ -19,6 +19,7 @@ const package_lock_json_1 = require("../updaters/node/package-lock-json");
 const samples_package_json_1 = require("../updaters/node/samples-package-json");
 const changelog_1 = require("../updaters/changelog");
 const package_json_1 = require("../updaters/node/package-json");
+const errors_1 = require("../errors");
 class Node extends base_1.BaseStrategy {
     async buildUpdates(options) {
         var _a;
@@ -74,7 +75,15 @@ class Node extends base_1.BaseStrategy {
     }
     async getPkgJsonContents() {
         if (!this.pkgJsonContents) {
-            this.pkgJsonContents = await this.github.getFileContentsOnBranch(this.addPath('package.json'), this.targetBranch);
+            try {
+                this.pkgJsonContents = await this.github.getFileContentsOnBranch(this.addPath('package.json'), this.targetBranch);
+            }
+            catch (e) {
+                if (e instanceof errors_1.FileNotFoundError) {
+                    throw new errors_1.MissingRequiredFileError(this.addPath('package.json'), 'node', `${this.repository.owner}/${this.repository.repo}`);
+                }
+                throw e;
+            }
         }
         return this.pkgJsonContents;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "14.7.0",
+  "version": "14.7.1",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",