release-please 14.6.0 → 14.7.0

package/CHANGELOG.md

@@ -4,6 +4,25 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [14.7.0](https://github.com/googleapis/release-please/compare/v14.6.1...v14.7.0) (2022-09-20)
+
+
+### Features
+
+* Easy proxy configuration ([#1639](https://github.com/googleapis/release-please/issues/1639)) ([4bb4c65](https://github.com/googleapis/release-please/commit/4bb4c658e3c30150432802b5ccc2aa5a96332f1e))
+
+
+### Bug Fixes
+
+* **commit-split:** Detect overlapping prefixes ([#1638](https://github.com/googleapis/release-please/issues/1638)) ([db51b29](https://github.com/googleapis/release-please/commit/db51b295d711e657ee5928bc32a3dbb88c793969)), closes [#1637](https://github.com/googleapis/release-please/issues/1637)
+
+## [14.6.1](https://github.com/googleapis/release-please/compare/v14.6.0...v14.6.1) (2022-09-20)
+
+
+### Bug Fixes
+
+* Detect uppercase readme.md files ([#1644](https://github.com/googleapis/release-please/issues/1644)) ([d3b68b2](https://github.com/googleapis/release-please/commit/d3b68b2afe622b0a9f83c77da33bfcf1bc4c77b4))
+
 ## [14.6.0](https://github.com/googleapis/release-please/compare/v14.5.0...v14.6.0) (2022-09-15)
 
 

package/build/src/github.d.ts

@@ -24,6 +24,10 @@ export interface GitHubOptions {
     octokitAPIs: OctokitAPIs;
     logger?: Logger;
 }
+interface ProxyOption {
+    host: string;
+    port: number;
+}
 interface GitHubCreateOptions {
     owner: string;
     repo: string;
@@ -33,6 +37,7 @@ interface GitHubCreateOptions {
     octokitAPIs?: OctokitAPIs;
     token?: string;
     logger?: Logger;
+    proxy?: ProxyOption;
 }
 declare type CommitFilter = (commit: Commit) => boolean;
 interface CommitIteratorOptions {
@@ -76,6 +81,7 @@ export declare class GitHub {
     private fileCache;
     private logger;
     private constructor();
+    static createDefaultAgent(baseUrl: string, defaultProxy?: ProxyOption): import("https-proxy-agent/dist/agent").default | import("http-proxy-agent/dist/agent").default | undefined;
     /**
      * Build a new GitHub client with auto-detected default branch.
      *

package/build/src/github.js

@@ -28,6 +28,8 @@ const logger_1 = require("./util/logger");
 const manifest_1 = require("./manifest");
 const signoff_commit_message_1 = require("./util/signoff-commit-message");
 const git_file_utils_1 = require("@google-automations/git-file-utils");
+const https_proxy_agent_1 = require("https-proxy-agent");
+const http_proxy_agent_1 = require("http-proxy-agent");
 class GitHub {
     constructor(options) {
         var _a;
@@ -344,6 +346,21 @@ class GitHub {
         this.fileCache = new git_file_utils_1.RepositoryFileCache(this.octokit, this.repository);
         this.logger = (_a = options.logger) !== null && _a !== void 0 ? _a : logger_1.logger;
     }
+    static createDefaultAgent(baseUrl, defaultProxy) {
+        if (!defaultProxy) {
+            return undefined;
+        }
+        const { host, port } = defaultProxy;
+        return new URL(baseUrl).protocol.replace(':', '') === 'http'
+            ? new http_proxy_agent_1.HttpProxyAgent({
+                host,
+                port,
+            })
+            : new https_proxy_agent_1.HttpsProxyAgent({
+                host,
+                port,
+            });
+    }
     /**
      * Build a new GitHub client with auto-detected default branch.
      *
@@ -367,6 +384,9 @@ class GitHub {
             octokit: new rest_1.Octokit({
                 baseUrl: apiUrl,
                 auth: options.token,
+                request: {
+                    agent: this.createDefaultAgent(apiUrl, options.proxy),
+                },
             }),
             request: request_1.request.defaults({
                 baseUrl: apiUrl,

package/build/src/strategies/terraform-module.js

@@ -35,7 +35,12 @@ class TerraformModule extends base_1.BaseStrategy {
         });
         // Update version in README to current candidate version.
         // A module may have submodules, so find all submodules.
-        const readmeFiles = await this.github.findFilesByFilenameAndRef('readme.md', this.targetBranch, this.path);
+        const readmeFiles = await Promise.all([
+            this.github.findFilesByFilenameAndRef('readme.md', this.targetBranch, this.path),
+            this.github.findFilesByFilenameAndRef('README.md', this.targetBranch, this.path),
+        ]).then(([v, vt]) => {
+            return v.concat(vt);
+        });
         readmeFiles.forEach(path => {
             updates.push({
                 path: this.addPath(path),

package/build/src/util/commit-split.js

@@ -44,7 +44,7 @@ class CommitSplit {
                 for (let exPath of paths) {
                     exPath = exPath.replace(/$/, '/');
                     exPath = exPath.replace(/^/, '/');
-                    if (newPath.indexOf(exPath) >= 0 || exPath.indexOf(newPath) >= 0) {
+                    if (newPath.startsWith(exPath) || exPath.startsWith(newPath)) {
                         throw new Error(`Path prefixes must be unique: ${newPath}, ${exPath}`);
                     }
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "14.6.0",
+  "version": "14.7.0",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
@@ -88,6 +88,8 @@
     "detect-indent": "^6.1.0",
     "diff": "^5.0.0",
     "figures": "^3.0.0",
+    "http-proxy-agent": "^5.0.0",
+    "https-proxy-agent": "^5.0.1",
     "js-yaml": "^4.0.0",
     "jsonpath": "^1.1.1",
     "node-html-parser": "^6.0.0",