release-please 14.17.3 → 14.17.5

package/CHANGELOG.md

@@ -4,6 +4,20 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [14.17.5](https://github.com/googleapis/release-please/compare/v14.17.4...v14.17.5) (2022-12-08)
+
+
+### Bug Fixes
+
+* **expo:** Android version now correctly builds as a number ([#1770](https://github.com/googleapis/release-please/issues/1770)) ([d54483b](https://github.com/googleapis/release-please/commit/d54483be6d307aea75797f6a5bcfa6679b64088f))
+
+## [14.17.4](https://github.com/googleapis/release-please/compare/v14.17.3...v14.17.4) (2022-12-01)
+
+
+### Bug Fixes
+
+* Pass group-pull-request-title-pattern to strategies to parse releases ([#1760](https://github.com/googleapis/release-please/issues/1760)) ([f7601e4](https://github.com/googleapis/release-please/commit/f7601e423a267861fb86a441d1835ddf6da07a83))
+
 ## [14.17.3](https://github.com/googleapis/release-please/compare/v14.17.2...v14.17.3) (2022-11-26)
 
 

package/build/src/manifest.js

@@ -587,7 +587,9 @@ class Manifest {
                 this.logger.debug(`type: ${config.releaseType}`);
                 this.logger.debug(`targetBranch: ${this.targetBranch}`);
                 const strategy = strategiesByPath[path];
-                const release = await strategy.buildRelease(pullRequest);
+                const release = await strategy.buildRelease(pullRequest, {
+                    groupPullRequestTitlePattern: this.groupPullRequestTitlePattern,
+                });
                 if (release) {
                     releases.push({
                         ...release,

package/build/src/plugins/linked-versions.js

@@ -116,9 +116,10 @@ class LinkedVersions extends plugin_1.ManifestPlugin {
             }
             return collection;
         }, [[], []]);
+        this.logger.info(`found ${inScopeCandidates.length} linked-versions candidates`);
         // delegate to the merge plugin and add merged pull request
         if (inScopeCandidates.length > 0) {
-            const merge = new merge_1.Merge(this.github, this.targetBranch, this.repositoryConfig, `chore\${branch}: release ${this.groupName} libraries`);
+            const merge = new merge_1.Merge(this.github, this.targetBranch, this.repositoryConfig, `chore\${scope}: release ${this.groupName} libraries`);
             const merged = await merge.run(inScopeCandidates);
             outOfScopeCandidates.push(...merged);
         }

package/build/src/strategies/base.d.ts

@@ -1,4 +1,4 @@
-import { Strategy } from '../strategy';
+import { Strategy, BuildReleaseOptions } from '../strategy';
 import { GitHub } from '../github';
 import { VersioningStrategy } from '../versioning-strategy';
 import { Repository } from '../repository';
@@ -125,7 +125,7 @@ export declare abstract class BaseStrategy implements Strategy {
      * @param {PullRequest} mergedPullRequest The merged release pull request.
      * @returns {Release} The candidate release.
      */
-    buildRelease(mergedPullRequest: PullRequest): Promise<Release | undefined>;
+    buildRelease(mergedPullRequest: PullRequest, options?: BuildReleaseOptions): Promise<Release | undefined>;
     isPublishedVersion(_version: Version): boolean;
     /**
      * Override this to handle the initial version of a new library.

package/build/src/strategies/base.js

@@ -288,7 +288,8 @@ class BaseStrategy {
      * @param {PullRequest} mergedPullRequest The merged release pull request.
      * @returns {Release} The candidate release.
      */
-    async buildRelease(mergedPullRequest) {
+    async buildRelease(mergedPullRequest, options) {
+        var _a;
         if (this.skipGitHubRelease) {
             this.logger.info('Release skipped from strategy config');
             return;
@@ -297,8 +298,9 @@ class BaseStrategy {
             this.logger.error('Pull request should have been merged');
             return;
         }
+        const mergedTitlePattern = (_a = options === null || options === void 0 ? void 0 : options.groupPullRequestTitlePattern) !== null && _a !== void 0 ? _a : manifest_1.MANIFEST_PULL_REQUEST_TITLE_PATTERN;
         const pullRequestTitle = pull_request_title_1.PullRequestTitle.parse(mergedPullRequest.title, this.pullRequestTitlePattern, this.logger) ||
-            pull_request_title_1.PullRequestTitle.parse(mergedPullRequest.title, manifest_1.MANIFEST_PULL_REQUEST_TITLE_PATTERN, this.logger);
+            pull_request_title_1.PullRequestTitle.parse(mergedPullRequest.title, mergedTitlePattern, this.logger);
         if (!pullRequestTitle) {
             this.logger.error(`Bad pull request title: '${mergedPullRequest.title}'`);
             return;

package/build/src/strategy.d.ts

@@ -5,6 +5,9 @@ import { Commit } from './commit';
 import { VersioningStrategy } from './versioning-strategy';
 import { ChangelogNotes } from './changelog-notes';
 import { Version } from './version';
+export interface BuildReleaseOptions {
+    groupPullRequestTitlePattern?: string;
+}
 /**
  * A strategy is responsible for determining which files are
  * necessary to update in a release pull request.
@@ -30,7 +33,7 @@ export interface Strategy {
      * @param {PullRequest} mergedPullRequest The merged release pull request.
      * @returns {Release} The candidate release.
      */
-    buildRelease(mergedPullRequest: PullRequest): Promise<Release | undefined>;
+    buildRelease(mergedPullRequest: PullRequest, options?: BuildReleaseOptions): Promise<Release | undefined>;
     /**
      * Return the component for this strategy. This may be a computed field.
      * @returns {string}

package/build/src/updaters/expo/app-json.d.ts

@@ -8,7 +8,7 @@ export interface AppJson {
             buildNumber?: string;
         };
         android?: {
-            versionCode?: string;
+            versionCode?: number;
         };
     };
 }

package/build/src/updaters/expo/app-json.js

@@ -58,7 +58,7 @@ class AppJson extends default_1.DefaultUpdater {
                 this.version.minor * 100 +
                 this.version.patch;
             logger.info(`updating Android version from ${parsed.expo.android.versionCode} to ${versionCode}`);
-            parsed.expo.android.versionCode = versionCode.toString();
+            parsed.expo.android.versionCode = versionCode;
         }
         return (0, json_stringify_1.jsonStringify)(parsed, content);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "14.17.3",
+  "version": "14.17.5",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
@@ -63,7 +63,7 @@
     "gts": "^3.1.0",
     "mocha": "^9.2.2",
     "nock": "^13.0.0",
-    "sinon": "14.0.2",
+    "sinon": "15.0.0",
     "snap-shot-it": "^7.0.0"
   },
   "dependencies": {