release-please 14.17.0 → 14.17.2

package/CHANGELOG.md

@@ -4,6 +4,22 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [14.17.2](https://github.com/googleapis/release-please/compare/v14.17.1...v14.17.2) (2022-11-22)
+
+
+### Bug Fixes
+
+* Handle issue links in BREAKING_CHANGE notes section ([#1757](https://github.com/googleapis/release-please/issues/1757)) ([cd8c04b](https://github.com/googleapis/release-please/commit/cd8c04b4d7a67116b31baff60279fa6d719c73a0))
+
+## [14.17.1](https://github.com/googleapis/release-please/compare/v14.17.0...v14.17.1) (2022-11-22)
+
+
+### Bug Fixes
+
+* **dart:** Throw MissingRequiredFileError if pubspec.yaml is missing ([#1756](https://github.com/googleapis/release-please/issues/1756)) ([ada9fd6](https://github.com/googleapis/release-please/commit/ada9fd6db42aa6db0db52b8a81aa7f70b064e914))
+* **helm:** throw MissingRequiredFileError if Chart.yaml is missing ([ada9fd6](https://github.com/googleapis/release-please/commit/ada9fd6db42aa6db0db52b8a81aa7f70b064e914))
+* **node-workspace:** Maintain the dependency version prefix in newCandidate ([#1748](https://github.com/googleapis/release-please/issues/1748)) ([909d310](https://github.com/googleapis/release-please/commit/909d310defdf24adfd4858bbe1604668c14ef77f))
+
 ## [14.17.0](https://github.com/googleapis/release-please/compare/v14.16.0...v14.17.0) (2022-11-11)
 
 

package/README.md

@@ -219,6 +219,10 @@ Contributions welcome! See the [Contributing Guide](https://github.com/googleapi
 
 For more information on the design of the library, see [design](https://github.com/googleapis/release-please/blob/main/docs/design.md).
 
+## Troubleshooting
+
+For common issues and help troubleshooting your configuration, see [Troubleshooting](https://github.com/googleapis/release-please/blob/main/docs/troubleshooting.md).
+
 ## License
 
 Apache Version 2.0

package/build/src/changelog-notes/default.js

@@ -47,12 +47,15 @@ class DefaultChangelogNotes {
         preset.writerOpts.mainTemplate =
             this.mainTemplate || preset.writerOpts.mainTemplate;
         const changelogCommits = commits.map(commit => {
+            const notes = commit.notes
+                .filter(note => note.title === 'BREAKING CHANGE')
+                .map(note => replaceIssueLink(note, context.host, context.owner, context.repository));
             return {
                 body: '',
                 subject: htmlEscape(commit.bareMessage),
                 type: commit.type,
                 scope: commit.scope,
-                notes: commit.notes.filter(note => note.title === 'BREAKING CHANGE'),
+                notes,
                 references: commit.references,
                 mentions: [],
                 merge: null,
@@ -71,6 +74,10 @@ class DefaultChangelogNotes {
     }
 }
 exports.DefaultChangelogNotes = DefaultChangelogNotes;
+function replaceIssueLink(note, host, owner, repo) {
+    note.text = note.text.replace(/\(#(\d+)\)/, `([#$1](${host}/${owner}/${repo}/issues/$1))`);
+    return note;
+}
 function htmlEscape(message) {
     return message.replace('<', '&lt;').replace('>', '&gt;');
 }

package/build/src/factories/changelog-notes-factory.d.ts

@@ -1,6 +1,6 @@
 import { GitHub } from '../github';
 import { ChangelogNotes, ChangelogSection } from '../changelog-notes';
-export declare type ChangelogNotesType = string;
+export type ChangelogNotesType = string;
 export interface ChangelogNotesFactoryOptions {
     type: ChangelogNotesType;
     github: GitHub;
@@ -9,7 +9,7 @@ export interface ChangelogNotesFactoryOptions {
     headerPartial?: string;
     mainTemplate?: string;
 }
-export declare type ChangelogNotesBuilder = (options: ChangelogNotesFactoryOptions) => ChangelogNotes;
+export type ChangelogNotesBuilder = (options: ChangelogNotesFactoryOptions) => ChangelogNotes;
 export declare function buildChangelogNotes(options: ChangelogNotesFactoryOptions): ChangelogNotes;
 export declare function registerChangelogNotes(name: string, changelogNotesBuilder: ChangelogNotesBuilder): void;
 export declare function unregisterChangelogNotes(name: string): void;

package/build/src/factories/plugin-factory.d.ts

@@ -14,7 +14,7 @@ export interface PluginFactoryOptions {
     considerAllArtifacts?: boolean;
     logger?: Logger;
 }
-export declare type PluginBuilder = (options: PluginFactoryOptions) => ManifestPlugin;
+export type PluginBuilder = (options: PluginFactoryOptions) => ManifestPlugin;
 export declare function buildPlugin(options: PluginFactoryOptions): ManifestPlugin;
 export declare function registerPlugin(name: string, pluginBuilder: PluginBuilder): void;
 export declare function unregisterPlugin(name: string): void;

package/build/src/factories/versioning-strategy-factory.d.ts

@@ -1,13 +1,13 @@
 import { VersioningStrategy } from '../versioning-strategy';
 import { GitHub } from '../github';
-export declare type VersioningStrategyType = string;
+export type VersioningStrategyType = string;
 export interface VersioningStrategyFactoryOptions {
     type?: VersioningStrategyType;
     bumpMinorPreMajor?: boolean;
     bumpPatchForMinorPreMajor?: boolean;
     github: GitHub;
 }
-export declare type VersioningStrategyBuilder = (options: VersioningStrategyFactoryOptions) => VersioningStrategy;
+export type VersioningStrategyBuilder = (options: VersioningStrategyFactoryOptions) => VersioningStrategy;
 export declare function buildVersioningStrategy(options: VersioningStrategyFactoryOptions): VersioningStrategy;
 export declare function registerVersioningStrategy(name: string, versioningStrategyBuilder: VersioningStrategyBuilder): void;
 export declare function unregisterVersioningStrategy(name: string): void;

package/build/src/factory.d.ts

@@ -5,8 +5,8 @@ import { BaseStrategyOptions } from './strategies/base';
 export * from './factories/changelog-notes-factory';
 export * from './factories/plugin-factory';
 export * from './factories/versioning-strategy-factory';
-export declare type ReleaseType = string;
-export declare type ReleaseBuilder = (options: BaseStrategyOptions) => Strategy;
+export type ReleaseType = string;
+export type ReleaseBuilder = (options: BaseStrategyOptions) => Strategy;
 export interface StrategyFactoryOptions extends ReleaserConfig {
     github: GitHub;
     path?: string;

package/build/src/github.d.ts

@@ -4,7 +4,7 @@ import { Octokit } from '@octokit/rest';
 import { request } from '@octokit/request';
 export declare const GH_API_URL = "https://api.github.com";
 export declare const GH_GRAPHQL_URL = "https://api.github.com";
-declare type OctokitType = InstanceType<typeof Octokit>;
+type OctokitType = InstanceType<typeof Octokit>;
 import { Repository } from './repository';
 import { ReleasePullRequest } from './release-pull-request';
 import { Update } from './update';
@@ -12,9 +12,9 @@ import { Release } from './release';
 import { GitHubFileContents } from '@google-automations/git-file-utils';
 import { Logger } from 'code-suggester/build/src/types';
 import { PullRequestOverflowHandler } from './util/pull-request-overflow-handler';
-declare type RequestBuilderType = typeof request;
-declare type DefaultFunctionType = RequestBuilderType['defaults'];
-declare type RequestFunctionType = ReturnType<DefaultFunctionType>;
+type RequestBuilderType = typeof request;
+type DefaultFunctionType = RequestBuilderType['defaults'];
+type RequestFunctionType = ReturnType<DefaultFunctionType>;
 export interface OctokitAPIs {
     graphql: Function;
     request: RequestFunctionType;
@@ -40,7 +40,7 @@ interface GitHubCreateOptions {
     logger?: Logger;
     proxy?: ProxyOption;
 }
-declare type CommitFilter = (commit: Commit) => boolean;
+type CommitFilter = (commit: Commit) => boolean;
 interface CommitIteratorOptions {
     maxResults?: number;
     backfillFiles?: boolean;
@@ -74,7 +74,7 @@ interface FileDiff {
     readonly content: string | null;
     readonly originalContent: string | null;
 }
-export declare type ChangeSet = Map<string, FileDiff>;
+export type ChangeSet = Map<string, FileDiff>;
 interface CreatePullRequestOptions {
     fork?: boolean;
     draft?: boolean;

package/build/src/manifest.d.ts

@@ -7,30 +7,30 @@ import { ReleasePullRequest } from './release-pull-request';
 import { ReleaseType, VersioningStrategyType, ChangelogNotesType } from './factory';
 import { Release } from './release';
 import { ManifestPlugin } from './plugin';
-declare type ExtraJsonFile = {
+type ExtraJsonFile = {
     type: 'json';
     path: string;
     jsonpath: string;
     glob?: boolean;
 };
-declare type ExtraYamlFile = {
+type ExtraYamlFile = {
     type: 'yaml';
     path: string;
     jsonpath: string;
     glob?: boolean;
 };
-declare type ExtraXmlFile = {
+type ExtraXmlFile = {
     type: 'xml';
     path: string;
     xpath: string;
     glob?: boolean;
 };
-declare type ExtraPomFile = {
+type ExtraPomFile = {
     type: 'pom';
     path: string;
     glob?: boolean;
 };
-export declare type ExtraFile = string | ExtraJsonFile | ExtraYamlFile | ExtraXmlFile | ExtraPomFile;
+export type ExtraFile = string | ExtraJsonFile | ExtraYamlFile | ExtraXmlFile | ExtraPomFile;
 /**
  * These are configurations provided to each strategy per-path.
  */
@@ -131,7 +131,7 @@ export interface ReleaserPackageConfig extends ReleaserConfigJson {
     component?: string;
     'changelog-path'?: string;
 }
-export declare type DirectPluginType = string;
+export type DirectPluginType = string;
 export interface ConfigurablePluginType {
     type: string;
 }
@@ -151,7 +151,7 @@ export interface WorkspacePluginConfig extends ConfigurablePluginType {
 export interface GroupPriorityPluginConfig extends ConfigurablePluginType {
     groups: string[];
 }
-export declare type PluginType = DirectPluginType | ConfigurablePluginType | GroupPriorityPluginConfig | LinkedVersionPluginConfig | SentenceCasePluginConfig | WorkspacePluginConfig;
+export type PluginType = DirectPluginType | ConfigurablePluginType | GroupPriorityPluginConfig | LinkedVersionPluginConfig | SentenceCasePluginConfig | WorkspacePluginConfig;
 /**
  * This is the schema of the manifest config json
  */
@@ -166,8 +166,8 @@ export interface ManifestConfig extends ReleaserConfigJson {
     'commit-search-depth'?: number;
     'sequential-calls'?: boolean;
 }
-export declare type ReleasedVersions = Record<string, Version>;
-export declare type RepositoryConfig = Record<string, ReleaserConfig>;
+export type ReleasedVersions = Record<string, Version>;
+export type RepositoryConfig = Record<string, ReleaserConfig>;
 export declare const DEFAULT_RELEASE_PLEASE_CONFIG = "release-please-config.json";
 export declare const DEFAULT_RELEASE_PLEASE_MANIFEST = ".release-please-manifest.json";
 export declare const ROOT_PROJECT_PATH = ".";

package/build/src/plugins/node-workspace.js

@@ -149,7 +149,7 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
         return existingCandidate;
     }
     newCandidate(pkg, updatedVersions) {
-        var _a;
+        var _a, _b;
         const graphPackage = (_a = this.packageGraph) === null || _a === void 0 ? void 0 : _a.get(pkg.name);
         if (!graphPackage) {
             throw new Error(`Could not find graph package for ${pkg.name}`);
@@ -164,8 +164,12 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
         for (const [depName, resolved] of graphPackage.localDependencies) {
             const depVersion = updatedVersions.get(depName);
             if (depVersion && resolved.type !== 'directory') {
-                updatedPackage.updateLocalDependency(resolved, depVersion.toString(), '^');
-                this.logger.info(`${pkg.name}.${depName} updated to ^${depVersion.toString()}`);
+                const currentVersion = (_b = this.combineDeps(pkg)) === null || _b === void 0 ? void 0 : _b[depName];
+                const prefix = currentVersion
+                    ? this.detectRangePrefix(currentVersion)
+                    : '';
+                updatedPackage.updateLocalDependency(resolved, depVersion.toString(), prefix);
+                this.logger.info(`${pkg.name}.${depName} updated to ${prefix}${depVersion.toString()}`);
             }
         }
         const dependencyNotes = getChangelogDepsNotes(pkg, updatedPackage);

package/build/src/plugins/workspace.d.ts

@@ -3,7 +3,7 @@ import { CandidateReleasePullRequest, RepositoryConfig } from '../manifest';
 import { Logger } from '../util/logger';
 import { VersionsMap, Version } from '../version';
 import { GitHub } from '../github';
-export declare type DependencyGraph<T> = Map<string, DependencyNode<T>>;
+export type DependencyGraph<T> = Map<string, DependencyNode<T>>;
 export interface DependencyNode<T> {
     deps: string[];
     value: T;

package/build/src/strategies/dart.js

@@ -20,6 +20,7 @@ const yaml = require("js-yaml");
 // pubspec
 const pubspec_yaml_1 = require("../updaters/dart/pubspec-yaml");
 const base_1 = require("./base");
+const errors_1 = require("../errors");
 class Dart extends base_1.BaseStrategy {
     async buildUpdates(options) {
         const updates = [];
@@ -54,7 +55,15 @@ class Dart extends base_1.BaseStrategy {
     }
     async getPubspecYmlContents() {
         if (!this.pubspecYmlContents) {
-            this.pubspecYmlContents = await this.github.getFileContentsOnBranch(this.addPath('pubspec.yaml'), this.targetBranch);
+            try {
+                this.pubspecYmlContents = await this.github.getFileContentsOnBranch(this.addPath('pubspec.yaml'), this.targetBranch);
+            }
+            catch (e) {
+                if (e instanceof errors_1.FileNotFoundError) {
+                    throw new errors_1.MissingRequiredFileError(this.addPath('pubspec.yaml'), Dart.name, `${this.repository.owner}/${this.repository.repo}`);
+                }
+                throw e;
+            }
         }
         return this.pubspecYmlContents;
     }

package/build/src/strategies/helm.js

@@ -20,6 +20,7 @@ const yaml = require("js-yaml");
 // helm
 const chart_yaml_1 = require("../updaters/helm/chart-yaml");
 const base_1 = require("./base");
+const errors_1 = require("../errors");
 class Helm extends base_1.BaseStrategy {
     async buildUpdates(options) {
         const updates = [];
@@ -54,7 +55,15 @@ class Helm extends base_1.BaseStrategy {
     }
     async getChartYmlContents() {
         if (!this.chartYmlContents) {
-            this.chartYmlContents = await this.github.getFileContents(this.addPath('Chart.yaml'));
+            try {
+                this.chartYmlContents = await this.github.getFileContents(this.addPath('Chart.yaml'));
+            }
+            catch (e) {
+                if (e instanceof errors_1.FileNotFoundError) {
+                    throw new errors_1.MissingRequiredFileError(this.addPath('Chart.yaml'), Helm.name, `${this.repository.owner}/${this.repository.repo}`);
+                }
+                throw e;
+            }
         }
         return this.chartYmlContents;
     }

package/build/src/updaters/rust/common.d.ts

@@ -34,7 +34,7 @@ export interface CargoDependency {
     path?: string;
     registry?: string;
 }
-export declare type DepKind = 'dependencies' | 'dev-dependencies' | 'build-dependencies';
+export type DepKind = 'dependencies' | 'dev-dependencies' | 'build-dependencies';
 /**
  * All possible dependency kinds for `CargoManifest`,
  * typed properly.

package/build/src/util/branch-name.js

@@ -31,7 +31,6 @@ function getAllResourceNames() {
     ];
 }
 class BranchName {
-    constructor(_branchName) { }
     static parse(branchName, logger = logger_1.logger) {
         try {
             const branchNameClass = getAllResourceNames().find(clazz => {
@@ -59,6 +58,7 @@ class BranchName {
     static ofComponentTargetBranch(component, targetBranch) {
         return new ComponentBranchName(`${RELEASE_PLEASE}--branches--${targetBranch}--components--${component}`);
     }
+    constructor(_branchName) { }
     static matches(_branchName) {
         return false;
     }

package/build/src/version.d.ts

@@ -31,4 +31,4 @@ export declare class Version {
      */
     toString(): string;
 }
-export declare type VersionsMap = Map<string, Version>;
+export type VersionsMap = Map<string, Version>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "14.17.0",
+  "version": "14.17.2",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",