release-please 14.14.0 → 14.15.1

package/CHANGELOG.md

@@ -4,6 +4,25 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [14.15.1](https://github.com/googleapis/release-please/compare/v14.15.0...v14.15.1) (2022-10-28)
+
+
+### Bug Fixes
+
+* **maven-workspace:** SNAPSHOT versions should not be included in the manifest ([#1727](https://github.com/googleapis/release-please/issues/1727)) ([d926c84](https://github.com/googleapis/release-please/commit/d926c840ec99de013a0b5cb198f9fb2700930cf7))
+
+## [14.15.0](https://github.com/googleapis/release-please/compare/v14.14.0...v14.15.0) (2022-10-27)
+
+
+### Features
+
+* **php-yoshi:** Add "misc" as trigger, hide "chore" ([#1725](https://github.com/googleapis/release-please/issues/1725)) ([f7a9d09](https://github.com/googleapis/release-please/commit/f7a9d091670f0a70a13a1b641fbc6d07ec000da2))
+
+
+### Bug Fixes
+
+* **deps:** Update dependency type-fest to v3 ([#1649](https://github.com/googleapis/release-please/issues/1649)) ([d3c3a3e](https://github.com/googleapis/release-please/commit/d3c3a3eae6557994ad244c0bdd79e1782971d2c1))
+
 ## [14.14.0](https://github.com/googleapis/release-please/compare/v14.13.2...v14.14.0) (2022-10-25)
 
 

package/build/src/plugins/maven-workspace.d.ts

@@ -63,6 +63,13 @@ export declare class MavenWorkspace extends WorkspacePlugin<MavenArtifact> {
         updatedPathVersions: VersionsMap;
     }>;
     protected buildGraph(allPackages: MavenArtifact[]): Promise<DependencyGraph<MavenArtifact>>;
+    /**
+     * Given a release version, determine if we should bump the manifest
+     * version as well. For maven artifacts, SNAPSHOT versions are not
+     * considered releases.
+     * @param {Version} version The release version
+     */
+    protected isReleaseVersion(version: Version): boolean;
     protected bumpVersion(artifact: MavenArtifact): Version;
     protected updateCandidate(existingCandidate: CandidateReleasePullRequest, artifact: MavenArtifact, updatedVersions: VersionsMap): CandidateReleasePullRequest;
     protected newCandidate(artifact: MavenArtifact, updatedVersions: VersionsMap): CandidateReleasePullRequest;

package/build/src/plugins/maven-workspace.js

@@ -155,7 +155,8 @@ class MavenWorkspace extends workspace_1.WorkspacePlugin {
                     this.logger.warn(`${pomUpdate.path} does not have cached contents`);
                 }
             }
-            if (candidate.pullRequest.version) {
+            if (candidate.pullRequest.version &&
+                this.isReleaseVersion(candidate.pullRequest.version)) {
                 updatedPathVersions.set(candidate.path, candidate.pullRequest.version);
             }
         }
@@ -176,7 +177,9 @@ class MavenWorkspace extends workspace_1.WorkspacePlugin {
                 else {
                     this.logger.debug(`version: ${version} forced bump`);
                     updatedVersions.set(packageName, version);
-                    updatedPathVersions.set(this.pathFromPackage(pkg), version);
+                    if (this.isReleaseVersion(version)) {
+                        updatedPathVersions.set(this.pathFromPackage(pkg), version);
+                    }
                 }
             }
         }
@@ -207,6 +210,16 @@ class MavenWorkspace extends workspace_1.WorkspacePlugin {
         }
         return graph;
     }
+    /**
+     * Given a release version, determine if we should bump the manifest
+     * version as well. For maven artifacts, SNAPSHOT versions are not
+     * considered releases.
+     * @param {Version} version The release version
+     */
+    isReleaseVersion(version) {
+        var _a;
+        return !((_a = version.preRelease) === null || _a === void 0 ? void 0 : _a.includes('SNAPSHOT'));
+    }
     bumpVersion(artifact) {
         const strategy = new java_snapshot_1.JavaSnapshot(new always_bump_patch_1.AlwaysBumpPatch());
         return strategy.bump(version_1.Version.parse(artifact.version), [FAKE_COMMIT]);

package/build/src/plugins/workspace.d.ts

@@ -74,6 +74,12 @@ export declare abstract class WorkspacePlugin<T> extends ManifestPlugin {
         updatedVersions: VersionsMap;
         updatedPathVersions: VersionsMap;
     }>;
+    /**
+     * Given a release version, determine if we should bump the manifest
+     * version as well.
+     * @param {Version} _version The release version
+     */
+    protected isReleaseVersion(_version: Version): boolean;
     /**
      * Given a package, return the new bumped version after updating
      * the dependency.

package/build/src/plugins/workspace.js

@@ -173,7 +173,9 @@ class WorkspacePlugin extends plugin_1.ManifestPlugin {
                 const version = this.bumpVersion(pkg);
                 this.logger.debug(`version: ${version} forced bump`);
                 updatedVersions.set(packageName, version);
-                updatedPathVersions.set(this.pathFromPackage(pkg), version);
+                if (this.isReleaseVersion(version)) {
+                    updatedPathVersions.set(this.pathFromPackage(pkg), version);
+                }
             }
         }
         return {
@@ -181,6 +183,14 @@ class WorkspacePlugin extends plugin_1.ManifestPlugin {
             updatedPathVersions,
         };
     }
+    /**
+     * Given a release version, determine if we should bump the manifest
+     * version as well.
+     * @param {Version} _version The release version
+     */
+    isReleaseVersion(_version) {
+        return true;
+    }
     /**
      * Helper to invert the graph from package => packages that it depends on
      * to package => packages that depend on it.

package/build/src/strategies/php-yoshi.js

@@ -34,7 +34,8 @@ const CHANGELOG_SECTIONS = [
     { type: 'perf', section: 'Performance Improvements' },
     { type: 'revert', section: 'Reverts' },
     { type: 'docs', section: 'Documentation' },
-    { type: 'chore', section: 'Miscellaneous Chores' },
+    { type: 'misc', section: 'Miscellaneous' },
+    { type: 'chore', section: 'Chores', hidden: true },
     { type: 'style', section: 'Styles', hidden: true },
     { type: 'refactor', section: 'Code Refactoring', hidden: true },
     { type: 'test', section: 'Tests', hidden: true },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "14.14.0",
+  "version": "14.15.1",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
@@ -95,7 +95,7 @@
     "node-html-parser": "^6.0.0",
     "parse-github-repo-url": "^1.4.1",
     "semver": "^7.0.0",
-    "type-fest": "^2.0.0",
+    "type-fest": "^3.0.0",
     "typescript": "^4.6.4",
     "unist-util-visit": "^2.0.3",
     "unist-util-visit-parents": "^3.1.1",