release-please 14.13.0 → 14.13.1

package/CHANGELOG.md

@@ -4,6 +4,13 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [14.13.1](https://github.com/googleapis/release-please/compare/v14.13.0...v14.13.1) (2022-10-14)
+
+
+### Bug Fixes
+
+* Updating a pull request uses overflow handler if body is too large ([#1702](https://github.com/googleapis/release-please/issues/1702)) ([f328511](https://github.com/googleapis/release-please/commit/f3285115a9c0e4a199f86038319bafd6d604d96a))
+
 ## [14.13.0](https://github.com/googleapis/release-please/compare/v14.12.0...v14.13.0) (2022-10-13)
 
 

package/README.md

@@ -12,6 +12,9 @@ It does so by parsing your
 git history, looking for [Conventional Commit messages](https://www.conventionalcommits.org/),
 and creating release PRs.
 
+It does not handle publication to package managers or handle complex branch
+management.
+
 ## What's a Release PR?
 
 Rather than continuously releasing what's landed to your default branch,

package/build/src/github.d.ts

@@ -11,6 +11,7 @@ import { Update } from './update';
 import { Release } from './release';
 import { GitHubFileContents } from '@google-automations/git-file-utils';
 import { Logger } from 'code-suggester/build/src/types';
+import { PullRequestOverflowHandler } from './util/pull-request-overflow-handler';
 declare type RequestBuilderType = typeof request;
 declare type DefaultFunctionType = RequestBuilderType['defaults'];
 declare type RequestFunctionType = ReturnType<DefaultFunctionType>;
@@ -319,11 +320,17 @@ export declare class GitHub {
      * Update a pull request's title and body.
      * @param {number} number The pull request number
      * @param {ReleasePullRequest} releasePullRequest Pull request data to update
-     * @param {}
+     * @param {string} targetBranch The target branch of the pull request
+     * @param {string} options.signoffUser Optional. Commit signoff message
+     * @param {boolean} options.fork Optional. Whether to open the pull request from
+     *   a fork or not. Defaults to `false`
+     * @param {PullRequestOverflowHandler} options.pullRequestOverflowHandler Optional.
+     *   Handles extra large pull request body messages.
      */
     updatePullRequest: (number: number, releasePullRequest: ReleasePullRequest, targetBranch: string, options?: {
         signoffUser?: string | undefined;
         fork?: boolean | undefined;
+        pullRequestOverflowHandler?: PullRequestOverflowHandler | undefined;
     } | undefined) => Promise<PullRequest>;
     /**
      * Given a set of proposed updates, build a changeset to suggest.

package/build/src/github.js

@@ -186,7 +186,12 @@ class GitHub {
          * Update a pull request's title and body.
          * @param {number} number The pull request number
          * @param {ReleasePullRequest} releasePullRequest Pull request data to update
-         * @param {}
+         * @param {string} targetBranch The target branch of the pull request
+         * @param {string} options.signoffUser Optional. Commit signoff message
+         * @param {boolean} options.fork Optional. Whether to open the pull request from
+         *   a fork or not. Defaults to `false`
+         * @param {PullRequestOverflowHandler} options.pullRequestOverflowHandler Optional.
+         *   Handles extra large pull request body messages.
          */
         this.updatePullRequest = wrapAsync(async (number, releasePullRequest, targetBranch, options) => {
             //  Update the files for the release if not already supplied
@@ -196,7 +201,9 @@ class GitHub {
                 message = (0, signoff_commit_message_1.signoffCommitMessage)(message, options.signoffUser);
             }
             const title = releasePullRequest.title.toString();
-            const body = releasePullRequest.body
+            const body = ((options === null || options === void 0 ? void 0 : options.pullRequestOverflowHandler)
+                ? await options.pullRequestOverflowHandler.handleOverflow(releasePullRequest)
+                : releasePullRequest.body)
                 .toString()
                 .slice(0, MAX_ISSUE_BODY_SIZE);
             const prNumber = await (0, code_suggester_1.createPullRequest)(this.octokit, changes, {

package/build/src/manifest.js

@@ -527,6 +527,7 @@ class Manifest {
         const updatedPullRequest = await this.github.updatePullRequest(existing.number, pullRequest, this.targetBranch, {
             fork: this.fork,
             signoffUser: this.signoffUser,
+            pullRequestOverflowHandler: this.pullRequestOverflowHandler,
         });
         return updatedPullRequest;
     }
@@ -540,6 +541,7 @@ class Manifest {
         const updatedPullRequest = await this.github.updatePullRequest(snoozed.number, pullRequest, this.targetBranch, {
             fork: this.fork,
             signoffUser: this.signoffUser,
+            pullRequestOverflowHandler: this.pullRequestOverflowHandler,
         });
         // TODO: consider leaving the snooze label
         await this.github.removeIssueLabels([exports.SNOOZE_LABEL], snoozed.number);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "14.13.0",
+  "version": "14.13.1",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",