release-please 13.9.0 → 13.10.2

package/CHANGELOG.md

@@ -4,6 +4,37 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [13.10.2](https://github.com/googleapis/release-please/compare/v13.10.1...v13.10.2) (2022-04-14)
+
+
+### Bug Fixes
+
+* **java:** snapshots should bump versionsMap versions ([#1386](https://github.com/googleapis/release-please/issues/1386)) ([558331c](https://github.com/googleapis/release-please/commit/558331c160a066daeda476438f6524bf958f8d41)), closes [#1381](https://github.com/googleapis/release-please/issues/1381)
+* **ruby-yoshi:** Remove bolded scope and fix link removal ([#1382](https://github.com/googleapis/release-please/issues/1382)) ([f6b3202](https://github.com/googleapis/release-please/commit/f6b32024998c4e414b723a4071166f253e95b1d2))
+
+### [13.10.1](https://github.com/googleapis/release-please/compare/v13.10.0...v13.10.1) (2022-04-13)
+
+
+### Bug Fixes
+
+* bump retries for pull request iterator from 1 to 3 ([#1377](https://github.com/googleapis/release-please/issues/1377)) ([b2b7ff8](https://github.com/googleapis/release-please/commit/b2b7ff8ce98714ac591857b194ba0d51d9c2a641)), closes [#1376](https://github.com/googleapis/release-please/issues/1376)
+* don't crash when pull request iterator GraphQL returns no response ([b2b7ff8](https://github.com/googleapis/release-please/commit/b2b7ff8ce98714ac591857b194ba0d51d9c2a641))
+* fixed maxResults check in tag and release iterators ([#1378](https://github.com/googleapis/release-please/issues/1378)) ([6492a86](https://github.com/googleapis/release-please/commit/6492a86c56bbbb9b85f96bdf7edba910f1d66fc0))
+* GraphQL retry now uses exponential backoff ([b2b7ff8](https://github.com/googleapis/release-please/commit/b2b7ff8ce98714ac591857b194ba0d51d9c2a641))
+
+## [13.10.0](https://github.com/googleapis/release-please/compare/v13.9.0...v13.10.0) (2022-04-12)
+
+
+### Features
+
+* enable overriding release-as ([ffa0f7c](https://github.com/googleapis/release-please/commit/ffa0f7c7b0d0d2b65ce6285b62802ac08951a43c))
+* support selecting a single path when releasing from a manifest ([#1362](https://github.com/googleapis/release-please/issues/1362)) ([ffa0f7c](https://github.com/googleapis/release-please/commit/ffa0f7c7b0d0d2b65ce6285b62802ac08951a43c))
+
+
+### Bug Fixes
+
+* **rust:** update Cargo.lock for single Rust crate ([#1374](https://github.com/googleapis/release-please/issues/1374)) ([e3571d3](https://github.com/googleapis/release-please/commit/e3571d32c44ae2bef8bac7dd8cdc3556a9d621c7))
+
 ## [13.9.0](https://github.com/googleapis/release-please/compare/v13.8.1...v13.9.0) (2022-04-12)
 
 

package/build/src/bin/release-please.js

@@ -290,7 +290,7 @@ const createReleasePullRequestCommand = {
         }
         else {
             const manifestOptions = extractManifestOptions(argv);
-            manifest = await manifest_1.Manifest.fromManifest(github, targetBranch, argv.configFile, argv.manifestFile, manifestOptions);
+            manifest = await manifest_1.Manifest.fromManifest(github, targetBranch, argv.configFile, argv.manifestFile, manifestOptions, argv.path, argv.releaseAs);
         }
         if (argv.dryRun) {
             const pullRequests = await manifest.buildPullRequests();

package/build/src/github.js

@@ -59,17 +59,30 @@ class GitHub {
             return files;
         });
         this.graphqlRequest = wrapAsync(async (opts, maxRetries = 1) => {
+            let seconds = 1;
             while (maxRetries >= 0) {
                 try {
-                    return await this.graphql(opts);
+                    const response = await this.graphql(opts);
+                    if (response) {
+                        return response;
+                    }
+                    logger_1.logger.trace('no GraphQL response, retrying');
                 }
                 catch (err) {
                     if (err.status !== 502) {
                         throw err;
                     }
+                    logger_1.logger.trace('received 502 error, retrying');
                 }
                 maxRetries -= 1;
+                if (maxRetries >= 0) {
+                    logger_1.logger.trace(`sleeping ${seconds} seconds`);
+                    await sleepInMs(1000 * seconds);
+                    seconds *= 2;
+                }
             }
+            logger_1.logger.trace('ran out of retries');
+            return undefined;
         });
         /**
          * Returns a list of paths to all files with a given name.
@@ -622,6 +635,7 @@ class GitHub {
      * @throws {GitHubAPIError} on an API error
      */
     async pullRequestsGraphQL(targetBranch, states = 'MERGED', cursor) {
+        var _a;
         logger_1.logger.debug(`Fetching ${states} pull requests on branch ${targetBranch} with cursor ${cursor}`);
         const response = await this.graphqlRequest({
             query: `query mergedPullRequests($owner: String!, $repo: String!, $num: Int!, $maxFilesChanged: Int, $targetBranch: String!, $states: [PullRequestState!], $cursor: String) {
@@ -665,8 +679,8 @@ class GitHub {
             targetBranch,
             states,
             maxFilesChanged: 64,
-        });
-        if (!response.repository.pullRequests) {
+        }, 3);
+        if (!((_a = response === null || response === void 0 ? void 0 : response.repository) === null || _a === void 0 ? void 0 : _a.pullRequests)) {
             logger_1.logger.warn(`Could not find merged pull requests for branch ${targetBranch} - it likely does not exist.`);
             return null;
         }
@@ -714,7 +728,7 @@ class GitHub {
                 }
                 yield response.data[i];
             }
-            if (!response.pageInfo.hasNextPage) {
+            if (results > maxResults || !response.pageInfo.hasNextPage) {
                 break;
             }
             cursor = response.pageInfo.endCursor;
@@ -799,6 +813,8 @@ class GitHub {
                     sha: tag.commit.sha,
                 };
             }
+            if (results > maxResults)
+                break;
         }
     }
     /**
@@ -975,4 +991,5 @@ const wrapAsync = (fn, errorHandler) => {
         }
     };
 };
+const sleepInMs = (ms) => new Promise(resolve => setTimeout(resolve, ms));
 //# sourceMappingURL=github.js.map

package/build/src/manifest.d.ts

@@ -192,9 +192,10 @@ export declare class Manifest {
      * @param {string} targetBranch The releaseable base branch
      * @param {string} configFile Optional. The path to the manifest config file
      * @param {string} manifestFile Optional. The path to the manifest versions file
+     * @param {string} path The single path to check. Optional
      * @returns {Manifest}
      */
-    static fromManifest(github: GitHub, targetBranch: string, configFile?: string, manifestFile?: string, manifestOptionOverrides?: ManifestOptions): Promise<Manifest>;
+    static fromManifest(github: GitHub, targetBranch: string, configFile?: string, manifestFile?: string, manifestOptionOverrides?: ManifestOptions, path?: string, releaseAs?: string): Promise<Manifest>;
     /**
      * Create a Manifest from explicit config in code. This assumes that the
      * repository has a single component at the root path.

package/build/src/manifest.js

@@ -91,11 +91,12 @@ class Manifest {
      * @param {string} targetBranch The releaseable base branch
      * @param {string} configFile Optional. The path to the manifest config file
      * @param {string} manifestFile Optional. The path to the manifest versions file
+     * @param {string} path The single path to check. Optional
      * @returns {Manifest}
      */
-    static async fromManifest(github, targetBranch, configFile = exports.DEFAULT_RELEASE_PLEASE_CONFIG, manifestFile = exports.DEFAULT_RELEASE_PLEASE_MANIFEST, manifestOptionOverrides = {}) {
+    static async fromManifest(github, targetBranch, configFile = exports.DEFAULT_RELEASE_PLEASE_CONFIG, manifestFile = exports.DEFAULT_RELEASE_PLEASE_MANIFEST, manifestOptionOverrides = {}, path, releaseAs) {
         const [{ config: repositoryConfig, options: manifestOptions }, releasedVersions,] = await Promise.all([
-            parseConfig(github, configFile, targetBranch),
+            parseConfig(github, configFile, targetBranch, path, releaseAs),
             parseReleasedVersions(github, manifestFile, targetBranch),
         ]);
         return new Manifest(github, targetBranch, repositoryConfig, releasedVersions, {
@@ -690,13 +691,20 @@ function extractReleaserConfig(config) {
  * @param {GitHub} github GitHub client
  * @param {string} configFile Path in the repository to the manifest config
  * @param {string} branch Branch to fetch the config file from
+ * @param {string} onlyPath Optional. Use only the given package
+ * @param {string} releaseAs Optional. Override release-as and use the given version
  */
-async function parseConfig(github, configFile, branch) {
+async function parseConfig(github, configFile, branch, onlyPath, releaseAs) {
     const config = await github.getFileJson(configFile, branch);
     const defaultConfig = extractReleaserConfig(config);
     const repositoryConfig = {};
     for (const path in config.packages) {
+        if (onlyPath && onlyPath !== path)
+            continue;
         repositoryConfig[path] = mergeReleaserConfig(defaultConfig, extractReleaserConfig(config.packages[path]));
+        if (releaseAs) {
+            repositoryConfig[path].releaseAs = releaseAs;
+        }
     }
     const configLabel = config['label'];
     const configReleaseLabel = config['release-label'];

package/build/src/strategies/base.js

@@ -204,14 +204,8 @@ class BaseStrategy {
         return changelogEntry.split('\n').length <= 1;
     }
     async updateVersionsMap(versionsMap, conventionalCommits, _newVersion) {
-        for (const versionKey of versionsMap.keys()) {
-            const version = versionsMap.get(versionKey);
-            if (!version) {
-                logger_1.logger.warn(`didn't find version for ${versionKey}`);
-                continue;
-            }
-            const newVersion = await this.versioningStrategy.bump(version, conventionalCommits);
-            versionsMap.set(versionKey, newVersion);
+        for (const [component, version] of versionsMap.entries()) {
+            versionsMap.set(component, await this.versioningStrategy.bump(version, conventionalCommits));
         }
         return versionsMap;
     }

package/build/src/strategies/java.js

@@ -70,6 +70,9 @@ class Java extends base_1.BaseStrategy {
             ? await this.snapshotVersioning.bump(latestRelease.tag.version, [])
             : this.initialReleaseVersion();
         const versionsMap = await this.buildVersionsMap([]);
+        for (const [component, version] of versionsMap.entries()) {
+            versionsMap.set(component, await this.snapshotVersioning.bump(version, []));
+        }
         const pullRequestTitle = pull_request_title_1.PullRequestTitle.ofComponentTargetBranchVersion(component || '', this.targetBranch, newVersion);
         const branchName = component
             ? branch_name_1.BranchName.ofComponentTargetBranch(component, this.targetBranch)

package/build/src/strategies/ruby-yoshi.js

@@ -82,8 +82,10 @@ class RubyYoshi extends base_1.BaseStrategy {
         return (releaseNotes
             // Remove links in version title line and standardize on h3
             .replace(/^###? \[([\d.]+)\]\([^)]*\)/gm, '### $1')
+            // Remove bolded scope from change lines
+            .replace(/^\* \*\*[\w-]+:\*\* /gm, '* ')
             // Remove PR and commit links from pull request title suffixes
-            .replace(/ \(\[#\d+\]\([^)]*\)\)( \(\[\w+\]\([^)]*\)\))?\s*$/gm, '')
+            .replace(/( \(\[(\w+|#\d+)\]\(https:\/\/github\.com\/[^)]*\)\))+\s*$/gm, '')
             // Standardize on h4 for change type subheaders
             .replace(/^### (Features|Bug Fixes|Documentation)$/gm, '#### $1')
             // Collapse 2 or more blank lines

package/build/src/strategies/rust.js

@@ -88,10 +88,16 @@ class Rust extends base_1.BaseStrategy {
             });
         }
         else {
-            const manifestPath = this.addPath('Cargo.toml');
-            logger_1.logger.info(`single crate found, updating ${manifestPath}`);
+            logger_1.logger.info('single crate found, updating Cargo.toml');
+            const packageName = await this.getDefaultPackageName();
+            if (packageName) {
+                versionsMap.set(packageName, version);
+            }
+            else {
+                logger_1.logger.warn('No crate package name found');
+            }
             updates.push({
-                path: manifestPath,
+                path: this.addPath('Cargo.toml'),
                 createIfMissing: false,
                 updater: new cargo_toml_1.CargoToml({
                     version,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.9.0",
+  "version": "13.10.2",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
@@ -59,7 +59,7 @@
     "gts": "^3.0.0",
     "mocha": "^9.0.0",
     "nock": "^13.0.0",
-    "sinon": "13.0.1",
+    "sinon": "13.0.2",
     "snap-shot-it": "^7.0.0"
   },
   "dependencies": {