release-please 13.8.0 → 13.8.1

package/CHANGELOG.md

@@ -4,6 +4,13 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [13.8.1](https://github.com/googleapis/release-please/compare/v13.8.0...v13.8.1) (2022-04-11)
+
+
+### Bug Fixes
+
+* Restore v12 changelog formatting for ruby-yoshi ([#1361](https://github.com/googleapis/release-please/issues/1361)) ([ff87c7d](https://github.com/googleapis/release-please/commit/ff87c7df00b652512641454ead34bb2cede2f67e))
+
 ## [13.8.0](https://github.com/googleapis/release-please/compare/v13.7.1...v13.8.0) (2022-03-31)
 
 

package/build/src/strategies/ruby-yoshi.d.ts

@@ -1,9 +1,9 @@
 import { BaseStrategy, BuildUpdatesOptions, BaseStrategyOptions } from './base';
-import { ConventionalCommit } from '../commit';
+import { ConventionalCommit, Commit } from '../commit';
 import { Update } from '../update';
 import { Release } from '../release';
+import { TagName } from '../util/tag-name';
 import { Version } from '../version';
-import { PullRequestBody } from '../util/pull-request-body';
 interface RubyYoshiStrategyOptions extends BaseStrategyOptions {
     versionFile?: string;
 }
@@ -12,6 +12,6 @@ export declare class RubyYoshi extends BaseStrategy {
     constructor(options: RubyYoshiStrategyOptions);
     protected buildUpdates(options: BuildUpdatesOptions): Promise<Update[]>;
     protected postProcessCommits(commits: ConventionalCommit[]): Promise<ConventionalCommit[]>;
-    protected buildPullRequestBody(component: string | undefined, newVersion: Version, releaseNotesBody: string, conventionalCommits: ConventionalCommit[], latestRelease?: Release): Promise<PullRequestBody>;
+    protected buildReleaseNotes(conventionalCommits: ConventionalCommit[], newVersion: Version, newVersionTag: TagName, latestRelease?: Release, commits?: Commit[]): Promise<string>;
 }
 export {};

package/build/src/strategies/ruby-yoshi.js

@@ -22,9 +22,6 @@ const version_rb_1 = require("../updaters/ruby/version-rb");
 const base_1 = require("./base");
 const fs_1 = require("fs");
 const path_1 = require("path");
-const manifest_1 = require("../manifest");
-const logger_1 = require("../util/logger");
-const pull_request_body_1 = require("../util/pull-request-body");
 const CHANGELOG_SECTIONS = [
     { type: 'feat', section: 'Features' },
     { type: 'fix', section: 'Bug Fixes' },
@@ -80,49 +77,17 @@ class RubyYoshi extends base_1.BaseStrategy {
         });
         return commits;
     }
-    async buildPullRequestBody(component, newVersion, releaseNotesBody, conventionalCommits, latestRelease) {
-        if (!latestRelease) {
-            return await super.buildPullRequestBody(component, newVersion, releaseNotesBody, conventionalCommits, latestRelease);
-        }
-        // summarize the commits that landed:
-        let summary = '### Commits since last release:\n\n';
-        const updatedFiles = {};
-        const repoUrl = `${this.repository.owner}/${this.repository.repo}`;
-        for (const commit of conventionalCommits) {
-            if (!commit.sha)
-                continue;
-            const splitMessage = commit.message.split('\n');
-            summary += `* [${splitMessage[0]}](https://github.com/${repoUrl}/commit/${commit.sha})\n`;
-            if (splitMessage.length > 2) {
-                summary = `${summary}<pre><code>${splitMessage
-                    .slice(1)
-                    .join('\n')}</code></pre>\n`;
-            }
-            if (commit.files === undefined) {
-                logger_1.logger.error('No files for commit - this is likely a bug.');
-                continue;
-            }
-            commit.files.forEach(file => {
-                if (this.path === manifest_1.ROOT_PROJECT_PATH || file.startsWith(this.path)) {
-                    updatedFiles[file] = true;
-                }
-            });
-        }
-        // summarize the files that changed:
-        summary = `${summary}\n### Files edited since last release:\n\n<pre><code>`;
-        Object.keys(updatedFiles).forEach(file => {
-            summary += `${file}\n`;
-        });
-        summary += `</code></pre>\n[Compare Changes](https://github.com/${repoUrl}/compare/${latestRelease.sha}...HEAD)\n`;
-        return new pull_request_body_1.PullRequestBody([
-            {
-                component,
-                version: newVersion,
-                notes: releaseNotesBody,
-            },
-        ], {
-            extra: summary,
-        });
+    async buildReleaseNotes(conventionalCommits, newVersion, newVersionTag, latestRelease, commits) {
+        const releaseNotes = await super.buildReleaseNotes(conventionalCommits, newVersion, newVersionTag, latestRelease, commits);
+        return (releaseNotes
+            // Remove links in version title line and standardize on h3
+            .replace(/^###? \[([\d.]+)\]\([^)]*\)/gm, '### $1')
+            // Remove PR and commit links from pull request title suffixes
+            .replace(/ \(\[#\d+\]\([^)]*\)\)( \(\[\w+\]\([^)]*\)\))?\s*$/gm, '')
+            // Standardize on h4 for change type subheaders
+            .replace(/^### (Features|Bug Fixes|Documentation)$/gm, '#### $1')
+            // Collapse 2 or more blank lines
+            .replace(/\n{3,}/g, '\n\n'));
     }
 }
 exports.RubyYoshi = RubyYoshi;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.8.0",
+  "version": "13.8.1",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",