release-please 13.8.0 → 13.10.0

package/CHANGELOG.md

@@ -4,6 +4,33 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [13.10.0](https://github.com/googleapis/release-please/compare/v13.9.0...v13.10.0) (2022-04-12)
+
+
+### Features
+
+* enable overriding release-as ([ffa0f7c](https://github.com/googleapis/release-please/commit/ffa0f7c7b0d0d2b65ce6285b62802ac08951a43c))
+* support selecting a single path when releasing from a manifest ([#1362](https://github.com/googleapis/release-please/issues/1362)) ([ffa0f7c](https://github.com/googleapis/release-please/commit/ffa0f7c7b0d0d2b65ce6285b62802ac08951a43c))
+
+
+### Bug Fixes
+
+* **rust:** update Cargo.lock for single Rust crate ([#1374](https://github.com/googleapis/release-please/issues/1374)) ([e3571d3](https://github.com/googleapis/release-please/commit/e3571d32c44ae2bef8bac7dd8cdc3556a9d621c7))
+
+## [13.9.0](https://github.com/googleapis/release-please/compare/v13.8.1...v13.9.0) (2022-04-12)
+
+
+### Features
+
+* added java strategy ([#1333](https://github.com/googleapis/release-please/issues/1333)) ([25f9c85](https://github.com/googleapis/release-please/commit/25f9c85a8472208a83dfd5cc4014c84adc3c771f))
+
+### [13.8.1](https://github.com/googleapis/release-please/compare/v13.8.0...v13.8.1) (2022-04-11)
+
+
+### Bug Fixes
+
+* Restore v12 changelog formatting for ruby-yoshi ([#1361](https://github.com/googleapis/release-please/issues/1361)) ([ff87c7d](https://github.com/googleapis/release-please/commit/ff87c7df00b652512641454ead34bb2cede2f67e))
+
 ## [13.8.0](https://github.com/googleapis/release-please/compare/v13.7.1...v13.8.0) (2022-03-31)
 
 

package/README.md

@@ -32,9 +32,10 @@ When the Release PR is merged, release-please takes the following steps:
 You can tell where the Release PR is its lifecycle by the status label on the
 PR itself:
 
-- `autorelease:pending` is the initial state of the Release PR before it is merged
-- `autorelease:tagged` means that the Release PR has been merged and the release has been tagged in GitHub
-- `autorelease:published` means that a GitHub release has been published based on the Release PR (_release-please does not automatically add this tag, but we recommend it as a convention for publication tooling_).
+- `autorelease: pending` is the initial state of the Release PR before it is merged
+- `autorelease: tagged` means that the Release PR has been merged and the release has been tagged in GitHub
+- `autorelease: snapshot` is special state for snapshot version bumps
+- `autorelease: published` means that a GitHub release has been published based on the Release PR (_release-please does not automatically add this tag, but we recommend it as a convention for publication tooling_).
 
 ## How should I write my commits?
 
@@ -112,7 +113,7 @@ commit message instead of the merged commit message.
 ## Release Please bot does not create a release PR. Why?
 
 Release Please creates a release pull request after it sees the default branch
-contains "releaseable units" since the last release.
+contains "releasable units" since the last release.
 A releasable unit is a commit to the branch with one of the following
 prefixes: "feat" and "fix". (A "chore" commit is not a releasable unit.)
 
@@ -123,13 +124,15 @@ Some languages have their specific releasable unit configuration. For example,
 
 Release Please automates releases for the following flavors of repositories:
 
-| release type            | description
-|-------------------|---------------------------------------------------------|
+| release type        | description |
+|---------------------|---------------------------------------------------------|
 | `dart`              | A repository with a pubspec.yaml and a CHANGELOG.md |
 | `elixir`            | A repository with a mix.exs and a CHANGELOG.md |
 | `go`                | A repository with a CHANGELOG.md |
 | `helm`              | A repository with a Chart.yaml and a CHANGELOG.md |
+| `java`              | [A strategy that generates SNAPSHOT version after each release](docs/java.md) |
 | `krm-blueprint`     | [A kpt package, with 1 or more KRM files and a CHANGELOG.md](https://github.com/GoogleCloudPlatform/blueprints/tree/main/catalog/project) |
+| `maven`             | [Strategy for Maven projects, generates SNAPSHOT version after each release and updates `pom.xml` automatically](docs/java.md) |
 | `node`              | [A Node.js repository, with a package.json and CHANGELOG.md](https://github.com/yargs/yargs) |
 | `ocaml`             | [An OCaml repository, containing 1 or more opam or esy files and a CHANGELOG.md](https://github.com/grain-lang/binaryen.ml) |
 | `php`               | A repository with a composer.json and a CHANGELOG.md |

package/build/src/bin/release-please.d.ts

@@ -41,6 +41,7 @@ interface ReleaseArgs {
     draft?: boolean;
     prerelease?: boolean;
     releaseLabel?: string;
+    snapshotLabel?: string;
     label?: string;
 }
 interface PullRequestArgs {

package/build/src/bin/release-please.js

@@ -91,6 +91,11 @@ function releaseOptions(yargs) {
         describe: 'set a pull request label other than "autorelease: tagged"',
         default: 'autorelease: tagged',
         type: 'string',
+    })
+        .option('snapshot-label', {
+        describe: 'set a java snapshot pull request label other than "autorelease: snapshot"',
+        default: 'autorelease: snapshot',
+        type: 'string',
     });
 }
 function pullRequestOptions(yargs) {
@@ -285,7 +290,7 @@ const createReleasePullRequestCommand = {
         }
         else {
             const manifestOptions = extractManifestOptions(argv);
-            manifest = await manifest_1.Manifest.fromManifest(github, targetBranch, argv.configFile, argv.manifestFile, manifestOptions);
+            manifest = await manifest_1.Manifest.fromManifest(github, targetBranch, argv.configFile, argv.manifestFile, manifestOptions, argv.path, argv.releaseAs);
         }
         if (argv.dryRun) {
             const pullRequests = await manifest.buildPullRequests();
@@ -505,6 +510,9 @@ function extractManifestOptions(argv) {
     if ('releaseLabel' in argv && argv.releaseLabel) {
         manifestOptions.releaseLabels = argv.releaseLabel.split(',');
     }
+    if ('snapshotLabel' in argv && argv.snapshotLabel) {
+        manifestOptions.snapshotLabels = argv.snapshotLabel.split(',');
+    }
     if ('signoff' in argv && argv.signoff) {
         manifestOptions.signoff = argv.signoff;
     }

package/build/src/factory.d.ts

@@ -3,7 +3,7 @@ import { GitHub } from './github';
 import { ReleaserConfig, PluginType, RepositoryConfig } from './manifest';
 import { ManifestPlugin } from './plugin';
 import { ChangelogNotes, ChangelogSection } from './changelog-notes';
-declare const allReleaseTypes: readonly ["dart", "dotnet-yoshi", "elixir", "go", "go-yoshi", "helm", "java-backport", "java-bom", "java-lts", "java-yoshi", "krm-blueprint", "node", "ocaml", "php", "php-yoshi", "python", "ruby", "ruby-yoshi", "rust", "simple", "terraform-module"];
+declare const allReleaseTypes: readonly ["dart", "dotnet-yoshi", "elixir", "go", "go-yoshi", "helm", "java", "java-backport", "java-bom", "java-lts", "java-yoshi", "krm-blueprint", "maven", "node", "ocaml", "php", "php-yoshi", "python", "ruby", "ruby-yoshi", "rust", "simple", "terraform-module"];
 export declare type ReleaseType = typeof allReleaseTypes[number];
 export declare function getReleaserTypes(): readonly ReleaseType[];
 export declare function getVersioningStrategyTypes(): readonly VersioningStrategyType[];

package/build/src/factory.js

@@ -41,6 +41,8 @@ const github_1 = require("./changelog-notes/github");
 const default_2 = require("./changelog-notes/default");
 const linked_versions_1 = require("./plugins/linked-versions");
 const dotnet_yoshi_1 = require("./strategies/dotnet-yoshi");
+const java_1 = require("./strategies/java");
+const maven_1 = require("./strategies/maven");
 // Factory shared by GitHub Action and CLI for creating Release PRs
 // and GitHub Releases:
 // add any new releasers you create to this type as well as the `releasers`
@@ -52,11 +54,13 @@ const allReleaseTypes = [
     'go',
     'go-yoshi',
     'helm',
+    'java',
     'java-backport',
     'java-bom',
     'java-lts',
     'java-yoshi',
     'krm-blueprint',
+    'maven',
     'node',
     'ocaml',
     'php',
@@ -72,7 +76,6 @@ const releasers = {
     'dotnet-yoshi': options => new dotnet_yoshi_1.DotnetYoshi(options),
     go: options => new go_1.Go(options),
     'go-yoshi': options => new go_yoshi_1.GoYoshi(options),
-    'java-yoshi': options => new java_yoshi_1.JavaYoshi(options),
     'krm-blueprint': options => new krm_blueprint_1.KRMBlueprint(options),
     node: options => new node_1.Node(options),
     ocaml: options => new ocaml_1.OCaml(options),
@@ -142,6 +145,24 @@ async function buildStrategy(options) {
                 versionFile: options.versionFile,
             });
         }
+        case 'java': {
+            return new java_1.Java({
+                ...strategyOptions,
+                snapshotLabels: options.snapshotLabels,
+            });
+        }
+        case 'maven': {
+            return new maven_1.Maven({
+                ...strategyOptions,
+                snapshotLabels: options.snapshotLabels,
+            });
+        }
+        case 'java-yoshi': {
+            return new java_yoshi_1.JavaYoshi({
+                ...strategyOptions,
+                snapshotLabels: options.snapshotLabels,
+            });
+        }
         case 'java-backport': {
             return new java_yoshi_1.JavaYoshi({
                 ...strategyOptions,

package/build/src/manifest.d.ts

@@ -15,7 +15,11 @@ declare type ExtraXmlFile = {
     path: string;
     xpath: string;
 };
-export declare type ExtraFile = string | ExtraJsonFile | ExtraXmlFile;
+declare type ExtraPomFile = {
+    type: 'pom';
+    path: string;
+};
+export declare type ExtraFile = string | ExtraJsonFile | ExtraXmlFile | ExtraPomFile;
 /**
  * These are configurations provided to each strategy per-path.
  */
@@ -40,6 +44,7 @@ export interface ReleaserConfig {
     changelogType?: ChangelogNotesType;
     versionFile?: string;
     extraFiles?: ExtraFile[];
+    snapshotLabels?: string[];
 }
 export interface CandidateReleasePullRequest {
     path: string;
@@ -71,6 +76,7 @@ interface ReleaserConfigJson {
     'tag-separator'?: string;
     'version-file'?: string;
     'extra-files'?: string[];
+    'snapshot-label'?: string;
 }
 export interface ManifestOptions {
     bootstrapSha?: string;
@@ -83,6 +89,7 @@ export interface ManifestOptions {
     manifestPath?: string;
     labels?: string[];
     releaseLabels?: string[];
+    snapshotLabels?: string[];
     draft?: boolean;
     prerelease?: boolean;
     draftPullRequest?: boolean;
@@ -117,6 +124,11 @@ export declare type RepositoryConfig = Record<string, ReleaserConfig>;
 export declare const DEFAULT_RELEASE_PLEASE_CONFIG = "release-please-config.json";
 export declare const DEFAULT_RELEASE_PLEASE_MANIFEST = ".release-please-manifest.json";
 export declare const ROOT_PROJECT_PATH = ".";
+export declare const DEFAULT_COMPONENT_NAME = "";
+export declare const DEFAULT_LABELS: string[];
+export declare const DEFAULT_RELEASE_LABELS: string[];
+export declare const DEFAULT_SNAPSHOT_LABELS: string[];
+export declare const SNOOZE_LABEL = "autorelease: snooze";
 export declare const MANIFEST_PULL_REQUEST_TITLE_PATTERN = "chore: release ${branch}";
 interface CreatedRelease extends GitHubRelease {
     path: string;
@@ -136,6 +148,7 @@ export declare class Manifest {
     private signoffUser?;
     private labels;
     private releaseLabels;
+    private snapshotLabels;
     private plugins;
     private _strategiesByPath?;
     private _pathsByComponent?;
@@ -179,9 +192,10 @@ export declare class Manifest {
      * @param {string} targetBranch The releaseable base branch
      * @param {string} configFile Optional. The path to the manifest config file
      * @param {string} manifestFile Optional. The path to the manifest versions file
+     * @param {string} path The single path to check. Optional
      * @returns {Manifest}
      */
-    static fromManifest(github: GitHub, targetBranch: string, configFile?: string, manifestFile?: string, manifestOptionOverrides?: ManifestOptions): Promise<Manifest>;
+    static fromManifest(github: GitHub, targetBranch: string, configFile?: string, manifestFile?: string, manifestOptionOverrides?: ManifestOptions, path?: string, releaseAs?: string): Promise<Manifest>;
     /**
      * Create a Manifest from explicit config in code. This assumes that the
      * repository has a single component at the root path.

package/build/src/manifest.js

@@ -13,7 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Manifest = exports.MANIFEST_PULL_REQUEST_TITLE_PATTERN = exports.ROOT_PROJECT_PATH = exports.DEFAULT_RELEASE_PLEASE_MANIFEST = exports.DEFAULT_RELEASE_PLEASE_CONFIG = void 0;
+exports.Manifest = exports.MANIFEST_PULL_REQUEST_TITLE_PATTERN = exports.SNOOZE_LABEL = exports.DEFAULT_SNAPSHOT_LABELS = exports.DEFAULT_RELEASE_LABELS = exports.DEFAULT_LABELS = exports.DEFAULT_COMPONENT_NAME = exports.ROOT_PROJECT_PATH = exports.DEFAULT_RELEASE_PLEASE_MANIFEST = exports.DEFAULT_RELEASE_PLEASE_CONFIG = void 0;
 const version_1 = require("./version");
 const logger_1 = require("./util/logger");
 const commit_split_1 = require("./util/commit-split");
@@ -28,10 +28,11 @@ const errors_1 = require("./errors");
 exports.DEFAULT_RELEASE_PLEASE_CONFIG = 'release-please-config.json';
 exports.DEFAULT_RELEASE_PLEASE_MANIFEST = '.release-please-manifest.json';
 exports.ROOT_PROJECT_PATH = '.';
-const DEFAULT_COMPONENT_NAME = '';
-const DEFAULT_LABELS = ['autorelease: pending'];
-const DEFAULT_RELEASE_LABELS = ['autorelease: tagged'];
-const SNOOZE_LABEL = 'autorelease: snooze';
+exports.DEFAULT_COMPONENT_NAME = '';
+exports.DEFAULT_LABELS = ['autorelease: pending'];
+exports.DEFAULT_RELEASE_LABELS = ['autorelease: tagged'];
+exports.DEFAULT_SNAPSHOT_LABELS = ['autorelease: snapshot'];
+exports.SNOOZE_LABEL = 'autorelease: snooze';
 exports.MANIFEST_PULL_REQUEST_TITLE_PATTERN = 'chore: release ${branch}';
 class Manifest {
     /**
@@ -73,8 +74,10 @@ class Manifest {
         this.fork = (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.fork) || false;
         this.signoffUser = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.signoff;
         this.releaseLabels =
-            (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.releaseLabels) || DEFAULT_RELEASE_LABELS;
-        this.labels = (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.labels) || DEFAULT_LABELS;
+            (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.releaseLabels) || exports.DEFAULT_RELEASE_LABELS;
+        this.labels = (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.labels) || exports.DEFAULT_LABELS;
+        this.snapshotLabels =
+            (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.snapshotLabels) || exports.DEFAULT_SNAPSHOT_LABELS;
         this.bootstrapSha = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.bootstrapSha;
         this.lastReleaseSha = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.lastReleaseSha;
         this.draft = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.draft;
@@ -88,11 +91,12 @@ class Manifest {
      * @param {string} targetBranch The releaseable base branch
      * @param {string} configFile Optional. The path to the manifest config file
      * @param {string} manifestFile Optional. The path to the manifest versions file
+     * @param {string} path The single path to check. Optional
      * @returns {Manifest}
      */
-    static async fromManifest(github, targetBranch, configFile = exports.DEFAULT_RELEASE_PLEASE_CONFIG, manifestFile = exports.DEFAULT_RELEASE_PLEASE_MANIFEST, manifestOptionOverrides = {}) {
+    static async fromManifest(github, targetBranch, configFile = exports.DEFAULT_RELEASE_PLEASE_CONFIG, manifestFile = exports.DEFAULT_RELEASE_PLEASE_MANIFEST, manifestOptionOverrides = {}, path, releaseAs) {
         const [{ config: repositoryConfig, options: manifestOptions }, releasedVersions,] = await Promise.all([
-            parseConfig(github, configFile, targetBranch),
+            parseConfig(github, configFile, targetBranch, path, releaseAs),
             parseReleasedVersions(github, manifestFile, targetBranch),
         ]);
         return new Manifest(github, targetBranch, repositoryConfig, releasedVersions, {
@@ -135,7 +139,7 @@ class Manifest {
         });
         const component = await strategy.getComponent();
         const releasedVersions = {};
-        const latestVersion = await latestReleaseVersion(github, targetBranch, config.includeComponentInTag ? component : '', config.pullRequestTitlePattern);
+        const latestVersion = await latestReleaseVersion(github, targetBranch, version => isPublishedVersion(strategy, version), config.includeComponentInTag ? component : '', config.pullRequestTitlePattern);
         if (latestVersion) {
             releasedVersions[path] = latestVersion;
         }
@@ -173,7 +177,7 @@ class Manifest {
                 logger_1.logger.warn(`Unable to parse release name: ${release.name}`);
                 continue;
             }
-            const component = tagName.component || DEFAULT_COMPONENT_NAME;
+            const component = tagName.component || exports.DEFAULT_COMPONENT_NAME;
             const path = pathsByComponent[component];
             if (!path) {
                 logger_1.logger.warn(`Found release tag with component '${component}', but not configured in manifest`);
@@ -321,7 +325,9 @@ class Manifest {
             const latestRelease = releasesByPath[path];
             const releasePullRequest = await strategy.buildReleasePullRequest(pathCommits, latestRelease, (_a = config.draftPullRequest) !== null && _a !== void 0 ? _a : this.draftPullRequest, this.labels);
             if (releasePullRequest) {
-                if (releasePullRequest.version) {
+                // Update manifest, but only for valid release version - this will skip SNAPSHOT from java strategy
+                if (releasePullRequest.version &&
+                    isPublishedVersion(strategy, releasePullRequest.version)) {
                     const versionsMap = new Map();
                     versionsMap.set(path, releasePullRequest.version);
                     releasePullRequest.updates.push({
@@ -415,7 +421,8 @@ class Manifest {
         const openPullRequests = [];
         const generator = this.github.pullRequestIterator(this.targetBranch, 'OPEN');
         for await (const openPullRequest of generator) {
-            if (hasAllLabels(this.labels, openPullRequest.labels) &&
+            if ((hasAllLabels(this.labels, openPullRequest.labels) ||
+                hasAllLabels(this.snapshotLabels, openPullRequest.labels)) &&
                 branch_name_1.BranchName.parse(openPullRequest.headBranchName) &&
                 pull_request_body_1.PullRequestBody.parse(openPullRequest.body)) {
                 openPullRequests.push(openPullRequest);
@@ -429,7 +436,7 @@ class Manifest {
         const snoozedPullRequests = [];
         const closedGenerator = this.github.pullRequestIterator(this.targetBranch, 'CLOSED');
         for await (const closedPullRequest of closedGenerator) {
-            if (hasAllLabels([SNOOZE_LABEL], closedPullRequest.labels) &&
+            if (hasAllLabels([exports.SNOOZE_LABEL], closedPullRequest.labels) &&
                 branch_name_1.BranchName.parse(closedPullRequest.headBranchName) &&
                 pull_request_body_1.PullRequestBody.parse(closedPullRequest.body)) {
                 snoozedPullRequests.push(closedPullRequest);
@@ -480,7 +487,7 @@ class Manifest {
             signoffUser: this.signoffUser,
         });
         // TODO: consider leaving the snooze label
-        await this.github.removeIssueLabels([SNOOZE_LABEL], snoozed.number);
+        await this.github.removeIssueLabels([exports.SNOOZE_LABEL], snoozed.number);
         return updatedPullRequest;
     }
     async *findMergedReleasePullRequests() {
@@ -684,16 +691,24 @@ function extractReleaserConfig(config) {
  * @param {GitHub} github GitHub client
  * @param {string} configFile Path in the repository to the manifest config
  * @param {string} branch Branch to fetch the config file from
+ * @param {string} onlyPath Optional. Use only the given package
+ * @param {string} releaseAs Optional. Override release-as and use the given version
  */
-async function parseConfig(github, configFile, branch) {
+async function parseConfig(github, configFile, branch, onlyPath, releaseAs) {
     const config = await github.getFileJson(configFile, branch);
     const defaultConfig = extractReleaserConfig(config);
     const repositoryConfig = {};
     for (const path in config.packages) {
+        if (onlyPath && onlyPath !== path)
+            continue;
         repositoryConfig[path] = mergeReleaserConfig(defaultConfig, extractReleaserConfig(config.packages[path]));
+        if (releaseAs) {
+            repositoryConfig[path].releaseAs = releaseAs;
+        }
     }
     const configLabel = config['label'];
     const configReleaseLabel = config['release-label'];
+    const configSnapshotLabel = config['snapshot-label'];
     const manifestOptions = {
         bootstrapSha: config['bootstrap-sha'],
         lastReleaseSha: config['last-release-sha'],
@@ -703,6 +718,7 @@ async function parseConfig(github, configFile, branch) {
         plugins: config['plugins'],
         labels: configLabel === undefined ? undefined : [configLabel],
         releaseLabels: configReleaseLabel === undefined ? undefined : [configReleaseLabel],
+        snapshotLabels: configSnapshotLabel === undefined ? undefined : [configSnapshotLabel],
     };
     return { config: repositoryConfig, options: manifestOptions };
 }
@@ -721,16 +737,22 @@ async function parseReleasedVersions(github, manifestFile, branch) {
     }
     return releasedVersions;
 }
+function isPublishedVersion(strategy, version) {
+    return strategy.isPublishedVersion
+        ? strategy.isPublishedVersion(version)
+        : true;
+}
 /**
  * Find the most recent matching release tag on the branch we're
  * configured for.
  *
- * @param {string} prefix - Limit the release to a specific component.
- * @param {boolean} preRelease - Whether or not to return pre-release
- *   versions. Defaults to false.
+ * @param github GitHub client instance.
+ * @param {string} targetBranch Name of the scanned branch.
+ * @param releaseFilter Validator function for release version. Used to filter-out SNAPSHOT releases for Java strategy.
+ * @param {string} prefix Limit the release to a specific component.
+ * @param pullRequestTitlePattern Configured PR title pattern.
  */
-async function latestReleaseVersion(github, targetBranch, prefix, pullRequestTitlePattern) {
-    var _a;
+async function latestReleaseVersion(github, targetBranch, releaseFilter, prefix, pullRequestTitlePattern) {
     const branchPrefix = prefix
         ? prefix.endsWith('-')
             ? prefix.replace(/-$/, '')
@@ -765,11 +787,7 @@ async function latestReleaseVersion(github, targetBranch, prefix, pullRequestTit
             continue;
         }
         const version = pullRequestTitle.getVersion();
-        if ((_a = version === null || version === void 0 ? void 0 : version.preRelease) === null || _a === void 0 ? void 0 : _a.includes('SNAPSHOT')) {
-            // FIXME, don't hardcode this
-            continue;
-        }
-        if (version) {
+        if (version && releaseFilter(version)) {
             logger_1.logger.debug(`Found latest release pull request: ${mergedPullRequest.number} version: ${version}`);
             candidateReleaseVersions.push(version);
             break;

package/build/src/strategies/base.d.ts

@@ -59,7 +59,7 @@ export declare abstract class BaseStrategy implements Strategy {
     private releaseAs?;
     protected includeComponentInTag: boolean;
     protected includeVInTag: boolean;
-    private pullRequestTitlePattern?;
+    readonly pullRequestTitlePattern?: string;
     readonly extraFiles: ExtraFile[];
     readonly changelogNotes: ChangelogNotes;
     protected changelogSections?: ChangelogSection[];
@@ -98,9 +98,9 @@ export declare abstract class BaseStrategy implements Strategy {
      *   open a pull request.
      */
     buildReleasePullRequest(commits: Commit[], latestRelease?: Release, draft?: boolean, labels?: string[]): Promise<ReleasePullRequest | undefined>;
-    private extraFileUpdates;
+    protected extraFileUpdates(version: Version, versionsMap: VersionsMap): Update[];
     protected changelogEmpty(changelogEntry: string): boolean;
-    protected updateVersionsMap(versionsMap: VersionsMap, conventionalCommits: ConventionalCommit[]): Promise<VersionsMap>;
+    protected updateVersionsMap(versionsMap: VersionsMap, conventionalCommits: ConventionalCommit[], _newVersion: Version): Promise<VersionsMap>;
     protected buildNewVersion(conventionalCommits: ConventionalCommit[], latestRelease?: Release): Promise<Version>;
     protected buildVersionsMap(_conventionalCommits: ConventionalCommit[]): Promise<VersionsMap>;
     protected parsePullRequestBody(pullRequestBody: string): Promise<PullRequestBody | undefined>;

package/build/src/strategies/base.js

@@ -28,6 +28,7 @@ const composite_1 = require("../updaters/composite");
 const generic_1 = require("../updaters/generic");
 const generic_json_1 = require("../updaters/generic-json");
 const generic_xml_1 = require("../updaters/generic-xml");
+const pom_xml_1 = require("../updaters/java/pom-xml");
 const DEFAULT_CHANGELOG_PATH = 'CHANGELOG.md';
 /**
  * A strategy is responsible for determining which files are
@@ -134,7 +135,7 @@ class BaseStrategy {
             return undefined;
         }
         const newVersion = await this.buildNewVersion(conventionalCommits, latestRelease);
-        const versionsMap = await this.updateVersionsMap(await this.buildVersionsMap(conventionalCommits), conventionalCommits);
+        const versionsMap = await this.updateVersionsMap(await this.buildVersionsMap(conventionalCommits), conventionalCommits, newVersion);
         const component = await this.getComponent();
         logger_1.logger.debug('component:', component);
         const newVersionTag = new tag_name_1.TagName(newVersion, this.includeComponentInTag ? component : undefined, this.tagSeparator, this.includeVInTag);
@@ -154,7 +155,7 @@ class BaseStrategy {
             versionsMap,
             latestVersion: latestRelease === null || latestRelease === void 0 ? void 0 : latestRelease.tag.version,
         });
-        const updatesWithExtras = composite_1.mergeUpdates(updates.concat(...this.extraFileUpdates(newVersion)));
+        const updatesWithExtras = composite_1.mergeUpdates(updates.concat(...this.extraFileUpdates(newVersion, versionsMap)));
         const pullRequestBody = await this.buildPullRequestBody(component, newVersion, releaseNotesBody, conventionalCommits, latestRelease);
         return {
             title: pullRequestTitle,
@@ -166,7 +167,7 @@ class BaseStrategy {
             draft: draft !== null && draft !== void 0 ? draft : false,
         };
     }
-    extraFileUpdates(version) {
+    extraFileUpdates(version, versionsMap) {
         return this.extraFiles.map(extraFile => {
             if (typeof extraFile === 'object') {
                 switch (extraFile.type) {
@@ -182,6 +183,12 @@ class BaseStrategy {
                             createIfMissing: false,
                             updater: new generic_xml_1.GenericXml(extraFile.xpath, version),
                         };
+                    case 'pom':
+                        return {
+                            path: this.addPath(extraFile.path),
+                            createIfMissing: false,
+                            updater: new pom_xml_1.PomXml(version),
+                        };
                     default:
                         throw new Error(`unsupported extraFile type: ${extraFile.type}`);
                 }
@@ -189,14 +196,14 @@ class BaseStrategy {
             return {
                 path: this.addPath(extraFile),
                 createIfMissing: false,
-                updater: new generic_1.Generic({ version }),
+                updater: new generic_1.Generic({ version, versionsMap }),
             };
         });
     }
     changelogEmpty(changelogEntry) {
         return changelogEntry.split('\n').length <= 1;
     }
-    async updateVersionsMap(versionsMap, conventionalCommits) {
+    async updateVersionsMap(versionsMap, conventionalCommits, _newVersion) {
         for (const versionKey of versionsMap.keys()) {
             const version = versionsMap.get(versionKey);
             if (!version) {

package/build/src/strategies/java-yoshi.d.ts

@@ -1,30 +1,20 @@
 import { Update } from '../update';
 import { Version, VersionsMap } from '../version';
-import { BaseStrategy, BuildUpdatesOptions, BaseStrategyOptions } from './base';
 import { GitHubFileContents } from '../util/file-cache';
-import { Commit, ConventionalCommit } from '../commit';
-import { Release } from '../release';
-import { ReleasePullRequest } from '../release-pull-request';
-interface JavaBuildUpdatesOption extends BuildUpdatesOptions {
-    isSnapshot?: boolean;
-}
-export declare class JavaYoshi extends BaseStrategy {
+import { ConventionalCommit } from '../commit';
+import { Java, JavaBuildUpdatesOption } from './java';
+export declare class JavaYoshi extends Java {
     private versionsContent?;
-    private snapshotVersioning;
-    constructor(options: BaseStrategyOptions);
-    buildReleasePullRequest(commits: Commit[], latestRelease?: Release, draft?: boolean, labels?: string[]): Promise<ReleasePullRequest | undefined>;
-    private buildSnapshotPullRequest;
     /**
      * Override this method to post process commits
      * @param {ConventionalCommit[]} commits parsed commits
      * @returns {ConventionalCommit[]} modified commits
      */
     protected postProcessCommits(commits: ConventionalCommit[]): Promise<ConventionalCommit[]>;
-    private needsSnapshot;
+    protected needsSnapshot(): Promise<boolean>;
     protected buildVersionsMap(): Promise<VersionsMap>;
     protected getVersionsContent(): Promise<GitHubFileContents>;
     protected buildUpdates(options: JavaBuildUpdatesOption): Promise<Update[]>;
     protected updateVersionsMap(versionsMap: VersionsMap, conventionalCommits: ConventionalCommit[]): Promise<VersionsMap>;
     protected initialReleaseVersion(): Version;
 }
-export {};

package/build/src/strategies/java-yoshi.js

@@ -16,92 +16,12 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.JavaYoshi = void 0;
 const versions_manifest_1 = require("../updaters/java/versions-manifest");
 const version_1 = require("../version");
-const java_update_1 = require("../updaters/java/java-update");
-const base_1 = require("./base");
 const changelog_1 = require("../updaters/changelog");
-const java_snapshot_1 = require("../versioning-strategies/java-snapshot");
 const errors_1 = require("../errors");
 const logger_1 = require("../util/logger");
-const pull_request_title_1 = require("../util/pull-request-title");
-const branch_name_1 = require("../util/branch-name");
-const pull_request_body_1 = require("../util/pull-request-body");
-const default_1 = require("../versioning-strategies/default");
-const java_add_snapshot_1 = require("../versioning-strategies/java-add-snapshot");
-const CHANGELOG_SECTIONS = [
-    { type: 'feat', section: 'Features' },
-    { type: 'fix', section: 'Bug Fixes' },
-    { type: 'perf', section: 'Performance Improvements' },
-    { type: 'deps', section: 'Dependencies' },
-    { type: 'revert', section: 'Reverts' },
-    { type: 'docs', section: 'Documentation' },
-    { type: 'style', section: 'Styles', hidden: true },
-    { type: 'chore', section: 'Miscellaneous Chores', hidden: true },
-    { type: 'refactor', section: 'Code Refactoring', hidden: true },
-    { type: 'test', section: 'Tests', hidden: true },
-    { type: 'build', section: 'Build System', hidden: true },
-    { type: 'ci', section: 'Continuous Integration', hidden: true },
-];
-class JavaYoshi extends base_1.BaseStrategy {
-    constructor(options) {
-        var _a;
-        options.changelogSections = (_a = options.changelogSections) !== null && _a !== void 0 ? _a : CHANGELOG_SECTIONS;
-        // wrap the configured versioning strategy with snapshotting
-        const parentVersioningStrategy = options.versioningStrategy || new default_1.DefaultVersioningStrategy();
-        options.versioningStrategy = new java_snapshot_1.JavaSnapshot(parentVersioningStrategy);
-        super(options);
-        this.snapshotVersioning = new java_add_snapshot_1.JavaAddSnapshot(parentVersioningStrategy);
-    }
-    async buildReleasePullRequest(commits, latestRelease, draft, labels = []) {
-        if (await this.needsSnapshot()) {
-            logger_1.logger.info('Repository needs a snapshot bump.');
-            return await this.buildSnapshotPullRequest(latestRelease);
-        }
-        logger_1.logger.info('No Java snapshot needed');
-        return await super.buildReleasePullRequest(commits, latestRelease, draft, labels);
-    }
-    async buildSnapshotPullRequest(latestRelease) {
-        const component = await this.getComponent();
-        const newVersion = latestRelease
-            ? await this.snapshotVersioning.bump(latestRelease.tag.version, [])
-            : this.initialReleaseVersion();
-        const versionsMap = await this.buildVersionsMap();
-        for (const versionKey of versionsMap.keys()) {
-            const version = versionsMap.get(versionKey);
-            if (!version) {
-                logger_1.logger.warn(`didn't find version for ${versionKey}`);
-                continue;
-            }
-            const newVersion = await this.snapshotVersioning.bump(version, []);
-            versionsMap.set(versionKey, newVersion);
-        }
-        const pullRequestTitle = pull_request_title_1.PullRequestTitle.ofComponentTargetBranchVersion(component || '', this.targetBranch, newVersion);
-        const branchName = component
-            ? branch_name_1.BranchName.ofComponentTargetBranch(component, this.targetBranch)
-            : branch_name_1.BranchName.ofTargetBranch(this.targetBranch);
-        const notes = '### Updating meta-information for bleeding-edge SNAPSHOT release.';
-        const pullRequestBody = new pull_request_body_1.PullRequestBody([
-            {
-                component,
-                version: newVersion,
-                notes,
-            },
-        ]);
-        const updates = await this.buildUpdates({
-            newVersion,
-            versionsMap,
-            changelogEntry: notes,
-            isSnapshot: true,
-        });
-        return {
-            title: pullRequestTitle,
-            body: pullRequestBody,
-            updates,
-            labels: [],
-            headRefName: branchName.toString(),
-            version: newVersion,
-            draft: false,
-        };
-    }
+const java_1 = require("./java");
+const java_update_1 = require("../updaters/java/java-update");
+class JavaYoshi extends java_1.Java {
     /**
      * Override this method to post process commits
      * @param {ConventionalCommit[]} commits parsed commits