release-please 13.4.9 → 13.4.10

package/CHANGELOG.md

@@ -4,6 +4,15 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [13.4.10](https://github.com/googleapis/release-please/compare/v13.4.9...v13.4.10) (2022-02-16)
+
+
+### Bug Fixes
+
+* **go-yoshi:** dynamically load list of ignored submodules for google-cloud-go ([#1291](https://github.com/googleapis/release-please/issues/1291)) ([36f6ad9](https://github.com/googleapis/release-please/commit/36f6ad94fe471e5a46cc46ebd6f5b5c581a29c2c))
+* manifest release can handle componentless entry ([#1300](https://github.com/googleapis/release-please/issues/1300)) ([6b58573](https://github.com/googleapis/release-please/commit/6b585734fe7b49f0e351b73b27260a304d6c80dd))
+* return uploadUrl and body when creating release ([#1298](https://github.com/googleapis/release-please/issues/1298)) ([5d767c5](https://github.com/googleapis/release-please/commit/5d767c536594a8e24d274a4268cda1f1aa3babff))
+
 ### [13.4.9](https://github.com/googleapis/release-please/compare/v13.4.8...v13.4.9) (2022-02-14)
 
 

package/build/src/github.d.ts

@@ -57,6 +57,7 @@ export interface GitHubRelease {
     notes?: string;
     url: string;
     draft?: boolean;
+    uploadUrl?: string;
 }
 export interface GitHubTag {
     name: string;

package/build/src/github.js

@@ -324,9 +324,13 @@ class GitHub {
                 name: resp.data.name || undefined,
                 tagName: resp.data.tag_name,
                 sha: resp.data.target_commitish,
-                notes: resp.data.body_text,
+                notes: resp.data.body_text ||
+                    resp.data.body ||
+                    resp.data.body_html ||
+                    undefined,
                 url: resp.data.html_url,
                 draft: resp.data.draft,
+                uploadUrl: resp.data.upload_url,
             };
         }, e => {
             if (e instanceof request_error_1.RequestError) {

package/build/src/strategies/go-yoshi.d.ts

@@ -8,6 +8,7 @@ export declare class GoYoshi extends BaseStrategy {
     constructor(options: BaseStrategyOptions);
     protected buildUpdates(options: BuildUpdatesOptions): Promise<Update[]>;
     protected postProcessCommits(commits: ConventionalCommit[]): Promise<ConventionalCommit[]>;
+    getIgnoredSubModules(): Promise<Set<string>>;
     protected buildReleaseNotes(conventionalCommits: ConventionalCommit[], newVersion: Version, newVersionTag: TagName, latestRelease?: Release): Promise<string>;
     protected initialReleaseVersion(): Version;
 }

package/build/src/strategies/go-yoshi.js

@@ -19,19 +19,7 @@ const changelog_1 = require("../updaters/changelog");
 const version_1 = require("../version");
 const version_go_1 = require("../updaters/go/version-go");
 const logger_1 = require("../util/logger");
-// Commits containing a scope prefixed with an item in this array will be
-// ignored when generating a release PR for the parent module.
-const IGNORED_SUB_MODULES = new Set([
-    'bigtable',
-    'bigquery',
-    'datastore',
-    'firestore',
-    'logging',
-    'pubsub',
-    'pubsublite',
-    'spanner',
-    'storage',
-]);
+const path_1 = require("path");
 const REGEN_PR_REGEX = /.*auto-regenerate.*/;
 const REGEN_ISSUE_REGEX = /(?<prefix>.*)\(#(?<pr>.*)\)(\n|$)/;
 class GoYoshi extends base_1.BaseStrategy {
@@ -64,6 +52,7 @@ class GoYoshi extends base_1.BaseStrategy {
         let regenCommit;
         const component = await this.getComponent();
         logger_1.logger.debug('Filtering commits');
+        const ignoredSubmodules = await this.getIgnoredSubModules();
         return commits.filter(commit => {
             var _a, _b;
             // Only have a single entry of the nightly regen listed in the changelog.
@@ -119,7 +108,7 @@ class GoYoshi extends base_1.BaseStrategy {
                 else {
                     // This is the main module release, so ignore sub modules that
                     // are released independently
-                    for (const submodule of IGNORED_SUB_MODULES) {
+                    for (const submodule of ignoredSubmodules) {
                         if (commitMatchesScope(commit.scope, submodule)) {
                             logger_1.logger.debug(`Skipping ignored commit scope: ${commit.scope}`);
                             return false;
@@ -130,6 +119,22 @@ class GoYoshi extends base_1.BaseStrategy {
             return true;
         });
     }
+    async getIgnoredSubModules() {
+        // ignored submodules only applies to the root component of
+        // googleapis/google-cloud-go
+        if (this.repository.owner !== 'googleapis' ||
+            this.repository.repo !== 'google-cloud-go' ||
+            this.includeComponentInTag) {
+            return new Set();
+        }
+        logger_1.logger.info('Looking for go.mod files');
+        const paths = (await this.github.findFilesByFilenameAndRef('go.mod', this.targetBranch))
+            .filter(path => !path.includes('internal') && path !== 'go.mod')
+            .map(path => path_1.dirname(path));
+        logger_1.logger.info(`Found ${paths.length} submodules`);
+        logger_1.logger.debug(JSON.stringify(paths));
+        return new Set(paths);
+    }
     // "closes" is a little presumptuous, let's just indicate that the
     // PR references these other commits:
     async buildReleaseNotes(conventionalCommits, newVersion, newVersionTag, latestRelease) {

package/build/src/util/pull-request-body.js

@@ -52,7 +52,7 @@ class PullRequestBody {
             return this.releaseData
                 .map(release => {
                 var _a;
-                return `<details><summary>${release.component}: ${(_a = release.version) === null || _a === void 0 ? void 0 : _a.toString()}</summary>\n\n${release.notes}\n</details>`;
+                return `<details><summary>${release.component ? `${release.component}: ` : ''}${(_a = release.version) === null || _a === void 0 ? void 0 : _a.toString()}</summary>\n\n${release.notes}\n</details>`;
             })
                 .join('\n\n');
         }
@@ -91,6 +91,7 @@ function splitBody(body) {
     };
 }
 const SUMMARY_PATTERN = /^(?<component>.*[^:]):? (?<version>\d+\.\d+\.\d+.*)$/;
+const COMPONENTLESS_SUMMARY_PATTERN = /^(?<version>\d+\.\d+\.\d+.*)$/;
 function extractMultipleReleases(notes) {
     const data = [];
     const root = node_html_parser_1.parse(notes);
@@ -98,17 +99,28 @@ function extractMultipleReleases(notes) {
         const summaryNode = detail.getElementsByTagName('summary')[0];
         const summary = summaryNode === null || summaryNode === void 0 ? void 0 : summaryNode.textContent;
         const match = summary.match(SUMMARY_PATTERN);
-        if (!(match === null || match === void 0 ? void 0 : match.groups)) {
-            logger_1.logger.warn(`Summary: ${summary} did not match the expected pattern`);
-            continue;
+        if (match === null || match === void 0 ? void 0 : match.groups) {
+            detail.removeChild(summaryNode);
+            const notes = detail.textContent.trim();
+            data.push({
+                component: match.groups.component,
+                version: version_1.Version.parse(match.groups.version),
+                notes,
+            });
+        }
+        else {
+            const componentlessMatch = summary.match(COMPONENTLESS_SUMMARY_PATTERN);
+            if (!(componentlessMatch === null || componentlessMatch === void 0 ? void 0 : componentlessMatch.groups)) {
+                logger_1.logger.warn(`Summary: ${summary} did not match the expected pattern`);
+                continue;
+            }
+            detail.removeChild(summaryNode);
+            const notes = detail.textContent.trim();
+            data.push({
+                version: version_1.Version.parse(componentlessMatch.groups.version),
+                notes,
+            });
         }
-        detail.removeChild(summaryNode);
-        const notes = detail.textContent.trim();
-        data.push({
-            component: match.groups.component,
-            version: version_1.Version.parse(match.groups.version),
-            notes,
-        });
     }
     return data;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.4.9",
+  "version": "13.4.10",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",