release-please 13.4.12 → 13.4.15

package/CHANGELOG.md

@@ -4,6 +4,27 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [13.4.15](https://github.com/googleapis/release-please/compare/v13.4.14...v13.4.15) (2022-03-02)
+
+
+### Bug Fixes
+
+* tagging many GitHub releases should not require a file touched check ([#1321](https://github.com/googleapis/release-please/issues/1321)) ([ab99242](https://github.com/googleapis/release-please/commit/ab9924215e68838e6ec62d283b5712cbff6e6a4c))
+
+### [13.4.14](https://github.com/googleapis/release-please/compare/v13.4.13...v13.4.14) (2022-03-01)
+
+
+### Bug Fixes
+
+* node-workspace plugin should update package.json versions ([#1319](https://github.com/googleapis/release-please/issues/1319)) ([e2aaacb](https://github.com/googleapis/release-please/commit/e2aaacbab59c7660abe572c5e6ce31ad666a90c5))
+
+### [13.4.13](https://github.com/googleapis/release-please/compare/v13.4.12...v13.4.13) (2022-02-28)
+
+
+### Bug Fixes
+
+* handle failures during multiple release creation ([#1315](https://github.com/googleapis/release-please/issues/1315)) ([fc856ae](https://github.com/googleapis/release-please/commit/fc856aed1d95def38170eff6381829cd6d7d1e0b))
+
 ### [13.4.12](https://github.com/googleapis/release-please/compare/v13.4.11...v13.4.12) (2022-02-22)
 
 

package/README.md

@@ -109,6 +109,16 @@ END_COMMIT_OVERRIDE
 The next time release please runs, it will use that override section as the
 commit message instead of the merged commit message.
 
+## Release Please bot does not create a release PR. Why?
+
+Release Please creates a release pull request after it sees the default branch
+contains "releaseable units" since the last release.
+A releasable unit is a commit to the branch with one of the following
+prefixes: "feat" and "fix". (A "chore" commit is not a releasable unit.)
+
+Some languages have their specific releasable unit configuration. For example,
+"docs" is a prefix for releasable units in Java and Python.
+
 ## Strategy (Language) types supported
 
 Release Please automates releases for the following flavors of repositories:

package/build/src/bin/release-please.js

@@ -332,7 +332,18 @@ const createReleaseCommand = {
         }
         if (argv.dryRun) {
             const releases = await manifest.buildReleases();
-            logger_1.logger.info(releases);
+            logger_1.logger.info(`Would tag ${releases.length} releases:`);
+            for (const release of releases) {
+                logger_1.logger.info({
+                    name: release.name,
+                    tag: release.tag.toString(),
+                    notes: release.notes,
+                    sha: release.sha,
+                    draft: release.draft,
+                    prerelease: release.prerelease,
+                    pullNumber: release.pullRequest.number,
+                });
+            }
         }
         else {
             const releaseNumbers = await manifest.createReleases();

package/build/src/manifest.js

@@ -24,6 +24,7 @@ const factory_1 = require("./factory");
 const pull_request_body_1 = require("./util/pull-request-body");
 const merge_1 = require("./plugins/merge");
 const release_please_manifest_1 = require("./updaters/release-please-manifest");
+const errors_1 = require("./errors");
 exports.DEFAULT_RELEASE_PLEASE_CONFIG = 'release-please-config.json';
 exports.DEFAULT_RELEASE_PLEASE_MANIFEST = '.release-please-manifest.json';
 exports.ROOT_PROJECT_PATH = '.';
@@ -453,29 +454,11 @@ class Manifest {
         const generator = await this.findMergedReleasePullRequests();
         const releases = [];
         for await (const pullRequest of generator) {
-            logger_1.logger.info('Looking at files touched by path');
-            const cs = new commit_split_1.CommitSplit({
-                includeEmpty: true,
-                packagePaths: Object.keys(this.repositoryConfig),
-            });
-            const commits = [
-                {
-                    sha: pullRequest.sha,
-                    message: pullRequest.title,
-                    files: pullRequest.files,
-                },
-            ];
-            const commitsPerPath = cs.split(commits);
             for (const path in this.repositoryConfig) {
                 const config = this.repositoryConfig[path];
                 logger_1.logger.info(`Building release for path: ${path}`);
                 logger_1.logger.debug(`type: ${config.releaseType}`);
                 logger_1.logger.debug(`targetBranch: ${this.targetBranch}`);
-                const pathCommits = path === exports.ROOT_PROJECT_PATH ? commits : commitsPerPath[path];
-                if (!pathCommits || pathCommits.length === 0) {
-                    logger_1.logger.info(`No commits for path: ${path}, skipping`);
-                    continue;
-                }
                 const strategy = strategiesByPath[path];
                 const release = await strategy.buildRelease(pullRequest);
                 if (release) {
@@ -489,6 +472,9 @@ class Manifest {
                                 release.tag.version.major === 0),
                     });
                 }
+                else {
+                    logger_1.logger.info(`No release necessary for path: ${path}`);
+                }
             }
         }
         return releases;
@@ -525,7 +511,25 @@ class Manifest {
         for (const release of releases) {
             promises.push(this.createRelease(release));
         }
-        const githubReleases = await Promise.all(promises);
+        const duplicateReleases = [];
+        const githubReleases = [];
+        for (const promise of promises) {
+            try {
+                githubReleases.push(await promise);
+            }
+            catch (err) {
+                if (err instanceof errors_1.DuplicateReleaseError) {
+                    logger_1.logger.warn(`Duplicate release tag: ${err.tag}`);
+                    duplicateReleases.push(err);
+                }
+                else {
+                    throw err;
+                }
+            }
+        }
+        if (duplicateReleases.length > 0 && githubReleases.length === 0) {
+            throw duplicateReleases[0];
+        }
         // adjust tags on pullRequest
         await Promise.all([
             this.github.removeIssueLabels(this.labels, pullRequest.number),

package/build/src/plugins/node-workspace.js

@@ -102,6 +102,13 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
             throw new Error(`Could not find graph package for ${pkg.name}`);
         }
         const updatedPackage = pkg.clone();
+        // Update version of the package
+        const newVersion = updatedVersions.get(updatedPackage.name);
+        if (newVersion) {
+            logger_1.logger.info(`Updating ${updatedPackage.name} to ${newVersion}`);
+            updatedPackage.version = newVersion.toString();
+        }
+        // Update dependency versions
         for (const [depName, resolved] of graphPackage.localDependencies) {
             const depVersion = updatedVersions.get(depName);
             if (depVersion && resolved.type !== 'directory') {
@@ -116,7 +123,10 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
                     update.updater = new raw_content_1.RawContent(json_stringify_1.jsonStringify(updatedPackage.toJSON(), updatedPackage.rawContent));
                 }
                 else if (update.updater instanceof changelog_1.Changelog) {
-                    update.updater.changelogEntry = appendDependenciesSectionToChangelog(update.updater.changelogEntry, dependencyNotes);
+                    if (dependencyNotes) {
+                        update.updater.changelogEntry =
+                            appendDependenciesSectionToChangelog(update.updater.changelogEntry, dependencyNotes);
+                    }
                 }
                 return update;
             });
@@ -143,6 +153,12 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
             throw new Error(`Could not find graph package for ${pkg.name}`);
         }
         const updatedPackage = pkg.clone();
+        // Update version of the package
+        const newVersion = updatedVersions.get(updatedPackage.name);
+        if (newVersion) {
+            logger_1.logger.info(`Updating ${updatedPackage.name} to ${newVersion}`);
+            updatedPackage.version = newVersion.toString();
+        }
         for (const [depName, resolved] of graphPackage.localDependencies) {
             const depVersion = updatedVersions.get(depName);
             if (depVersion && resolved.type !== 'directory') {
@@ -173,7 +189,7 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
                     createIfMissing: false,
                     updater: new changelog_1.Changelog({
                         version,
-                        changelogEntry: dependencyNotes,
+                        changelogEntry: appendDependenciesSectionToChangelog('', dependencyNotes),
                     }),
                 },
             ],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.4.12",
+  "version": "13.4.15",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",