release-please 13.4.11 → 13.4.14

package/CHANGELOG.md

@@ -4,6 +4,29 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [13.4.14](https://github.com/googleapis/release-please/compare/v13.4.13...v13.4.14) (2022-03-01)
+
+
+### Bug Fixes
+
+* node-workspace plugin should update package.json versions ([#1319](https://github.com/googleapis/release-please/issues/1319)) ([e2aaacb](https://github.com/googleapis/release-please/commit/e2aaacbab59c7660abe572c5e6ce31ad666a90c5))
+
+### [13.4.13](https://github.com/googleapis/release-please/compare/v13.4.12...v13.4.13) (2022-02-28)
+
+
+### Bug Fixes
+
+* handle failures during multiple release creation ([#1315](https://github.com/googleapis/release-please/issues/1315)) ([fc856ae](https://github.com/googleapis/release-please/commit/fc856aed1d95def38170eff6381829cd6d7d1e0b))
+
+### [13.4.12](https://github.com/googleapis/release-please/compare/v13.4.11...v13.4.12) (2022-02-22)
+
+
+### Bug Fixes
+
+* address false-positive matches for autorelease branch naming ([#1311](https://github.com/googleapis/release-please/issues/1311)) ([c5e76dc](https://github.com/googleapis/release-please/commit/c5e76dc8202958ed5af0f3635188261b8845f561)), closes [#1310](https://github.com/googleapis/release-please/issues/1310)
+* catch FileNotFound error when building changeset ([#1306](https://github.com/googleapis/release-please/issues/1306)) ([3944b17](https://github.com/googleapis/release-please/commit/3944b17f33500cecc63a1ff63db81cdbd50ce1a1))
+* manifest config should allow overriding labels ([#1303](https://github.com/googleapis/release-please/issues/1303)) ([f4d0314](https://github.com/googleapis/release-please/commit/f4d0314d1a394389a233ba9e1383852f0875dcd1)), closes [#1302](https://github.com/googleapis/release-please/issues/1302)
+
 ### [13.4.11](https://github.com/googleapis/release-please/compare/v13.4.10...v13.4.11) (2022-02-18)
 
 

package/README.md

@@ -109,6 +109,16 @@ END_COMMIT_OVERRIDE
 The next time release please runs, it will use that override section as the
 commit message instead of the merged commit message.
 
+## Release Please bot does not create a release PR. Why?
+
+Release Please creates a release pull request after it sees the default branch
+contains "releaseable units" since the last release.
+A releasable unit is a commit to the branch with one of the following
+prefixes: "feat" and "fix". (A "chore" commit is not a releasable unit.)
+
+Some languages have their specific releasable unit configuration. For example,
+"docs" is a prefix for releasable units in Java and Python.
+
 ## Strategy (Language) types supported
 
 Release Please automates releases for the following flavors of repositories:

package/build/src/github.js

@@ -883,7 +883,7 @@ class GitHub {
                 content = await this.getFileContentsOnBranch(update.path, defaultBranch);
             }
             catch (err) {
-                if (err.status !== 404)
+                if (!(err instanceof errors_1.FileNotFoundError))
                     throw err;
                 // if the file is missing and create = false, just continue
                 // to the next update, otherwise create the file.

package/build/src/manifest.js

@@ -24,6 +24,7 @@ const factory_1 = require("./factory");
 const pull_request_body_1 = require("./util/pull-request-body");
 const merge_1 = require("./plugins/merge");
 const release_please_manifest_1 = require("./updaters/release-please-manifest");
+const errors_1 = require("./errors");
 exports.DEFAULT_RELEASE_PLEASE_CONFIG = 'release-please-config.json';
 exports.DEFAULT_RELEASE_PLEASE_MANIFEST = '.release-please-manifest.json';
 exports.ROOT_PROJECT_PATH = '.';
@@ -525,7 +526,25 @@ class Manifest {
         for (const release of releases) {
             promises.push(this.createRelease(release));
         }
-        const githubReleases = await Promise.all(promises);
+        const duplicateReleases = [];
+        const githubReleases = [];
+        for (const promise of promises) {
+            try {
+                githubReleases.push(await promise);
+            }
+            catch (err) {
+                if (err instanceof errors_1.DuplicateReleaseError) {
+                    logger_1.logger.warn(`Duplicate release tag: ${err.tag}`);
+                    duplicateReleases.push(err);
+                }
+                else {
+                    throw err;
+                }
+            }
+        }
+        if (duplicateReleases.length > 0 && githubReleases.length === 0) {
+            throw duplicateReleases[0];
+        }
         // adjust tags on pullRequest
         await Promise.all([
             this.github.removeIssueLabels(this.labels, pullRequest.number),
@@ -629,6 +648,8 @@ async function parseConfig(github, configFile, branch) {
     for (const path in config.packages) {
         repositoryConfig[path] = mergeReleaserConfig(defaultConfig, extractReleaserConfig(config.packages[path]));
     }
+    const configLabel = config['label'];
+    const configReleaseLabel = config['release-label'];
     const manifestOptions = {
         bootstrapSha: config['bootstrap-sha'],
         lastReleaseSha: config['last-release-sha'],
@@ -636,6 +657,8 @@ async function parseConfig(github, configFile, branch) {
         separatePullRequests: config['separate-pull-requests'],
         groupPullRequestTitlePattern: config['group-pull-request-title-pattern'],
         plugins: config['plugins'],
+        labels: configLabel === undefined ? undefined : [configLabel],
+        releaseLabels: configReleaseLabel === undefined ? undefined : [configReleaseLabel],
     };
     return { config: repositoryConfig, options: manifestOptions };
 }

package/build/src/plugins/node-workspace.js

@@ -102,6 +102,13 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
             throw new Error(`Could not find graph package for ${pkg.name}`);
         }
         const updatedPackage = pkg.clone();
+        // Update version of the package
+        const newVersion = updatedVersions.get(updatedPackage.name);
+        if (newVersion) {
+            logger_1.logger.info(`Updating ${updatedPackage.name} to ${newVersion}`);
+            updatedPackage.version = newVersion.toString();
+        }
+        // Update dependency versions
         for (const [depName, resolved] of graphPackage.localDependencies) {
             const depVersion = updatedVersions.get(depName);
             if (depVersion && resolved.type !== 'directory') {
@@ -116,7 +123,10 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
                     update.updater = new raw_content_1.RawContent(json_stringify_1.jsonStringify(updatedPackage.toJSON(), updatedPackage.rawContent));
                 }
                 else if (update.updater instanceof changelog_1.Changelog) {
-                    update.updater.changelogEntry = appendDependenciesSectionToChangelog(update.updater.changelogEntry, dependencyNotes);
+                    if (dependencyNotes) {
+                        update.updater.changelogEntry =
+                            appendDependenciesSectionToChangelog(update.updater.changelogEntry, dependencyNotes);
+                    }
                 }
                 return update;
             });
@@ -143,6 +153,12 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
             throw new Error(`Could not find graph package for ${pkg.name}`);
         }
         const updatedPackage = pkg.clone();
+        // Update version of the package
+        const newVersion = updatedVersions.get(updatedPackage.name);
+        if (newVersion) {
+            logger_1.logger.info(`Updating ${updatedPackage.name} to ${newVersion}`);
+            updatedPackage.version = newVersion.toString();
+        }
         for (const [depName, resolved] of graphPackage.localDependencies) {
             const depVersion = updatedVersions.get(depName);
             if (depVersion && resolved.type !== 'directory') {
@@ -173,7 +189,7 @@ class NodeWorkspace extends workspace_1.WorkspacePlugin {
                     createIfMissing: false,
                     updater: new changelog_1.Changelog({
                         version,
-                        changelogEntry: dependencyNotes,
+                        changelogEntry: appendDependenciesSectionToChangelog('', dependencyNotes),
                     }),
                 },
             ],

package/build/src/util/branch-name.js

@@ -82,8 +82,12 @@ exports.BranchName = BranchName;
  * @see https://github.com/googleapis/releasetool
  */
 const AUTORELEASE_PATTERN = /^release-?(?<component>[\w-.]*)?-v(?<version>[0-9].*)$/;
+const RELEASE_PLEASE_BRANCH_PREFIX = 'release-please--branches';
 class AutoreleaseBranchName extends BranchName {
     static matches(branchName) {
+        if (branchName.startsWith(RELEASE_PLEASE_BRANCH_PREFIX)) {
+            return false;
+        }
         return !!branchName.match(AUTORELEASE_PATTERN);
     }
     constructor(branchName) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.4.11",
+  "version": "13.4.14",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",