release-please 13.20.0 → 13.21.0

package/CHANGELOG.md

@@ -4,6 +4,18 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [13.21.0](https://github.com/googleapis/release-please/compare/v13.20.0...v13.21.0) (2022-08-11)
+
+
+### Features
+
+* parse versioning type from the manifest config ([#1572](https://github.com/googleapis/release-please/issues/1572)) ([8a7bfc1](https://github.com/googleapis/release-please/commit/8a7bfc165755cec97cc9a3baa39ccd21e719644c)), closes [#1569](https://github.com/googleapis/release-please/issues/1569)
+
+
+### Bug Fixes
+
+* throw underlying API error when the manifest fetch commits when determining the latest released version ([#1571](https://github.com/googleapis/release-please/issues/1571)) ([0944bde](https://github.com/googleapis/release-please/commit/0944bdeb04bcee2872e79a07fbe05967847caef0))
+
 ## [13.20.0](https://github.com/googleapis/release-please/compare/v13.19.9...v13.20.0) (2022-08-08)
 
 

package/README.md

@@ -115,11 +115,18 @@ commit message instead of the merged commit message.
 Release Please creates a release pull request after it notices the default branch
 contains "releasable units" since the last release.
 A releasable unit is a commit to the branch with one of the following
-prefixes: "feat" and "fix". (A "chore" commit is not a releasable unit.)
+prefixes: "feat", "fix", and "deps".
+(A "chore" or "build" commit is not a releasable unit.)
 
 Some languages have their specific releasable unit configuration. For example,
 "docs" is a prefix for releasable units in Java and Python.
 
+If you think Release Please missed to create a release PR after a pull request
+with with releasable unit has been merged, please re-run `release-please`. If you are using
+the GitHub application, add `release-please:force-run` label to the merged pull request. If
+you are using the action, look for the failed invocation and retry the workflow run.
+Release Please will process the pull request immediately to find releasable units.
+
 ## Strategy (Language) types supported
 
 Release Please automates releases for the following flavors of repositories:

package/build/src/github.d.ts

@@ -332,4 +332,5 @@ export declare class GitHub {
      */
     generateReleaseNotes(tagName: string, targetCommitish: string, previousTag?: string): Promise<string>;
 }
+export declare const sleepInMs: (ms: number) => Promise<unknown>;
 export {};

package/build/src/github.js

@@ -13,7 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.GitHub = exports.GH_GRAPHQL_URL = exports.GH_API_URL = void 0;
+exports.sleepInMs = exports.GitHub = exports.GH_GRAPHQL_URL = exports.GH_API_URL = void 0;
 const code_suggester_1 = require("code-suggester");
 const rest_1 = require("@octokit/rest");
 const request_1 = require("@octokit/request");
@@ -21,6 +21,7 @@ const graphql_1 = require("@octokit/graphql");
 const request_error_1 = require("@octokit/request-error");
 const errors_1 = require("./errors");
 const MAX_ISSUE_BODY_SIZE = 65536;
+const MAX_SLEEP_SECONDS = 20;
 exports.GH_API_URL = 'https://api.github.com';
 exports.GH_GRAPHQL_URL = 'https://api.github.com';
 const logger_1 = require("./util/logger");
@@ -58,7 +59,9 @@ class GitHub {
             }
             return files;
         });
-        this.graphqlRequest = wrapAsync(async (opts, maxRetries = 1) => {
+        this.graphqlRequest = wrapAsync(async (opts, options) => {
+            var _a;
+            let maxRetries = (_a = options === null || options === void 0 ? void 0 : options.maxRetries) !== null && _a !== void 0 ? _a : 5;
             let seconds = 1;
             while (maxRetries >= 0) {
                 try {
@@ -72,13 +75,17 @@ class GitHub {
                     if (err.status !== 502) {
                         throw err;
                     }
-                    logger_1.logger.trace('received 502 error, retrying');
+                    if (maxRetries === 0) {
+                        logger_1.logger.warn('ran out of retries and response is required');
+                        throw err;
+                    }
+                    logger_1.logger.info(`received 502 error, ${maxRetries} attempts remaining`);
                 }
                 maxRetries -= 1;
                 if (maxRetries >= 0) {
                     logger_1.logger.trace(`sleeping ${seconds} seconds`);
-                    await sleepInMs(1000 * seconds);
-                    seconds *= 2;
+                    await (0, exports.sleepInMs)(1000 * seconds);
+                    seconds = Math.min(seconds * 2, MAX_SLEEP_SECONDS);
                 }
             }
             logger_1.logger.trace('ran out of retries');
@@ -687,7 +694,7 @@ class GitHub {
             targetBranch,
             states,
             maxFilesChanged: 64,
-        }, 3);
+        });
         if (!((_a = response === null || response === void 0 ? void 0 : response.repository) === null || _a === void 0 ? void 0 : _a.pullRequests)) {
             logger_1.logger.warn(`Could not find merged pull requests for branch ${targetBranch} - it likely does not exist.`);
             return null;
@@ -1004,4 +1011,5 @@ const wrapAsync = (fn, errorHandler) => {
     };
 };
 const sleepInMs = (ms) => new Promise(resolve => setTimeout(resolve, ms));
+exports.sleepInMs = sleepInMs;
 //# sourceMappingURL=github.js.map

package/build/src/manifest.d.ts

@@ -69,6 +69,7 @@ export interface CandidateRelease extends Release {
 }
 interface ReleaserConfigJson {
     'release-type'?: ReleaseType;
+    versioning?: VersioningStrategyType;
     'bump-minor-pre-major'?: boolean;
     'bump-patch-for-minor-pre-major'?: boolean;
     'changelog-sections'?: ChangelogSection[];

package/build/src/manifest.js

@@ -713,6 +713,7 @@ function extractReleaserConfig(config) {
         releaseType: config['release-type'],
         bumpMinorPreMajor: config['bump-minor-pre-major'],
         bumpPatchForMinorPreMajor: config['bump-patch-for-minor-pre-major'],
+        versioning: config['versioning'],
         changelogSections: config['changelog-sections'],
         changelogPath: config['changelog-path'],
         changelogHost: config['changelog-host'],
@@ -867,7 +868,9 @@ async function latestReleaseVersion(github, targetBranch, releaseFilter, config,
     // only look at the last 250 or so commits to find the latest tag - we
     // don't want to scan the entire repository history if this repo has never
     // been released
-    const generator = github.mergeCommitIterator(targetBranch, { maxResults: 250 });
+    const generator = github.mergeCommitIterator(targetBranch, {
+        maxResults: 250,
+    });
     for await (const commitWithPullRequest of generator) {
         commitShas.add(commitWithPullRequest.sha);
         const mergedPullRequest = commitWithPullRequest.pullRequest;
@@ -938,29 +941,30 @@ async function latestReleaseVersion(github, targetBranch, releaseFilter, config,
     return candidateTagVersion.sort((a, b) => b.compare(a))[0];
 }
 function mergeReleaserConfig(defaultConfig, pathConfig) {
-    var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x;
+    var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t, _u, _v, _w, _x, _y;
     return {
         releaseType: (_b = (_a = pathConfig.releaseType) !== null && _a !== void 0 ? _a : defaultConfig.releaseType) !== null && _b !== void 0 ? _b : 'node',
         bumpMinorPreMajor: (_c = pathConfig.bumpMinorPreMajor) !== null && _c !== void 0 ? _c : defaultConfig.bumpMinorPreMajor,
         bumpPatchForMinorPreMajor: (_d = pathConfig.bumpPatchForMinorPreMajor) !== null && _d !== void 0 ? _d : defaultConfig.bumpPatchForMinorPreMajor,
-        changelogSections: (_e = pathConfig.changelogSections) !== null && _e !== void 0 ? _e : defaultConfig.changelogSections,
-        changelogPath: (_f = pathConfig.changelogPath) !== null && _f !== void 0 ? _f : defaultConfig.changelogPath,
-        changelogHost: (_g = pathConfig.changelogHost) !== null && _g !== void 0 ? _g : defaultConfig.changelogHost,
-        changelogType: (_h = pathConfig.changelogType) !== null && _h !== void 0 ? _h : defaultConfig.changelogType,
-        releaseAs: (_j = pathConfig.releaseAs) !== null && _j !== void 0 ? _j : defaultConfig.releaseAs,
-        skipGithubRelease: (_k = pathConfig.skipGithubRelease) !== null && _k !== void 0 ? _k : defaultConfig.skipGithubRelease,
-        draft: (_l = pathConfig.draft) !== null && _l !== void 0 ? _l : defaultConfig.draft,
-        prerelease: (_m = pathConfig.prerelease) !== null && _m !== void 0 ? _m : defaultConfig.prerelease,
-        component: (_o = pathConfig.component) !== null && _o !== void 0 ? _o : defaultConfig.component,
-        packageName: (_p = pathConfig.packageName) !== null && _p !== void 0 ? _p : defaultConfig.packageName,
-        versionFile: (_q = pathConfig.versionFile) !== null && _q !== void 0 ? _q : defaultConfig.versionFile,
-        extraFiles: (_r = pathConfig.extraFiles) !== null && _r !== void 0 ? _r : defaultConfig.extraFiles,
-        includeComponentInTag: (_s = pathConfig.includeComponentInTag) !== null && _s !== void 0 ? _s : defaultConfig.includeComponentInTag,
-        includeVInTag: (_t = pathConfig.includeVInTag) !== null && _t !== void 0 ? _t : defaultConfig.includeVInTag,
-        tagSeparator: (_u = pathConfig.tagSeparator) !== null && _u !== void 0 ? _u : defaultConfig.tagSeparator,
-        pullRequestTitlePattern: (_v = pathConfig.pullRequestTitlePattern) !== null && _v !== void 0 ? _v : defaultConfig.pullRequestTitlePattern,
-        separatePullRequests: (_w = pathConfig.separatePullRequests) !== null && _w !== void 0 ? _w : defaultConfig.separatePullRequests,
-        skipSnapshot: (_x = pathConfig.skipSnapshot) !== null && _x !== void 0 ? _x : defaultConfig.skipSnapshot,
+        versioning: (_e = pathConfig.versioning) !== null && _e !== void 0 ? _e : defaultConfig.versioning,
+        changelogSections: (_f = pathConfig.changelogSections) !== null && _f !== void 0 ? _f : defaultConfig.changelogSections,
+        changelogPath: (_g = pathConfig.changelogPath) !== null && _g !== void 0 ? _g : defaultConfig.changelogPath,
+        changelogHost: (_h = pathConfig.changelogHost) !== null && _h !== void 0 ? _h : defaultConfig.changelogHost,
+        changelogType: (_j = pathConfig.changelogType) !== null && _j !== void 0 ? _j : defaultConfig.changelogType,
+        releaseAs: (_k = pathConfig.releaseAs) !== null && _k !== void 0 ? _k : defaultConfig.releaseAs,
+        skipGithubRelease: (_l = pathConfig.skipGithubRelease) !== null && _l !== void 0 ? _l : defaultConfig.skipGithubRelease,
+        draft: (_m = pathConfig.draft) !== null && _m !== void 0 ? _m : defaultConfig.draft,
+        prerelease: (_o = pathConfig.prerelease) !== null && _o !== void 0 ? _o : defaultConfig.prerelease,
+        component: (_p = pathConfig.component) !== null && _p !== void 0 ? _p : defaultConfig.component,
+        packageName: (_q = pathConfig.packageName) !== null && _q !== void 0 ? _q : defaultConfig.packageName,
+        versionFile: (_r = pathConfig.versionFile) !== null && _r !== void 0 ? _r : defaultConfig.versionFile,
+        extraFiles: (_s = pathConfig.extraFiles) !== null && _s !== void 0 ? _s : defaultConfig.extraFiles,
+        includeComponentInTag: (_t = pathConfig.includeComponentInTag) !== null && _t !== void 0 ? _t : defaultConfig.includeComponentInTag,
+        includeVInTag: (_u = pathConfig.includeVInTag) !== null && _u !== void 0 ? _u : defaultConfig.includeVInTag,
+        tagSeparator: (_v = pathConfig.tagSeparator) !== null && _v !== void 0 ? _v : defaultConfig.tagSeparator,
+        pullRequestTitlePattern: (_w = pathConfig.pullRequestTitlePattern) !== null && _w !== void 0 ? _w : defaultConfig.pullRequestTitlePattern,
+        separatePullRequests: (_x = pathConfig.separatePullRequests) !== null && _x !== void 0 ? _x : defaultConfig.separatePullRequests,
+        skipSnapshot: (_y = pathConfig.skipSnapshot) !== null && _y !== void 0 ? _y : defaultConfig.skipSnapshot,
     };
 }
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.20.0",
+  "version": "13.21.0",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",

package/schemas/config.json

@@ -20,6 +20,10 @@
           "description": "Feature changes only bump semver patch if version < 1.0.0",
           "type": "boolean"
         },
+        "versioning": {
+          "description": "Versioning strategy. Defaults to `default`",
+          "type": "string"
+        },
         "changelog-sections": {
           "description": "Override the Changelog configuration sections",
           "type": "array",
@@ -305,6 +309,7 @@
     "release-type": true,
     "bump-minor-pre-major": true,
     "bump-patch-for-minor-pre-major": true,
+    "versioning": true,
     "changelog-sections": true,
     "release-as": true,
     "skip-github-release": true,