release-please 13.19.2 → 13.19.3

package/CHANGELOG.md

@@ -4,6 +4,13 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [13.19.3](https://github.com/googleapis/release-please/compare/v13.19.2...v13.19.3) (2022-07-08)
+
+
+### Bug Fixes
+
+* stop iterating if we fail to receive commits from a graphql query ([#1518](https://github.com/googleapis/release-please/issues/1518)) ([0f27cb5](https://github.com/googleapis/release-please/commit/0f27cb58d5a21e95a4f1a6c3fcfff019cdfdaff9))
+
 ## [13.19.2](https://github.com/googleapis/release-please/compare/v13.19.1...v13.19.2) (2022-07-06)
 
 

package/build/src/github.js

@@ -488,64 +488,72 @@ class GitHub {
         }
     }
     async mergeCommitsGraphQL(targetBranch, cursor, options = {}) {
-        var _a;
+        var _a, _b;
         logger_1.logger.debug(`Fetching merge commits on branch ${targetBranch} with cursor: ${cursor}`);
-        const response = await this.graphqlRequest({
-            query: `query pullRequestsSince($owner: String!, $repo: String!, $num: Int!, $maxFilesChanged: Int, $targetBranch: String!, $cursor: String) {
-        repository(owner: $owner, name: $repo) {
-          ref(qualifiedName: $targetBranch) {
-            target {
-              ... on Commit {
-                history(first: $num, after: $cursor) {
-                  nodes {
-                    associatedPullRequests(first: 10) {
-                      nodes {
-                        number
-                        title
-                        baseRefName
-                        headRefName
-                        labels(first: 10) {
-                          nodes {
-                            name
-                          }
+        const query = `query pullRequestsSince($owner: String!, $repo: String!, $num: Int!, $maxFilesChanged: Int, $targetBranch: String!, $cursor: String) {
+      repository(owner: $owner, name: $repo) {
+        ref(qualifiedName: $targetBranch) {
+          target {
+            ... on Commit {
+              history(first: $num, after: $cursor) {
+                nodes {
+                  associatedPullRequests(first: 10) {
+                    nodes {
+                      number
+                      title
+                      baseRefName
+                      headRefName
+                      labels(first: 10) {
+                        nodes {
+                          name
                         }
-                        body
-                        mergeCommit {
-                          oid
+                      }
+                      body
+                      mergeCommit {
+                        oid
+                      }
+                      files(first: $maxFilesChanged) {
+                        nodes {
+                          path
                         }
-                        files(first: $maxFilesChanged) {
-                          nodes {
-                            path
-                          }
-                          pageInfo {
-                            endCursor
-                            hasNextPage
-                          }
+                        pageInfo {
+                          endCursor
+                          hasNextPage
                         }
                       }
                     }
-                    sha: oid
-                    message
-                  }
-                  pageInfo {
-                    hasNextPage
-                    endCursor
                   }
+                  sha: oid
+                  message
+                }
+                pageInfo {
+                  hasNextPage
+                  endCursor
                 }
               }
             }
           }
         }
-      }`,
+      }
+    }`;
+        const params = {
             cursor,
             owner: this.repository.owner,
             repo: this.repository.repo,
             num: 25,
             targetBranch,
             maxFilesChanged: 100, // max is 100
+        };
+        const response = await this.graphqlRequest({
+            query,
+            ...params,
         });
+        if (!response) {
+            logger_1.logger.warn(`Did not receive a response for query: ${query}`, params);
+            return null;
+        }
         // if the branch does exist, return null
-        if (!response.repository.ref) {
+        if (!((_a = response.repository) === null || _a === void 0 ? void 0 : _a.ref)) {
             logger_1.logger.warn(`Could not find commits for branch ${targetBranch} - it likely does not exist.`);
             return null;
         }
@@ -572,7 +580,7 @@ class GitHub {
                     labels: pullRequest.labels.nodes.map(node => node.name),
                     files,
                 };
-                if (((_a = pullRequest.files.pageInfo) === null || _a === void 0 ? void 0 : _a.hasNextPage) && options.backfillFiles) {
+                if (((_b = pullRequest.files.pageInfo) === null || _b === void 0 ? void 0 : _b.hasNextPage) && options.backfillFiles) {
                     logger_1.logger.info(`PR #${pullRequest.number} has many files, backfilling`);
                     commit.files = await this.getCommitFiles(graphCommit.sha);
                 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.19.2",
+  "version": "13.19.3",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",