release-please 13.19.1 → 13.19.4

package/CHANGELOG.md

@@ -4,6 +4,28 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [13.19.4](https://github.com/googleapis/release-please/compare/v13.19.3...v13.19.4) (2022-07-25)
+
+
+### Bug Fixes
+
+* **commits:** remove content before and after BREAKING in body ([#1531](https://github.com/googleapis/release-please/issues/1531)) ([f75e49f](https://github.com/googleapis/release-please/commit/f75e49f6b751347456746d9c4068191d340c8e1e))
+* **python:** make` __init__.py` bump underscore / hyphen agnostic ([4b25a47](https://github.com/googleapis/release-please/commit/4b25a475d53fd4f2eadd14619f701e51275f8e62))
+
+## [13.19.3](https://github.com/googleapis/release-please/compare/v13.19.2...v13.19.3) (2022-07-08)
+
+
+### Bug Fixes
+
+* stop iterating if we fail to receive commits from a graphql query ([#1518](https://github.com/googleapis/release-please/issues/1518)) ([0f27cb5](https://github.com/googleapis/release-please/commit/0f27cb58d5a21e95a4f1a6c3fcfff019cdfdaff9))
+
+## [13.19.2](https://github.com/googleapis/release-please/compare/v13.19.1...v13.19.2) (2022-07-06)
+
+
+### Bug Fixes
+
+* move schemas to their own directory and add to dist ([#1512](https://github.com/googleapis/release-please/issues/1512)) ([b7fb4ad](https://github.com/googleapis/release-please/commit/b7fb4ad6182a050a2c2a8376b4dd84d105b83438)), closes [#1511](https://github.com/googleapis/release-please/issues/1511)
+
 ## [13.19.1](https://github.com/googleapis/release-please/compare/v13.19.0...v13.19.1) (2022-07-06)
 
 

package/build/src/commit.js

@@ -92,6 +92,7 @@ function toConventionalChangelogFormat(ast) {
         text: '', // "text" will be populated if a BREAKING CHANGE token is parsed.
     };
     visitWithAncestors(ast, ['breaking-change'], (node, ancestors) => {
+        let hitBreakingMarker = false;
         let parent = ancestors.pop();
         if (!parent) {
             return;
@@ -104,7 +105,13 @@ function toConventionalChangelogFormat(ast) {
                 breaking.text = '';
                 // We treat text from the BREAKING CHANGE marker forward as
                 // the breaking change notes:
-                visit(parent, ['text', 'newline'], (node) => {
+                visit(parent, ['breaking-change', 'text', 'newline'], (node) => {
+                    if (node.type === 'breaking-change') {
+                        hitBreakingMarker = true;
+                        return;
+                    }
+                    if (!hitBreakingMarker)
+                        return;
                     breaking.text += node.value;
                 });
                 break;

package/build/src/github.js

@@ -488,64 +488,72 @@ class GitHub {
         }
     }
     async mergeCommitsGraphQL(targetBranch, cursor, options = {}) {
-        var _a;
+        var _a, _b;
         logger_1.logger.debug(`Fetching merge commits on branch ${targetBranch} with cursor: ${cursor}`);
-        const response = await this.graphqlRequest({
-            query: `query pullRequestsSince($owner: String!, $repo: String!, $num: Int!, $maxFilesChanged: Int, $targetBranch: String!, $cursor: String) {
-        repository(owner: $owner, name: $repo) {
-          ref(qualifiedName: $targetBranch) {
-            target {
-              ... on Commit {
-                history(first: $num, after: $cursor) {
-                  nodes {
-                    associatedPullRequests(first: 10) {
-                      nodes {
-                        number
-                        title
-                        baseRefName
-                        headRefName
-                        labels(first: 10) {
-                          nodes {
-                            name
-                          }
+        const query = `query pullRequestsSince($owner: String!, $repo: String!, $num: Int!, $maxFilesChanged: Int, $targetBranch: String!, $cursor: String) {
+      repository(owner: $owner, name: $repo) {
+        ref(qualifiedName: $targetBranch) {
+          target {
+            ... on Commit {
+              history(first: $num, after: $cursor) {
+                nodes {
+                  associatedPullRequests(first: 10) {
+                    nodes {
+                      number
+                      title
+                      baseRefName
+                      headRefName
+                      labels(first: 10) {
+                        nodes {
+                          name
                         }
-                        body
-                        mergeCommit {
-                          oid
+                      }
+                      body
+                      mergeCommit {
+                        oid
+                      }
+                      files(first: $maxFilesChanged) {
+                        nodes {
+                          path
                         }
-                        files(first: $maxFilesChanged) {
-                          nodes {
-                            path
-                          }
-                          pageInfo {
-                            endCursor
-                            hasNextPage
-                          }
+                        pageInfo {
+                          endCursor
+                          hasNextPage
                         }
                       }
                     }
-                    sha: oid
-                    message
-                  }
-                  pageInfo {
-                    hasNextPage
-                    endCursor
                   }
+                  sha: oid
+                  message
+                }
+                pageInfo {
+                  hasNextPage
+                  endCursor
                 }
               }
             }
           }
         }
-      }`,
+      }
+    }`;
+        const params = {
             cursor,
             owner: this.repository.owner,
             repo: this.repository.repo,
             num: 25,
             targetBranch,
             maxFilesChanged: 100, // max is 100
+        };
+        const response = await this.graphqlRequest({
+            query,
+            ...params,
         });
+        if (!response) {
+            logger_1.logger.warn(`Did not receive a response for query: ${query}`, params);
+            return null;
+        }
         // if the branch does exist, return null
-        if (!response.repository.ref) {
+        if (!((_a = response.repository) === null || _a === void 0 ? void 0 : _a.ref)) {
             logger_1.logger.warn(`Could not find commits for branch ${targetBranch} - it likely does not exist.`);
             return null;
         }
@@ -572,7 +580,7 @@ class GitHub {
                     labels: pullRequest.labels.nodes.map(node => node.name),
                     files,
                 };
-                if (((_a = pullRequest.files.pageInfo) === null || _a === void 0 ? void 0 : _a.hasNextPage) && options.backfillFiles) {
+                if (((_b = pullRequest.files.pageInfo) === null || _b === void 0 ? void 0 : _b.hasNextPage) && options.backfillFiles) {
                     logger_1.logger.info(`PR #${pullRequest.number} has many files, backfilling`);
                     commit.files = await this.getCommitFiles(graphCommit.sha);
                 }

package/build/src/index.js

@@ -14,7 +14,6 @@
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.manifestSchema = exports.configSchema = exports.GitHub = exports.setLogger = exports.registerVersioningStrategy = exports.getVersioningStrategyTypes = exports.registerPlugin = exports.getPluginTypes = exports.registerChangelogNotes = exports.getChangelogTypes = exports.registerReleaseType = exports.getReleaserTypes = exports.Manifest = exports.Errors = void 0;
-const path_1 = require("path");
 exports.Errors = require("./errors");
 var manifest_1 = require("./manifest");
 Object.defineProperty(exports, "Manifest", { enumerable: true, get: function () { return manifest_1.Manifest; } });
@@ -34,6 +33,6 @@ var logger_1 = require("./util/logger");
 Object.defineProperty(exports, "setLogger", { enumerable: true, get: function () { return logger_1.setLogger; } });
 var github_1 = require("./github");
 Object.defineProperty(exports, "GitHub", { enumerable: true, get: function () { return github_1.GitHub; } });
-exports.configSchema = require((0, path_1.resolve)('./src/schemas/config'));
-exports.manifestSchema = require((0, path_1.resolve)('./src/schemas/manifest'));
+exports.configSchema = require('../../schemas/config.json');
+exports.manifestSchema = require('../../schemas/manifest.json');
 //# sourceMappingURL=index.js.map

package/build/src/strategies/python.js

@@ -90,20 +90,16 @@ class Python extends base_1.BaseStrategy {
             logger_1.logger.warn('No project/component found.');
         }
         else {
-            updates.push({
-                path: this.addPath(`${projectName}/__init__.py`),
+            [projectName, projectName.replace(/-/g, '_')]
+                .flatMap(packageName => [
+                `${packageName}/__init__.py`,
+                `src/${packageName}/__init__.py`,
+            ])
+                .forEach(packagePath => updates.push({
+                path: this.addPath(packagePath),
                 createIfMissing: false,
-                updater: new python_file_with_version_1.PythonFileWithVersion({
-                    version,
-                }),
-            });
-            updates.push({
-                path: this.addPath(`src/${projectName}/__init__.py`),
-                createIfMissing: false,
-                updater: new python_file_with_version_1.PythonFileWithVersion({
-                    version,
-                }),
-            });
+                updater: new python_file_with_version_1.PythonFileWithVersion({ version }),
+            }));
         }
         // There should be only one version.py, but foreach in case that is incorrect
         const versionPyFilesSearch = this.github.findFilesByFilenameAndRef('version.py', this.targetBranch, this.path);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.19.1",
+  "version": "13.19.4",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
@@ -18,7 +18,8 @@
   "files": [
     "build/src",
     "templates",
-    "!build/src/**/*.map"
+    "!build/src/**/*.map",
+    "schemas"
   ],
   "repository": "googleapis/release-please",
   "keywords": [

package/schemas/config.json

@@ -0,0 +1,300 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "title": "release-please manifest config schema",
+  "description": "Schema for defining manifest config file",
+  "type": "object",
+  "additionalProperties": false,
+  "definitions": {
+    "ReleaserConfigOptions": {
+      "type": "object",
+      "properties": {
+        "release-type": {
+          "description": "The strategy to use for this component.",
+          "type": "string"
+        },
+        "bump-minor-pre-major": {
+          "description": "Breaking changes only bump semver minor if version < 1.0.0",
+          "type": "boolean"
+        },
+        "bump-patch-for-minor-pre-major": {
+          "description": "Feature changes only bump semver patch if version < 1.0.0",
+          "type": "boolean"
+        },
+        "changelog-sections": {
+          "description": "Override the Changelog configuration sections",
+          "type": "array",
+          "items": {
+            "type": "object",
+            "properties": {
+              "type": {
+                "description": "Semantic commit type (e.g. `feat`, `chore`)",
+                "type": "string"
+              },
+              "section": {
+                "description": "Changelog section title",
+                "type": "string"
+              },
+              "hidden": {
+                "description": "Skip displaying this type of commit. Defaults to `false`.",
+                "type": "boolean"
+              }
+            },
+            "required": ["type", "section"]
+          }
+        },
+        "release-as": {
+          "description": "[DEPRECATED] Override the next version of this package. Consider using a `Release-As` commit instead.",
+          "type": "string"
+        },
+        "skip-github-release": {
+          "description": "Skip tagging GitHub releases for this package. Defaults to `false`.",
+          "type": "boolean"
+        },
+        "draft": {
+          "description": "Create the GitHub release in draft mode. Defaults to `false`.",
+          "type": "boolean"
+        },
+        "prerelease": {
+          "description": "Create the GitHub release as prerelease. Defaults to `false`.",
+          "type": "boolean"
+        },
+        "draft-pull-request": {
+          "description": "Open the release pull request in draft mode. Defaults to `false`.",
+          "type": "boolean"
+        },
+        "label": {
+          "description": "Comma-separated list of labels to add to newly opened pull request",
+          "type": "string"
+        },
+        "release-label": {
+          "description": "Comma-separated list of labels to add to a pull request that has been released/tagged",
+          "type": "string"
+        },
+        "include-component-in-tag": {
+          "description": "When tagging a release, include the component name as part of the tag. Defaults to `true`.",
+          "type": "boolean"
+        },
+        "include-v-in-tag": {
+          "description": "When tagging a release, include `v` in the tag. Defaults to `false`.",
+          "type": "boolean"
+        },
+        "changelog-type": {
+          "description": "The type of changelog to use. Defaults to `default`.",
+          "type": "string",
+          "enum": ["default", "github"]
+        },
+        "changelog-host": {
+          "description": "Generate changelog links to this GitHub host. Useful for running against GitHub Enterprise.",
+          "type": "string"
+        },
+        "pull-request-title-pattern": {
+          "description": "Customize the release pull request title.",
+          "type": "string"
+        },
+        "separate-pull-requests": {
+          "description": "Open a separate release pull request for each component. Defaults to `false`.",
+          "type": "boolean"
+        },
+        "tag-separator": {
+          "description": "Customize the separator between the component and version in the GitHub tag.",
+          "type": "string"
+        },
+        "extra-files": {
+          "description": "Specify extra generic files to replace versions.",
+          "type": "array",
+          "items": {
+            "anyOf": [
+              {
+                "description": "The path to the file. The `Generic` updater uses annotations to replace versions.",
+                "type": "string"
+              },
+              {
+                "description": "An extra JSON on YAML file with a targeted update via jsonpath.",
+                "type": "object",
+                "properties": {
+                  "type": {
+                    "description": "The file format type.",
+                    "enum": ["json", "yaml"]
+                  },
+                  "path": {
+                    "description": "The path to the file.",
+                    "type": "string"
+                  },
+                  "jsonpath": {
+                    "description": "The jsonpath to the version entry in the file.",
+                    "type": "string"
+                  }
+                },
+                "required": ["type", "path", "jsonpath"]
+              },
+              {
+                "description": "An extra XML file with a targeted update via xpath.",
+                "type": "object",
+                "properties": {
+                  "type": {
+                    "description": "The file format type.",
+                    "enum": ["xml"]
+                  },
+                  "path": {
+                    "description": "The path to the file.",
+                    "type": "string"
+                  },
+                  "xpath": {
+                    "description": "The xpath to the version entry in the file.",
+                    "type": "string"
+                  }
+                },
+                "required": ["type", "path", "xpath"]
+              },
+              {
+                "description": "An extra pom.xml file.",
+                "type": "object",
+                "properties": {
+                  "type": {
+                    "description": "The file format type.",
+                    "enum": ["pom"]
+                  },
+                  "path": {
+                    "description": "The path to the file.",
+                    "type": "string"
+                  }
+                },
+                "required": ["type", "path"]
+              }
+            ]
+          }
+        },
+        "version-file": {
+          "description": "Path to the specialize version file. Used by `ruby` and `simple` strategies.",
+          "type": "string"
+        },
+        "snapshot-label": {
+          "description": "Label to add to snapshot pull request. Used by `java` strategies.",
+          "type": "string"
+        }
+      }
+    }
+  },
+  "allOf": [
+    {
+      "$ref": "#/definitions/ReleaserConfigOptions"
+    },
+    {
+      "properties": {
+        "packages": {
+          "description": "Per-path component configuration.",
+          "type": "object",
+          "additionalProperties": {
+            "$ref": "#/definitions/ReleaserConfigOptions"
+          }
+        },
+        "bootstrap-sha": {
+          "description": "For the initial release of a library, only consider as far back as this commit SHA. This is an uncommon use case and should generally be avoided.",
+          "type": "string"
+        },
+        "last-release-sha": {
+          "description": "For any release, only consider as far back as this commit SHA. This is an uncommon use case and should generally be avoided.",
+          "type": "string"
+        },
+        "always-link-local": {
+          "description": "When using the `node-workspace` plugin, force all local dependencies to be linked.",
+          "type": "boolean"
+        },
+        "plugins": {
+          "description": "Plugins to apply to pull requests. Plugins can be added to perform extra release processing that cannot be achieved by an individual release strategy.",
+          "type": "array",
+          "items": {
+            "anyOf": [
+              {
+                "description": "The plugin name for plugins that do not require other options.",
+                "type": "string"
+              },
+              {
+                "description": "Configuration for the `linked-versions` plugin.",
+                "type": "object",
+                "properties": {
+                  "type": {
+                    "description": "The name of the plugin.",
+                    "type": "string",
+                    "enum": ["linked-versions"]
+                  },
+                  "groupName": {
+                    "description": "The name of the group of components.",
+                    "type": "string"
+                  },
+                  "components": {
+                    "description": "List of component names that are part of this group.",
+                    "type": "array",
+                    "items": {
+                      "type": "string"
+                    }
+                  }
+                },
+                "required": ["type", "groupName", "components"]
+              },
+              {
+                "description": "Other plugins",
+                "type": "object",
+                "properties": {
+                  "type": {
+                    "description": "The name of the plugin.",
+                    "type": "string"
+                  }
+                }
+              }
+            ]
+          }
+        },
+        "group-pull-request-title-pattern": {
+          "description": "When grouping multiple release pull requests use this pattern for the title.",
+          "type": "string"
+        },
+        "release-search-depth": {
+          "description": "When considering previously releases, only look this deep.",
+          "type": "number"
+        },
+        "commit-search-depth": {
+          "description": "When considering commit history, only look this many commits deep.",
+          "type": "number"
+        },
+        "sequential-calls": {
+          "description": "Whether to open pull requests/releases sequentially rather than concurrently. If you have many components, you may want to set this to avoid secondary rate limits.",
+          "type": "boolean"
+        }
+      },
+      "required": ["packages"]
+    }
+  ],
+  "properties": {
+    "packages": true,
+    "bootstrap-sha": true,
+    "last-release-sha": true,
+    "always-link-local": true,
+    "plugins": true,
+    "group-pull-request-title-pattern": true,
+    "release-search-depth": true,
+    "commit-search-depth": true,
+    "sequential-calls": true,
+    "release-type": true,
+    "bump-minor-pre-major": true,
+    "bump-patch-for-minor-pre-major": true,
+    "changelog-sections": true,
+    "release-as": true,
+    "skip-github-release": true,
+    "draft": true,
+    "prerelease": true,
+    "draft-pull-request": true,
+    "label": true,
+    "release-label": true,
+    "include-component-in-tag": true,
+    "include-v-in-tag": true,
+    "changelog-type": true,
+    "changelog-host": true,
+    "pull-request-title-pattern": true,
+    "separate-pull-requests": true,
+    "tag-separator": true,
+    "extra-files": true,
+    "version-file": true,
+    "snapshot-label": true
+  }
+}

package/schemas/manifest.json

@@ -0,0 +1,9 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "title": "release-please manifest config versions",
+  "description": "Schema for defining manifest versions file",
+  "type": "object",
+  "additionalProperties": {
+    "type": "string"
+  }
+}