release-please 13.18.1 → 13.18.2

package/CHANGELOG.md

@@ -4,6 +4,13 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [13.18.2](https://github.com/googleapis/release-please/compare/v13.18.1...v13.18.2) (2022-06-08)
+
+
+### Bug Fixes
+
+* factory errors for unknown types throw ConfigurationError instead of Error ([#1467](https://github.com/googleapis/release-please/issues/1467)) ([faa5d25](https://github.com/googleapis/release-please/commit/faa5d25fa2075d27d42238adf34e54f6a1bc39a4))
+
 ## [13.18.1](https://github.com/googleapis/release-please/compare/v13.18.0...v13.18.1) (2022-06-08)
 
 

package/build/src/factories/changelog-notes-factory.js

@@ -16,6 +16,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getChangelogTypes = exports.unregisterChangelogNotes = exports.registerChangelogNotes = exports.buildChangelogNotes = void 0;
 const github_1 = require("../changelog-notes/github");
 const default_1 = require("../changelog-notes/default");
+const errors_1 = require("../errors");
 const changelogNotesFactories = {
     github: options => new github_1.GitHubChangelogNotes(options.github),
     default: options => new default_1.DefaultChangelogNotes(options),
@@ -25,7 +26,7 @@ function buildChangelogNotes(options) {
     if (builder) {
         return builder(options);
     }
-    throw new Error(`Unknown changelog type: ${options.type}`);
+    throw new errors_1.ConfigurationError(`Unknown changelog type: ${options.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
 }
 exports.buildChangelogNotes = buildChangelogNotes;
 function registerChangelogNotes(name, changelogNotesBuilder) {

package/build/src/factories/plugin-factory.js

@@ -18,6 +18,7 @@ const linked_versions_1 = require("../plugins/linked-versions");
 const cargo_workspace_1 = require("../plugins/cargo-workspace");
 const node_workspace_1 = require("../plugins/node-workspace");
 const maven_workspace_1 = require("../plugins/maven-workspace");
+const errors_1 = require("../errors");
 const pluginFactories = {
     'linked-versions': options => new linked_versions_1.LinkedVersions(options.github, options.targetBranch, options.repositoryConfig, options.type.groupName, options.type.components),
     'cargo-workspace': options => new cargo_workspace_1.CargoWorkspace(options.github, options.targetBranch, options.repositoryConfig, options),
@@ -30,14 +31,14 @@ function buildPlugin(options) {
         if (builder) {
             return builder(options);
         }
-        throw new Error(`Unknown plugin type: ${options.type.type}`);
+        throw new errors_1.ConfigurationError(`Unknown plugin type: ${options.type.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
     }
     else {
         const builder = pluginFactories[options.type];
         if (builder) {
             return builder(options);
         }
-        throw new Error(`Unknown plugin type: ${options.type}`);
+        throw new errors_1.ConfigurationError(`Unknown plugin type: ${options.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
     }
 }
 exports.buildPlugin = buildPlugin;

package/build/src/factories/versioning-strategy-factory.d.ts

@@ -1,9 +1,11 @@
 import { VersioningStrategy } from '../versioning-strategy';
+import { GitHub } from '../github';
 export declare type VersioningStrategyType = string;
 export interface VersioningStrategyFactoryOptions {
     type?: VersioningStrategyType;
     bumpMinorPreMajor?: boolean;
     bumpPatchForMinorPreMajor?: boolean;
+    github: GitHub;
 }
 export declare type VersioningStrategyBuilder = (options: VersioningStrategyFactoryOptions) => VersioningStrategy;
 export declare function buildVersioningStrategy(options: VersioningStrategyFactoryOptions): VersioningStrategy;

package/build/src/factories/versioning-strategy-factory.js

@@ -17,6 +17,7 @@ exports.getVersioningStrategyTypes = exports.unregisterVersioningStrategy = expo
 const default_1 = require("../versioning-strategies/default");
 const always_bump_patch_1 = require("../versioning-strategies/always-bump-patch");
 const service_pack_1 = require("../versioning-strategies/service-pack");
+const errors_1 = require("../errors");
 const versioningTypes = {
     default: options => new default_1.DefaultVersioningStrategy(options),
     'always-bump-patch': options => new always_bump_patch_1.AlwaysBumpPatch(options),
@@ -27,7 +28,7 @@ function buildVersioningStrategy(options) {
     if (builder) {
         return builder(options);
     }
-    throw new Error(`Unknown versioning strategy type: ${options.type}`);
+    throw new errors_1.ConfigurationError(`Unknown versioning strategy type: ${options.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
 }
 exports.buildVersioningStrategy = buildVersioningStrategy;
 function registerVersioningStrategy(name, versioningStrategyBuilder) {

package/build/src/factory.js

@@ -53,6 +53,7 @@ const java_1 = require("./strategies/java");
 const maven_1 = require("./strategies/maven");
 const versioning_strategy_factory_1 = require("./factories/versioning-strategy-factory");
 const changelog_notes_factory_1 = require("./factories/changelog-notes-factory");
+const errors_1 = require("./errors");
 __exportStar(require("./factories/changelog-notes-factory"), exports);
 __exportStar(require("./factories/plugin-factory"), exports);
 __exportStar(require("./factories/versioning-strategy-factory"), exports);
@@ -97,6 +98,7 @@ async function buildStrategy(options) {
     var _a;
     const targetBranch = (_a = options.targetBranch) !== null && _a !== void 0 ? _a : options.github.repository.defaultBranch;
     const versioningStrategy = (0, versioning_strategy_factory_1.buildVersioningStrategy)({
+        github: options.github,
         type: options.versioning,
         bumpMinorPreMajor: options.bumpMinorPreMajor,
         bumpPatchForMinorPreMajor: options.bumpPatchForMinorPreMajor,
@@ -117,7 +119,7 @@ async function buildStrategy(options) {
     if (builder) {
         return builder(strategyOptions);
     }
-    throw new Error(`Unknown release type: ${options.releaseType}`);
+    throw new errors_1.ConfigurationError(`Unknown release type: ${options.releaseType}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
 }
 exports.buildStrategy = buildStrategy;
 function registerReleaseType(name, strategyBuilder) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.18.1",
+  "version": "13.18.2",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",