release-please 13.17.1 → 13.18.2

package/CHANGELOG.md

@@ -4,6 +4,32 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [13.18.2](https://github.com/googleapis/release-please/compare/v13.18.1...v13.18.2) (2022-06-08)
+
+
+### Bug Fixes
+
+* factory errors for unknown types throw ConfigurationError instead of Error ([#1467](https://github.com/googleapis/release-please/issues/1467)) ([faa5d25](https://github.com/googleapis/release-please/commit/faa5d25fa2075d27d42238adf34e54f6a1bc39a4))
+
+## [13.18.1](https://github.com/googleapis/release-please/compare/v13.18.0...v13.18.1) (2022-06-08)
+
+
+### Bug Fixes
+
+* set default bootstrap path to . ([#1464](https://github.com/googleapis/release-please/issues/1464)) ([c2bfbe5](https://github.com/googleapis/release-please/commit/c2bfbe5affe504f4a5183f79e338f9e7d48a8386)), closes [#1450](https://github.com/googleapis/release-please/issues/1450)
+
+## [13.18.0](https://github.com/googleapis/release-please/compare/v13.17.1...v13.18.0) (2022-06-01)
+
+
+### Features
+
+* add support for generic yaml updater ([#1452](https://github.com/googleapis/release-please/issues/1452)) ([002231a](https://github.com/googleapis/release-please/commit/002231acfa49b3859a7eaee184a2b520eb6611d3))
+
+
+### Bug Fixes
+
+* fix parsing of tags with major versions higher than 9 ([#1451](https://github.com/googleapis/release-please/issues/1451)) ([5fc402a](https://github.com/googleapis/release-please/commit/5fc402ae41cd5aba4be5155f90fbc39f9369817d))
+
 ### [13.17.1](https://github.com/googleapis/release-please/compare/v13.17.0...v13.17.1) (2022-05-27)
 
 

package/build/src/bin/release-please.js

@@ -466,7 +466,8 @@ const bootstrapCommand = {
             argv.defaultBranch ||
             github.repository.defaultBranch;
         const bootstrapper = new bootstrapper_1.Bootstrapper(github, targetBranch, argv.manifestFile, argv.configFile, argv.initialVersion);
-        const pullRequest = await bootstrapper.bootstrap(argv.path, {
+        const path = argv.path || manifest_1.ROOT_PROJECT_PATH;
+        const pullRequest = await bootstrapper.bootstrap(path, {
             releaseType: argv.releaseType,
             component: argv.component,
             packageName: argv.packageName,

package/build/src/factories/changelog-notes-factory.js

@@ -16,6 +16,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.getChangelogTypes = exports.unregisterChangelogNotes = exports.registerChangelogNotes = exports.buildChangelogNotes = void 0;
 const github_1 = require("../changelog-notes/github");
 const default_1 = require("../changelog-notes/default");
+const errors_1 = require("../errors");
 const changelogNotesFactories = {
     github: options => new github_1.GitHubChangelogNotes(options.github),
     default: options => new default_1.DefaultChangelogNotes(options),
@@ -25,7 +26,7 @@ function buildChangelogNotes(options) {
     if (builder) {
         return builder(options);
     }
-    throw new Error(`Unknown changelog type: ${options.type}`);
+    throw new errors_1.ConfigurationError(`Unknown changelog type: ${options.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
 }
 exports.buildChangelogNotes = buildChangelogNotes;
 function registerChangelogNotes(name, changelogNotesBuilder) {

package/build/src/factories/plugin-factory.js

@@ -18,6 +18,7 @@ const linked_versions_1 = require("../plugins/linked-versions");
 const cargo_workspace_1 = require("../plugins/cargo-workspace");
 const node_workspace_1 = require("../plugins/node-workspace");
 const maven_workspace_1 = require("../plugins/maven-workspace");
+const errors_1 = require("../errors");
 const pluginFactories = {
     'linked-versions': options => new linked_versions_1.LinkedVersions(options.github, options.targetBranch, options.repositoryConfig, options.type.groupName, options.type.components),
     'cargo-workspace': options => new cargo_workspace_1.CargoWorkspace(options.github, options.targetBranch, options.repositoryConfig, options),
@@ -30,14 +31,14 @@ function buildPlugin(options) {
         if (builder) {
             return builder(options);
         }
-        throw new Error(`Unknown plugin type: ${options.type.type}`);
+        throw new errors_1.ConfigurationError(`Unknown plugin type: ${options.type.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
     }
     else {
         const builder = pluginFactories[options.type];
         if (builder) {
             return builder(options);
         }
-        throw new Error(`Unknown plugin type: ${options.type}`);
+        throw new errors_1.ConfigurationError(`Unknown plugin type: ${options.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
     }
 }
 exports.buildPlugin = buildPlugin;

package/build/src/factories/versioning-strategy-factory.d.ts

@@ -1,9 +1,11 @@
 import { VersioningStrategy } from '../versioning-strategy';
+import { GitHub } from '../github';
 export declare type VersioningStrategyType = string;
 export interface VersioningStrategyFactoryOptions {
     type?: VersioningStrategyType;
     bumpMinorPreMajor?: boolean;
     bumpPatchForMinorPreMajor?: boolean;
+    github: GitHub;
 }
 export declare type VersioningStrategyBuilder = (options: VersioningStrategyFactoryOptions) => VersioningStrategy;
 export declare function buildVersioningStrategy(options: VersioningStrategyFactoryOptions): VersioningStrategy;

package/build/src/factories/versioning-strategy-factory.js

@@ -17,6 +17,7 @@ exports.getVersioningStrategyTypes = exports.unregisterVersioningStrategy = expo
 const default_1 = require("../versioning-strategies/default");
 const always_bump_patch_1 = require("../versioning-strategies/always-bump-patch");
 const service_pack_1 = require("../versioning-strategies/service-pack");
+const errors_1 = require("../errors");
 const versioningTypes = {
     default: options => new default_1.DefaultVersioningStrategy(options),
     'always-bump-patch': options => new always_bump_patch_1.AlwaysBumpPatch(options),
@@ -27,7 +28,7 @@ function buildVersioningStrategy(options) {
     if (builder) {
         return builder(options);
     }
-    throw new Error(`Unknown versioning strategy type: ${options.type}`);
+    throw new errors_1.ConfigurationError(`Unknown versioning strategy type: ${options.type}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
 }
 exports.buildVersioningStrategy = buildVersioningStrategy;
 function registerVersioningStrategy(name, versioningStrategyBuilder) {

package/build/src/factory.js

@@ -53,6 +53,7 @@ const java_1 = require("./strategies/java");
 const maven_1 = require("./strategies/maven");
 const versioning_strategy_factory_1 = require("./factories/versioning-strategy-factory");
 const changelog_notes_factory_1 = require("./factories/changelog-notes-factory");
+const errors_1 = require("./errors");
 __exportStar(require("./factories/changelog-notes-factory"), exports);
 __exportStar(require("./factories/plugin-factory"), exports);
 __exportStar(require("./factories/versioning-strategy-factory"), exports);
@@ -97,6 +98,7 @@ async function buildStrategy(options) {
     var _a;
     const targetBranch = (_a = options.targetBranch) !== null && _a !== void 0 ? _a : options.github.repository.defaultBranch;
     const versioningStrategy = (0, versioning_strategy_factory_1.buildVersioningStrategy)({
+        github: options.github,
         type: options.versioning,
         bumpMinorPreMajor: options.bumpMinorPreMajor,
         bumpPatchForMinorPreMajor: options.bumpPatchForMinorPreMajor,
@@ -117,7 +119,7 @@ async function buildStrategy(options) {
     if (builder) {
         return builder(strategyOptions);
     }
-    throw new Error(`Unknown release type: ${options.releaseType}`);
+    throw new errors_1.ConfigurationError(`Unknown release type: ${options.releaseType}`, 'core', `${options.github.repository.owner}/${options.github.repository.repo}`);
 }
 exports.buildStrategy = buildStrategy;
 function registerReleaseType(name, strategyBuilder) {

package/build/src/manifest.d.ts

@@ -10,6 +10,11 @@ declare type ExtraJsonFile = {
     path: string;
     jsonpath: string;
 };
+declare type ExtraYamlFile = {
+    type: 'yaml';
+    path: string;
+    jsonpath: string;
+};
 declare type ExtraXmlFile = {
     type: 'xml';
     path: string;
@@ -19,7 +24,7 @@ declare type ExtraPomFile = {
     type: 'pom';
     path: string;
 };
-export declare type ExtraFile = string | ExtraJsonFile | ExtraXmlFile | ExtraPomFile;
+export declare type ExtraFile = string | ExtraJsonFile | ExtraYamlFile | ExtraXmlFile | ExtraPomFile;
 /**
  * These are configurations provided to each strategy per-path.
  */

package/build/src/strategies/base.js

@@ -29,6 +29,7 @@ const generic_1 = require("../updaters/generic");
 const generic_json_1 = require("../updaters/generic-json");
 const generic_xml_1 = require("../updaters/generic-xml");
 const pom_xml_1 = require("../updaters/java/pom-xml");
+const generic_yaml_1 = require("../updaters/generic-yaml");
 const DEFAULT_CHANGELOG_PATH = 'CHANGELOG.md';
 /**
  * A strategy is responsible for determining which files are
@@ -183,6 +184,12 @@ class BaseStrategy {
                             createIfMissing: false,
                             updater: new generic_json_1.GenericJson(extraFile.jsonpath, version),
                         };
+                    case 'yaml':
+                        return {
+                            path: this.addPath(extraFile.path),
+                            createIfMissing: false,
+                            updater: new generic_yaml_1.GenericYaml(extraFile.jsonpath, version),
+                        };
                     case 'xml':
                         return {
                             path: this.addPath(extraFile.path),

package/build/src/updaters/generic-yaml.d.ts

@@ -0,0 +1,22 @@
+import { Updater } from '../update';
+import { Version } from '../version';
+/**
+ * Updates YAML document according to given JSONPath.
+ *
+ * Note that used parser does reformat the document and removes all comments,
+ * and converts everything to pure YAML (even JSON source).
+ * If you want to retain formatting, use generic updater with comment hints.
+ *
+ * When applied on multi-document file, it updates all documents.
+ */
+export declare class GenericYaml implements Updater {
+    readonly jsonpath: string;
+    readonly version: Version;
+    constructor(jsonpath: string, version: Version);
+    /**
+     * Given initial file contents, return updated contents.
+     * @param {string} content The initial content
+     * @returns {string} The updated content
+     */
+    updateContent(content: string): string;
+}

package/build/src/updaters/generic-yaml.js

@@ -0,0 +1,77 @@
+"use strict";
+// Copyright 2022 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.GenericYaml = void 0;
+const jp = require("jsonpath");
+const yaml = require("js-yaml");
+const logger_1 = require("../util/logger");
+const DOCUMENT_SEPARATOR = '---\n';
+/**
+ * Updates YAML document according to given JSONPath.
+ *
+ * Note that used parser does reformat the document and removes all comments,
+ * and converts everything to pure YAML (even JSON source).
+ * If you want to retain formatting, use generic updater with comment hints.
+ *
+ * When applied on multi-document file, it updates all documents.
+ */
+class GenericYaml {
+    constructor(jsonpath, version) {
+        this.jsonpath = jsonpath;
+        this.version = version;
+    }
+    /**
+     * Given initial file contents, return updated contents.
+     * @param {string} content The initial content
+     * @returns {string} The updated content
+     */
+    updateContent(content) {
+        // Parse possibly multi-document file
+        let docs;
+        try {
+            docs = yaml.loadAll(content, null, { json: true });
+        }
+        catch (e) {
+            logger_1.logger.warn('Invalid yaml, cannot be parsed', e);
+            return content;
+        }
+        // Update each document
+        let modified = false;
+        docs.forEach(data => {
+            const nodes = jp.apply(data, this.jsonpath, _val => {
+                return this.version.toString();
+            });
+            if (nodes && nodes.length) {
+                modified = true;
+            }
+        });
+        // If nothing was modified, return original content
+        if (!modified) {
+            logger_1.logger.warn(`No entries modified in ${this.jsonpath}`);
+            return content;
+        }
+        // Stringify documents
+        if (docs.length === 1) {
+            // Single doc
+            return yaml.dump(docs[0]);
+        }
+        else {
+            // Multi-document, each document starts with separator
+            return docs.map(data => DOCUMENT_SEPARATOR + yaml.dump(data)).join('');
+        }
+    }
+}
+exports.GenericYaml = GenericYaml;
+//# sourceMappingURL=generic-yaml.js.map

package/build/src/util/tag-name.js

@@ -15,7 +15,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.TagName = void 0;
 const version_1 = require("../version");
-const TAG_PATTERN = /^((?<component>.*)(?<separator>[^a-zA-Z]))?(?<v>v)?(?<version>\d+\.\d+\.\d+.*)$/;
+const TAG_PATTERN = /^((?<component>.*)(?<separator>[^a-zA-Z0-9]))?(?<v>v)?(?<version>\d+\.\d+\.\d+.*)$/;
 const DEFAULT_SEPARATOR = '-';
 class TagName {
     constructor(version, component, separator = DEFAULT_SEPARATOR, includeV = true) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.17.1",
+  "version": "13.18.2",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",