release-please 13.16.1 → 13.16.2

package/CHANGELOG.md

@@ -4,6 +4,13 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [13.16.2](https://github.com/googleapis/release-please/compare/v13.16.1...v13.16.2) (2022-05-12)
+
+
+### Bug Fixes
+
+* throw ConfigurationError when required manifest config file is missing ([#1422](https://github.com/googleapis/release-please/issues/1422)) ([83e461e](https://github.com/googleapis/release-please/commit/83e461e8947d16fbd92d57a0d9c64d37ab0dfa42))
+
 ### [13.16.1](https://github.com/googleapis/release-please/compare/v13.16.0...v13.16.1) (2022-05-10)
 
 

package/build/src/manifest.js

@@ -729,7 +729,7 @@ function extractReleaserConfig(config) {
  * @param {string} releaseAs Optional. Override release-as and use the given version
  */
 async function parseConfig(github, configFile, branch, onlyPath, releaseAs) {
-    const config = await github.getFileJson(configFile, branch);
+    const config = await fetchManifestConfig(github, configFile, branch);
     const defaultConfig = extractReleaserConfig(config);
     const repositoryConfig = {};
     for (const path in config.packages) {
@@ -759,21 +759,61 @@ async function parseConfig(github, configFile, branch, onlyPath, releaseAs) {
     };
     return { config: repositoryConfig, options: manifestOptions };
 }
+/**
+ * Helper to fetch manifest config
+ *
+ * @param {GitHub} github
+ * @param {string} configFile
+ * @param {string} branch
+ * @returns {ManifestConfig}
+ * @throws {ConfigurationError} if missing the manifest config file
+ */
+async function fetchManifestConfig(github, configFile, branch) {
+    try {
+        return await github.getFileJson(configFile, branch);
+    }
+    catch (e) {
+        if (e instanceof errors_1.FileNotFoundError) {
+            throw new errors_1.ConfigurationError(`Missing required manifest config: ${configFile}`, 'base', `${github.repository.owner}/${github.repository.repo}`);
+        }
+        throw e;
+    }
+}
 /**
  * Helper to parse the manifest versions file.
  *
  * @param {GitHub} github GitHub client
  * @param {string} manifestFile Path in the repository to the versions file
  * @param {string} branch Branch to fetch the versions file from
+ * @returns {Record<string, string>}
  */
 async function parseReleasedVersions(github, manifestFile, branch) {
-    const manifestJson = await github.getFileJson(manifestFile, branch);
+    const manifestJson = await fetchReleasedVersions(github, manifestFile, branch);
     const releasedVersions = {};
     for (const path in manifestJson) {
         releasedVersions[path] = version_1.Version.parse(manifestJson[path]);
     }
     return releasedVersions;
 }
+/**
+ * Helper to fetch manifest config
+ *
+ * @param {GitHub} github
+ * @param {string} manifestFile
+ * @param {string} branch
+ * @throws {ConfigurationError} if missing the manifest config file
+ */
+async function fetchReleasedVersions(github, manifestFile, branch) {
+    try {
+        return await github.getFileJson(manifestFile, branch);
+    }
+    catch (e) {
+        if (e instanceof errors_1.FileNotFoundError) {
+            throw new errors_1.ConfigurationError(`Missing required manifest versions: ${manifestFile}`, 'base', `${github.repository.owner}/${github.repository.repo}`);
+        }
+        throw e;
+    }
+}
 function isPublishedVersion(strategy, version) {
     return strategy.isPublishedVersion
         ? strategy.isPublishedVersion(version)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.16.1",
+  "version": "13.16.2",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",