release-please 13.11.0 → 13.13.0

package/CHANGELOG.md

@@ -4,6 +4,32 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+## [13.13.0](https://github.com/googleapis/release-please/compare/v13.12.0...v13.13.0) (2022-04-18)
+
+
+### Features
+
+* add a flag to disable adding labels to new pull requests ([#1399](https://github.com/googleapis/release-please/issues/1399)) ([3957ef5](https://github.com/googleapis/release-please/commit/3957ef542512eb1ae2c3353b3c2a7fde4540c731))
+
+## [13.12.0](https://github.com/googleapis/release-please/compare/v13.11.1...v13.12.0) (2022-04-15)
+
+
+### Features
+
+* allow configuring `release-search-depth` and `commit-search-depth` ([#1396](https://github.com/googleapis/release-please/issues/1396)) ([102d650](https://github.com/googleapis/release-please/commit/102d650394140667d17d84726bd962477d69562c)), closes [#1394](https://github.com/googleapis/release-please/issues/1394)
+
+
+### Bug Fixes
+
+* Allow an empty value for --label ([#1397](https://github.com/googleapis/release-please/issues/1397)) ([f5aff97](https://github.com/googleapis/release-please/commit/f5aff97dbb20086a26b846dde89b289a4540dba1))
+
+### [13.11.1](https://github.com/googleapis/release-please/compare/v13.11.0...v13.11.1) (2022-04-15)
+
+
+### Bug Fixes
+
+* **deps:** switch from `xmldom` to `@xmldom/xmldom` and update to v0.8.2 ([#1393](https://github.com/googleapis/release-please/issues/1393)) ([b6af677](https://github.com/googleapis/release-please/commit/b6af677da635493230d7e3a632aeedb5cfd1edb7))
+
 ## [13.11.0](https://github.com/googleapis/release-please/compare/v13.10.2...v13.11.0) (2022-04-15)
 
 

package/build/src/bin/release-please.d.ts

@@ -48,6 +48,7 @@ interface ReleaseArgs {
 interface PullRequestArgs {
     draftPullRequest?: boolean;
     label?: string;
+    skipLabeling?: boolean;
     signoff?: string;
 }
 interface PullRequestStrategyArgs {

package/build/src/bin/release-please.js

@@ -105,6 +105,11 @@ function pullRequestOptions(yargs) {
         .option('label', {
         default: 'autorelease: pending',
         describe: 'comma-separated list of labels to add to from release PR',
+    })
+        .option('skip-labeling', {
+        describe: 'skip application of labels to pull requests',
+        type: 'boolean',
+        default: false,
     })
         .option('fork', {
         describe: 'should the PR be created from a fork',
@@ -516,8 +521,14 @@ function extractManifestOptions(argv) {
     if ('fork' in argv && argv.fork !== undefined) {
         manifestOptions.fork = argv.fork;
     }
-    if (argv.label) {
-        manifestOptions.labels = argv.label.split(',');
+    if (argv.label !== undefined) {
+        let labels = argv.label.split(',');
+        if (labels.length === 1 && labels[0] === '')
+            labels = [];
+        manifestOptions.labels = labels;
+    }
+    if ('skipLabeling' in argv && argv.skipLabeling !== undefined) {
+        manifestOptions.skipLabeling = argv.skipLabeling;
     }
     if ('releaseLabel' in argv && argv.releaseLabel) {
         manifestOptions.releaseLabels = argv.releaseLabel.split(',');

package/build/src/github.d.ts

@@ -233,6 +233,7 @@ export declare class GitHub {
     createReleasePullRequest(releasePullRequest: ReleasePullRequest, targetBranch: string, options?: {
         signoffUser?: string;
         fork?: boolean;
+        skipLabeling?: boolean;
     }): Promise<PullRequest>;
     createPullRequest: (pullRequest: PullRequest, targetBranch: string, message: string, updates: Update[], options?: {
         fork?: boolean | undefined;

package/build/src/github.js

@@ -870,13 +870,15 @@ class GitHub {
         if (options === null || options === void 0 ? void 0 : options.signoffUser) {
             message = signoff_commit_message_1.signoffCommitMessage(message, options.signoffUser);
         }
+        const pullRequestLabels = (options === null || options === void 0 ? void 0 : options.skipLabeling) ? []
+            : releasePullRequest.labels;
         return await this.createPullRequest({
             headBranchName: releasePullRequest.headRefName,
             baseBranchName: targetBranch,
             number: -1,
             title: releasePullRequest.title.toString(),
             body: releasePullRequest.body.toString().slice(0, MAX_ISSUE_BODY_SIZE),
-            labels: releasePullRequest.labels,
+            labels: pullRequestLabels,
             files: [],
         }, targetBranch, message, releasePullRequest.updates, {
             fork: options === null || options === void 0 ? void 0 : options.fork,

package/build/src/manifest.d.ts

@@ -88,12 +88,15 @@ export interface ManifestOptions {
     signoff?: string;
     manifestPath?: string;
     labels?: string[];
+    skipLabeling?: boolean;
     releaseLabels?: string[];
     snapshotLabels?: string[];
     draft?: boolean;
     prerelease?: boolean;
     draftPullRequest?: boolean;
     groupPullRequestTitlePattern?: string;
+    releaseSearchDepth?: number;
+    commitSearchDepth?: number;
 }
 interface ReleaserPackageConfig extends ReleaserConfigJson {
     'package-name'?: string;
@@ -121,6 +124,8 @@ export interface ManifestConfig extends ReleaserConfigJson {
     plugins?: PluginType[];
     'separate-pull-requests'?: boolean;
     'group-pull-request-title-pattern'?: string;
+    'release-search-depth'?: number;
+    'commit-search-depth'?: number;
 }
 export declare type ReleasedVersions = Record<string, Version>;
 export declare type RepositoryConfig = Record<string, ReleaserConfig>;
@@ -150,6 +155,7 @@ export declare class Manifest {
     readonly fork: boolean;
     private signoffUser?;
     private labels;
+    private skipLabeling?;
     private releaseLabels;
     private snapshotLabels;
     private plugins;
@@ -162,6 +168,8 @@ export declare class Manifest {
     private prerelease?;
     private draftPullRequest?;
     private groupPullRequestTitlePattern?;
+    readonly releaseSearchDepth: number;
+    readonly commitSearchDepth: number;
     /**
      * Create a Manifest from explicit config in code. This assumes that the
      * repository has a single component at the root path.

package/build/src/manifest.js

@@ -33,6 +33,8 @@ exports.DEFAULT_LABELS = ['autorelease: pending'];
 exports.DEFAULT_RELEASE_LABELS = ['autorelease: tagged'];
 exports.DEFAULT_SNAPSHOT_LABELS = ['autorelease: snapshot'];
 exports.SNOOZE_LABEL = 'autorelease: snooze';
+const DEFAULT_RELEASE_SEARCH_DEPTH = 400;
+const DEFAULT_COMMIT_SEARCH_DEPTH = 500;
 exports.MANIFEST_PULL_REQUEST_TITLE_PATTERN = 'chore: release ${branch}';
 class Manifest {
     /**
@@ -76,6 +78,7 @@ class Manifest {
         this.releaseLabels =
             (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.releaseLabels) || exports.DEFAULT_RELEASE_LABELS;
         this.labels = (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.labels) || exports.DEFAULT_LABELS;
+        this.skipLabeling = (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.skipLabeling) || false;
         this.snapshotLabels =
             (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.snapshotLabels) || exports.DEFAULT_SNAPSHOT_LABELS;
         this.bootstrapSha = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.bootstrapSha;
@@ -83,6 +86,10 @@ class Manifest {
         this.draft = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.draft;
         this.draftPullRequest = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.draftPullRequest;
         this.groupPullRequestTitlePattern = manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.groupPullRequestTitlePattern;
+        this.releaseSearchDepth =
+            (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.releaseSearchDepth) || DEFAULT_RELEASE_SEARCH_DEPTH;
+        this.commitSearchDepth =
+            (manifestOptions === null || manifestOptions === void 0 ? void 0 : manifestOptions.commitSearchDepth) || DEFAULT_COMMIT_SEARCH_DEPTH;
     }
     /**
      * Create a Manifest from config files in the repository.
@@ -169,8 +176,9 @@ class Manifest {
         const releaseShasByPath = {};
         // Releases by path
         const releasesByPath = {};
+        logger_1.logger.debug(`release search depth: ${this.releaseSearchDepth}`);
         for await (const release of this.github.releaseIterator({
-            maxResults: 400,
+            maxResults: this.releaseSearchDepth,
         })) {
             const tagName = tag_name_1.TagName.parse(release.tagName);
             if (!tagName) {
@@ -227,8 +235,9 @@ class Manifest {
         // seen all release commits
         logger_1.logger.info('Collecting commits since all latest releases');
         const commits = [];
+        logger_1.logger.debug(`commit search depth: ${this.commitSearchDepth}`);
         const commitGenerator = this.github.mergeCommitIterator(this.targetBranch, {
-            maxResults: 500,
+            maxResults: this.commitSearchDepth,
             backfillFiles: true,
         });
         const releaseShas = new Set(Object.values(releaseShasByPath));
@@ -459,6 +468,7 @@ class Manifest {
         const newPullRequest = await this.github.createReleasePullRequest(pullRequest, this.targetBranch, {
             fork: this.fork,
             signoffUser: this.signoffUser,
+            skipLabeling: this.skipLabeling,
         });
         return newPullRequest;
     }
@@ -719,6 +729,8 @@ async function parseConfig(github, configFile, branch, onlyPath, releaseAs) {
         labels: configLabel === undefined ? undefined : [configLabel],
         releaseLabels: configReleaseLabel === undefined ? undefined : [configReleaseLabel],
         snapshotLabels: configSnapshotLabel === undefined ? undefined : [configSnapshotLabel],
+        releaseSearchDepth: config['release-search-depth'],
+        commitSearchDepth: config['commit-search-depth'],
     };
     return { config: repositoryConfig, options: manifestOptions };
 }

package/build/src/updaters/base-xml.js

@@ -14,7 +14,7 @@
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.BaseXml = void 0;
-const dom = require("xmldom");
+const dom = require("@xmldom/xmldom");
 /**
  * Base class for all updaters working with XML files.
  */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.11.0",
+  "version": "13.13.0",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
@@ -75,6 +75,7 @@
     "@octokit/request-error": "^2.1.0",
     "@octokit/rest": "^18.12.0",
     "@types/npm-package-arg": "^6.1.0",
+    "@xmldom/xmldom": "^0.8.2",
     "chalk": "^4.0.0",
     "code-suggester": "^2.0.0",
     "conventional-changelog-conventionalcommits": "^4.6.0",
@@ -92,7 +93,6 @@
     "typescript": "^3.8.3",
     "unist-util-visit": "^2.0.3",
     "unist-util-visit-parents": "^3.1.1",
-    "xmldom": "^0.6.0",
     "xpath": "^0.0.32",
     "yargs": "^17.0.0"
   },