release-please 13.10.0 → 13.10.1

package/CHANGELOG.md

@@ -4,6 +4,16 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [13.10.1](https://github.com/googleapis/release-please/compare/v13.10.0...v13.10.1) (2022-04-13)
+
+
+### Bug Fixes
+
+* bump retries for pull request iterator from 1 to 3 ([#1377](https://github.com/googleapis/release-please/issues/1377)) ([b2b7ff8](https://github.com/googleapis/release-please/commit/b2b7ff8ce98714ac591857b194ba0d51d9c2a641)), closes [#1376](https://github.com/googleapis/release-please/issues/1376)
+* don't crash when pull request iterator GraphQL returns no response ([b2b7ff8](https://github.com/googleapis/release-please/commit/b2b7ff8ce98714ac591857b194ba0d51d9c2a641))
+* fixed maxResults check in tag and release iterators ([#1378](https://github.com/googleapis/release-please/issues/1378)) ([6492a86](https://github.com/googleapis/release-please/commit/6492a86c56bbbb9b85f96bdf7edba910f1d66fc0))
+* GraphQL retry now uses exponential backoff ([b2b7ff8](https://github.com/googleapis/release-please/commit/b2b7ff8ce98714ac591857b194ba0d51d9c2a641))
+
 ## [13.10.0](https://github.com/googleapis/release-please/compare/v13.9.0...v13.10.0) (2022-04-12)
 
 

package/build/src/github.js

@@ -59,17 +59,30 @@ class GitHub {
             return files;
         });
         this.graphqlRequest = wrapAsync(async (opts, maxRetries = 1) => {
+            let seconds = 1;
             while (maxRetries >= 0) {
                 try {
-                    return await this.graphql(opts);
+                    const response = await this.graphql(opts);
+                    if (response) {
+                        return response;
+                    }
+                    logger_1.logger.trace('no GraphQL response, retrying');
                 }
                 catch (err) {
                     if (err.status !== 502) {
                         throw err;
                     }
+                    logger_1.logger.trace('received 502 error, retrying');
                 }
                 maxRetries -= 1;
+                if (maxRetries >= 0) {
+                    logger_1.logger.trace(`sleeping ${seconds} seconds`);
+                    await sleepInMs(1000 * seconds);
+                    seconds *= 2;
+                }
             }
+            logger_1.logger.trace('ran out of retries');
+            return undefined;
         });
         /**
          * Returns a list of paths to all files with a given name.
@@ -622,6 +635,7 @@ class GitHub {
      * @throws {GitHubAPIError} on an API error
      */
     async pullRequestsGraphQL(targetBranch, states = 'MERGED', cursor) {
+        var _a;
         logger_1.logger.debug(`Fetching ${states} pull requests on branch ${targetBranch} with cursor ${cursor}`);
         const response = await this.graphqlRequest({
             query: `query mergedPullRequests($owner: String!, $repo: String!, $num: Int!, $maxFilesChanged: Int, $targetBranch: String!, $states: [PullRequestState!], $cursor: String) {
@@ -665,8 +679,8 @@ class GitHub {
             targetBranch,
             states,
             maxFilesChanged: 64,
-        });
-        if (!response.repository.pullRequests) {
+        }, 3);
+        if (!((_a = response === null || response === void 0 ? void 0 : response.repository) === null || _a === void 0 ? void 0 : _a.pullRequests)) {
             logger_1.logger.warn(`Could not find merged pull requests for branch ${targetBranch} - it likely does not exist.`);
             return null;
         }
@@ -714,7 +728,7 @@ class GitHub {
                 }
                 yield response.data[i];
             }
-            if (!response.pageInfo.hasNextPage) {
+            if (results > maxResults || !response.pageInfo.hasNextPage) {
                 break;
             }
             cursor = response.pageInfo.endCursor;
@@ -799,6 +813,8 @@ class GitHub {
                     sha: tag.commit.sha,
                 };
             }
+            if (results > maxResults)
+                break;
         }
     }
     /**
@@ -975,4 +991,5 @@ const wrapAsync = (fn, errorHandler) => {
         }
     };
 };
+const sleepInMs = (ms) => new Promise(resolve => setTimeout(resolve, ms));
 //# sourceMappingURL=github.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "release-please",
-  "version": "13.10.0",
+  "version": "13.10.1",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",