release-please 12.5.0 → 12.6.3

package/CHANGELOG.md

@@ -4,6 +4,34 @@
 
 [1]: https://www.npmjs.com/package/release-please?activeTab=versions
 
+### [12.6.3](https://www.github.com/googleapis/release-please/compare/v12.6.2...v12.6.3) (2021-12-22)
+
+
+### Bug Fixes
+
+* GitHub#findFilesByExtension should treat prefix as a directory ([#1166](https://www.github.com/googleapis/release-please/issues/1166)) ([8329825](https://www.github.com/googleapis/release-please/commit/83298257a2021f88df4db3c95869955f8773eb70)), closes [#1164](https://www.github.com/googleapis/release-please/issues/1164)
+
+### [12.6.2](https://www.github.com/googleapis/release-please/compare/v12.6.1...v12.6.2) (2021-12-21)
+
+
+### Bug Fixes
+
+* **release:** ensure release-backed tokens work on branch ([#1155](https://www.github.com/googleapis/release-please/issues/1155)) ([9849f93](https://www.github.com/googleapis/release-please/commit/9849f930f2137aa41b54b54d5d6a6faa2a9fe8ee))
+
+### [12.6.1](https://www.github.com/googleapis/release-please/compare/v12.6.0...v12.6.1) (2021-12-21)
+
+
+### Bug Fixes
+
+* **rust:** Don't update dev-dependencies lacking a version key ([#1095](https://www.github.com/googleapis/release-please/issues/1095)) ([dc1bad9](https://www.github.com/googleapis/release-please/commit/dc1bad997ef0d028e280e75b0e6510a99d06cb44))
+
+## [12.6.0](https://www.github.com/googleapis/release-please/compare/v12.5.0...v12.6.0) (2021-10-11)
+
+
+### Features
+
+* add GraphQL URL option for Github ([#1083](https://www.github.com/googleapis/release-please/issues/1083)) ([ec661e2](https://www.github.com/googleapis/release-please/commit/ec661e22c7f5fa80e26d32d4cf0d93a4a90af4be)), closes [#1082](https://www.github.com/googleapis/release-please/issues/1082)
+
 ## [12.5.0](https://www.github.com/googleapis/release-please/compare/v12.4.0...v12.5.0) (2021-09-29)
 
 

package/README.md

@@ -218,6 +218,8 @@ release-please release-pr --package-name=@google-cloud/firestore" \
 | `--monorepo-tags` | add prefix to tags and branches, allowing multiple libraries to be released from the same repository. |
 | `--pull-request-title-pattern` | add title pattern to make release PR, defaults to using `chore${scope}: release${component} ${version}`. |
 | `--signoff` | Add [`Signed-off-by`](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff) line at the end of the commit log message using the user and email provided. (format "Name \<email@example.com\>") |
+| `--api-url` | URL to use when making API requests [default: "https://api.github.com"] |
+| `--graphql-url` | URL to use when making GraphQL requests [default: "https://api.github.com"] |
 
 ### Creating a release on GitHub
 
@@ -232,6 +234,8 @@ release-please github-release --repo-url=googleapis/nodejs-firestore \
 | `--repo-url`      | is the URL of the repository on GitHub.                 |
 | `--token`         | a token with write access to `--repo-url`.              |
 | `--path`          | create a release from a path other than the repository's root |
+| `--api-url`       | URL to use when making API requests [default: "https://api.github.com"] |
+| `--graphql-url`   | URL to use when making GraphQL requests [default: "https://api.github.com"] |
 
 ### Running as a GitHub App
 

package/build/src/bin/release-please.d.ts

@@ -13,6 +13,8 @@ export declare const parser: yargs.Argv<yargs.Omit<yargs.Omit<GitHubReleaseFacto
     token: unknown;
 } & {
     "api-url": string;
+} & {
+    "graphql-url": string;
 } & {
     "default-branch": string | undefined;
 }, "fork"> & {

package/build/src/bin/release-please.js

@@ -175,6 +175,8 @@ exports.parser = yargs
         argv.token = coerce_option_1.coerceOption(argv.token);
     if (argv.apiUrl)
         argv.apiUrl = coerce_option_1.coerceOption(argv.apiUrl);
+    if (argv.graphqlUrl)
+        argv.graphqlUrl = coerce_option_1.coerceOption(argv.graphqlUrl);
 })
     .option('debug', {
     describe: 'print verbose errors (use only for local debugging).',
@@ -187,6 +189,11 @@ exports.parser = yargs
     describe: 'URL to use when making API requests',
     default: constants_1.GH_API_URL,
     type: 'string',
+})
+    .option('graphql-url', {
+    describe: 'URL to use when making GraphQL requests',
+    default: constants_1.GH_GRAPHQL_URL,
+    type: 'string',
 })
     .option('default-branch', {
     describe: 'The branch to open release PRs against and tag releases on',

package/build/src/constants.d.ts

@@ -1,5 +1,6 @@
 export declare const DEFAULT_LABELS: string[];
 export declare const GH_API_URL = "https://api.github.com";
+export declare const GH_GRAPHQL_URL = "https://api.github.com";
 export declare const RELEASE_PLEASE = "release-please";
 export declare const RELEASE_PLEASE_CONFIG: string;
 export declare const RELEASE_PLEASE_MANIFEST: string;

package/build/src/constants.js

@@ -13,9 +13,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.MAX_ISSUE_BODY_SIZE = exports.RELEASE_PLEASE_MANIFEST = exports.RELEASE_PLEASE_CONFIG = exports.RELEASE_PLEASE = exports.GH_API_URL = exports.DEFAULT_LABELS = void 0;
+exports.MAX_ISSUE_BODY_SIZE = exports.RELEASE_PLEASE_MANIFEST = exports.RELEASE_PLEASE_CONFIG = exports.RELEASE_PLEASE = exports.GH_GRAPHQL_URL = exports.GH_API_URL = exports.DEFAULT_LABELS = void 0;
 exports.DEFAULT_LABELS = ['autorelease: pending'];
 exports.GH_API_URL = 'https://api.github.com';
+exports.GH_GRAPHQL_URL = 'https://api.github.com';
 exports.RELEASE_PLEASE = 'release-please';
 exports.RELEASE_PLEASE_CONFIG = `${exports.RELEASE_PLEASE}-config.json`;
 exports.RELEASE_PLEASE_MANIFEST = `.${exports.RELEASE_PLEASE}-manifest.json`;

package/build/src/factory.js

@@ -97,7 +97,7 @@ function getLabels(label) {
     return label ? label.split(',') : constants_1.DEFAULT_LABELS;
 }
 function getGitHubFactoryOpts(options) {
-    const { repoUrl, defaultBranch, fork, token, apiUrl, octokitAPIs, ...remaining } = options;
+    const { repoUrl, defaultBranch, fork, token, apiUrl, graphqlUrl, octokitAPIs, ...remaining } = options;
     return [
         {
             repoUrl,
@@ -105,6 +105,7 @@ function getGitHubFactoryOpts(options) {
             fork,
             token,
             apiUrl,
+            graphqlUrl,
             octokitAPIs,
         },
         remaining,

package/build/src/github.d.ts

@@ -98,6 +98,7 @@ export declare class GitHub {
     owner: string;
     repo: string;
     apiUrl: string;
+    graphqlUrl: string;
     fork: boolean;
     repositoryDefaultBranch?: string;
     constructor(options: GitHubConstructorOptions);

package/build/src/github.js

@@ -475,7 +475,7 @@ class GitHub {
                     // match the filename
                     path.endsWith(filename) &&
                     // match the prefix if provided
-                    (!prefix || path.startsWith(prefix)));
+                    (!prefix || path.startsWith(`${prefix}/`)));
             })
                 .map(file => {
                 let path = file.path;
@@ -518,7 +518,7 @@ class GitHub {
                     // match the file extension
                     path.endsWith(`.${extension}`) &&
                     // match the prefix if provided
-                    (!prefix || path.startsWith(prefix)));
+                    (!prefix || path.startsWith(`${prefix}/`)));
             })
                 .map(file => {
                 let path = file.path;
@@ -538,7 +538,7 @@ class GitHub {
          * @throws {GitHubAPIError} on an API error
          */
         this.commentOnIssue = wrapAsync(async (comment, number) => {
-            logger_1.logger.info(`adding comment to https://github.com/${this.owner}/${this.repo}/issue/${number}`);
+            logger_1.logger.info(`adding comment to https://github.com/${this.owner}/${this.repo}/issues/${number}`);
             return (await this.request('POST /repos/:owner/:repo/issues/:issue_number/comments', {
                 owner: this.owner,
                 repo: this.repo,
@@ -552,6 +552,7 @@ class GitHub {
         this.repo = options.repo;
         this.fork = !!options.fork;
         this.apiUrl = options.apiUrl || constants_1.GH_API_URL;
+        this.graphqlUrl = options.graphqlUrl || constants_1.GH_GRAPHQL_URL;
         if (options.octokitAPIs === undefined) {
             this.octokit = new rest_1.Octokit({
                 baseUrl: options.apiUrl,
@@ -580,7 +581,7 @@ class GitHub {
         let opts = Object.assign({}, _opts);
         if (!probotMode) {
             opts = Object.assign(opts, {
-                url: `${this.apiUrl}/graphql`,
+                url: `${this.graphqlUrl}/graphql`,
                 headers: {
                     authorization: `token ${this.token}`,
                     'content-type': 'application/vnd.github.v3+json',

package/build/src/index.d.ts

@@ -11,6 +11,7 @@ interface GitHubOptions {
     fork?: boolean;
     token?: string;
     apiUrl?: string;
+    graphqlUrl?: string;
     octokitAPIs?: OctokitAPIs;
 }
 export interface GitHubReleaseOptions {

package/build/src/updaters/rust/cargo-toml.js

@@ -57,7 +57,11 @@ class CargoToml {
                 }
                 const dep = deps[pkgName];
                 if (typeof dep === 'string' || typeof dep.path === 'undefined') {
-                    logger_1.logger.info(`skipping ${depKind}.${pkgName} in ${this.path}`);
+                    logger_1.logger.info(`skipping ${depKind}.${pkgName} in ${this.path} (no path set)`);
+                    continue; // to next depKind
+                }
+                if (typeof dep.version === 'undefined') {
+                    logger_1.logger.info(`skipping ${depKind}.${pkgName} in ${this.path} (no version set)`);
                     continue; // to next depKind
                 }
                 logger_1.logger.info(`updating ${this.path} ${depKind}.${pkgName} from ${dep.version} to ${pkgVersion}`);

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "release-please",
-  "version": "12.5.0",
+  "version": "12.6.3",
   "description": "generate release PRs based on the conventionalcommits.org spec",
   "main": "./build/src/index.js",
   "bin": "./build/src/bin/release-please.js",
   "scripts": {
     "test": "cross-env ENVIRONMENT=test c8 mocha --recursive --timeout=5000 build/test",
-    "docs-test": "echo add docs tests",
+    "docs": "echo add docs tests",
     "test:snap": "SNAPSHOT_UPDATE=1 npm test",
     "clean": "gts clean",
     "prepare": "npm run compile",
@@ -42,7 +42,7 @@
     "@types/iarna__toml": "^2.0.1",
     "@types/js-yaml": "^4.0.0",
     "@types/mocha": "^8.0.0",
-    "@types/node": "^14.0.0",
+    "@types/node": "^16.0.0",
     "@types/pino": "^6.3.0",
     "@types/semver": "^7.0.0",
     "@types/sinon": "^10.0.0",